{"thread":{"id":"16467","subject":"Extra pair of double quotes in \"git commit\" output?","startedAt":"2008-11-25T21:49:06Z","lastAt":"2008-11-26T17:15:42Z","messageCount":7,"participants":["Nanako Shiraishi","Junio C Hamano","Jeff King","Santi Béjar","Jakub Narebski","David Brown"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"96498","messageId":"20081126064906.6117@nanako3.lavabit.com","threadId":"16467","inReplyTo":null,"subject":"Extra pair of double quotes in \"git commit\" output?","fromName":"Nanako Shiraishi","fromEmail":"nanako3@lavabit.com","sentAt":"2008-11-25T21:49:06Z","receivedAt":"2008-11-25T21:49:06Z","isPatch":false,"sender":{"key":"nanako3@lavabit.com","avatar":"https://gravatar.com/avatar/3777b9e201c5883a62b1a6fdf7c53f2d712d1d80989146063ea861e33aad72a8?d=mp&s=160"},"body":"While I think the way recent \"git commit\" displays the commit you just created is very helpful, I often find the double quotes around the message unnecessary and sometimes even confusing.  I just made a commit and saw this message:\n\n    [master]: created d9a5491: \"Show \"standard deviation\" column in table 3\"\n\nThe colon after the shortened commit SHA1 is enough to signal that it will talk about a different piece of information on the rest of the line.  I think the extra double quotes can be dropped safely:\n\n    [master]: created d9a5491: Show \"standard deviation\" column in table 3\n\nand it will make the output shorter by two columns, more pretty, and does not lose the clarity.\n\n-- \nNanako Shiraishi\nhttp://ivory.ap.teacup.com/nanako3/\n"},{"id":"96499","messageId":"7vej0zjwgm.fsf@gitster.siamese.dyndns.org","threadId":"16467","inReplyTo":"20081126064906.6117@nanako3.lavabit.com","subject":"Re: Extra pair of double quotes in \"git commit\" output?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-11-25T22:02:17Z","receivedAt":"2008-11-25T22:02:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nanako Shiraishi <nanako3@lavabit.com> writes:\n\n> While I think the way recent \"git commit\" displays the commit you just created is very helpful, I often find the double quotes around the message unnecessary and sometimes even confusing.  I just made a commit and saw this message:\n>\n>     [master]: created d9a5491: \"Show \"standard deviation\" column in table 3\"\n>\n> The colon after the shortened commit SHA1 is enough to signal that it will talk about a different piece of information on the rest of the line.  I think the extra double quotes can be dropped safely:\n>\n>     [master]: created d9a5491: Show \"standard deviation\" column in table 3\n>\n> and it will make the output shorter by two columns, more pretty, and does not lose the clarity.\n\n[offtopic.  Please wrap your text at a reasonable width around 70 columns]\n\nLike this?\n\nIt might break some existing tests (I didn't check), but I think that is a\nsensible thing to do.\n\n\n\n builtin-commit.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git c/builtin-commit.c w/builtin-commit.c\nindex 591d16b..654bfbe 100644\n--- c/builtin-commit.c\n+++ w/builtin-commit.c\n@@ -881,7 +881,7 @@ static void print_summary(const char *prefix, const unsigned char *sha1)\n {\n \tstruct rev_info rev;\n \tstruct commit *commit;\n-\tstatic const char *format = \"format:%h: \\\"%s\\\"\";\n+\tstatic const char *format = \"format:%h: %s\";\n \tunsigned char junk_sha1[20];\n \tconst char *head = resolve_ref(\"HEAD\", junk_sha1, 0, NULL);\n \n"},{"id":"96503","messageId":"20081125232521.GC30942@coredump.intra.peff.net","threadId":"16467","inReplyTo":"20081126064906.6117@nanako3.lavabit.com","subject":"Re: Extra pair of double quotes in \"git commit\" output?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-11-25T23:25:21Z","receivedAt":"2008-11-25T23:25:21Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Nov 26, 2008 at 06:49:06AM +0900, Nanako Shiraishi wrote:\n\n> While I think the way recent \"git commit\" displays the commit you just\n> created is very helpful, I often find the double quotes around the\n> message unnecessary and sometimes even confusing.  I just made a\n> commit and saw this message:\n> \n>     [master]: created d9a5491: \"Show \"standard deviation\" column in table 3\"\n\nWhile I do think that typographically the embedded quotes look awful, I\nfind that the quotes do help separate the commit subject from the other\ntext when there are colons in the subject. IOW, I think that\n\n  [master]: created d9a5491: foo: bar\n\nis harder to read than\n\n  [master]: created d9a5491: \"foo: bar\"\n\nAnd 47% of commits in git.git have a colon (only 7% have a double\nquote).\n\nSo I sympathize with the desire to remove the quotes, as they look bad\nand are obviously not too rare. But I'd like to find a solution which\nmaintains a better visual separation between the subject and the other\ntext than simply removing them.\n\n-Peff\n"},{"id":"96509","messageId":"adf1fd3d0811251606t7f49eb84y53075427859bd26a@mail.gmail.com","threadId":"16467","inReplyTo":"20081125232521.GC30942@coredump.intra.peff.net","subject":"Re: Extra pair of double quotes in \"git commit\" output?","fromName":"Santi Béjar","fromEmail":"santi@agolina.net","sentAt":"2008-11-26T00:06:34Z","receivedAt":"2008-11-26T00:06:34Z","isPatch":false,"sender":{"key":"santi@agolina.net","avatar":null},"body":"On Wed, Nov 26, 2008 at 12:25 AM, Jeff King <peff@peff.net> wrote:\n\n[...]\n\n>\n> So I sympathize with the desire to remove the quotes, as they look bad\n> and are obviously not too rare. But I'd like to find a solution which\n> maintains a better visual separation between the subject and the other\n> text than simply removing them.\n\nMaybe just use the output of \"git branch -v\":\n\nmaster d9a5491 foo: bar\n\nor even literally:\n\n* master d9a5491 [ahead 1] foo: bar\n\nor to make the separation more evident:\n\n[master d9a5491] foo: bar\n\nSanti\n"},{"id":"96546","messageId":"20081126133422.GA1761@coredump.intra.peff.net","threadId":"16467","inReplyTo":"adf1fd3d0811251606t7f49eb84y53075427859bd26a@mail.gmail.com","subject":"Re: Extra pair of double quotes in \"git commit\" output?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-11-26T13:34:23Z","receivedAt":"2008-11-26T13:34:23Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Nov 26, 2008 at 01:06:34AM +0100, Santi Béjar wrote:\n\n> Maybe just use the output of \"git branch -v\":\n> \n> master d9a5491 foo: bar\n> \n> or even literally:\n> \n> * master d9a5491 [ahead 1] foo: bar\n> \n> or to make the separation more evident:\n> \n> [master d9a5491] foo: bar\n\nOut of those suggestions, I find only the final one aesthetically\nacceptable. Nobody else has weighed in, so maybe they don't care. Or\nmaybe they are just on vacation due to the (American) holiday.\n\n-Peff\n"},{"id":"96550","messageId":"ggjolt$t7t$1@ger.gmane.org","threadId":"16467","inReplyTo":"20081126133422.GA1761@coredump.intra.peff.net","subject":"Re: Extra pair of double quotes in \"git commit\" output?","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-11-26T15:07:13Z","receivedAt":"2008-11-26T15:07:13Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jeff King wrote:\n> On Wed, Nov 26, 2008 at 01:06:34AM +0100, Santi Béjar wrote:\n> \n>> Maybe just use the output of \"git branch -v\":\n>> \n>> master d9a5491 foo: bar\n>> \n>> or even literally:\n>> \n>> * master d9a5491 [ahead 1] foo: bar\n>> \n>> or to make the separation more evident:\n>> \n>> [master d9a5491] foo: bar\n> \n> Out of those suggestions, I find only the final one aesthetically\n> acceptable. Nobody else has weighed in, so maybe they don't care. Or\n> maybe they are just on vacation due to the (American) holiday.\n\n+1 for the last one.\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"96560","messageId":"20081126171540.GA21540@linode.davidb.org","threadId":"16467","inReplyTo":"20081126133422.GA1761@coredump.intra.peff.net","subject":"Re: Extra pair of double quotes in \"git commit\" output?","fromName":"David Brown","fromEmail":"git@davidb.org","sentAt":"2008-11-26T17:15:42Z","receivedAt":"2008-11-26T17:15:42Z","isPatch":false,"sender":{"key":"git@davidb.org","avatar":"https://gravatar.com/avatar/94c86a2938470a74c2eac5e2b69afc0871f79a660295c02219597aba8cb101c1?d=mp&s=160"},"body":"On Wed, Nov 26, 2008 at 08:34:23AM -0500, Jeff King wrote:\n\n>> or to make the separation more evident:\n>> \n>> [master d9a5491] foo: bar\n>\n>Out of those suggestions, I find only the final one aesthetically\n>acceptable. Nobody else has weighed in, so maybe they don't care. Or\n>maybe they are just on vacation due to the (American) holiday.\n\nColor certainly works well in the cases where that is available.\nOtherwise, I prefer the above solution.\n\nDavid\n"}]}