{"thread":{"id":"16409","subject":"Whats happening with git-notes?","startedAt":"2008-11-20T12:12:42Z","lastAt":"2008-11-20T16:51:37Z","messageCount":4,"participants":["Tim Ansell","Johannes Schindelin","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"96225","messageId":"1227183162.23155.32.camel@vaio","threadId":"16409","inReplyTo":null,"subject":"Whats happening with git-notes?","fromName":"Tim Ansell","fromEmail":"mithro@mithis.com","sentAt":"2008-11-20T12:12:42Z","receivedAt":"2008-11-20T12:12:42Z","isPatch":false,"sender":{"key":"mithro@mithis.com","avatar":"https://gravatar.com/avatar/1df49ebfaff79712e08212ff66228e688973c823b6452c23268f9a8c0e4d341b?d=mp&s=160"},"body":"Hey guys,\n\nI was just wondering what is happening with git notes stuff? I really\nlike the idea of being able to annotate commits with various\ninformation.\n\nAfter the gittogether it sounded like we had a solid proposal and\npossible implementation, has anything happened since then? I had a quick\nlook over the archives but didn't seem much mention of them in the last\ncouple of weeks.\n\nThanks for your help.\n\nTim 'mithro' Ansell\nPS I'm going to try harder to find the time to continue to work on the\ngit-media cloning stuff, been a bit snowed under at work.\n"},{"id":"96230","messageId":"alpine.DEB.1.00.0811201410320.30769@pacific.mpi-cbg.de","threadId":"16409","inReplyTo":"1227183162.23155.32.camel@vaio","subject":"Re: Whats happening with git-notes?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-11-20T13:12:54Z","receivedAt":"2008-11-20T13:12:54Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 20 Nov 2008, Tim Ansell wrote:\n\n> I was just wondering what is happening with git notes stuff? I really \n> like the idea of being able to annotate commits with various \n> information.\n> \n> After the gittogether it sounded like we had a solid proposal and\n> possible implementation, has anything happened since then? I had a quick\n> look over the archives but didn't seem much mention of them in the last\n> couple of weeks.\n> \n> Thanks for your help.\n> \n> Tim 'mithro' Ansell\n> PS I'm going to try harder to find the time to continue to work on the\n> git-media cloning stuff, been a bit snowed under at work.\n\nThe same goes on here.  I wanted to take Peff's idea -- that hadn't \noccurred to me back when I tried to help Johan with his notes idea -- \nwhich is to read in the whole notes tree into a singleton when needed, and \nincorporate it into my existing test framework.\n\nMaybe I'll find time later today.\n\nCiao,\nDscho\n"},{"id":"96271","messageId":"20081120163930.GA27808@coredump.intra.peff.net","threadId":"16409","inReplyTo":"1227183162.23155.32.camel@vaio","subject":"Re: Whats happening with git-notes?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-11-20T16:39:30Z","receivedAt":"2008-11-20T16:39:30Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Nov 20, 2008 at 11:12:42PM +1100, Tim Ansell wrote:\n\n> I was just wondering what is happening with git notes stuff? I really\n> like the idea of being able to annotate commits with various\n> information.\n\nIt's on my todo list, but I doubt I will get to it for at least another\nweek. For what was said since then, try this thread:\n\n  http://thread.gmane.org/gmane.comp.version-control.git/100533\n\nand this message from another thread:\n\n  http://article.gmane.org/gmane.comp.version-control.git/100402\n\n-Peff\n"},{"id":"96272","messageId":"20081120165137.GB27808@coredump.intra.peff.net","threadId":"16409","inReplyTo":"alpine.DEB.1.00.0811201410320.30769@pacific.mpi-cbg.de","subject":"Re: Whats happening with git-notes?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-11-20T16:51:37Z","receivedAt":"2008-11-20T16:51:37Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Nov 20, 2008 at 02:12:54PM +0100, Johannes Schindelin wrote:\n\n> The same goes on here.  I wanted to take Peff's idea -- that hadn't \n> occurred to me back when I tried to help Johan with his notes idea -- \n> which is to read in the whole notes tree into a singleton when needed, and \n> incorporate it into my existing test framework.\n> \n> Maybe I'll find time later today.\n\nIn case you do work on it, let me quickly communicate the two thoughts I\nhave had since the GitTogether (and you can feel free to ignore them,\nbut I want to try to say them before you code something differently,\nso you at least have the _choice_ of ignoring them. :) ).\n\nOne is some thoughts on naming, which I already articulated here:\n\n  http://article.gmane.org/gmane.comp.version-control.git/100402\n\nThe other is on speeding up tree lookup. I think the \"notes as a git\ntree\" is sound, but as we obviously realized, somewhat slow. So the\n\"speeding up notes\" code is really about \"speeding up tree lookup\". And\nwhile it would be nice for pack v4 to fix this for free, I don't think\nwe want to wait for that. And I think the \"build a hash on the fly\"\napproach that I posted earlier is a sensible way to go.\n\n_But_ where I think we should differ from that patch is that any notes\nspeedup should really be about a generic interface for speeding up tree\nlookup. That is, it should come in the generic form of:\n\n  void tree_study(struct tree_study_context *c, struct tree *tree);\n  void tree_study_lookup(struct tree_study_context *c, const char *name);\n\nwhere \"tree_study\" spends some cycles to make \"tree_study_lookup\" much\nfaster.  And obviously most tree lookups wouldn't want to make this\ntradeoff, but there may be a few other places that look in the same tree\nseveral times, and we can benchmark them to see if they benefit. And if\nand when faster non-studied tree lookup comes about, we can adjust the\ntree studying algorithm easily.\n\n-Peff\n"}]}