{"thread":{"id":"16394","subject":"[TopGit PATCH] Print help output when no command is given","startedAt":"2008-11-19T16:03:39Z","lastAt":"2008-11-21T12:31:15Z","messageCount":16,"participants":["martin f. krafft","Petr Baudis","martin f krafft","Bert Wesarg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"96168","messageId":"1227110623-4474-1-git-send-email-madduck@debian.org","threadId":"16394","inReplyTo":null,"subject":"[TopGit] Improve help output","fromName":"martin f. krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-19T16:03:39Z","receivedAt":"2008-11-19T16:03:39Z","isPatch":false,"sender":{"key":"madduck@debian.org","avatar":null},"body":"The following patches improve the help output by TopGit. They are\nnot all related, but they conflict.\n\nI would just push them to the master branch, but I don't want to\nrisk my chances of Petr getting angry with his new release\nassistant...\n"},{"id":"96170","messageId":"1227110623-4474-2-git-send-email-madduck@debian.org","threadId":"16394","inReplyTo":"1227110623-4474-1-git-send-email-madduck@debian.org","subject":"[TopGit PATCH] Check for help invocation before setup","fromName":"martin f. krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-19T16:03:40Z","receivedAt":"2008-11-19T16:03:40Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"The user ought to be able to call `tg help` from anywhere in the\nfilesystem, not just Git repositories, so the help parsing has to happen\nbefore the calls to git git binary.\n\nDebian bug: #501982\n\nSigned-off-by: martin f. krafft <madduck@debian.org>\n---\n tg.sh |   17 ++++++++++++++---\n 1 files changed, 14 insertions(+), 3 deletions(-)\n\ndiff --git a/tg.sh b/tg.sh\nindex 2961106..40c4ab7 100644\n--- a/tg.sh\n+++ b/tg.sh\n@@ -235,6 +235,20 @@ do_help()\n \tfi\n }\n \n+## Startup\n+\n+args_saved=\"$@\"\n+while [ -n \"$1\" ]; do\n+\tcase \"$1\" in\n+\thelp|--help|-h)\n+\t\tshift\n+\t\tdo_help \"$1\"\n+\t\texit 1;;\n+\tesac\n+\tshift\n+done\n+set -- $args_saved\n+unset args_saved\n \n ## Initial setup\n \n@@ -268,9 +282,6 @@ cmd=\"$1\"\n shift\n \n case \"$cmd\" in\n-help|--help|-h)\n-\tdo_help \"$1\"\n-\texit 1;;\n --hooks-path)\n \t# Internal command\n \techo \"@hooksdir@\";;\n-- \n1.6.0.2\n"},{"id":"96167","messageId":"1227110623-4474-3-git-send-email-madduck@debian.org","threadId":"16394","inReplyTo":"1227110623-4474-2-git-send-email-madduck@debian.org","subject":"[TopGit PATCH] Change tg help exit code to 0","fromName":"martin f. krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-19T16:03:41Z","receivedAt":"2008-11-19T16:03:41Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"Printing --help is not an error, but a successful operation, if the help\noutput could be printed.\n\nSigned-off-by: martin f. krafft <madduck@debian.org>\n---\n tg.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/tg.sh b/tg.sh\nindex 40c4ab7..ea22544 100644\n--- a/tg.sh\n+++ b/tg.sh\n@@ -243,7 +243,7 @@ while [ -n \"$1\" ]; do\n \thelp|--help|-h)\n \t\tshift\n \t\tdo_help \"$1\"\n-\t\texit 1;;\n+\t\texit 0;;\n \tesac\n \tshift\n done\n-- \n1.6.0.2\n"},{"id":"96169","messageId":"1227110623-4474-4-git-send-email-madduck@debian.org","threadId":"16394","inReplyTo":"1227110623-4474-3-git-send-email-madduck@debian.org","subject":"[TopGit PATCH] Check for cmddir earlier","fromName":"martin f. krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-19T16:03:42Z","receivedAt":"2008-11-19T16:03:42Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"Without cmddir, tg is basically useless, even do_help() needs it, so\ncheck it first and die hard if not found\n\nSigned-off-by: martin f. krafft <madduck@debian.org>\n---\n tg.sh |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/tg.sh b/tg.sh\nindex ea22544..f3d1323 100644\n--- a/tg.sh\n+++ b/tg.sh\n@@ -237,6 +237,9 @@ do_help()\n \n ## Startup\n \n+[ -d \"@cmddir@\" ] ||\n+\tdie \"No command directory: '@cmddir@'\"\n+\n args_saved=\"$@\"\n while [ -n \"$1\" ]; do\n \tcase \"$1\" in\n@@ -263,9 +266,6 @@ tg=\"tg\"\n setup_ours\n setup_hook \"pre-commit\"\n \n-[ -d \"@cmddir@\" ] ||\n-\tdie \"No command directory: '@cmddir@'\"\n-\n ## Dispatch\n \n # We were sourced from another script for our utility functions;\n-- \n1.6.0.2\n"},{"id":"96166","messageId":"1227110623-4474-5-git-send-email-madduck@debian.org","threadId":"16394","inReplyTo":"1227110623-4474-4-git-send-email-madduck@debian.org","subject":"[TopGit PATCH] Print help output when no command is given","fromName":"martin f. krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-19T16:03:43Z","receivedAt":"2008-11-19T16:03:43Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"As much as I love your message (although you really ought not be\nthrowing around ducks!), this is more user-friendly.\n\nSigned-off-by: martin f. krafft <madduck@debian.org>\n---\n tg.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/tg.sh b/tg.sh\nindex f3d1323..e0d62e7 100644\n--- a/tg.sh\n+++ b/tg.sh\n@@ -278,7 +278,7 @@ if [ \"$1\" = \"-r\" ]; then\n fi\n \n cmd=\"$1\"\n-[ -n \"$cmd\" ] || die \"He took a duck in the face at two hundred and fifty knots\"\n+[ -n \"$cmd\" ] || { do_help; exit 1; }\n shift\n \n case \"$cmd\" in\n-- \n1.6.0.2\n"},{"id":"96178","messageId":"20081119182436.GB10544@machine.or.cz","threadId":"16394","inReplyTo":"1227110623-4474-2-git-send-email-madduck@debian.org","subject":"Re: [TopGit PATCH] Check for help invocation before setup","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2008-11-19T18:24:36Z","receivedAt":"2008-11-19T18:24:36Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Wed, Nov 19, 2008 at 05:03:40PM +0100, martin f. krafft wrote:\n> diff --git a/tg.sh b/tg.sh\n> index 2961106..40c4ab7 100644\n> --- a/tg.sh\n> +++ b/tg.sh\n> @@ -235,6 +235,20 @@ do_help()\n>  \tfi\n>  }\n>  \n> +## Startup\n> +\n> +args_saved=\"$@\"\n> +while [ -n \"$1\" ]; do\n> +\tcase \"$1\" in\n> +\thelp|--help|-h)\n> +\t\tshift\n> +\t\tdo_help \"$1\"\n> +\t\texit 1;;\n> +\tesac\n> +\tshift\n> +done\n> +set -- $args_saved\n> +unset args_saved\n>  \n>  ## Initial setup\n\nHuh, why do you actually need $args_saved at all? :-) This is bound to\ndo horrible things with space-containing arguments etc., I think. You\ndon't need to do the outer shift and then drop $args_saved altogether,\nno?\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nPeople who take cold baths never have rheumatism, but they have\ncold baths.\n"},{"id":"96179","messageId":"20081119183234.GA19781@piper.oerlikon.madduck.net","threadId":"16394","inReplyTo":"20081119182436.GB10544@machine.or.cz","subject":"Re: [TopGit PATCH] Check for help invocation before setup","fromName":"martin f krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-19T18:32:34Z","receivedAt":"2008-11-19T18:32:34Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"also sprach Petr Baudis <pasky@suse.cz> [2008.11.19.1924 +0100]:\n> > +args_saved=\"$@\"\n> > +while [ -n \"$1\" ]; do\n> > +\tcase \"$1\" in\n> > +\thelp|--help|-h)\n> > +\t\tshift\n> > +\t\tdo_help \"$1\"\n> > +\t\texit 1;;\n> > +\tesac\n> > +\tshift\n> > +done\n> > +set -- $args_saved\n> > +unset args_saved\n> >  \n> >  ## Initial setup\n> \n> Huh, why do you actually need $args_saved at all? :-) This is bound to\n> do horrible things with space-containing arguments etc., I think. You\n> don't need to do the outer shift and then drop $args_saved altogether,\n> no?\n\nI figured I need to restore $@ for others to consume, e.g. when you\ncheck for -r later.\n\nThe challenge is to identify help|--help|-h anywhere on the command\nline. Thus, you need to iterate, or do some weird matching against\n$*.\n\nWhen you iterate in a for loop, it's not easy to get at the next\nargument, except if you use a state machine. I wanted to avoid that.\n\nBut you are right, I am wreaking havoc with space-containing\narguments. I will have to go back and rework this.\n\nI take it you agree with the general principle though?\n\n-- \n .''`.   martin f. krafft <madduck@debian.org>\n: :'  :  proud Debian developer, author, administrator, and user\n`. `'`   http://people.debian.org/~madduck - http://debiansystem.info\n  `-  Debian - when you have better things to do than fixing systems\n \n\"it is easier to be a lover than a husband for the simple reason\n that it is more difficult to be witty every day\n than to say pretty things from time to time.\"\n                                                   -- honoré de balzac\n"},{"id":"96180","messageId":"20081119183902.GX10491@machine.or.cz","threadId":"16394","inReplyTo":"20081119183234.GA19781@piper.oerlikon.madduck.net","subject":"Re: [TopGit PATCH] Check for help invocation before setup","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2008-11-19T18:39:02Z","receivedAt":"2008-11-19T18:39:02Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Wed, Nov 19, 2008 at 07:32:34PM +0100, martin f krafft wrote:\n> also sprach Petr Baudis <pasky@suse.cz> [2008.11.19.1924 +0100]:\n> > > +args_saved=\"$@\"\n> > > +while [ -n \"$1\" ]; do\n> > > +\tcase \"$1\" in\n> > > +\thelp|--help|-h)\n> > > +\t\tshift\n> > > +\t\tdo_help \"$1\"\n> > > +\t\texit 1;;\n> > > +\tesac\n> > > +\tshift\n> > > +done\n> > > +set -- $args_saved\n> > > +unset args_saved\n> > >  \n> > >  ## Initial setup\n> > \n> > Huh, why do you actually need $args_saved at all? :-) This is bound to\n> > do horrible things with space-containing arguments etc., I think. You\n> > don't need to do the outer shift and then drop $args_saved altogether,\n> > no?\n> \n> I figured I need to restore $@ for others to consume, e.g. when you\n> check for -r later.\n> \n> The challenge is to identify help|--help|-h anywhere on the command\n> line. Thus, you need to iterate, or do some weird matching against\n> $*.\n> \n> When you iterate in a for loop, it's not easy to get at the next\n> argument, except if you use a state machine. I wanted to avoid that.\n\nOh, oops - I missed the loop, I should get some lunch. ;-)\nThus, something like this?\n\n\tcheck_help() { while [ -n \"$1\" ]; do ...; shift; done }\n\tcheck_help \"$@\"\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nPeople who take cold baths never have rheumatism, but they have\ncold baths.\n"},{"id":"96220","messageId":"20081120114813.GA8401@piper.oerlikon.madduck.net","threadId":"16394","inReplyTo":"20081119183902.GX10491@machine.or.cz","subject":"Re: [TopGit PATCH] Check for help invocation before setup","fromName":"martin f krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-20T11:48:13Z","receivedAt":"2008-11-20T11:48:13Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"also sprach Petr Baudis <pasky@suse.cz> [2008.11.19.1939 +0100]:\n> Oh, oops - I missed the loop, I should get some lunch. ;-)\n> Thus, something like this?\n> \n> \tcheck_help() { while [ -n \"$1\" ]; do ...; shift; done }\n> \tcheck_help \"$@\"\n\nWhy didn't I think of that???\n\nI just sent an updated patch without threading, sorry. tg-mail just\nfires without confirmation... :/\n\n-- \n .''`.   martin f. krafft <madduck@debian.org>\n: :'  :  proud Debian developer, author, administrator, and user\n`. `'`   http://people.debian.org/~madduck - http://debiansystem.info\n  `-  Debian - when you have better things to do than fixing systems\n \n\"the pure and simple truth is rarely pure and never simple.\"\n                                                      -- oscar wilde\n"},{"id":"96315","messageId":"36ca99e90811210119s215513a8m7c12c8d55fd54d70@mail.gmail.com","threadId":"16394","inReplyTo":"1227110623-4474-2-git-send-email-madduck@debian.org","subject":"Re: [TopGit PATCH] Check for help invocation before setup","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-11-21T09:19:01Z","receivedAt":"2008-11-21T09:19:01Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"Hi,\n\nOn Wed, Nov 19, 2008 at 17:03, martin f. krafft <madduck@debian.org> wrote:\n> The user ought to be able to call `tg help` from anywhere in the\n> filesystem, not just Git repositories, so the help parsing has to happen\n> before the calls to git git binary.\n>\n> Debian bug: #501982\nI really second this. Plus, I think its crucial to check that we are\nnot inside the .git directory before setting up topgit. Because git\nrev-parse --git-dir only works in the top .git dir, not deeper (i.e.\ninside .git/refs) and will always return \".\".\n\n\t$(git rev-parse --is-inside-work-tree) ||\n\t\tdie \"Not in a git working directory\"\n\nBert\n"},{"id":"96327","messageId":"20081121120609.GA10326@piper.oerlikon.madduck.net","threadId":"16394","inReplyTo":"36ca99e90811210119s215513a8m7c12c8d55fd54d70@mail.gmail.com","subject":"TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)","fromName":"martin f krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-21T12:06:09Z","receivedAt":"2008-11-21T12:06:09Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"I think you wanted to CC Petr, not Junio. It's also useful to CC\nDebian bugs if you know of them. :)\n\nalso sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1019 +0100]:\n> I really second this. Plus, I think its crucial to check that we are\n> not inside the .git directory before setting up topgit. Because git\n> rev-parse --git-dir only works in the top .git dir, not deeper (i.e.\n> inside .git/refs) and will always return \".\".\n> \n> \t$(git rev-parse --is-inside-work-tree) ||\n> \t\tdie \"Not in a git working directory\"\n\nThanks, noted. I am still working on this patch, since\nevaluating $argv/checking for --help at this early stage basically\nrequires a rewrite of the CLI parsing, ideally using POSIX getopt or\nsomething similar, which takes much of the load away.\n\nAnyway, Patch for your proposal forthcoming.\n\n-- \n .''`.   martin f. krafft <madduck@debian.org>\n: :'  :  proud Debian developer, author, administrator, and user\n`. `'`   http://people.debian.org/~madduck - http://debiansystem.info\n  `-  Debian - when you have better things to do than fixing systems\n \n(a)bort, (r)etry, (p)retend this never happened\n"},{"id":"96328","messageId":"1227269356-19093-1-git-send-email-madduck@debian.org","threadId":"16394","inReplyTo":"20081121120609.GA10326@piper.oerlikon.madduck.net","subject":"[TopGit PATCH] Ensure we are inside a Git worktree","fromName":"martin f. krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-21T12:09:16Z","receivedAt":"2008-11-21T12:09:16Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"Bert Wesarg suggests to check that we are not inside the .git directory before\nsetting up topgit. Because git rev-parse --git-dir only works in the top .git\ndir, not deeper (i.e. inside .git/refs) and will always return \".\"\n\nThis patch thus causes topgit to die early on when it's called from outside of\na Git repository, or from underneath .git and outputs error messages\naccordingly.\n\nThis temporarily makes it even more impossible to call tg --help, but I expect\nto have that fixed soon too.\n\nSigned-off-by: martin f. krafft <madduck@debian.org>\n\n---\n tg.sh |   16 ++++++++++++++++\n 1 files changed, 16 insertions(+), 0 deletions(-)\n\ndiff --git a/tg.sh b/tg.sh\nindex 8c23d26..f8c8de4 100644\n--- a/tg.sh\n+++ b/tg.sh\n@@ -17,6 +17,20 @@ die()\n \texit 1\n }\n \n+# Make sure we are in the worktree, not under .git; die otherwise\n+ensure_git_repo_or_die()\n+{\n+\tlocal is_inside_repo is_inside_git_dir\n+\tis_inside_repo=1\n+\tis_inside_git_dir=$(git rev-parse --is-inside-git-dir 2>/dev/null) ||\n+\t\tis_inside_repo=0\n+\n+\tcase \"$is_inside_repo/$is_inside_git_dir\" in\n+\t0*) die \"Cannot run outside of a Git repository.\";;\n+\t1/true) die \"Cannot run from inside \\`.git\\` hierarchy, please switch to work-tree.\";;\n+\tesac\n+}\n+\n # setup_hook NAME\n setup_hook()\n {\n@@ -249,6 +263,8 @@ do_help()\n [ -d \"@cmddir@\" ] ||\n \tdie \"No command directory: '@cmddir@'\"\n \n+ensure_git_repo_or_die\n+\n ## Initial setup\n \n set -e\n-- \ntg: (2ea19b6..) fixes/ensure-worktree (depends on: upstream)\n"},{"id":"96329","messageId":"36ca99e90811210415g7b50c5c1m3185bf19cab104aa@mail.gmail.com","threadId":"16394","inReplyTo":"20081121120609.GA10326@piper.oerlikon.madduck.net","subject":"Re: TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-11-21T12:15:19Z","receivedAt":"2008-11-21T12:15:19Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"On Fri, Nov 21, 2008 at 13:06, martin f krafft <madduck@debian.org> wrote:\n> I think you wanted to CC Petr, not Junio. It's also useful to CC\n> Debian bugs if you know of them. :)\nI CC'ed Junio, because I think this git rev-parse --git-dir is a bug.\nFor example you can try starting git gui inside a .git dir.\n\n>\n> also sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1019 +0100]:\n>> I really second this. Plus, I think its crucial to check that we are\n>> not inside the .git directory before setting up topgit. Because git\n>> rev-parse --git-dir only works in the top .git dir, not deeper (i.e.\n>> inside .git/refs) and will always return \".\".\n>>\n>>       $(git rev-parse --is-inside-work-tree) ||\n>>               die \"Not in a git working directory\"\n>\n> Thanks, noted. I am still working on this patch, since\n> evaluating $argv/checking for --help at this early stage basically\n> requires a rewrite of the CLI parsing, ideally using POSIX getopt or\n> something similar, which takes much of the load away.\n>\n> Anyway, Patch for your proposal forthcoming.\nA patch would depent on your --help patch, Because help should work everywhere.\nSo either I wait for you or do do it.\n\nBert\n>\n> --\n>  .''`.   martin f. krafft <madduck@debian.org>\n> : :'  :  proud Debian developer, author, administrator, and user\n> `. `'`   http://people.debian.org/~madduck - http://debiansystem.info\n>  `-  Debian - when you have better things to do than fixing systems\n>\n> (a)bort, (r)etry, (p)retend this never happened\n>\n> -----BEGIN PGP SIGNATURE-----\n> Version: GnuPG v1.4.9 (GNU/Linux)\n>\n> iEYEARECAAYFAkkmpDAACgkQIgvIgzMMSnUSKgCghXE+J9KegZ03tetnM3TIcyeM\n> zn0AoJmYVzh/Kjxk7NFEpQw7USR0daXy\n> =xl31\n> -----END PGP SIGNATURE-----\n>\n>\n"},{"id":"96330","messageId":"36ca99e90811210418i5ae14a42t882988aed289d534@mail.gmail.com","threadId":"16394","inReplyTo":"36ca99e90811210415g7b50c5c1m3185bf19cab104aa@mail.gmail.com","subject":"Re: TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-11-21T12:18:42Z","receivedAt":"2008-11-21T12:18:42Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"On Fri, Nov 21, 2008 at 13:15, Bert Wesarg <bert.wesarg@googlemail.com> wrote:\n> On Fri, Nov 21, 2008 at 13:06, martin f krafft <madduck@debian.org> wrote:\n>> I think you wanted to CC Petr, not Junio. It's also useful to CC\n>> Debian bugs if you know of them. :)\n> I CC'ed Junio, because I think this git rev-parse --git-dir is a bug.\n> For example you can try starting git gui inside a .git dir.\nOh, I send a patch only to petr, but forgot to cc the list ;-)\n\nBut your patch should be fine, thanks.\n\nBert\n"},{"id":"96331","messageId":"20081121122347.GA19916@piper.oerlikon.madduck.net","threadId":"16394","inReplyTo":"36ca99e90811210415g7b50c5c1m3185bf19cab104aa@mail.gmail.com","subject":"Re: TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)","fromName":"martin f krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-21T12:23:47Z","receivedAt":"2008-11-21T12:23:47Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"also sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1315 +0100]:\n> I CC'ed Junio, because I think this git rev-parse --git-dir is\n> a bug. For example you can try starting git gui inside a .git dir.\n\nYou might want to let him know of your intention. :)\n\n> A patch would depent on your --help patch, Because help should\n> work everywhere. So either I wait for you or do do it.\n\nNo, not depend, but the patch makes the --help situation slightly\nworse, for now you cannot call --help inside .git anymore either.\nThis will force us to fix the --help situation quicker.\n\nI've run out of time, for a while at least. If you want to pick up\nthe pieces and convert argument parsing to POSIX getopt, or maybe\neven better, git-rev-parse --parseopt, then please go for it. You\ncan find my current TopGit branch at\n\n  http://git.debian.org/?p=collab-maint/topgit.git;a=shortlog;h=refs/heads/fixes/independent-help\n  git://git.debian.org/git/collab-maint/topgit.git, branch fixes/independent-help\n\nIf you use Debian: debcheckout topgit (requires devscripts 2.10.40)\n\nThanks,\n\n-- \n .''`.   martin f. krafft <madduck@debian.org>\n: :'  :  proud Debian developer, author, administrator, and user\n`. `'`   http://people.debian.org/~madduck - http://debiansystem.info\n  `-  Debian - when you have better things to do than fixing systems\n \n\"heuristic is computer science jargon for 'doesn't actually work.'\"\n                                                     -- charlie reiman\n"},{"id":"96332","messageId":"20081121123115.GA20537@piper.oerlikon.madduck.net","threadId":"16394","inReplyTo":"36ca99e90811210418i5ae14a42t882988aed289d534@mail.gmail.com","subject":"Re: TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)","fromName":"martin f krafft","fromEmail":"madduck@debian.org","sentAt":"2008-11-21T12:31:15Z","receivedAt":"2008-11-21T12:31:15Z","isPatch":true,"sender":{"key":"madduck@debian.org","avatar":null},"body":"also sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1318 +0100]:\n> Oh, I send a patch only to petr, but forgot to cc the list ;-)\n\nMaybe you can try to remember to CC me on topgit stuff in the future\ntoo, since I am helping Petr out a bit as his release apprentice. :)\n\n-- \n .''`.   martin f. krafft <madduck@debian.org>\n: :'  :  proud Debian developer, author, administrator, and user\n`. `'`   http://people.debian.org/~madduck - http://debiansystem.info\n  `-  Debian - when you have better things to do than fixing systems\n \ni stopped fighting my inner demons.. we're all on the same side now.\n"}]}