{"thread":{"id":"16372","subject":"[PATCH] Retain multiple -q/-v occurrences in git pull","startedAt":"2008-11-17T22:09:30Z","lastAt":"2008-11-19T23:00:14Z","messageCount":5,"participants":["Tuncer Ayaz","Junio C Hamano","Constantine Plotnikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"96061","messageId":"1226959770-4252-1-git-send-email-tuncer.ayaz@gmail.com","threadId":"16372","inReplyTo":null,"subject":"[PATCH] Retain multiple -q/-v occurrences in git pull","fromName":"Tuncer Ayaz","fromEmail":"tuncer.ayaz@gmail.com","sentAt":"2008-11-17T22:09:30Z","receivedAt":"2008-11-17T22:09:30Z","isPatch":true,"sender":{"key":"tuncer.ayaz@gmail.com","avatar":null},"body":"To support counting -q/-v options in git pull retain\nthem by concatenating.\n\nSigned-off-by: Tuncer Ayaz \n---\n git-pull.sh | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-pull.sh b/git-pull.sh\nindex 8866f2a..1cac898 100755\n--- a/git-pull.sh\n+++ b/git-pull.sh\n@@ -24,9 +24,9 @@ while :\n do\n \tcase \"$1\" in\n \t-q|--quiet)\n-\t\tverbosity=-q ;;\n+\t\tverbosity=\"$verbosity -q\" ;;\n \t-v|--verbose)\n-\t\tverbosity=-v ;;\n+\t\tverbosity=\"$verbosity -v\" ;;\n \t-n|--no-stat|--no-summary)\n \t\tno_stat=-n ;;\n \t--stat|--summary)\n-- \n1.6.0.2.GIT\n"},{"id":"96119","messageId":"7vd4gstr9n.fsf@gitster.siamese.dyndns.org","threadId":"16372","inReplyTo":"1226959770-4252-1-git-send-email-tuncer.ayaz@gmail.com","subject":"Re: [PATCH] Retain multiple -q/-v occurrences in git pull","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-11-19T01:53:56Z","receivedAt":"2008-11-19T01:53:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, queued.\n"},{"id":"96138","messageId":"85647ef50811190346x11aea0fay3a8a7dfd8ddf6abc@mail.gmail.com","threadId":"16372","inReplyTo":"1226959770-4252-1-git-send-email-tuncer.ayaz@gmail.com","subject":"Re: [PATCH] Retain multiple -q/-v occurrences in git pull","fromName":"Constantine Plotnikov","fromEmail":"constantine.plotnikov@gmail.com","sentAt":"2008-11-19T11:46:30Z","receivedAt":"2008-11-19T11:46:30Z","isPatch":true,"sender":{"key":"constantine.plotnikov@gmail.com","avatar":null},"body":"On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz wrote:\n> To support counting -q/-v options in git pull retain\n> them by concatenating.\n>\n[rest of message cut]\n\nBy the way, there is yet another way to invoke git fetch. It is \"git\nremote update\". Possibly it should support \"-v\" and \"-q\" options for\nconsistency as well.\n\nRegards,\nConstantine\n"},{"id":"96191","messageId":"4ac8254d0811191447q7c9c475fka30a15c21b10524e@mail.gmail.com","threadId":"16372","inReplyTo":"85647ef50811190346x11aea0fay3a8a7dfd8ddf6abc@mail.gmail.com","subject":"Re: [PATCH] Retain multiple -q/-v occurrences in git pull","fromName":"Tuncer Ayaz","fromEmail":"tuncer.ayaz@gmail.com","sentAt":"2008-11-19T22:47:28Z","receivedAt":"2008-11-19T22:47:28Z","isPatch":true,"sender":{"key":"tuncer.ayaz@gmail.com","avatar":null},"body":"On Wed, Nov 19, 2008 at 12:46 PM, Constantine Plotnikov\n wrote:\n> On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz wrote:\n>> To support counting -q/-v options in git pull retain\n>> them by concatenating.\n>>\n> [rest of message cut]\n>\n> By the way, there is yet another way to invoke git fetch. It is \"git\n> remote update\". Possibly it should support \"-v\" and \"-q\" options for\n> consistency as well.\n\nYes, we could add -q to builtin-remote and also make sure that it\npasses the already existing -v and maybe a yet-to-be-added -q to\nthe fetch command.\nI want to be first sure what the overall strategy regarding -q/-v is.\n\nRight now we have some code which uses OPT__VERBOSE/OPT__QUIET\nand some new code which uses the newly-added OPT__VERBOSITY.\n\nThese are the options I can see:\n1) Use the old and new macros and decide in each module which one to use\n2) Get rid off OPT__VERBOSE and OPT__QUIET and use OPT__VERBOSITY only\n3) Think about new ways to handle all of this. Possibly some new print_* macros?\n\nAny opinions?\n"},{"id":"96192","messageId":"4ac8254d0811191500q4e06558aj79926ab9d2401e7f@mail.gmail.com","threadId":"16372","inReplyTo":"4ac8254d0811191458r2a205be3w4a412553edc9b07f@mail.gmail.com","subject":"Re: [PATCH] Retain multiple -q/-v occurrences in git pull","fromName":"Tuncer Ayaz","fromEmail":"tuncer.ayaz@gmail.com","sentAt":"2008-11-19T23:00:14Z","receivedAt":"2008-11-19T23:00:14Z","isPatch":true,"sender":{"key":"tuncer.ayaz@gmail.com","avatar":null},"body":"[re-sent due to propagated wrong Junio address. sorry.]\n\nOn Wed, Nov 19, 2008 at 12:46 PM, Constantine Plotnikov\n wrote:\n> On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz wrote:\n>> To support counting -q/-v options in git pull retain\n>> them by concatenating.\n>>\n> [rest of message cut]\n>\n> By the way, there is yet another way to invoke git fetch. It is \"git\n> remote update\". Possibly it should support \"-v\" and \"-q\" options for\n> consistency as well.\n\nYes, we could add -q to builtin-remote and also make sure that it\npasses the already existing -v and maybe a yet-to-be-added -q to\nthe fetch command.\nI want to be first sure what the overall strategy regarding -q/-v is.\n\nRight now we have some code which uses OPT__VERBOSE/OPT__QUIET\nand some new code which uses the newly-added OPT__VERBOSITY.\n\nThese are the options I can see:\n1) Use the old and new macros and decide in each module which one to use\n2) Get rid off OPT__VERBOSE and OPT__QUIET and use OPT__VERBOSITY only\n3) Think about new ways to handle all of this. Possibly some new print_* macros?\n\nAny opinions?\n"}]}