{"thread":{"id":"16319","subject":"[PATCH (GITK)] gitk: Make line origin search update the busy status.","startedAt":"2008-11-13T20:43:13Z","lastAt":"2008-11-13T22:00:38Z","messageCount":2,"participants":["Alexander Gavrilov","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"95726","messageId":"200811132343.13910.angavrilov@gmail.com","threadId":"16319","inReplyTo":null,"subject":"[PATCH (GITK)] gitk: Make line origin search update the busy status.","fromName":"Alexander Gavrilov","fromEmail":"angavrilov@gmail.com","sentAt":"2008-11-13T20:43:13Z","receivedAt":"2008-11-13T20:43:13Z","isPatch":true,"sender":{"key":"angavrilov@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42666?v=4"},"body":"Currently the 'show origin of this line' feature does\nnot update the status field of the gitk window, so it\nis not evident that any processing is going on. It may\nseem at first that clicking the item had no effect.\n\nThis commit adds calls to set and clear the busy\nstatus with an appropriate title, similar to other\nsearch commands.\n\nSigned-off-by: Alexander Gavrilov <angavrilov@gmail.com>\n---\n gitk |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex e4562d7..3fb9c44 100755\n--- a/gitk\n+++ b/gitk\n@@ -3400,6 +3400,7 @@ proc show_line_source {} {\n \terror_popup [mc \"Couldn't start git blame: %s\" $err]\n \treturn\n     }\n+    nowbusy blaming [mc \"Blaming\"]\n     fconfigure $f -blocking 0\n     set i [reg_instance $f]\n     set blamestuff($i) {}\n@@ -3413,6 +3414,7 @@ proc stopblaming {} {\n     if {[info exists blameinst]} {\n \tstop_instance $blameinst\n \tunset blameinst\n+\tnotbusy blaming\n     }\n }\n \n@@ -3427,6 +3429,7 @@ proc read_line_source {fd inst} {\n     }\n     unset commfd($inst)\n     unset blameinst\n+    notbusy blaming\n     fconfigure $fd -blocking 1\n     if {[catch {close $fd} err]} {\n \terror_popup [mc \"Error running git blame: %s\" $err]\n-- \n1.6.0.3.15.gb8d36\n"},{"id":"95731","messageId":"18716.41862.32019.303080@cargo.ozlabs.ibm.com","threadId":"16319","inReplyTo":"200811132343.13910.angavrilov@gmail.com","subject":"Re: [PATCH (GITK)] gitk: Make line origin search update the busy status.","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2008-11-13T22:00:38Z","receivedAt":"2008-11-13T22:00:38Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Alexander Gavrilov writes:\n\n> Currently the 'show origin of this line' feature does\n> not update the status field of the gitk window, so it\n> is not evident that any processing is going on. It may\n> seem at first that clicking the item had no effect.\n> \n> This commit adds calls to set and clear the busy\n> status with an appropriate title, similar to other\n> search commands.\n\nI have been meaning to do this myself.  I want to find something\nbetter than \"Blaming\" to put in the status field, though, since\n\"blaming\" is jargon in this context.  Actually, \"Searching\" would\nprobably do.\n\nPaul.\n"}]}