{"thread":{"id":"16248","subject":"Install issues","startedAt":"2008-11-10T11:17:39Z","lastAt":"2008-11-12T08:14:15Z","messageCount":14,"participants":["H.Merijn Brand","Miklos Vajna","Andreas Ericsson","Junio C Hamano","Boyd Lynn Gerber"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"95327","messageId":"20081110121739.15f77a01@pc09.procura.nl","threadId":"16248","inReplyTo":null,"subject":"Install issues","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2008-11-10T11:17:39Z","receivedAt":"2008-11-10T11:17:39Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"1. OpenSUSE 11.0's yast2 does not have \"ignore dependency\" anymore in\n the gui, which makes installing git from the GIT RPMS to fail as it\n seems to depend on openssh-clients, a package that has been\n deprecated in SUSE, and is not available anymore\n\n In 10.3 you could still go on after \"ignore this dependency\n locally\", and all worked fine.\n\nSo now I have to build from source, or download the rpm and look up the\nflags to rpm to make --no-deps work. That feels dirty, so I rather build\n\nBuilds fine. Now 'make test', which I often mistype as 'make check'\nbecause the GNU folk refuse to add 'make test' as an alias for 'make\ncheck' and switching between all the sourse distributions that do it\nright (perl, git, ...) and those that do it wrong (GNU) I often type\nthe wrong one\n\ngit-1.6.0.4 112 > make check\nfor i in *.c; do sparse -g -O2 -Wall -DSHA1_HEADER='' -DNO_STRLCPY -D__BIG_ENDIAN__ -D__powerpc__ $i || exit; done\n/bin/sh: sparse: command not found\nmake: *** [check] Error 127\n\nMaybe the Makefile could be a little more user-friendly with a message\nlike\n\n\t\"Cannot run 'make check', as you do not have 'sparse' installed.\n\t Did you mean to run 'make test' instead?\"\n\nFYI\n'/bin/sh' ./aggregate-results.sh test-results/t*-*\nfixed 1\nsuccess 3726\nfailed 0\nbroken 2\ntotal 3729\nrm -f -r 'trash directory' test-results\n\n-- \nH.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/\nusing & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,\n11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"95329","messageId":"20081110113924.GR24201@genesis.frugalware.org","threadId":"16248","inReplyTo":"20081110121739.15f77a01@pc09.procura.nl","subject":"Re: Install issues","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-11-10T11:39:24Z","receivedAt":"2008-11-10T11:39:24Z","isPatch":false,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Mon, Nov 10, 2008 at 12:17:39PM +0100, \"H.Merijn Brand\" wrote:\n> git-1.6.0.4 112 > make check\n> for i in *.c; do sparse -g -O2 -Wall -DSHA1_HEADER='' -DNO_STRLCPY -D__BIG_ENDIAN__ -D__powerpc__ $i || exit; done\n> /bin/sh: sparse: command not found\n> make: *** [check] Error 127\n> \n> Maybe the Makefile could be a little more user-friendly with a message\n> like\n> \n> \t\"Cannot run 'make check', as you do not have 'sparse' installed.\n> \t Did you mean to run 'make test' instead?\"\n\nCare to send a patch?\n"},{"id":"95344","messageId":"20081110173101.3d76613b@pc09.procura.nl","threadId":"16248","inReplyTo":"20081110113924.GR24201@genesis.frugalware.org","subject":"Re: Install issues","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2008-11-10T16:31:01Z","receivedAt":"2008-11-10T16:31:01Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Mon, 10 Nov 2008 12:39:24 +0100, Miklos Vajna\n wrote:\n\n> On Mon, Nov 10, 2008 at 12:17:39PM +0100, \"H.Merijn Brand\" wrote:\n> > git-1.6.0.4 112 > make check\n> > for i in *.c; do sparse -g -O2 -Wall -DSHA1_HEADER='' -DNO_STRLCPY -D__BIG_ENDIAN__ -D__powerpc__ $i || exit; done\n> > /bin/sh: sparse: command not found\n> > make: *** [check] Error 127\n> > \n> > Maybe the Makefile could be a little more user-friendly with a message\n> > like\n> > \n> > \t\"Cannot run 'make check', as you do not have 'sparse' installed.\n> > \t Did you mean to run 'make test' instead?\"\n> \n> Care to send a patch?\n\n--- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n+++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n@@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n \t./test-sha1.sh\n \n check: common-cmds.h\n+\t@`sparse /dev/null` || (\\\n+\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n+\t echo \"Did you mean 'make test' instead?\" ;\\\n+\t exit 1 )\n \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n \n remove-dashes:\n\n-- \nH.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/\nusing & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,\n11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"95348","messageId":"20081110175123.GV24201@genesis.frugalware.org","threadId":"16248","inReplyTo":"20081110173101.3d76613b@pc09.procura.nl","subject":"Re: Install issues","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-11-10T17:51:23Z","receivedAt":"2008-11-10T17:51:23Z","isPatch":false,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Mon, Nov 10, 2008 at 05:31:01PM +0100, \"H.Merijn Brand\" wrote:\n> --- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n> +++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n> \t./test-sha1.sh\n> \n> check: common-cmds.h\n> +\t@`sparse /dev/null` || (\\\n> +\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n> +\t echo \"Did you mean 'make test' instead?\" ;\\\n> +\t exit 1 )\n> \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n\nPlease read Documentation/SubmittingPatches, your patch lacks a signoff\nand a commit message.\n\nThanks.\n"},{"id":"95442","messageId":"20081111085923.00213a89@pc09.procura.nl","threadId":"16248","inReplyTo":"20081110175123.GV24201@genesis.frugalware.org","subject":"Re: Install issues","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2008-11-11T07:59:23Z","receivedAt":"2008-11-11T07:59:23Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Mon, 10 Nov 2008 18:51:23 +0100, Miklos Vajna\n wrote:\n\n> On Mon, Nov 10, 2008 at 05:31:01PM +0100, \"H.Merijn Brand\" wrote:\n> > --- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n> > +++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n> > @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n> > \t./test-sha1.sh\n> > \n> > check: common-cmds.h\n> > +\t@`sparse /dev/null` || (\\\n> > +\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n> > +\t echo \"Did you mean 'make test' instead?\" ;\\\n> > +\t exit 1 )\n> > \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n> \n> Please read Documentation/SubmittingPatches, your patch lacks a signoff\n> and a commit message.\n\nYou're not making things easier for people that do not use git from a\ngit repo, something that happens quite a lot when you build from a\nreleased tarball.\n\ngit-1.6.0.4 $ git format-patch -M\nfatal: Not a git repository\nExit 128\n\nI don't like this at all. How much more work is it for you to add the\nsubject and sign-off yourself, instead of requiring that from people\nthat like to help?\n\nIn the perl development, the only thing we *require* is a diff that\neither uses unified (preferred) or context diff.\n\nI did follow the ideal patch flow so far:\n--8<---\nAn ideal patch flow\n\nHere is an ideal patch flow for this project the current maintainer\nsuggests to the contributors:\n\n (0) You come up with an itch. You code it up.\n\n (1) Send it to the list and cc people who may need to know about\n the change.\n-->8---\n\nCode speaks louder than words, so I proposed a patch.\nThis might be my last patch. git is not just another project I want to\nloose so much time in.\n\n--8<---\nAuthor: H.Merijn Brand \nDate: Mon, 10 Nov 2008 17:31:01 +0100\n\n Make check needs sparse. If sparse is not available, it might as\n well be a user error who really wanted make test.\n\nSigned-off-by: H.Merijn Brand \n---\n\ndiff --git a/Makefile.org b/Makefile\nindex becd008..718ddf2 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n ./test-sha1.sh\n\n check: common-cmds.h\n+ @`sparse /dev/null` || (\\\n+ echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n+ echo \"Did you mean 'make test' instead?\" ;\\\n+ exit 1 )\n for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n\n remove-dashes:\n-->8---\n\n-- \nH.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/\nusing & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,\n11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"95445","messageId":"49194DA8.2030008@op5.se","threadId":"16248","inReplyTo":"20081111085923.00213a89@pc09.procura.nl","subject":"Re: Install issues","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2008-11-11T09:17:28Z","receivedAt":"2008-11-11T09:17:28Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"H.Merijn Brand wrote:\n> On Mon, 10 Nov 2008 18:51:23 +0100, Miklos Vajna\n> wrote:\n> \n>> On Mon, Nov 10, 2008 at 05:31:01PM +0100, \"H.Merijn Brand\" wrote:\n>>> --- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n>>> +++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n>>> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n>>> \t./test-sha1.sh\n>>> \n>>> check: common-cmds.h\n>>> +\t@`sparse /dev/null` || (\\\n>>> +\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n>>> +\t echo \"Did you mean 'make test' instead?\" ;\\\n>>> +\t exit 1 )\n>>> \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n>> Please read Documentation/SubmittingPatches, your patch lacks a signoff\n>> and a commit message.\n> \n> You're not making things easier for people that do not use git from a\n> git repo, something that happens quite a lot when you build from a\n> released tarball.\n> \n\nI think it's assumed that most git developers will clone the git repo so\nthey can send their patches against the very latest code. Usually, that's\npart of \"how to submit patches\" of all projects.\n\n> git-1.6.0.4 $ git format-patch -M\n> fatal: Not a git repository\n> Exit 128\n> \n> I don't like this at all. How much more work is it for you to add the\n> subject and sign-off yourself, instead of requiring that from people\n> that like to help?\n> \n\n\"Ask not what a bunch of oss devs can do for you, but what you can do\nfor them. Especially if you want your changes accepted\".\n\nThe harsh reality is that this is your itch. Noone else cares very\nmuch either way, so if you want your change included, you'll have to\ndo it the way the project maintainer wants it.\n\n> In the perl development, the only thing we *require* is a diff that\n> either uses unified (preferred) or context diff.\n> \n\nNothing's required here, but since nobody else seems to have problems\nwith the check/test stuff here, noone else will fix it up for you.\n\nBesides that, I'm sure you require a teensy bit more than that. If I\nsend you a 14k line patch without a reasoning behind it, you won't\njust go ahead and apply it, will you? If I send an algorithm for a new\nhash that might actually be proprietary code from an anonymous email\naddress, wouldn't you want some sort of verification that I'm actually\nallowed to send that algorithm to you?\n\nIn git, those two steps are formalized into \"Sign your patches!\" and\n\"Write a proper commit message!\". Since they *are* formalized, we\nprovide handy tools for doing just that. It's up to you if you want to\nuse them. Dictating the patch submission (or rather, acceptancy policy)\nis not. Patches submitted incorrectly will have one of the following\nthings happen to them:\n1. The patch is forgotten entirely, since nobody cares about it enough\n to make it a \"proper\" patch (by git standards).\n2. The patch author resubmits it in the proper format.\n3. Someone else resubmits it in the proper format.\n4. Junio accepts it anyway.\n\n4 is the least likely to happen, and will pretty much only occur if\nsomeone finds some really horrible bug that absolutely and obviously\nhas to go in the git code. Even in those cases, 3 usually happens\nbefore Junio wakes up.\n\n3 is not very likely to happen unless the feature you're suggesting\nis of interest to a lot of people.\n\nOfcourse, *after* the patch has been submitted in the proper format,\nit can still get rejected. Submitting it properly is only the first\nstep towards getting any kind of review on it (basically).\n\n> I did follow the ideal patch flow so far:\n> --8<---\n> An ideal patch flow\n> \n> Here is an ideal patch flow for this project the current maintainer\n> suggests to the contributors:\n> \n> (0) You come up with an itch. You code it up.\n> \n> (1) Send it to the list and cc people who may need to know about\n> the change.\n> -->8---\n> \n> Code speaks louder than words, so I proposed a patch.\n> This might be my last patch. git is not just another project I want to\n> loose so much time in.\n> \n\nThat would be sad. We're a tad short on perl folks, although I guess\nthat's not much of an issue since we're rewriting most of it in C\nanyways.\n\nIf you should decide to relent though, I seriously suggest using the\ntools git provides for sending patches. If you do, you'll be able to\nable to send (properly formatted) patches very easily indeed.\n\nRant aside, thanks for the re-send. I'm sure Junio can sed s/Author/From/\non the mail and have git accept it properly in case he accepts it.\nOtherwise, I'll resubmit it, faking you as the author.\n\n> --8<---\n> Author: H.Merijn Brand \n> Date: Mon, 10 Nov 2008 17:31:01 +0100\n> \n> Make check needs sparse. If sparse is not available, it might as\n> well be a user error who really wanted make test.\n> \n> Signed-off-by: H.Merijn Brand \n> ---\n> \n> diff --git a/Makefile.org b/Makefile\n> index becd008..718ddf2 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n> ./test-sha1.sh\n> \n> check: common-cmds.h\n> + @`sparse /dev/null` || (\\\n> + echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n> + echo \"Did you mean 'make test' instead?\" ;\\\n> + exit 1 )\n> for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n> \n> remove-dashes:\n> -->8---\n> \n\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"95474","messageId":"7vhc6e17fv.fsf@gitster.siamese.dyndns.org","threadId":"16248","inReplyTo":"20081110175123.GV24201@genesis.frugalware.org","subject":"Re: Install issues","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-11-11T17:47:00Z","receivedAt":"2008-11-11T17:47:00Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Miklos Vajna writes:\n\n> On Mon, Nov 10, 2008 at 05:31:01PM +0100, \"H.Merijn Brand\" wrote:\n>> --- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n>> +++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n>> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n>> \t./test-sha1.sh\n>> \n>> check: common-cmds.h\n>> +\t@`sparse /dev/null` || (\\\n>> +\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n>> +\t echo \"Did you mean 'make test' instead?\" ;\\\n>> +\t exit 1 )\n>> \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n>\n> Please read Documentation/SubmittingPatches, your patch lacks a signoff\n> and a commit message.\n\nHeh, for something small and obvious like this, that's asking a tad too\nmuch, although a properly formatted message does reduce my workload and is\nappreciated.\n\nI said \"obvious\" not in the sense that it is \"obviously good\". It is\nobvious what issue the patch wants to address.\n\nHaving said that, it is far from clear if special casing \"make check\" like\nthis is a good thing, though. The crufts resulting from \"Four extra lines\nwon't hurt\" kind of reasoning can accumulate and snowball. Is reading the\nMakefile when your build fails in order to see if the target was what you\nreally wanted to invoke (ideally, it should rater be \"_before_ running\nmake, reading the Makefile to find out what you want to run\") a lost art\nthese days?\n"},{"id":"95477","messageId":"20081111190243.7044d6cb@pc09.procura.nl","threadId":"16248","inReplyTo":"7vhc6e17fv.fsf@gitster.siamese.dyndns.org","subject":"Re: Install issues","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2008-11-11T18:02:43Z","receivedAt":"2008-11-11T18:02:43Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Tue, 11 Nov 2008 09:47:00 -0800, Junio C Hamano \nwrote:\n\n> Miklos Vajna writes:\n> \n> > On Mon, Nov 10, 2008 at 05:31:01PM +0100, \"H.Merijn Brand\" wrote:\n> >> --- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n> >> +++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n> >> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n> >> \t./test-sha1.sh\n> >> \n> >> check: common-cmds.h\n> >> +\t@`sparse /dev/null` || (\\\n> >> +\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n> >> +\t echo \"Did you mean 'make test' instead?\" ;\\\n> >> +\t exit 1 )\n> >> \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n> >\n> > Please read Documentation/SubmittingPatches, your patch lacks a signoff\n> > and a commit message.\n> \n> Heh, for something small and obvious like this, that's asking a tad too\n> much, although a properly formatted message does reduce my workload and is\n> appreciated.\n\nJunio++\n\n> I said \"obvious\" not in the sense that it is \"obviously good\". It is\n> obvious what issue the patch wants to address.\n> \n> Having said that, it is far from clear if special casing \"make check\" like\n> this is a good thing, though. The crufts resulting from \"Four extra lines\n> won't hurt\" kind of reasoning can accumulate and snowball. Is reading the\n> Makefile when your build fails in order to see if the target was what you\n> really wanted to invoke (ideally, it should rater be \"_before_ running\n> make, reading the Makefile to find out what you want to run\") a lost art\n> these days?\n\nNot at all, and for me it was clear from the start, so I typed 'make\ntest' and went ahead.\n\nIt was that I am just all to aware of the GNU world that I can easily\nimagine other people making the same mistake, and just thought it\nend-user-friendly to do as I proposed.\n\nI'm by now way offended or scared away if you reject these kind of\npatches\n\n-- \nH.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/\nusing & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,\n11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"95491","messageId":"7vskpyynla.fsf@gitster.siamese.dyndns.org","threadId":"16248","inReplyTo":"20081110173101.3d76613b@pc09.procura.nl","subject":"Re: Install issues","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-11-11T21:11:45Z","receivedAt":"2008-11-11T21:11:45Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"H.Merijn Brand\" writes:\n\n> --- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n> +++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n> \t./test-sha1.sh\n> \n> check: common-cmds.h\n> +\t@`sparse /dev/null` || (\\\n> +\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n> +\t echo \"Did you mean 'make test' instead?\" ;\\\n> +\t exit 1 )\n\nWhen you mean \"grouping\", using {} is much clearer to convey your\nintention. Use of needless (subshell) forces the reader to wonder if you\nwanted to do something that affects the environment for later commands\ninside, and in this case you didn't.\n\nWhy do you have sparse check inside a backtick to produce a string to be\ninterpreted as a command to be executed?\n\nHow about doing this instead? 'sparse' without any parameter exits with\nsuccess status silently; when you do not have the command, the shell will\ncomplain with \"sparse: command not found\" anyway, so you only need to\nsuggest \"make 'test'\" and nothing else.\n\n-- >8 --\nSubject: Makefile: help people who run 'make check' by mistake\n\nThe target to run self test is 'make test', but there are people who try\n'make check' and worse yet do not have sparse installed.\n\nSuggest 'make test' target when they do not have 'sparse'.\n\nSigned-off-by: Junio C Hamano \n---\n Makefile | 11 ++++++++++-\n 1 files changed, 10 insertions(+), 1 deletions(-)\n\ndiff --git c/Makefile w/Makefile\nindex 40309e1..d3137ca 100644\n--- c/Makefile\n+++ w/Makefile\n@@ -1355,7 +1355,16 @@ check-sha1:: test-sha1$X\n \t./test-sha1.sh\n \n check: common-cmds.h\n-\tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n+\tif sparse; \\\n+\tthen \\\n+\t\tfor i in *.c; \\\n+\t\tdo \\\n+\t\t\tsparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; \\\n+\t\tdone; \\\n+\telse \\\n+\t\techo 2>&1 \"Did you mean 'make test'?\"; \\\n+\t\texit 1; \\\n+\tfi\n \n remove-dashes:\n \t./fixup-builtins $(BUILT_INS) $(PROGRAMS) $(SCRIPTS)\n"},{"id":"95501","messageId":"alpine.LNX.2.00.0811111554530.19159@suse104.zenez.com","threadId":"16248","inReplyTo":"20081111190243.7044d6cb@pc09.procura.nl","subject":"Re: Install issues","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-11-11T23:03:50Z","receivedAt":"2008-11-11T23:03:50Z","isPatch":false,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Tue, 11 Nov 2008, H.Merijn Brand wrote:\n> On Tue, 11 Nov 2008 09:47:00 -0800, Junio C Hamano \n> wrote:\n>> Miklos Vajna writes:\n>>> On Mon, Nov 10, 2008 at 05:31:01PM +0100, \"H.Merijn Brand\" wrote:\n>>>> --- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n>>>> +++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n>>>> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n>>>> \t./test-sha1.sh\n>>>>\n>>>> check: common-cmds.h\n>>>> +\t@`sparse /dev/null` || (\\\n>>>> +\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n>>>> +\t echo \"Did you mean 'make test' instead?\" ;\\\n>>>> +\t exit 1 )\n>>>> \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n>>>\n>>> Please read Documentation/SubmittingPatches, your patch lacks a signoff\n>>> and a commit message.\n\nHere is a check list I use to make sure my patches are OK.\n\nhttp://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD\n\n...\n> I'm by now way offended or scared away if you reject these kind of\n> patches\n\nThe crowed here may seem harsh but they really are not. They just have a \nlot to do and getting things to them in a format that is easy to follow \nand uses the above URL guildlines assists them in looking at the patches, \ncommit messages and sign-off. Git requires a sign-off in order for them \nto use the patches. It is a way to make sure everything is kept above \nboard and proper. This allow ever line of code to have a resource as to \nwhere and whence it ...\n\nDo not give up. Just try to do things in a manner that is easy to allow \nyour patches into Git.\n\nGood Luck,\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"95505","messageId":"20081112003547.38081e09@pc09.procura.nl","threadId":"16248","inReplyTo":"alpine.LNX.2.00.0811111554530.19159@suse104.zenez.com","subject":"Re: Install issues","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2008-11-11T23:35:47Z","receivedAt":"2008-11-11T23:35:47Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Tue, 11 Nov 2008 16:03:50 -0700, Boyd Lynn Gerber wrote:\n\n> Here is a check list I use to make sure my patches are OK.\n> \n> http://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD\n> ...\n> > I'm by now way offended or scared away if you reject these kind of\n ^\n/me meant \"no\" where he wrote \"now\" :( :(\nI can imagine people interpreting that sentence very very wrong.\n\n> > patches\n> \n> The crowed here may seem harsh but they really are not. They just have a \n> lot to do and getting things to them in a format that is easy to follow \n> and uses the above URL guildlines assists them in looking at the patches, \n> commit messages and sign-off. Git requires a sign-off in order for them \n> to use the patches. It is a way to make sure everything is kept above \n> board and proper. This allow ever line of code to have a resource as to \n> where and whence it ...\n> \n> Do not give up. Just try to do things in a manner that is easy to allow \n> your patches into Git.\n\n-- \nH.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/\nusing & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,\n11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"95507","messageId":"7vzlk5x21p.fsf@gitster.siamese.dyndns.org","threadId":"16248","inReplyTo":"20081112003547.38081e09@pc09.procura.nl","subject":"Re: Install issues","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-11-11T23:42:26Z","receivedAt":"2008-11-11T23:42:26Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"H.Merijn Brand\" writes:\n\n> On Tue, 11 Nov 2008 16:03:50 -0700, Boyd Lynn Gerber wrote:\n>\n>> Here is a check list I use to make sure my patches are OK.\n>> \n>> http://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD\n>> ...\n>> > I'm by now way offended or scared away if you reject these kind of\n> ^\n> /me meant \"no\" where he wrote \"now\" :( :(\n> I can imagine people interpreting that sentence very very wrong.\n\nThat is not even \"interpretation\". You _literally_ wrote the exact\nopposite of what you meant ;-).\n"},{"id":"95509","messageId":"20081112005303.5ab54c0e@pc09.procura.nl","threadId":"16248","inReplyTo":"7vzlk5x21p.fsf@gitster.siamese.dyndns.org","subject":"Re: Install issues","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2008-11-11T23:53:03Z","receivedAt":"2008-11-11T23:53:03Z","isPatch":false,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Tue, 11 Nov 2008 15:42:26 -0800, Junio C Hamano \nwrote:\n\n> \"H.Merijn Brand\" writes:\n> \n> > On Tue, 11 Nov 2008 16:03:50 -0700, Boyd Lynn Gerber wrote:\n> >\n> >> Here is a check list I use to make sure my patches are OK.\n> >> \n> >> http://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD\n> >> ...\n> >> > I'm by now way offended or scared away if you reject these kind of\n> > ^\n> > /me meant \"no\" where he wrote \"now\" :( :(\n> > I can imagine people interpreting that sentence very very wrong.\n> \n> That is not even \"interpretation\". You _literally_ wrote the exact\n> opposite of what you meant ;-).\n\nI'm really really sorry. That must have sounded harsh.\n\n-- \nH.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/\nusing & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,\n11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"95531","messageId":"491A9057.1020305@op5.se","threadId":"16248","inReplyTo":"7vhc6e17fv.fsf@gitster.siamese.dyndns.org","subject":"Re: Install issues","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2008-11-12T08:14:15Z","receivedAt":"2008-11-12T08:14:15Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Junio C Hamano wrote:\n> Miklos Vajna writes:\n> \n>> On Mon, Nov 10, 2008 at 05:31:01PM +0100, \"H.Merijn Brand\" wrote:\n>>> --- Makefile.org\t2008-11-10 17:29:53.000000000 +0100\n>>> +++ Makefile\t2008-11-10 17:29:39.000000000 +0100\n>>> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X\n>>> \t./test-sha1.sh\n>>> \n>>> check: common-cmds.h\n>>> +\t@`sparse /dev/null` || (\\\n>>> +\t echo \"The 'sparse' command is not available, so I cannot make the 'check' target\" ;\\\n>>> +\t echo \"Did you mean 'make test' instead?\" ;\\\n>>> +\t exit 1 )\n>>> \tfor i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done\n>> Please read Documentation/SubmittingPatches, your patch lacks a signoff\n>> and a commit message.\n> \n> Heh, for something small and obvious like this, that's asking a tad too\n> much, although a properly formatted message does reduce my workload and is\n> appreciated.\n> \n> I said \"obvious\" not in the sense that it is \"obviously good\". It is\n> obvious what issue the patch wants to address.\n> \n> Having said that, it is far from clear if special casing \"make check\" like\n> this is a good thing, though. The crufts resulting from \"Four extra lines\n> won't hurt\" kind of reasoning can accumulate and snowball. Is reading the\n> Makefile when your build fails in order to see if the target was what you\n> really wanted to invoke (ideally, it should rater be \"_before_ running\n> make, reading the Makefile to find out what you want to run\") a lost art\n> these days?\n> \n\nWhy not \"make help\" with as friendly a message as we can muster, like the\nlinux kernel does it?\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"}]}