{"thread":{"id":"16198","subject":"Bug: \"git-svn fetch\" segfaults on unknown user","startedAt":"2008-11-06T14:38:31Z","lastAt":"2008-11-06T23:08:05Z","messageCount":4,"participants":["Jens Seidel","Mikael Magnusson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"95051","messageId":"20081106143826.GA26900@merkur.sol.de","threadId":"16198","inReplyTo":null,"subject":"Bug: \"git-svn fetch\" segfaults on unknown user","fromName":"Jens Seidel","fromEmail":"jensseidel@users.sf.net","sentAt":"2008-11-06T14:38:31Z","receivedAt":"2008-11-06T14:38:31Z","isPatch":false,"sender":{"key":"jensseidel@users.sf.net","avatar":null},"body":"Hi,\n\nI noticed the following bug in git-svn version 1.6.0.3 (svn 1.5.5):\n\n\"git-svn fetch\" segfaults if I provide an incomplete svn.authorsfile config\nfile setting with account<-->email mappings. This happens if an unknown user\naccount is found in the Subversion log.\n\nIf I do not provide svn.authorsfile at all, it doesn't crash.\n\nJens\n"},{"id":"95052","messageId":"237967ef0811060643g1037b8dbuf3660dfa8e3ff625@mail.gmail.com","threadId":"16198","inReplyTo":"20081106143826.GA26900@merkur.sol.de","subject":"Re: Bug: \"git-svn fetch\" segfaults on unknown user","fromName":"Mikael Magnusson","fromEmail":"mikachu@gmail.com","sentAt":"2008-11-06T14:43:18Z","receivedAt":"2008-11-06T14:43:18Z","isPatch":false,"sender":{"key":"mikachu@gmail.com","avatar":null},"body":"2008/11/6 Jens Seidel :\n> Hi,\n>\n> I noticed the following bug in git-svn version 1.6.0.3 (svn 1.5.5):\n>\n> \"git-svn fetch\" segfaults if I provide an incomplete svn.authorsfile config\n> file setting with account<-->email mappings. This happens if an unknown user\n> account is found in the Subversion log.\n>\n> If I do not provide svn.authorsfile at all, it doesn't crash.\n\nAre you sure this isn't the regular svn 1.5.x crash? Ie, does\ncompiling subversion with --disable-runtime-module-search fix it?\n\n-- \nMikael Magnusson\n"},{"id":"95056","messageId":"20081106154808.GA27102@merkur.sol.de","threadId":"16198","inReplyTo":"237967ef0811060643g1037b8dbuf3660dfa8e3ff625@mail.gmail.com","subject":"Re: Bug: \"git-svn fetch\" segfaults on unknown user","fromName":"Jens Seidel","fromEmail":"jensseidel@users.sf.net","sentAt":"2008-11-06T15:48:09Z","receivedAt":"2008-11-06T15:48:09Z","isPatch":false,"sender":{"key":"jensseidel@users.sf.net","avatar":null},"body":"On Thu, Nov 06, 2008 at 03:43:18PM +0100, Mikael Magnusson wrote:\n> 2008/11/6 Jens Seidel :\n> > I noticed the following bug in git-svn version 1.6.0.3 (svn 1.5.5):\n> >\n> > \"git-svn fetch\" segfaults if I provide an incomplete svn.authorsfile config\n> > file setting with account<-->email mappings. This happens if an unknown user\n> > account is found in the Subversion log.\n\nI should really provide more information:\n\nI imported my Subversion repository in the past succesfully from my server\n(svn+ssh protocol). Since I'm new to git (and still confused by the large\namount of git tools) I decided to start on a svnsync'ed copy of my repository\n(file protocol) to avoid any harm. I added also some new config settings\nincluding svn.authorsfile and fetching revisions started to fail. The last\noutput was:\n\nr38 = 4dca32e3d82a32206fd11545d4f270e118f51f12 (trunk@166)\n M myproject/file\n\nRevision 39 contained the unknown user account so I suspected the error\nis related to an incomplete authors file.\n\nI used following versions of Subversion:\nClient: 1.5.5\nServer: 1.5.3\n\nAfter adding the missing account to the authors file it fetched all revisions,\ncalled the garbage collector and stilled crashed with a core dump. Last\noutput:\n\nChecked out HEAD:\n file:///home/jens/Subversion-Repository.synced/myproject/trunk r1700\nAbgebrochen (core dumped)\n\nThis happened also after I removed the svn.authorsfile config setting.\nMy current settings:\n\n[user]\n name = Jens Seidel\n email = jensseidel@users.sf.net\n[color]\n diff = auto\n branch = auto\n interactive = auto\n[svn]\n findcopiesharder = true\n rmdir = true\n\n\"gdb -c core\" is useless, it just mentions the error occured in\n\"perl git-svn fetch\" and there is no stacktrace (don't know how to\ndebug perl).\n\nI removed now both [svn] options and it failed again. So it seems a problem\nwith file:// access while svn+ssh:// works well.\n\n> Are you sure this isn't the regular svn 1.5.x crash? Ie, does\n> compiling subversion with --disable-runtime-module-search fix it?\n\nHuch? I follow the Subversion developer list and I'm not not aware of\nsuch a problem. Will try it now ...\n\nPS: Compared to previous releases of git the import is at least 10 times\nfaster. Good job!\n\nJens\n"},{"id":"95083","messageId":"20081106230804.GA27848@merkur.sol.de","threadId":"16198","inReplyTo":"20081106154808.GA27102@merkur.sol.de","subject":"Re: Bug: \"git-svn fetch\" segfaults on unknown user","fromName":"Jens Seidel","fromEmail":"jensseidel@users.sf.net","sentAt":"2008-11-06T23:08:05Z","receivedAt":"2008-11-06T23:08:05Z","isPatch":false,"sender":{"key":"jensseidel@users.sf.net","avatar":null},"body":"On Thu, Nov 06, 2008 at 04:48:09PM +0100, Jens Seidel wrote:\n> On Thu, Nov 06, 2008 at 03:43:18PM +0100, Mikael Magnusson wrote:\n> > 2008/11/6 Jens Seidel :\n> > > I noticed the following bug in git-svn version 1.6.0.3 (svn 1.5.5):\n> > >\n> > > \"git-svn fetch\" segfaults\n> \n> \"gdb -c core\" is useless, it just mentions the error occured in\n> \"perl git-svn fetch\" and there is no stacktrace (don't know how to\n> debug perl).\n> \n> I removed now both [svn] options and it failed again. So it seems a problem\n> with file:// access while svn+ssh:// works well.\n\nCould this be possible?\n\nI tried now also to svnsync the same repository on the server which I access with\nsvn+ssh://. \"svn-git fetch\" fails on this as well, strange ... The hook scripts\nor the property added by \"svnsync init\" are not responsible, right?\n\n> > Are you sure this isn't the regular svn 1.5.x crash? Ie, does\n> > compiling subversion with --disable-runtime-module-search fix it?\n\nNo, it did not help.\n\nI tried to reproduce it with a simple svn repository instead of my larger (not\npublic) one but failed.\n\nWhat further information do you need? Is there any way to obtain more debug info?\n\nJens\n"}]}