{"thread":{"id":"16142","subject":"[PATCH] Make Pthread link flags configurable","startedAt":"2008-11-02T23:43:20Z","lastAt":"2008-11-03T18:26:28Z","messageCount":4,"participants":["david.syzdek@acsalaska.net","Jakub Narebski","David Syzdek"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"94705","messageId":"1225669400-79505-1-git-send-email-david.syzdek@acsalaska.net","threadId":"16142","inReplyTo":null,"subject":"[PATCH] Make Pthread link flags configurable","fromName":"","fromEmail":"david.syzdek@acsalaska.net","sentAt":"2008-11-02T23:43:20Z","receivedAt":"2008-11-02T23:43:20Z","isPatch":true,"sender":{"key":"david.syzdek@acsalaska.net","avatar":"https://gravatar.com/avatar/e95b1d3f9cd971d72dc364b7d942090876dd515c89a3252bd2baa8702a437f38?d=mp&s=160"},"body":"From: David M. Syzdek <david.syzdek@acsalaska.net>\n\nFreeBSD 4.x systems use the linker flags `-pthread' instead of the\nlinker flags `-lpthread' when linking against the pthread library.\n\nSigned-off-by: David M. Syzdek <david.syzdek@acsalaska.net>\n---\n Makefile |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 489774d..6737cb0 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -229,6 +229,7 @@ INSTALL = install\n RPMBUILD = rpmbuild\n TCL_PATH = tclsh\n TCLTK_PATH = wish\n+PTHREAD_LIBS = -lpthread\n \n export TCL_PATH TCLTK_PATH\n \n@@ -691,6 +692,7 @@ ifeq ($(uname_S),FreeBSD)\n \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n \tTHREADED_DELTA_SEARCH = YesPlease\n \tifeq ($(shell expr \"$(uname_R)\" : '4\\.'),2)\n+\t\tPTHREAD_LIBS = -pthread\n \t\tNO_UINTMAX_T = YesPlease\n \t\tNO_STRTOUMAX = YesPlease\n \tendif\n@@ -1017,7 +1019,7 @@ endif\n \n ifdef THREADED_DELTA_SEARCH\n \tBASIC_CFLAGS += -DTHREADED_DELTA_SEARCH\n-\tEXTLIBS += -lpthread\n+\tEXTLIBS += $(PTHREAD_LIBS)\n \tLIB_OBJS += thread-utils.o\n endif\n ifdef DIR_HAS_BSD_GROUP_SEMANTICS\n-- \n1.6.0.2.GIT\n"},{"id":"94738","messageId":"m3hc6pf8k6.fsf@localhost.localdomain","threadId":"16142","inReplyTo":"1225669400-79505-1-git-send-email-david.syzdek@acsalaska.net","subject":"Re: [PATCH] Make Pthread link flags configurable","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-11-03T09:44:54Z","receivedAt":"2008-11-03T09:44:54Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"david.syzdek@acsalaska.net writes:\n\n> From: David M. Syzdek <david.syzdek@acsalaska.net>\n> \n> FreeBSD 4.x systems use the linker flags `-pthread' instead of the\n> linker flags `-lpthread' when linking against the pthread library.\n> \n> Signed-off-by: David M. Syzdek <david.syzdek@acsalaska.net>\n> ---\n>  Makefile |    4 +++-\n>  1 files changed, 3 insertions(+), 1 deletions(-)\n\nWould it be possible to add support for this also to configure.ac\n(and config.mak.in)?\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"94785","messageId":"9a0027270811031018t2b90ee64kcd2ef5e9afa73f6a@mail.gmail.com","threadId":"16142","inReplyTo":"m3hc6pf8k6.fsf@localhost.localdomain","subject":"Re: [PATCH] Make Pthread link flags configurable","fromName":"David Syzdek","fromEmail":"syzdek@gmail.com","sentAt":"2008-11-03T18:18:42Z","receivedAt":"2008-11-03T18:18:42Z","isPatch":true,"sender":{"key":"syzdek@gmail.com","avatar":"https://gravatar.com/avatar/7f7b4df7a7d9be0b968c23c9fb9281953356e59ddb5d6dd8f02a6ddf3d9d9d22?d=mp&s=160"},"body":"On Mon, Nov 3, 2008 at 12:44 AM, Jakub Narebski <jnareb@gmail.com> wrote:\n> david.syzdek@acsalaska.net writes:\n>\n>> From: David M. Syzdek <david.syzdek@acsalaska.net>\n>>\n>> FreeBSD 4.x systems use the linker flags `-pthread' instead of the\n>> linker flags `-lpthread' when linking against the pthread library.\n>>\n>> Signed-off-by: David M. Syzdek <david.syzdek@acsalaska.net>\n>> ---\n>>  Makefile |    4 +++-\n>>  1 files changed, 3 insertions(+), 1 deletions(-)\n>\n> Would it be possible to add support for this also to configure.ac\n> (and config.mak.in)?\n>\n\nI just sent a patch to the list that adds autoconf tests for pthreads.\n If the test is able to determine which flag to use, then it also sets\nTHREADED_DELTA_SEARCH.\n"},{"id":"94788","messageId":"200811031926.29302.jnareb@gmail.com","threadId":"16142","inReplyTo":"9a0027270811031018t2b90ee64kcd2ef5e9afa73f6a@mail.gmail.com","subject":"Re: [PATCH] Make Pthread link flags configurable","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-11-03T18:26:28Z","receivedAt":"2008-11-03T18:26:28Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"David Syzdek wrote:\n> On Mon, Nov 3, 2008 at 12:44 AM, Jakub Narebski <jnareb@gmail.com> wrote:\n>> david.syzdek@acsalaska.net writes:\n>>\n>>> From: David M. Syzdek <david.syzdek@acsalaska.net>\n>>>\n>>> FreeBSD 4.x systems use the linker flags `-pthread' instead of the\n>>> linker flags `-lpthread' when linking against the pthread library.\n>>>\n>>> Signed-off-by: David M. Syzdek <david.syzdek@acsalaska.net>\n>>> ---\n>>>  Makefile |    4 +++-\n>>>  1 files changed, 3 insertions(+), 1 deletions(-)\n>>\n>> Would it be possible to add support for this also to configure.ac\n>> (and config.mak.in)?\n>>\n> \n> I just sent a patch to the list that adds autoconf tests for pthreads.\n>  If the test is able to determine which flag to use, then it also sets\n> THREADED_DELTA_SEARCH.\n\nThanks a lot.\n\n-- \nJakub Narebski\nPoland\n"}]}