{"thread":{"id":"16077","subject":"[PATCH 1/1] diff: support making output friendlier for fine, grand users","startedAt":"2008-10-29T05:23:52Z","lastAt":"2008-10-29T22:24:03Z","messageCount":8,"participants":["Petr Baudis","Johannes Schindelin","David Brown","Jeff King","Miklos Vajna","Daniel Barkalow"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"94164","messageId":"1225257832-29086-1-git-send-email-pasky@suse.cz","threadId":"16077","inReplyTo":null,"subject":"[PATCH 1/1] diff: support making output friendlier for fine, grand users","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2008-10-29T05:23:52Z","receivedAt":"2008-10-29T05:23:52Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Signed-off-by: Johannes Schindelin \nSigned-off-by: Scott Chacon \nSigned-off-by: Tom Preston-Werner \nSigned-off-by: Jeff King \nSigned-off-by: J.H. \nSigned-off-by: Sam Vilain \nSigned-off-by: Christian Couder \nSigned-off-by: Kai Blin \nAcked-by: Petr Baudis \nEnabled-by: Cascade \"Smooth\" Amber \n---\n diff.c | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex e368fef..0e2c14a 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -2489,6 +2489,9 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)\n \telse if (!prefixcmp(arg, \"--output=\")) {\n \t\toptions->file = fopen(arg + strlen(\"--output=\"), \"w\");\n \t\toptions->close_file = 1;\n+\t}\n+\telse if (!strcmp(arg, \"--pirate\")) {\n+\t\tprintf(\"Arrrr! These be yer fine changes, me 'earty!!\\n\");\n \t} else\n \t\treturn 0;\n \treturn 1;\n-- \n1.5.4.5\n"},{"id":"94189","messageId":"20081029150731.GA9942@linode.davidb.org","threadId":"16077","inReplyTo":"1225257832-29086-1-git-send-email-pasky@suse.cz","subject":"Re: [PATCH 1/1] diff: support making output friendlier for fine, grand users","fromName":"David Brown","fromEmail":"git@davidb.org","sentAt":"2008-10-29T15:07:31Z","receivedAt":"2008-10-29T15:07:31Z","isPatch":true,"sender":{"key":"git@davidb.org","avatar":"https://gravatar.com/avatar/94c86a2938470a74c2eac5e2b69afc0871f79a660295c02219597aba8cb101c1?d=mp&s=160"},"body":"On Tue, Oct 28, 2008 at 10:23:52PM -0700, Petr Baudis wrote:\n\n>+\t}\n>+\telse if (!strcmp(arg, \"--pirate\")) {\n>+\t\tprintf(\"Arrrr! These be yer fine changes, me 'earty!!\\n\");\n\nWe need to wait until Sept 19 to apply this patch, however.\n\nDavid\n"},{"id":"94187","messageId":"alpine.DEB.1.00.0810291628050.22125@pacific.mpi-cbg.de.mpi-cbg.de","threadId":"16077","inReplyTo":"20081029150731.GA9942@linode.davidb.org","subject":"Re: [PATCH 1/1] diff: support making output friendlier for fine, grand users","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-10-29T15:28:26Z","receivedAt":"2008-10-29T15:28:26Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 29 Oct 2008, David Brown wrote:\n\n> On Tue, Oct 28, 2008 at 10:23:52PM -0700, Petr Baudis wrote:\n> \n> >+\t}\n> >+\telse if (!strcmp(arg, \"--pirate\")) {\n> >+\t\tprintf(\"Arrrr! These be yer fine changes, me 'earty!!\\n\");\n> \n> We need to wait until Sept 19 to apply this patch, however.\n\nWe could back-date it, of course.\n\nCiao,\nDscho\n"},{"id":"94199","messageId":"20081029170631.GA12078@sigill.intra.peff.net","threadId":"16077","inReplyTo":"1225257832-29086-1-git-send-email-pasky@suse.cz","subject":"[PATCH] increase git el1T3nEss","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-10-29T17:06:31Z","receivedAt":"2008-10-29T17:06:31Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"The uptake of git by script kiddies has been disappointingly\nminimal. Let's make it more palatable by allowing mixed-case\nand l33t-speak commands.\n\nSigned-off-by: Jeff King \n---\nThis commit was made by \"git c0mM1t\".\n\n git.c | 27 ++++++++++++++++++++++++++-\n 1 files changed, 26 insertions(+), 1 deletions(-)\n\ndiff --git a/git.c b/git.c\nindex 89feb0b..fd0ca67 100644\n--- a/git.c\n+++ b/git.c\n@@ -261,6 +261,31 @@ static int run_command(struct cmd_struct *p, int argc, const char **argv)\n \treturn 0;\n }\n \n+static char deelite(char in) {\n+\tif (isalpha(in))\n+\t\treturn tolower(in);\n+\tswitch (in) {\n+\tcase '0': return 'o';\n+\tcase '1': return 'i';\n+\tcase '3': return 'e';\n+\tcase '5': return 's';\n+\tcase '7': return 'l';\n+\t}\n+\treturn in;\n+}\n+\n+static int elitecmp(const char *a, const char *b) {\n+\twhile (1) {\n+\t\tchar ca = deelite(*a), cb = deelite(*b);\n+\t\tif (ca != cb)\n+\t\t\treturn ca < cb ? -1 : 1;\n+\t\tif (!ca)\n+\t\t\treturn 0;\n+\t\ta++;\n+\t\tb++;\n+\t}\n+}\n+\n static void handle_internal_command(int argc, const char **argv)\n {\n \tconst char *cmd = argv[0];\n@@ -381,7 +406,7 @@ static void handle_internal_command(int argc, const char **argv)\n \n \tfor (i = 0; i < ARRAY_SIZE(commands); i++) {\n \t\tstruct cmd_struct *p = commands+i;\n-\t\tif (strcmp(p->cmd, cmd))\n+\t\tif (elitecmp(p->cmd, cmd))\n \t\t\tcontinue;\n \t\texit(run_command(p, argc, argv));\n \t}\n-- \n1.6.0.3.764.ge6f2.dirty\n"},{"id":"94201","messageId":"20081029171133.GJ24201@genesis.frugalware.org","threadId":"16077","inReplyTo":"20081029170631.GA12078@sigill.intra.peff.net","subject":"Re: [PATCH] increase git el1T3nEss","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-10-29T17:11:33Z","receivedAt":"2008-10-29T17:11:33Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Wed, Oct 29, 2008 at 01:06:31PM -0400, Jeff King wrote:\n> The uptake of git by script kiddies has been disappointingly\n> minimal. Let's make it more palatable by allowing mixed-case\n> and l33t-speak commands.\n> \n> Signed-off-by: Jeff King \n> ---\n> This commit was made by \"git c0mM1t\".\n\nTestcase?\n\n(I hope it was not serious, just like my question. ;-)\n"},{"id":"94226","messageId":"alpine.LNX.1.00.0810291623360.19665@iabervon.org","threadId":"16077","inReplyTo":"20081029170631.GA12078@sigill.intra.peff.net","subject":"Re: [PATCH] increase git el1T3nEss","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-10-29T20:28:16Z","receivedAt":"2008-10-29T20:28:16Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Wed, 29 Oct 2008, Jeff King wrote:\n\n> The uptake of git by script kiddies has been disappointingly\n> minimal. Let's make it more palatable by allowing mixed-case\n> and l33t-speak commands.\n> \n> Signed-off-by: Jeff King \n> ---\n> This commit was made by \"git c0mM1t\".\n> \n> git.c | 27 ++++++++++++++++++++++++++-\n> 1 files changed, 26 insertions(+), 1 deletions(-)\n> \n> diff --git a/git.c b/git.c\n> index 89feb0b..fd0ca67 100644\n> --- a/git.c\n> +++ b/git.c\n> @@ -261,6 +261,31 @@ static int run_command(struct cmd_struct *p, int argc, const char **argv)\n> \treturn 0;\n> }\n> \n> +static char deelite(char in) {\n> +\tif (isalpha(in))\n> +\t\treturn tolower(in);\n> +\tswitch (in) {\n> +\tcase '0': return 'o';\n> +\tcase '1': return 'i';\n> +\tcase '3': return 'e';\n> +\tcase '5': return 's';\n> +\tcase '7': return 'l';\n\nYour mapping doesn't comply with ISO 1337.5p34k; 1 can be l (in addition \nto i), and 7 is T. Also, you're missing 4.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"94232","messageId":"20081029215044.GA19864@sigill.intra.peff.net","threadId":"16077","inReplyTo":"alpine.LNX.1.00.0810291623360.19665@iabervon.org","subject":"Re: [PATCH] increase git el1T3nEss","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-10-29T21:50:44Z","receivedAt":"2008-10-29T21:50:44Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Oct 29, 2008 at 04:28:16PM -0400, Daniel Barkalow wrote:\n\n> Your mapping doesn't comply with ISO 1337.5p34k; 1 can be l (in addition \n> to i), and 7 is T. Also, you're missing 4.\n\nPatches welcome.\n\n-Peff\n"},{"id":"94236","messageId":"20081029222403.GY10544@machine.or.cz","threadId":"16077","inReplyTo":"1225257832-29086-1-git-send-email-pasky@suse.cz","subject":"Re: [PATCH 1/1] diff: support making output friendlier for fine, grand users","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2008-10-29T22:24:03Z","receivedAt":"2008-10-29T22:24:03Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Tue, Oct 28, 2008 at 10:23:52PM -0700, Petr Baudis wrote:\n> Signed-off-by: Johannes Schindelin \n> Signed-off-by: Scott Chacon \n> Signed-off-by: Tom Preston-Werner \n> Signed-off-by: Jeff King \n> Signed-off-by: J.H. \n> Signed-off-by: Sam Vilain \n> Signed-off-by: Christian Couder \n> Signed-off-by: Kai Blin \n> Acked-by: Petr Baudis \n> Enabled-by: Cascade \"Smooth\" Amber \n\nSponsored-by: A Large Angry SCM \n"}]}