{"thread":{"id":"16070","subject":"[PATCH] Plug a memleak in builtin-revert","startedAt":"2008-10-28T17:27:33Z","lastAt":"2008-10-28T17:27:33Z","messageCount":1,"participants":["Alex Riesen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"94123","messageId":"20081028172733.GA7054@blimp.localdomain","threadId":"16070","inReplyTo":null,"subject":"[PATCH] Plug a memleak in builtin-revert","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-10-28T17:27:33Z","receivedAt":"2008-10-28T17:27:33Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Probably happened when working around git_path's problem with returned\nbuffer being reused.\n\n---\n builtin-revert.c |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-revert.c b/builtin-revert.c\nindex 4725540..7483a7a 100644\n--- a/builtin-revert.c\n+++ b/builtin-revert.c\n@@ -251,7 +251,7 @@ static int revert_or_cherry_pick(int argc, const char **argv)\n \tint i, index_fd, clean;\n \tchar *oneline, *reencoded_message = NULL;\n \tconst char *message, *encoding;\n-\tconst char *defmsg = xstrdup(git_path(\"MERGE_MSG\"));\n+\tchar *defmsg = xstrdup(git_path(\"MERGE_MSG\"));\n \tstruct merge_options o;\n \tstruct tree *result, *next_tree, *base_tree, *head_tree;\n \tstatic struct lock_file index_lock;\n@@ -432,6 +432,7 @@ static int revert_or_cherry_pick(int argc, const char **argv)\n \t\treturn execv_git_cmd(args);\n \t}\n \tfree(reencoded_message);\n+\tfree(defmsg);\n \n \treturn 0;\n }\n-- \n1.6.0.3.549.gb475d\n"}]}