{"thread":{"id":"16060","subject":"Gitk/Cygwin bug: phony local changes","startedAt":"2008-10-27T15:22:52Z","lastAt":"2008-10-28T16:04:53Z","messageCount":4,"participants":["Hannu Koivisto","Alex Riesen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"94054","messageId":"83bpx62hbn.fsf@kalahari.s2.org","threadId":"16060","inReplyTo":null,"subject":"Gitk/Cygwin bug: phony local changes","fromName":"Hannu Koivisto","fromEmail":"azure@iki.fi","sentAt":"2008-10-27T15:22:52Z","receivedAt":"2008-10-27T15:22:52Z","isPatch":false,"sender":{"key":"azure@iki.fi","avatar":null},"body":"Greetings,\n\ngit clone git://git.kernel.org/pub/scm/git/git.git\ncd git\ngitk\n\nwith Cygwin build of git version 1.6.0.3.523.g304d0 in Windows XP\nSP2 with Cygwin dll version 1.5.24 results to gitk showing \"Local\nuncommitted changes, not checked in to index\" entry in the history\ntree and if I select that entry, it seems to indicate that all\nfiles have changed but without any actual content changes.\n\ngit status doesn't show any changes.\n\nIf I run git diff (which displays no changes) or git reset and then\nrun gitk again, there is no longer that \"Local uncommitted\nchanges...\" entry.\n\nSince it was suggested on #irc, I tried \"git config --global\ncore.trustctime false\" but that didn't help, which I suppose was\nexpected since the documentation talks about differences between\nthe index and the working copy and I haven't added anything to the\nindex.\n\nI can reproduce this problem with another (private) repository as\nwell.\n\n-- \nHannu\n"},{"id":"94111","messageId":"837i7s3ga4.fsf@kalahari.s2.org","threadId":"16060","inReplyTo":"83bpx62hbn.fsf@kalahari.s2.org","subject":"Re: Gitk/Cygwin bug: phony local changes","fromName":"Hannu Koivisto","fromEmail":"azure@iki.fi","sentAt":"2008-10-28T15:12:19Z","receivedAt":"2008-10-28T15:12:19Z","isPatch":false,"sender":{"key":"azure@iki.fi","avatar":null},"body":"Hannu Koivisto writes:\n\n> Greetings,\n>\n> git clone git://git.kernel.org/pub/scm/git/git.git\n> cd git\n> gitk\n>\n> with Cygwin build of git version 1.6.0.3.523.g304d0 in Windows XP\n> SP2 with Cygwin dll version 1.5.24 results to gitk showing \"Local\n> uncommitted changes, not checked in to index\" entry in the history\n> tree and if I select that entry, it seems to indicate that all\n> files have changed but without any actual content changes.\n>\n> git status doesn't show any changes.\n>\n> If I run git diff (which displays no changes) or git reset and then\n> run gitk again, there is no longer that \"Local uncommitted\n> changes...\" entry.\n>\n> Since it was suggested on #irc, I tried \"git config --global\n> core.trustctime false\" but that didn't help, which I suppose was\n> expected since the documentation talks about differences between\n> the index and the working copy and I haven't added anything to the\n> index.\n>\n> I can reproduce this problem with another (private) repository as\n> well.\n\nI used bisect to find which commit introduced this bug and the\nresult is:\n\n7faee6b8de836904227ee98dc3d2c4c75b0ef3a1 is first bad commit\ncommit 7faee6b8de836904227ee98dc3d2c4c75b0ef3a1\nAuthor: Mark Levedahl \nDate: Mon Oct 13 00:33:31 2008 -0400\n\n compat/cygwin.c - Use cygwin's stat if core.filemode == true\n\n Cygwin's POSIX emulation allows use of core.filemode true, unlike native\n Window's implementation of stat / lstat, and Cygwin/git users who have\n configured core.filemode true in various repositories will be very\n unpleasantly surprised to find that git is no longer honoring that option.\n So, this patch forces use of Cygwin's stat functions if core.filemode is\n set true, regardless of any other considerations.\n \n Signed-off-by: Mark Levedahl \n Signed-off-by: Junio C Hamano \n\n:040000 040000 8cbed462649839a444f63c54ddc5b1a0fb5eed8e 4dab6846ae35f2c5d2971d5810c30b39278c7060 M Documentation\n:040000 040000 f64d96b06609aadc586fa4312a57900c911779df cbf9743456a38bb3584e48e27d4659e8ec3b0be4 M compat\n\n-- \nHannu\n"},{"id":"94114","messageId":"81b0412b0810280827o2ccca3bfw127877782f5a0909@mail.gmail.com","threadId":"16060","inReplyTo":"837i7s3ga4.fsf@kalahari.s2.org","subject":"Re: Gitk/Cygwin bug: phony local changes","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-10-28T15:27:36Z","receivedAt":"2008-10-28T15:27:36Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"2008/10/28 Hannu Koivisto :\n\n> I used bisect to find which commit introduced this bug and the\n> result is:\n>\n> 7faee6b8de836904227ee98dc3d2c4c75b0ef3a1 is first bad commit\n> commit 7faee6b8de836904227ee98dc3d2c4c75b0ef3a1\n> Author: Mark Levedahl \n> Date: Mon Oct 13 00:33:31 2008 -0400\n>\n> compat/cygwin.c - Use cygwin's stat if core.filemode == true\n>\n\nCould you try the patch from Junio's \"Re: [PATCH] Only update the\ncygwin-related configuration during state auto-setup\" mail and see\nif it changes anything?\n"},{"id":"94117","messageId":"831vy03dui.fsf@kalahari.s2.org","threadId":"16060","inReplyTo":"81b0412b0810280827o2ccca3bfw127877782f5a0909@mail.gmail.com","subject":"Re: Gitk/Cygwin bug: phony local changes","fromName":"Hannu Koivisto","fromEmail":"azure@iki.fi","sentAt":"2008-10-28T16:04:53Z","receivedAt":"2008-10-28T16:04:53Z","isPatch":false,"sender":{"key":"azure@iki.fi","avatar":null},"body":"\"Alex Riesen\" writes:\n\n> 2008/10/28 Hannu Koivisto :\n>\n>> I used bisect to find which commit introduced this bug and the\n>> result is:\n>>\n>> 7faee6b8de836904227ee98dc3d2c4c75b0ef3a1 is first bad commit\n>> commit 7faee6b8de836904227ee98dc3d2c4c75b0ef3a1\n>> Author: Mark Levedahl \n>> Date: Mon Oct 13 00:33:31 2008 -0400\n>>\n>> compat/cygwin.c - Use cygwin's stat if core.filemode == true\n>>\n>\n> Could you try the patch from Junio's \"Re: [PATCH] Only update the\n> cygwin-related configuration during state auto-setup\" mail and see\n> if it changes anything?\n\nIt seems to fix the problem.\n\nSomething I forgot to mention in the previous mail: the problem\noccurs whether I have core.fileMode set to true or false.\n\n-- \nHannu\n"}]}