{"thread":{"id":"16027","subject":"[PATCH] git-svn: change dashed git-config to git config","startedAt":"2008-10-23T19:21:34Z","lastAt":"2008-10-24T15:27:04Z","messageCount":3,"participants":["Deskin Miller","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"93801","messageId":"20081023192134.GB8320@euler","threadId":"16027","inReplyTo":null,"subject":"[PATCH] git-svn: change dashed git-config to git config","fromName":"Deskin Miller","fromEmail":"deskinm@umich.edu","sentAt":"2008-10-23T19:21:34Z","receivedAt":"2008-10-23T19:21:34Z","isPatch":true,"sender":{"key":"deskinm@umich.edu","avatar":"https://gravatar.com/avatar/d340a0e612cdf0a79535c71863c0b4c535e9aba63b42032226ae903e638b64f9?d=mp&s=160"},"body":"---\nWhen testing git-svn changes, I'll often use git-svn.perl directly on a\nrepository of mine, to see how things work.  Recently I had this happen:\n\n$ git-svn.perl info\nUse of uninitialized value in scalar chomp at ../git/git-svn.perl line 1202.\nUse of uninitialized value in concatenation (.) or string at ../git/git-svn.perl line 1203.\n\nbut the expected output showed up correctly, giving the SVN-like info.\n\ngit svn info appeared to work just fine though, despite there being essentially\nno difference between the two.  However, if I do the following, this is what I\nsee:\n\n$ env /usr/libexec/git-core/git-svn info\nCan't exec \"git-config\": No such file or directory at /usr/libexec/git-core/git-svn line 1202.\nUse of uninitialized value in scalar chomp at /usr/libexec/git-core/git-svn line 1202.\n\nAgain, the SVN info would still appear.\n\nRegardless, I think we want to change this call to use the non-dashed form.\n\nDeskin Miller\n \n git-svn.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 33e1b50..2e68c68 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1126,7 +1126,7 @@ sub read_repo_config {\n \t\tmy $v = $opts->{$o};\n \t\tmy ($key) = ($o =~ /^([a-zA-Z\\-]+)/);\n \t\t$key =~ s/-//g;\n-\t\tmy $arg = 'git-config';\n+\t\tmy $arg = 'git config';\n \t\t$arg .= ' --int' if ($o =~ /[:=]i$/);\n \t\t$arg .= ' --bool' if ($o !~ /[:=][sfi]$/);\n \t\tif (ref $v eq 'ARRAY') {\n-- \n1.6.0.2.554.g3041b\n"},{"id":"93840","messageId":"20081024091544.GB27362@untitled","threadId":"16027","inReplyTo":"20081023192134.GB8320@euler","subject":"Re: [PATCH] git-svn: change dashed git-config to git config","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2008-10-24T09:15:44Z","receivedAt":"2008-10-24T09:15:44Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Deskin Miller <deskinm@umich.edu> wrote:\n> ---\n> When testing git-svn changes, I'll often use git-svn.perl directly on a\n> repository of mine, to see how things work.  Recently I had this happen:\n> \n> $ git-svn.perl info\n> Use of uninitialized value in scalar chomp at ../git/git-svn.perl line 1202.\n> Use of uninitialized value in concatenation (.) or string at ../git/git-svn.perl line 1203.\n> \n> but the expected output showed up correctly, giving the SVN-like info.\n> \n> git svn info appeared to work just fine though, despite there being essentially\n> no difference between the two.  However, if I do the following, this is what I\n> see:\n> \n> $ env /usr/libexec/git-core/git-svn info\n> Can't exec \"git-config\": No such file or directory at /usr/libexec/git-core/git-svn line 1202.\n> Use of uninitialized value in scalar chomp at /usr/libexec/git-core/git-svn line 1202.\n> \n> Again, the SVN info would still appear.\n> \n> Regardless, I think we want to change this call to use the non-dashed form.\n\nThanks Deskin,\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\n\n> Deskin Miller\n>  \n>  git-svn.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index 33e1b50..2e68c68 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -1126,7 +1126,7 @@ sub read_repo_config {\n>  \t\tmy $v = $opts->{$o};\n>  \t\tmy ($key) = ($o =~ /^([a-zA-Z\\-]+)/);\n>  \t\t$key =~ s/-//g;\n> -\t\tmy $arg = 'git-config';\n> +\t\tmy $arg = 'git config';\n>  \t\t$arg .= ' --int' if ($o =~ /[:=]i$/);\n>  \t\t$arg .= ' --bool' if ($o !~ /[:=][sfi]$/);\n>  \t\tif (ref $v eq 'ARRAY') {\n> -- \n> 1.6.0.2.554.g3041b\n"},{"id":"93859","messageId":"20081024152704.GA983@euler","threadId":"16027","inReplyTo":"20081024091544.GB27362@untitled","subject":"Re: [PATCH] git-svn: change dashed git-config to git config","fromName":"Deskin Miller","fromEmail":"deskinm@umich.edu","sentAt":"2008-10-24T15:27:04Z","receivedAt":"2008-10-24T15:27:04Z","isPatch":true,"sender":{"key":"deskinm@umich.edu","avatar":"https://gravatar.com/avatar/d340a0e612cdf0a79535c71863c0b4c535e9aba63b42032226ae903e638b64f9?d=mp&s=160"},"body":"On Fri, Oct 24, 2008 at 02:15:44AM -0700, Eric Wong wrote:\n> Deskin Miller <deskinm@umich.edu> wrote:\n> > ---\n> > When testing git-svn changes, I'll often use git-svn.perl directly on a\n> > repository of mine, to see how things work.  Recently I had this happen:\n> > \n> > $ git-svn.perl info\n> > Use of uninitialized value in scalar chomp at ../git/git-svn.perl line 1202.\n> > Use of uninitialized value in concatenation (.) or string at ../git/git-svn.perl line 1203.\n> > \n> > but the expected output showed up correctly, giving the SVN-like info.\n> > \n> > git svn info appeared to work just fine though, despite there being essentially\n> > no difference between the two.  However, if I do the following, this is what I\n> > see:\n> > \n> > $ env /usr/libexec/git-core/git-svn info\n> > Can't exec \"git-config\": No such file or directory at /usr/libexec/git-core/git-svn line 1202.\n> > Use of uninitialized value in scalar chomp at /usr/libexec/git-core/git-svn line 1202.\n> > \n> > Again, the SVN info would still appear.\n> > \n> > Regardless, I think we want to change this call to use the non-dashed form.\n> \n> Thanks Deskin,\n> \n> Acked-by: Eric Wong <normalperson@yhbt.net>\n\nSorry, patch should have had a\n\nSigned-off-by: Deskin Miller <deskinm@umich.edu>\n\nFeel free to forge it. \n\n> > Deskin Miller\n> >  \n> >  git-svn.perl |    2 +-\n> >  1 files changed, 1 insertions(+), 1 deletions(-)\n> > \n> > diff --git a/git-svn.perl b/git-svn.perl\n> > index 33e1b50..2e68c68 100755\n> > --- a/git-svn.perl\n> > +++ b/git-svn.perl\n> > @@ -1126,7 +1126,7 @@ sub read_repo_config {\n> >  \t\tmy $v = $opts->{$o};\n> >  \t\tmy ($key) = ($o =~ /^([a-zA-Z\\-]+)/);\n> >  \t\t$key =~ s/-//g;\n> > -\t\tmy $arg = 'git-config';\n> > +\t\tmy $arg = 'git config';\n> >  \t\t$arg .= ' --int' if ($o =~ /[:=]i$/);\n> >  \t\t$arg .= ' --bool' if ($o !~ /[:=][sfi]$/);\n> >  \t\tif (ref $v eq 'ARRAY') {\n> > -- \n> > 1.6.0.2.554.g3041b\n"}]}