{"thread":{"id":"15945","subject":"[PATCH] Documentation: Better explain git-commit --author implications","startedAt":"2008-10-18T03:35:16Z","lastAt":"2008-10-19T04:19:23Z","messageCount":3,"participants":["Abhijit Bhopatkar","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"93337","messageId":"48F95974.3010503@devslashzero.com","threadId":"15945","inReplyTo":null,"subject":"[PATCH] Documentation: Better explain git-commit --author implications","fromName":"Abhijit Bhopatkar","fromEmail":"bain@devslashzero.com","sentAt":"2008-10-18T03:35:16Z","receivedAt":"2008-10-18T03:35:16Z","isPatch":true,"sender":{"key":"bain@devslashzero.com","avatar":"https://gravatar.com/avatar/3f9bfde580be8d4de9df5a129387d9069d43eb1a65d745c583de9dfe9d97ebc8?d=mp&s=160"},"body":"'--author' changes the author name and email, but the\ndocumentation was not clear that it will not affect the\n'--signoff' option which will still use the user's name and\nemail from the git settings.\n\nSigned-off-by: Abhijit Bhopatkar <bain@devslashzero.com>\n---\n Documentation/git-commit.txt |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex eb05b0f..17b69fa 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -78,7 +78,8 @@ OPTIONS\n \tOverride the author name used in the commit.  You can use the\n \tstandard `A U Thor <author@example.com>` format.  Otherwise,\n \tan existing commit that matches the given string and its author\n-\tname is used.\n+\tname is used. This has no effect on singoff line which will\n+\tstill use commiter name and email .\n\n -m <msg>::\n --message=<msg>::\n@@ -95,6 +96,7 @@ OPTIONS\n -s::\n --signoff::\n \tAdd Signed-off-by line at the end of the commit message.\n+\t'--author' option has no effect on this line.\n\n -n::\n --no-verify::\n-- \n1.5.6.3\n"},{"id":"93340","messageId":"7vfxmuec46.fsf@gitster.siamese.dyndns.org","threadId":"15945","inReplyTo":"48F95974.3010503@devslashzero.com","subject":"Re: [PATCH] Documentation: Better explain git-commit --author implications","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-10-18T04:55:05Z","receivedAt":"2008-10-18T04:55:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Abhijit Bhopatkar <bain@devslashzero.com> writes:\n\n> '--author' changes the author name and email, but the\n> documentation was not clear that it will not affect the\n> '--signoff' option which will still use the user's name and\n> email from the git settings.\n>\n> Signed-off-by: Abhijit Bhopatkar <bain@devslashzero.com>\n> ---\n>  Documentation/git-commit.txt |    4 +++-\n>  1 files changed, 3 insertions(+), 1 deletions(-)\n>\n> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\n> index eb05b0f..17b69fa 100644\n> --- a/Documentation/git-commit.txt\n> +++ b/Documentation/git-commit.txt\n> @@ -78,7 +78,8 @@ OPTIONS\n>  \tOverride the author name used in the commit.  You can use the\n>  \tstandard `A U Thor <author@example.com>` format.  Otherwise,\n>  \tan existing commit that matches the given string and its author\n> -\tname is used.\n> +\tname is used. This has no effect on singoff line which will\n> +\tstill use commiter name and email .\n>\n>  -m <msg>::\n>  --message=<msg>::\n> @@ -95,6 +96,7 @@ OPTIONS\n>  -s::\n>  --signoff::\n>  \tAdd Signed-off-by line at the end of the commit message.\n> +\t'--author' option has no effect on this line.\n\nI think it is much clearer if you do not say what does _not_ affect\nthings, but instead say what does.  So let's do this instead.\n\n        --signoff::\n                Add Signed-off-by line by the committer at the end of the commit\n                log message.\n\n\nAnd no other changes.\n\nBy making it clear that signoff is about the committer, it would be clear\nthat --author (or GIT_AUTHOR_NAME environment variable) would not affect\nit.\n"},{"id":"93407","messageId":"48FAB54B.2020304@devslashzero.com","threadId":"15945","inReplyTo":"7vfxmuec46.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] Documentation: Clarify '--signoff' for git-commit","fromName":"Abhijit Bhopatkar","fromEmail":"bain@devslashzero.com","sentAt":"2008-10-19T04:19:23Z","receivedAt":"2008-10-19T04:19:23Z","isPatch":true,"sender":{"key":"bain@devslashzero.com","avatar":"https://gravatar.com/avatar/3f9bfde580be8d4de9df5a129387d9069d43eb1a65d745c583de9dfe9d97ebc8?d=mp&s=160"},"body":"'--signoff' uses commiter name always to add the signoff line,\nmake it explicit in the documentation.\n\nSigned-off-by: Abhijit Bhopatkar <bain@devslashzero.com>\n---\n Documentation/git-commit.txt |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex eb05b0f..713ab0a 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -94,7 +94,8 @@ OPTIONS\n\n -s::\n --signoff::\n-\tAdd Signed-off-by line at the end of the commit message.\n+\tAdd Signed-off-by line by the commiter at the end of the commit\n+\tlog message.\n\n -n::\n --no-verify::\n-- \n1.5.6.3\n"}]}