{"thread":{"id":"15876","subject":"[PATCH] tests: shell negation portability fix","startedAt":"2008-10-13T09:35:59Z","lastAt":"2008-10-13T09:35:59Z","messageCount":1,"participants":["Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"92919","messageId":"20081013093558.GA17282@coredump.intra.peff.net","threadId":"15876","inReplyTo":null,"subject":"[PATCH] tests: shell negation portability fix","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-10-13T09:35:59Z","receivedAt":"2008-10-13T09:35:59Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Commit 969c8775 introduced a test which uses the non-portable construct:\n\n  command1 && ! command2 | command3\n\nwhich must be\n\n  command1 && ! (command2 | command3)\n\nto work on bsd shells (this is another example of bbf08124, which fixed\nseveral similar cases).\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nI had totally forgotten about this monstrosity until my autobuild broke.\n\ndiff --git a/t/t4128-apply-root.sh b/t/t4128-apply-root.sh\nindex bc7a8a8..8f6aea4 100755\n--- a/t/t4128-apply-root.sh\n+++ b/t/t4128-apply-root.sh\n@@ -72,7 +72,7 @@ test_expect_success 'apply --directory (delete file)' '\n \techo content >some/sub/dir/delfile &&\n \tgit add some/sub/dir/delfile &&\n \tgit apply --directory=some/sub/dir/ --index patch &&\n-\t! git ls-files | grep delfile\n+\t! (git ls-files | grep delfile)\n '\n \n cat > patch << 'EOF'\n"}]}