{"thread":{"id":"15827","subject":"[PATCH] builtin-apply: fix typo leading to stack corruption","startedAt":"2008-10-08T21:24:16Z","lastAt":"2008-10-09T16:12:02Z","messageCount":5,"participants":["Imre Deak","Junio C Hamano","Shawn O. Pearce","Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"92627","messageId":"48ed30f5.0707d00a.2994.6f1e@mx.google.com","threadId":"15827","inReplyTo":null,"subject":"[PATCH] builtin-apply: fix typo leading to stack corruption","fromName":"Imre Deak","fromEmail":"imre.deak@gmail.com","sentAt":"2008-10-08T21:24:16Z","receivedAt":"2008-10-08T21:24:16Z","isPatch":true,"sender":{"key":"imre.deak@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1049948?v=4"},"body":"This typo led to stack corruption for lines with whitespace fixes\nand length > 1024.\n---\n builtin-apply.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-apply.c b/builtin-apply.c\nindex 20bef1f..720dc7f 100644\n--- a/builtin-apply.c\n+++ b/builtin-apply.c\n@@ -1696,7 +1696,7 @@ static int match_fragment(struct image *img,\n \t\tfixlen = ws_fix_copy(buf, orig, oldlen, ws_rule, NULL);\n \n \t\t/* Try fixing the line in the target */\n-\t\tif (sizeof(tgtfixbuf) < tgtlen)\n+\t\tif (sizeof(tgtfixbuf) > tgtlen)\n \t\t\ttgtfix = tgtfixbuf;\n \t\telse\n \t\t\ttgtfix = xmalloc(tgtlen);\n-- \n1.6.0.2.308.g754c\n"},{"id":"92668","messageId":"7v4p3mors6.fsf@gitster.siamese.dyndns.org","threadId":"15827","inReplyTo":"48ed30f5.0707d00a.2994.6f1e@mx.google.com","subject":"Re: [PATCH] builtin-apply: fix typo leading to stack corruption","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-10-09T12:51:37Z","receivedAt":"2008-10-09T12:51:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Looks good and would look better with a sign-off.\n"},{"id":"92685","messageId":"20081009160428.GB29829@spearce.org","threadId":"15827","inReplyTo":"7v4p3mors6.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] builtin-apply: fix typo leading to stack corruption","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-10-09T16:04:28Z","receivedAt":"2008-10-09T16:04:28Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano <gitster@pobox.com> wrote:\n> Looks good and would look better with a sign-off.\n\nI'm holding off on applying this change for a little, hoping Imre\ncan give us a sign off, but really I don't think anyone can claim\ncopyright to the < sign.  If they can, we're in big trouble.  :-)\n\n-- \nShawn.\n"},{"id":"92686","messageId":"jYNqXNcmiUXkVpg8nytGwxXfAQx2H1W9kx59NrgLLGIbPFpol_FZVQ@cipher.nrlssc.navy.mil","threadId":"15827","inReplyTo":"20081009160428.GB29829@spearce.org","subject":"Re: [PATCH] builtin-apply: fix typo leading to stack corruption","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-10-09T16:07:38Z","receivedAt":"2008-10-09T16:07:38Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Shawn O. Pearce wrote:\n> Junio C Hamano <gitster@pobox.com> wrote:\n>> Looks good and would look better with a sign-off.\n> \n> I'm holding off on applying this change for a little, hoping Imre\n> can give us a sign off, but really I don't think anyone can claim\n> copyright to the < sign.  If they can, we're in big trouble.  :-)\n\nYou must have missed 48ee0b28.04eb300a.03f6.fffffe21@mx.google.com\n\n-b\n"},{"id":"92687","messageId":"20081009161202.GW8203@spearce.org","threadId":"15827","inReplyTo":"jYNqXNcmiUXkVpg8nytGwxXfAQx2H1W9kx59NrgLLGIbPFpol_FZVQ@cipher.nrlssc.navy.mil","subject":"Re: [PATCH] builtin-apply: fix typo leading to stack corruption","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-10-09T16:12:02Z","receivedAt":"2008-10-09T16:12:02Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Brandon Casey <casey@nrlssc.navy.mil> wrote:\n> Shawn O. Pearce wrote:\n> > Junio C Hamano <gitster@pobox.com> wrote:\n> >> Looks good and would look better with a sign-off.\n> > \n> > I'm holding off on applying this change for a little, hoping Imre\n> > can give us a sign off, but really I don't think anyone can claim\n> > copyright to the < sign.  If they can, we're in big trouble.  :-)\n> \n> You must have missed 48ee0b28.04eb300a.03f6.fffffe21@mx.google.com\n\nYes, I did.  So did gmane, but marc has it.  Thanks.\n\n-- \nShawn.\n"}]}