{"thread":{"id":"15776","subject":"[PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied.","startedAt":"2008-10-03T19:34:33Z","lastAt":"2008-10-03T20:44:35Z","messageCount":6,"participants":["Tuncer Ayaz","Daniel Barkalow","Constantine Plotnikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"92269","messageId":"4ac8254d0810031234x26ebc96cy7cf5dcae2ef516e0@mail.gmail.com","threadId":"15776","inReplyTo":null,"subject":"[PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied.","fromName":"Tuncer Ayaz","fromEmail":"tuncer.ayaz@gmail.com","sentAt":"2008-10-03T19:34:33Z","receivedAt":"2008-10-03T19:34:33Z","isPatch":true,"sender":{"key":"tuncer.ayaz@gmail.com","avatar":null},"body":"Following is a patch to complete the changes discussed\nhere http://marc.info/?l=git&m=121529226023180&w=2.\n\nI hope it makes sense and doesn't break something else.\n\nWith this simple one-liner patch applied I no longer see\nthe following remote messages as no-progress is correctly\nsent to the remote site:\nremote: Counting objects: 84102, done.\nremote: Compressing objects: 100% (24720/24720), done.\nremote: Total 84102 (delta 60949), reused 80810 (delta 57900)\n\nRegards,\n\n Tuncer Ayaz\n\nSigned-off-by: Tuncer Ayaz \n---\n transport.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/transport.c b/transport.c\nindex 71433d9..1f24011 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -644,7 +644,7 @@ static int fetch_refs_via_pack(struct transport *transport,\n args.include_tag = data->followtags;\n args.verbose = (transport->verbose > 0);\n args.quiet = args.no_progress = (transport->verbose < 0);\n- args.no_progress = !isatty(1);\n+ args.no_progress = args.quiet || !isatty(1);\n args.depth = data->depth;\n\n for (i = 0; i < nr_heads; i++)\n-- \n1.6.0.2\n"},{"id":"92271","messageId":"alpine.LNX.1.00.0810031548260.19665@iabervon.org","threadId":"15776","inReplyTo":"4ac8254d0810031234x26ebc96cy7cf5dcae2ef516e0@mail.gmail.com","subject":"Re: [PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied.","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-10-03T19:50:34Z","receivedAt":"2008-10-03T19:50:34Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Fri, 3 Oct 2008, Tuncer Ayaz wrote:\n\n> Following is a patch to complete the changes discussed\n> here http://marc.info/?l=git&m=121529226023180&w=2.\n> \n> I hope it makes sense and doesn't break something else.\n> \n> With this simple one-liner patch applied I no longer see\n> the following remote messages as no-progress is correctly\n> sent to the remote site:\n> remote: Counting objects: 84102, done.\n> remote: Compressing objects: 100% (24720/24720), done.\n> remote: Total 84102 (delta 60949), reused 80810 (delta 57900)\n> \n> Regards,\n> \n> Tuncer Ayaz\n> \n> Signed-off-by: Tuncer Ayaz \n> ---\n> transport.c | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/transport.c b/transport.c\n> index 71433d9..1f24011 100644\n> --- a/transport.c\n> +++ b/transport.c\n> @@ -644,7 +644,7 @@ static int fetch_refs_via_pack(struct transport *transport,\n> args.include_tag = data->followtags;\n> args.verbose = (transport->verbose > 0);\n> args.quiet = args.no_progress = (transport->verbose < 0);\n> - args.no_progress = !isatty(1);\n> + args.no_progress = args.quiet || !isatty(1);\n\nIf you're doing that, remove the \"args.no_progress =\" from the previous \nline, which was there to have that effect (but not so clearly). Aside from \nthat, it looks good to me.\n\n> args.depth = data->depth;\n> \n> for (i = 0; i < nr_heads; i++)\n> -- \n> 1.6.0.2\n> \n"},{"id":"92275","messageId":"4ac8254d0810031318j3e0f326ewc4bf250c51681670@mail.gmail.com","threadId":"15776","inReplyTo":"alpine.LNX.1.00.0810031548260.19665@iabervon.org","subject":"Re: [PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied.","fromName":"Tuncer Ayaz","fromEmail":"tuncer.ayaz@gmail.com","sentAt":"2008-10-03T20:18:55Z","receivedAt":"2008-10-03T20:18:55Z","isPatch":true,"sender":{"key":"tuncer.ayaz@gmail.com","avatar":null},"body":"On Fri, Oct 3, 2008 at 9:50 PM, Daniel Barkalow wrote:\n> On Fri, 3 Oct 2008, Tuncer Ayaz wrote:\n\n\n\n>> diff --git a/transport.c b/transport.c\n>> index 71433d9..1f24011 100644\n>> --- a/transport.c\n>> +++ b/transport.c\n>> @@ -644,7 +644,7 @@ static int fetch_refs_via_pack(struct transport *transport,\n>> args.include_tag = data->followtags;\n>> args.verbose = (transport->verbose > 0);\n>> args.quiet = args.no_progress = (transport->verbose < 0);\n>> - args.no_progress = !isatty(1);\n>> + args.no_progress = args.quiet || !isatty(1);\n>\n> If you're doing that, remove the \"args.no_progress =\" from the previous\n> line, which was there to have that effect (but not so clearly). Aside from\n> that, it looks good to me.\n>\n\n\n\nThanks Daniel, that makes a lot of sense.\n\nSigned-off-by: Tuncer Ayaz \n---\n transport.c | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/transport.c b/transport.c\nindex 71433d9..35cac44 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -643,8 +643,8 @@ static int fetch_refs_via_pack(struct transport *transport,\n args.use_thin_pack = data->thin;\n args.include_tag = data->followtags;\n args.verbose = (transport->verbose > 0);\n- args.quiet = args.no_progress = (transport->verbose < 0);\n- args.no_progress = !isatty(1);\n+ args.quiet = (transport->verbose < 0);\n+ args.no_progress = args.quiet || !isatty(1);\n args.depth = data->depth;\n\n for (i = 0; i < nr_heads; i++)\n-- \n1.6.0.2\n"},{"id":"92276","messageId":"85647ef50810031333m254036bav81d6dd4a58fb56da@mail.gmail.com","threadId":"15776","inReplyTo":"4ac8254d0810031318j3e0f326ewc4bf250c51681670@mail.gmail.com","subject":"Re: [PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied.","fromName":"Constantine Plotnikov","fromEmail":"constantine.plotnikov@gmail.com","sentAt":"2008-10-03T20:33:35Z","receivedAt":"2008-10-03T20:33:35Z","isPatch":true,"sender":{"key":"constantine.plotnikov@gmail.com","avatar":null},"body":"I think such patch would be too harsh for IDE plugin developers. When\ngit is run from IDE, the isatty(1) will be true. But progress\ninformation will be still useful, to display an operation progress to\nuser. Please provide a way to force output of progress (for example\nusing environment).\n\nRegards,\nConstantine\n\n\nOn Sat, Oct 4, 2008 at 12:18 AM, Tuncer Ayaz wrote:\n> On Fri, Oct 3, 2008 at 9:50 PM, Daniel Barkalow wrote:\n>> On Fri, 3 Oct 2008, Tuncer Ayaz wrote:\n>\n> \n>\n>>> diff --git a/transport.c b/transport.c\n>>> index 71433d9..1f24011 100644\n>>> --- a/transport.c\n>>> +++ b/transport.c\n>>> @@ -644,7 +644,7 @@ static int fetch_refs_via_pack(struct transport *transport,\n>>> args.include_tag = data->followtags;\n>>> args.verbose = (transport->verbose > 0);\n>>> args.quiet = args.no_progress = (transport->verbose < 0);\n>>> - args.no_progress = !isatty(1);\n>>> + args.no_progress = args.quiet || !isatty(1);\n>>\n>> If you're doing that, remove the \"args.no_progress =\" from the previous\n>> line, which was there to have that effect (but not so clearly). Aside from\n>> that, it looks good to me.\n>>\n>\n> \n>\n> Thanks Daniel, that makes a lot of sense.\n>\n> Signed-off-by: Tuncer Ayaz \n> ---\n> transport.c | 4 ++--\n> 1 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/transport.c b/transport.c\n> index 71433d9..35cac44 100644\n> --- a/transport.c\n> +++ b/transport.c\n> @@ -643,8 +643,8 @@ static int fetch_refs_via_pack(struct transport *transport,\n> args.use_thin_pack = data->thin;\n> args.include_tag = data->followtags;\n> args.verbose = (transport->verbose > 0);\n> - args.quiet = args.no_progress = (transport->verbose < 0);\n> - args.no_progress = !isatty(1);\n> + args.quiet = (transport->verbose < 0);\n> + args.no_progress = args.quiet || !isatty(1);\n> args.depth = data->depth;\n>\n> for (i = 0; i < nr_heads; i++)\n> --\n> 1.6.0.2\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>\n"},{"id":"92277","messageId":"alpine.LNX.1.00.0810031636010.19665@iabervon.org","threadId":"15776","inReplyTo":"85647ef50810031333m254036bav81d6dd4a58fb56da@mail.gmail.com","subject":"Re: [PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied.","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-10-03T20:39:55Z","receivedAt":"2008-10-03T20:39:55Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Sat, 4 Oct 2008, Constantine Plotnikov wrote:\n\n> I think such patch would be too harsh for IDE plugin developers. When\n> git is run from IDE, the isatty(1) will be true. But progress\n> information will be still useful, to display an operation progress to\n> user. Please provide a way to force output of progress (for example\n> using environment).\n\nProbably progress.h ought to have something for whether progress bars make \nsense, that uses isatty(1) with an environment variable override. \nConceptually, transport.c should be figuring out whether the verbosity of \nthe operation suggests progress bars, and should pass off to something \nelse the determination of whether we can actually output progress bars in \nparticular.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"92278","messageId":"4ac8254d0810031344q12638e4ra5982373ae9c8908@mail.gmail.com","threadId":"15776","inReplyTo":"85647ef50810031333m254036bav81d6dd4a58fb56da@mail.gmail.com","subject":"Re: [PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied.","fromName":"Tuncer Ayaz","fromEmail":"tuncer.ayaz@gmail.com","sentAt":"2008-10-03T20:44:35Z","receivedAt":"2008-10-03T20:44:35Z","isPatch":true,"sender":{"key":"tuncer.ayaz@gmail.com","avatar":null},"body":"On Fri, Oct 3, 2008 at 10:33 PM, Constantine Plotnikov\n wrote:\n> I think such patch would be too harsh for IDE plugin developers. When\n> git is run from IDE, the isatty(1) will be true. But progress\n> information will be still useful, to display an operation progress to\n> user. Please provide a way to force output of progress (for example\n> using environment).\n\nHi Constantine,\n\nthis only fixes what was wrong: If you call \"git clone -q\" args.no_progress\nwas meant to be 1 but wasn't due to a small error.\nIf isatty(1) returns 1 then args.no_progress=0, so you will get progress\nlogging in that case - assuming you haven't supplied -q.\n\nTo get progress logging call without -q _and_ have isatty(1)==1.\n\n> Regards,\n> Constantine\n>\n>\n> On Sat, Oct 4, 2008 at 12:18 AM, Tuncer Ayaz wrote:\n>> On Fri, Oct 3, 2008 at 9:50 PM, Daniel Barkalow wrote:\n>>> On Fri, 3 Oct 2008, Tuncer Ayaz wrote:\n>>\n>> \n>>\n>>>> diff --git a/transport.c b/transport.c\n>>>> index 71433d9..1f24011 100644\n>>>> --- a/transport.c\n>>>> +++ b/transport.c\n>>>> @@ -644,7 +644,7 @@ static int fetch_refs_via_pack(struct transport *transport,\n>>>> args.include_tag = data->followtags;\n>>>> args.verbose = (transport->verbose > 0);\n>>>> args.quiet = args.no_progress = (transport->verbose < 0);\n>>>> - args.no_progress = !isatty(1);\n>>>> + args.no_progress = args.quiet || !isatty(1);\n>>>\n>>> If you're doing that, remove the \"args.no_progress =\" from the previous\n>>> line, which was there to have that effect (but not so clearly). Aside from\n>>> that, it looks good to me.\n>>>\n>>\n>> \n>>\n>> Thanks Daniel, that makes a lot of sense.\n>>\n>> Signed-off-by: Tuncer Ayaz \n>> ---\n>> transport.c | 4 ++--\n>> 1 files changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/transport.c b/transport.c\n>> index 71433d9..35cac44 100644\n>> --- a/transport.c\n>> +++ b/transport.c\n>> @@ -643,8 +643,8 @@ static int fetch_refs_via_pack(struct transport *transport,\n>> args.use_thin_pack = data->thin;\n>> args.include_tag = data->followtags;\n>> args.verbose = (transport->verbose > 0);\n>> - args.quiet = args.no_progress = (transport->verbose < 0);\n>> - args.no_progress = !isatty(1);\n>> + args.quiet = (transport->verbose < 0);\n>> + args.no_progress = args.quiet || !isatty(1);\n>> args.depth = data->depth;\n>>\n>> for (i = 0; i < nr_heads; i++)\n>> --\n>> 1.6.0.2\n>> --\n>> To unsubscribe from this list: send the line \"unsubscribe git\" in\n>> the body of a message to majordomo@vger.kernel.org\n>> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>>\n>\n"}]}