{"thread":{"id":"15765","subject":"[PATCH] Makefile: do not set NEEDS_LIBICONV for Solaris 8","startedAt":"2008-10-03T06:39:36Z","lastAt":"2008-10-03T06:39:36Z","messageCount":1,"participants":["Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"92223","messageId":"20081003063936.GA15132@coredump.intra.peff.net","threadId":"15765","inReplyTo":null,"subject":"[PATCH] Makefile: do not set NEEDS_LIBICONV for Solaris 8","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-10-03T06:39:36Z","receivedAt":"2008-10-03T06:39:36Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"This breaks my build on Solaris 8, as there is no separate\nlibiconv.\n\nThe history of this line is somewhat convoluted. In 2fd955c\n(in November 2005), NEEDS_LIBICONV was turned on for all\nSolaris builds, claiming to \"fix an error in Solaris 10 by\nsetting NEEDS_LIBICONV\".\n\nLater, e15f545 (in February of 2006) claimed that \"Solaris\n9+ don't need iconv\", and moved NEEDS_LIBICONV into a\nsection for Solaris 8.\n\nFurthermore, Brandon Casey claims in\n\n<5A1KxlhmUIHe8iXPxnXYuNXsq0Yjlbwkz2eBin3z7ELuL9nK-4tSpw@cipher.nrlssc.navy.mil>\n\nthat he does not set NEEDS_LIBICONV for Solaris 7.\n\nSo either one of those commits is totally wrong, or there is\nsome other magic going on where some Solaris installs need\nit and others don't.\n\nGiven Brandon's statement and my problems on Solaris 8 with\nNEEDS_LIBICONV, I am inclined to think the first commit was\nbogus, and that NEEDS_LIBICONV shouldn't be set for Solaris\nat all by default. If somebody wants to use iconv and has\ninstalled it manually, they can set it in their config.mak.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\n Makefile |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 3abbb4e..308dc70 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -651,7 +651,6 @@ ifeq ($(uname_S),SunOS)\n \tNO_MKDTEMP = YesPlease\n \tOLD_ICONV = UnfortunatelyYes\n \tifeq ($(uname_R),5.8)\n-\t\tNEEDS_LIBICONV = YesPlease\n \t\tNO_UNSETENV = YesPlease\n \t\tNO_SETENV = YesPlease\n \t\tNO_C99_FORMAT = YesPlease\n-- \n1.6.0.2.624.g13e35\n"}]}