{"thread":{"id":"15758","subject":"[PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh","startedAt":"2008-10-02T14:52:20Z","lastAt":"2008-10-02T16:41:30Z","messageCount":3,"participants":["Jakub Narebski","Petr Baudis","Eric Raible"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"92171","messageId":"20081002145010.19247.44420.stgit@localhost.localdomain","threadId":"15758","inReplyTo":null,"subject":"[PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-10-02T14:52:20Z","receivedAt":"2008-10-02T14:52:20Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Note that those tests only that there are no errors nor warnings\nfrom Perl; they do not check for example if gitweb doesn't use\nARRAY(0x8e3cc20) instead of correct value in links, etc.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nThis is the test thans to which I have dicovered errors in git_tree()\nfixed in previous email. Nevertheless those two patches are unrelated,\nso they are not numbered.\n\nThose tests check _current_ situation, without $action, not\n$hash_parent parameters possible in path_info.\n\n t/t9500-gitweb-standalone-no-errors.sh |   49 ++++++++++++++++++++++++++++++++\n 1 files changed, 49 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh\nindex 07117a8..64c4cce 100755\n--- a/t/t9500-gitweb-standalone-no-errors.sh\n+++ b/t/t9500-gitweb-standalone-no-errors.sh\n@@ -503,6 +503,55 @@ test_expect_success \\\n test_debug 'cat gitweb.log'\n \n # ----------------------------------------------------------------------\n+# path_info links\n+test_expect_success \\\n+\t'path_info: project' \\\n+\t'gitweb_run \"\" \"/.git\"'\n+test_debug 'cat gitweb.log'\n+\n+test_expect_success \\\n+\t'path_info: project/branch' \\\n+\t'gitweb_run \"\" \"/.git/b\"'\n+test_debug 'cat gitweb.log'\n+\n+test_expect_success \\\n+\t'path_info: project/branch:file' \\\n+\t'gitweb_run \"\" \"/.git/master:file\"'\n+test_debug 'cat gitweb.log'\n+\n+test_expect_success \\\n+\t'path_info: project/branch:dir/' \\\n+\t'gitweb_run \"\" \"/.git/master:foo/\"'\n+test_debug 'cat gitweb.log'\n+\n+test_expect_success \\\n+\t'path_info: project/branch:file (non-existent)' \\\n+\t'gitweb_run \"\" \"/.git/master:non-existent\"'\n+test_debug 'cat gitweb.log'\n+\n+test_expect_success \\\n+\t'path_info: project/branch:dir/ (non-existent)' \\\n+\t'gitweb_run \"\" \"/.git/master:non-existent/\"'\n+test_debug 'cat gitweb.log'\n+\n+\n+test_expect_success \\\n+\t'path_info: project/branch:/file' \\\n+\t'gitweb_run \"\" \"/.git/master:/file\"'\n+test_debug 'cat gitweb.log'\n+\n+test_expect_success \\\n+\t'path_info: project/:/file (implicit HEAD)' \\\n+\t'gitweb_run \"\" \"/.git/:/file\"'\n+test_debug 'cat gitweb.log'\n+\n+test_expect_success \\\n+\t'path_info: project/:/ (implicit HEAD, top tree)' \\\n+\t'gitweb_run \"\" \"/.git/:/\"'\n+test_debug 'cat gitweb.log'\n+\n+\n+# ----------------------------------------------------------------------\n # feed generation\n \n test_expect_success \\\n"},{"id":"92177","messageId":"20081002150725.GP10544@machine.or.cz","threadId":"15758","inReplyTo":"20081002145010.19247.44420.stgit@localhost.localdomain","subject":"Re: [PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2008-10-02T15:07:25Z","receivedAt":"2008-10-02T15:07:25Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Thu, Oct 02, 2008 at 04:52:20PM +0200, Jakub Narebski wrote:\n> Note that those tests only that there are no errors nor warnings\n> from Perl; they do not check for example if gitweb doesn't use\n> ARRAY(0x8e3cc20) instead of correct value in links, etc.\n> \n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> ---\n> This is the test thans to which I have dicovered errors in git_tree()\n> fixed in previous email. Nevertheless those two patches are unrelated,\n> so they are not numbered.\n> \n> Those tests check _current_ situation, without $action, not\n> $hash_parent parameters possible in path_info.\n\nI didn't test the patch but it all looks sensible.\n\nAcked-by: Petr Baudis <pasky@suse.cz>\n"},{"id":"92184","messageId":"loom.20081002T164037-13@post.gmane.org","threadId":"15758","inReplyTo":"20081002145010.19247.44420.stgit@localhost.localdomain","subject":"Re: [PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh","fromName":"Eric Raible","fromEmail":"raible@gmail.com","sentAt":"2008-10-02T16:41:30Z","receivedAt":"2008-10-02T16:41:30Z","isPatch":true,"sender":{"key":"raible@gmail.com","avatar":null},"body":"Jakub Narebski <jnareb <at> gmail.com> writes:\n\n> \n> Note that those tests only that there are no errors nor warnings\n> from Perl; they do not check for example if gitweb doesn't use\n> ARRAY(0x8e3cc20) instead of correct value in links, etc.\n> \n> Signed-off-by: Jakub Narebski <jnareb <at> gmail.com>\n> ---\n\ns/only that/only check that/\n"}]}