{"thread":{"id":"15754","subject":"Re: [PATCH] format-patch: autonumber by default","startedAt":"2008-10-02T11:27:40Z","lastAt":"2009-11-04T17:48:34Z","messageCount":21,"participants":["Johannes Schindelin","Giuseppe Bilotta","Andreas Ericsson","Johannes Sixt","Jakub Narebski","Jeff King","Brian Gernhardt","Eric W. Biederman","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"92189","messageId":"1222946860-15518-1-git-send-email-giuseppe.bilotta@gmail.com","threadId":"15754","inReplyTo":null,"subject":"[PATCH] format-patch: autonumber by default","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2008-10-02T11:27:40Z","receivedAt":"2008-10-02T11:27:40Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"Set auto-number true by default, allowing the format.number key to be\nset to 'noauto' to override this.\n---\n builtin-log.c | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-log.c b/builtin-log.c\nindex fc5e4da..5187dc2 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -426,7 +426,7 @@ static int istitlechar(char c)\n \n static const char *fmt_patch_suffix = \".patch\";\n static int numbered = 0;\n-static int auto_number = 0;\n+static int auto_number = 1;\n \n static char **extra_hdr;\n static int extra_hdr_nr;\n@@ -484,6 +484,10 @@ static int git_format_config(const char *var, const char *value, void *cb)\n \t\t\tauto_number = 1;\n \t\t\treturn 0;\n \t\t}\n+\t\tif (value && !strcasecmp(value, \"noauto\")) {\n+\t\t\tauto_number = 0;\n+\t\t\treturn 0;\n+\t\t}\n \t\tnumbered = git_config_bool(var, value);\n \t\treturn 0;\n \t}\n-- \n1.5.6.5\n"},{"id":"92143","messageId":"alpine.DEB.1.00.0810021433130.22125@pacific.mpi-cbg.de.mpi-cbg.de","threadId":"15754","inReplyTo":"1222946860-15518-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-10-02T12:33:54Z","receivedAt":"2008-10-02T12:33:54Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 2 Oct 2008, Giuseppe Bilotta wrote:\n\n> Set auto-number true by default, allowing the format.number key to be\n> set to 'noauto' to override this.\n> ---\n> builtin-log.c | 6 +++++-\n> 1 files changed, 5 insertions(+), 1 deletions(-)\n\nInteresting. No sign-off, no defense why this is actually desirable, \nafter we lived for so long without this behavior... Care to elaborate?\n\nCiao,\nDscho\n"},{"id":"92148","messageId":"cb7bb73a0810020610q657dec7clf85b4ef3575b751f@mail.gmail.com","threadId":"15754","inReplyTo":"alpine.DEB.1.00.0810021433130.22125@pacific.mpi-cbg.de.mpi-cbg.de","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2008-10-02T13:10:40Z","receivedAt":"2008-10-02T13:10:40Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Thu, Oct 2, 2008 at 2:33 PM, Johannes Schindelin\n wrote:\n> Hi,\n>\n> On Thu, 2 Oct 2008, Giuseppe Bilotta wrote:\n>\n>> Set auto-number true by default, allowing the format.number key to be\n>> set to 'noauto' to override this.\n>> ---\n>> builtin-log.c | 6 +++++-\n>> 1 files changed, 5 insertions(+), 1 deletions(-)\n>\n> Interesting. No sign-off, no defense why this is actually desirable,\n> after we lived for so long without this behavior... Care to elaborate?\n\nDoh, sorry about the Sign-off, I'll resend with.\n\nNow, about the reason for this patch: I would say that the most common\nuse-case of format-patch being used to prepare multiple patches is\nwhen one plans on sending a patchset. When format.numbering is set to\nauto, single-patches will still be extracted without numbers, but\npatchset will be properly numbered.\n\nOf course, there may be cases where one doesn't want numbering (for\nwhich there is the -N flag already), and of course we want to give the\nuser the choice to disable autonumbering at the config level, for\nwhich there is the new noauto option for format.numbering.\n\nIf this explanation is good enough for you, I'll plop it in the resend\nmessage too :)\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"},{"id":"92149","messageId":"alpine.DEB.1.00.0810021541470.22125@pacific.mpi-cbg.de.mpi-cbg.de","threadId":"15754","inReplyTo":"cb7bb73a0810020610q657dec7clf85b4ef3575b751f@mail.gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-10-02T13:42:05Z","receivedAt":"2008-10-02T13:42:05Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 2 Oct 2008, Giuseppe Bilotta wrote:\n\n> On Thu, Oct 2, 2008 at 2:33 PM, Johannes Schindelin\n> wrote:\n>\n> > On Thu, 2 Oct 2008, Giuseppe Bilotta wrote:\n> >\n> >> Set auto-number true by default, allowing the format.number key to be\n> >> set to 'noauto' to override this.\n> >> ---\n> >> builtin-log.c | 6 +++++-\n> >> 1 files changed, 5 insertions(+), 1 deletions(-)\n> >\n> > Interesting. No sign-off, no defense why this is actually desirable,\n> > after we lived for so long without this behavior... Care to elaborate?\n> \n> Doh, sorry about the Sign-off, I'll resend with.\n> \n> Now, about the reason for this patch: I would say that the most common\n> use-case of format-patch being used to prepare multiple patches is\n> when one plans on sending a patchset. When format.numbering is set to\n> auto, single-patches will still be extracted without numbers, but\n> patchset will be properly numbered.\n> \n> Of course, there may be cases where one doesn't want numbering (for\n> which there is the -N flag already), and of course we want to give the\n> user the choice to disable autonumbering at the config level, for\n> which there is the new noauto option for format.numbering.\n> \n> If this explanation is good enough for you, I'll plop it in the resend\n> message too :)\n\nYep, this is worthy of a commit message.\n\nThanks,\nDscho\n"},{"id":"92151","messageId":"48E4CFED.3060903@op5.se","threadId":"15754","inReplyTo":"cb7bb73a0810020610q657dec7clf85b4ef3575b751f@mail.gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2008-10-02T13:43:09Z","receivedAt":"2008-10-02T13:43:09Z","isPatch":true,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Giuseppe Bilotta wrote:\n> On Thu, Oct 2, 2008 at 2:33 PM, Johannes Schindelin\n> wrote:\n>> Hi,\n>>\n>> On Thu, 2 Oct 2008, Giuseppe Bilotta wrote:\n>>\n>>> Set auto-number true by default, allowing the format.number key to be\n>>> set to 'noauto' to override this.\n>>> ---\n>>> builtin-log.c | 6 +++++-\n>>> 1 files changed, 5 insertions(+), 1 deletions(-)\n>> Interesting. No sign-off, no defense why this is actually desirable,\n>> after we lived for so long without this behavior... Care to elaborate?\n> \n> Doh, sorry about the Sign-off, I'll resend with.\n> \n> Now, about the reason for this patch: I would say that the most common\n> use-case of format-patch being used to prepare multiple patches is\n> when one plans on sending a patchset. When format.numbering is set to\n> auto, single-patches will still be extracted without numbers, but\n> patchset will be properly numbered.\n> \n\nI like it. It hasn't bitten me since I moved to imap-send, but when I\nused send-email I sometimes forgot and ended up sending patch-series\nwithout numbers.\n\nI sent a patch for it once, but changed the default instead of making\nit configurable so it got turned down.\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"92152","messageId":"1222955278-16908-1-git-send-email-giuseppe.bilotta@gmail.com","threadId":"15754","inReplyTo":"alpine.DEB.1.00.0810021541470.22125@pacific.mpi-cbg.de.mpi-cbg.de","subject":"[PATCH] format-patch: autonumber by default","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2008-10-02T13:47:58Z","receivedAt":"2008-10-02T13:47:58Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"format-patch is most commoly used for multiple patches at once when\nsending a patchset, in which case we want to number the patches; on the\nother hand, single-patches are not usually expected to be numbered.\n\nThe typical behavior expected by format-patch is therefore the one\nobtained by enabling autonumber, which should therefore be the default.\n\nUsers that want to disable numbering for a particular patchset can do so\nwith the existing -N command-line switch. For users that want to change\nthe default behavior we provide a 'noauto' option for the\nformat.numbering config key.\n\nSigned-off-by: Giuseppe Bilotta \n---\n builtin-log.c | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-log.c b/builtin-log.c\nindex fc5e4da..5187dc2 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -426,7 +426,7 @@ static int istitlechar(char c)\n \n static const char *fmt_patch_suffix = \".patch\";\n static int numbered = 0;\n-static int auto_number = 0;\n+static int auto_number = 1;\n \n static char **extra_hdr;\n static int extra_hdr_nr;\n@@ -484,6 +484,10 @@ static int git_format_config(const char *var, const char *value, void *cb)\n \t\t\tauto_number = 1;\n \t\t\treturn 0;\n \t\t}\n+\t\tif (value && !strcasecmp(value, \"noauto\")) {\n+\t\t\tauto_number = 0;\n+\t\t\treturn 0;\n+\t\t}\n \t\tnumbered = git_config_bool(var, value);\n \t\treturn 0;\n \t}\n-- \n1.5.6.5\n"},{"id":"92154","messageId":"48E4D278.1000103@viscovery.net","threadId":"15754","inReplyTo":"cb7bb73a0810020610q657dec7clf85b4ef3575b751f@mail.gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2008-10-02T13:54:00Z","receivedAt":"2008-10-02T13:54:00Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Giuseppe Bilotta schrieb:\n> Now, about the reason for this patch: I would say that the most common\n> use-case of format-patch being used to prepare multiple patches is\n> when one plans on sending a patchset. When format.numbering is set to\n> auto, single-patches will still be extracted without numbers, but\n> patchset will be properly numbered.\n> \n> Of course, there may be cases where one doesn't want numbering (for\n> which there is the -N flag already), and of course we want to give the\n> user the choice to disable autonumbering at the config level, for\n> which there is the new noauto option for format.numbering.\n\nI recall that this has been discussed (months or years ago), but I don't\nrecall whether there was a conclusion or whether the change was dismissed.\nDid you research the ML archives?\n\n-- Hannes\n"},{"id":"92160","messageId":"200810021608.54287.jnareb@gmail.com","threadId":"15754","inReplyTo":"1222955278-16908-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-10-02T14:08:53Z","receivedAt":"2008-10-02T14:08:53Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Giuseppe Bilotta wrote:\n> format-patch is most commoly used for multiple patches at once when\n\ns/commoly/commonly/;\n\nI'm not sure about 'most' there...\n\n> sending a patchset, in which case we want to number the patches; on the\n> other hand, single-patches are not usually expected to be numbered.\n> \n> The typical behavior expected by format-patch is therefore the one\n> obtained by enabling autonumber, which should therefore be the default.\n> \n> Users that want to disable numbering for a particular patchset can do so\n> with the existing -N command-line switch. For users that want to change\n> the default behavior we provide a 'noauto' option for the\n> format.numbering config key.\n\nNice. I like it.\n-- \nJakub Narebski\nPoland\n"},{"id":"92161","messageId":"48E4D73B.9090508@op5.se","threadId":"15754","inReplyTo":"200810021608.54287.jnareb@gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2008-10-02T14:14:19Z","receivedAt":"2008-10-02T14:14:19Z","isPatch":true,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Jakub Narebski wrote:\n> Giuseppe Bilotta wrote:\n>> format-patch is most commoly used for multiple patches at once when\n> \n> s/commoly/commonly/;\n> \n> I'm not sure about 'most' there...\n\nIn that case, just make it \"often\" and cut \"most commoly\" (sic) out.\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"92186","messageId":"1222970291-5337-1-git-send-email-giuseppe.bilotta@gmail.com","threadId":"15754","inReplyTo":"48E4D73B.9090508@op5.se","subject":"[PATCH] format-patch: autonumber by default","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2008-10-02T17:58:11Z","receivedAt":"2008-10-02T17:58:11Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"format-patch is often used for multiple patches at once when sending a\npatchset, in which case we want to number the patches; on the other\nhand, single-patches are not usually expected to be numbered.\n\nThe typical behavior expected by format-patch is therefore the one\nobtained by enabling autonumber, which should thus be the default.\n\nUsers that want to disable numbering for a particular patchset can do\nso with the existing -N command-line switch. For users that want to\nchange the default behavior we provide a 'noauto' option for the\nformat.numbering config key.\n\nSigned-off-by: Giuseppe Bilotta \n---\n builtin-log.c | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-log.c b/builtin-log.c\nindex fc5e4da..5187dc2 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -426,7 +426,7 @@ static int istitlechar(char c)\n \n static const char *fmt_patch_suffix = \".patch\";\n static int numbered = 0;\n-static int auto_number = 0;\n+static int auto_number = 1;\n \n static char **extra_hdr;\n static int extra_hdr_nr;\n@@ -484,6 +484,10 @@ static int git_format_config(const char *var, const char *value, void *cb)\n \t\t\tauto_number = 1;\n \t\t\treturn 0;\n \t\t}\n+\t\tif (value && !strcasecmp(value, \"noauto\")) {\n+\t\t\tauto_number = 0;\n+\t\t\treturn 0;\n+\t\t}\n \t\tnumbered = git_config_bool(var, value);\n \t\treturn 0;\n \t}\n-- \n1.5.6.5\n"},{"id":"92191","messageId":"20081002200333.GA29303@coredump.intra.peff.net","threadId":"15754","inReplyTo":"1222970291-5337-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-10-02T20:03:33Z","receivedAt":"2008-10-02T20:03:33Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Oct 02, 2008 at 07:58:11PM +0200, Giuseppe Bilotta wrote:\n\n> format-patch is often used for multiple patches at once when sending a\n> patchset, in which case we want to number the patches; on the other\n> hand, single-patches are not usually expected to be numbered.\n> \n> The typical behavior expected by format-patch is therefore the one\n> obtained by enabling autonumber, which should thus be the default.\n\nI personally do not agree with this default. My usual use of\nformat-patch is to dump a cluster of miscellaneous patches since\n\"origin\", and then grab the one(s) I want by title.\n\nHowever, I would not be surprised to find that my use is unlike that of\nmost other people[1], so I am not opposed to the patch.\n\n[1] Actually, my use has a deficiency, which is that I am often sending\n2/4, without nobody having seen 1/4, on which it might actually depend.\nThis works in practice for me because I am often producing unrelated\njanitorial patches for git. :)\n\nSo I think the goal is reasonable, but:\n\n> ---\n> builtin-log.c | 6 +++++-\n> 1 files changed, 5 insertions(+), 1 deletions(-)\n\nDocumentation update?\n\n-Peff\n"},{"id":"92192","messageId":"1222978500-5780-1-git-send-email-giuseppe.bilotta@gmail.com","threadId":"15754","inReplyTo":"20081002200333.GA29303@coredump.intra.peff.net","subject":"[PATCH] format-patch: autonumber by default","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2008-10-02T20:15:00Z","receivedAt":"2008-10-02T20:15:00Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"format-patch is most commoly used for multiple patches at once when\nsending a patchset, in which case we want to number the patches; on the\nother hand, single patches are not usually expected to be numbered.\n\nIn other words, the typical behavior expected from format-patch is the\none obtained by enabling autonumber, so we set it to be the default.\n\nUsers that want to disable numbering for a particular patchset can do so\nwith the existing -N command-line switch. For users that want to change\nthe default behavior we provide a 'noauto' option for the\nformat.numbering config key.\n\nSigned-off-by: Giuseppe Bilotta \n---\n Documentation/config.txt | 5 +++--\n Documentation/git-format-patch.txt | 9 ++++++---\n builtin-log.c | 6 +++++-\n 3 files changed, 14 insertions(+), 6 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex bbe38cc..9a9ed98 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -633,8 +633,9 @@ fetch.unpackLimit::\n format.numbered::\n \tA boolean which can enable sequence numbers in patch subjects.\n \tSetting this option to \"auto\" will enable it only if there is\n-\tmore than one patch. See --numbered option in\n-\tlinkgit:git-format-patch[1].\n+\tmore than one patch. This is the default behavior and can be\n+\tdisabled by setting this option to \"noauto\". See --numbered\n+\toption in linkgit:git-format-patch[1].\n \n format.headers::\n \tAdditional email headers to include in a patch to be submitted\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex adb4ea7..d7be5bb 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -59,7 +59,9 @@ If -o is specified, output files are created in . Otherwise\n they are created in the current working directory.\n \n If -n is specified, instead of \"[PATCH] Subject\", the first line\n-is formatted as \"[PATCH n/m] Subject\".\n+is formatted as \"[PATCH n/m] Subject\". This is the default behavior\n+when outputting more than one patch, and it can be suppressed with\n+the -N command line option.\n \n If given --thread, 'git-format-patch' will generate In-Reply-To and\n References headers to make the second and subsequent patch mails appear\n@@ -171,14 +173,15 @@ CONFIGURATION\n -------------\n You can specify extra mail header lines to be added to each message\n in the repository configuration, new defaults for the subject prefix\n-and file suffix, and number patches when outputting more than one.\n+and file suffix, and disable automatic numbering of patches when outputting\n+more than one.\n \n ------------\n [format]\n \theaders = \"Organization: git-foo\\n\"\n \tsubjectprefix = CHANGE\n \tsuffix = .txt\n-\tnumbered = auto\n+\tnumbered = noauto\n \tcc = \n ------------\n \ndiff --git a/builtin-log.c b/builtin-log.c\nindex fc5e4da..5187dc2 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -426,7 +426,7 @@ static int istitlechar(char c)\n \n static const char *fmt_patch_suffix = \".patch\";\n static int numbered = 0;\n-static int auto_number = 0;\n+static int auto_number = 1;\n \n static char **extra_hdr;\n static int extra_hdr_nr;\n@@ -484,6 +484,10 @@ static int git_format_config(const char *var, const char *value, void *cb)\n \t\t\tauto_number = 1;\n \t\t\treturn 0;\n \t\t}\n+\t\tif (value && !strcasecmp(value, \"noauto\")) {\n+\t\t\tauto_number = 0;\n+\t\t\treturn 0;\n+\t\t}\n \t\tnumbered = git_config_bool(var, value);\n \t\treturn 0;\n \t}\n-- \n1.5.6.5\n"},{"id":"92193","messageId":"91634D16-B28A-4458-97A9-C469B5AF4E5D@silverinsanity.com","threadId":"15754","inReplyTo":"1222970291-5337-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2008-10-02T20:17:46Z","receivedAt":"2008-10-02T20:17:46Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Oct 2, 2008, at 1:58 PM, Giuseppe Bilotta wrote:\n\n> diff --git a/builtin-log.c b/builtin-log.c\n> index fc5e4da..5187dc2 100644\n> --- a/builtin-log.c\n> +++ b/builtin-log.c\n> @@ -426,7 +426,7 @@ static int istitlechar(char c)\n>\n> static const char *fmt_patch_suffix = \".patch\";\n> static int numbered = 0;\n> -static int auto_number = 0;\n> +static int auto_number = 1;\n>\n> static char **extra_hdr;\n> static int extra_hdr_nr;\n> @@ -484,6 +484,10 @@ static int git_format_config(const char *var, \n> const char *value, void *cb)\n> \t\t\tauto_number = 1;\n> \t\t\treturn 0;\n> \t\t}\n> +\t\tif (value && !strcasecmp(value, \"noauto\")) {\n> +\t\t\tauto_number = 0;\n> +\t\t\treturn 0;\n> +\t\t}\n> \t\tnumbered = git_config_bool(var, value);\n> \t\treturn 0;\n> \t}\n\nformat.numbered is a tri-state config option right now: {yes, no, \nauto}. With this patch, if you add \"[format] numbered = false\" into \nyour config, you still get auto-numbering.\n\nA better way to do this might be to default both numbered and \nauto_number to true and only use auto_number is numbered is true. Or \nturn off auto-numbering when numbering is turned off just below your \nhunk.\n\nEither way, \"noauto\" is a bad idea. It's spelled \"no\" or \"false\".\n\n~~ Brian Gernhardt\n"},{"id":"92194","messageId":"1222979802-98319-1-git-send-email-benji@silverinsanity.com","threadId":"15754","inReplyTo":"91634D16-B28A-4458-97A9-C469B5AF4E5D@silverinsanity.com","subject":"[PATCH] format-patch: autonumber by default","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2008-10-02T20:36:42Z","receivedAt":"2008-10-02T20:36:42Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"format-patch is most commonly used for multiple patches at once when\nsending a patchset, in which case we want to number the patches; on\nthe other hand, single patches are not usually expected to be\nnumbered.\n\nIn other words, the typical behavior expected from format-patch is the\none obtained by enabling autonumber, so we set it to be the default.\n\nUsers that want to disable numbering for a particular patchset can do\nso with the existing -N command-line switch. Users that want to\nchange the default behavior can use the format.numbering config key.\n\nSigned-off-by: Brian Gernhardt \n---\n\n This is what I was talking about. The appropriate setting to turn it off is\n \"false\", not \"noauto\".\n\n Documentation/config.txt | 9 +++++----\n Documentation/git-format-patch.txt | 8 +++++---\n builtin-log.c | 3 ++-\n 3 files changed, 12 insertions(+), 8 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex da18a54..5ba3ffa 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -640,10 +640,11 @@ fetch.unpackLimit::\n \t`transfer.unpackLimit` is used instead.\n \n format.numbered::\n-\tA boolean which can enable sequence numbers in patch subjects.\n-\tSetting this option to \"auto\" will enable it only if there is\n-\tmore than one patch. See --numbered option in\n-\tlinkgit:git-format-patch[1].\n+\tA boolean which can enable or disable sequence numbers in patch\n+\tsubjects. It defaults to \"auto\" which enables it only if there\n+\tis more than one patch. It can be enabled or disabled for all\n+\tmessages by setting it to \"true\" or \"false\". See --numbered\n+\toption in linkgit:git-format-patch[1].\n \n format.headers::\n \tAdditional email headers to include in a patch to be submitted\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex adb4ea7..ac36ce8 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -58,8 +58,10 @@ output, unless the --stdout option is specified.\n If -o is specified, output files are created in . Otherwise\n they are created in the current working directory.\n \n-If -n is specified, instead of \"[PATCH] Subject\", the first line\n-is formatted as \"[PATCH n/m] Subject\".\n+By default, the subject of a single patch is \"[PATCH] First Line\" and\n+the subject when multiple patches are output is \"[PATCH n/m] First\n+Line\". To force 1/1 to be added for a single patch, use -n. To omit\n+patch numbers from the subject, use -N\n \n If given --thread, 'git-format-patch' will generate In-Reply-To and\n References headers to make the second and subsequent patch mails appear\n@@ -81,7 +83,7 @@ include::diff-options.txt[]\n \n -n::\n --numbered::\n-\tName output in '[PATCH n/m]' format.\n+\tName output in '[PATCH n/m]' format, even with a single patch.\n \n -N::\n --no-numbered::\ndiff --git a/builtin-log.c b/builtin-log.c\nindex fc5e4da..93987ee 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -426,7 +426,7 @@ static int istitlechar(char c)\n \n static const char *fmt_patch_suffix = \".patch\";\n static int numbered = 0;\n-static int auto_number = 0;\n+static int auto_number = 1;\n \n static char **extra_hdr;\n static int extra_hdr_nr;\n@@ -485,6 +485,7 @@ static int git_format_config(const char *var, const char *value, void *cb)\n \t\t\treturn 0;\n \t\t}\n \t\tnumbered = git_config_bool(var, value);\n+\t\tauto_number &&= numbered;\n \t\treturn 0;\n \t}\n \n-- \n1.6.0.2.589.gcd70\n"},{"id":"92195","messageId":"20081002204145.GA98400@Hermes","threadId":"15754","inReplyTo":"91634D16-B28A-4458-97A9-C469B5AF4E5D@silverinsanity.com","subject":"[PATCH] format-patch: autonumber by default","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2008-10-02T20:41:45Z","receivedAt":"2008-10-02T20:41:45Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nformat-patch is most commonly used for multiple patches at once when\nsending a patchset, in which case we want to number the patches; on\nthe other hand, single patches are not usually expected to be\nnumbered.\n\nIn other words, the typical behavior expected from format-patch is the\none obtained by enabling autonumber, so we set it to be the default.\n\nUsers that want to disable numbering for a particular patchset can do\nso with the existing -N command-line switch. Users that want to\nchange the default behavior can use the format.numbering config key.\n\nSigned-off-by: Brian Gernhardt \n---\n\n This is what I was talking about. The appropriate setting to turn it off is\n \"false\", not \"noauto\".\n\n Re-sending with the correct CC list.\n\n Documentation/config.txt | 9 +++++----\n Documentation/git-format-patch.txt | 8 +++++---\n builtin-log.c | 3 ++-\n 3 files changed, 12 insertions(+), 8 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex da18a54..5ba3ffa 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -640,10 +640,11 @@ fetch.unpackLimit::\n \t`transfer.unpackLimit` is used instead.\n \n format.numbered::\n-\tA boolean which can enable sequence numbers in patch subjects.\n-\tSetting this option to \"auto\" will enable it only if there is\n-\tmore than one patch. See --numbered option in\n-\tlinkgit:git-format-patch[1].\n+\tA boolean which can enable or disable sequence numbers in patch\n+\tsubjects. It defaults to \"auto\" which enables it only if there\n+\tis more than one patch. It can be enabled or disabled for all\n+\tmessages by setting it to \"true\" or \"false\". See --numbered\n+\toption in linkgit:git-format-patch[1].\n \n format.headers::\n \tAdditional email headers to include in a patch to be submitted\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex adb4ea7..ac36ce8 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -58,8 +58,10 @@ output, unless the --stdout option is specified.\n If -o is specified, output files are created in . Otherwise\n they are created in the current working directory.\n \n-If -n is specified, instead of \"[PATCH] Subject\", the first line\n-is formatted as \"[PATCH n/m] Subject\".\n+By default, the subject of a single patch is \"[PATCH] First Line\" and\n+the subject when multiple patches are output is \"[PATCH n/m] First\n+Line\". To force 1/1 to be added for a single patch, use -n. To omit\n+patch numbers from the subject, use -N\n \n If given --thread, 'git-format-patch' will generate In-Reply-To and\n References headers to make the second and subsequent patch mails appear\n@@ -81,7 +83,7 @@ include::diff-options.txt[]\n \n -n::\n --numbered::\n-\tName output in '[PATCH n/m]' format.\n+\tName output in '[PATCH n/m]' format, even with a single patch.\n \n -N::\n --no-numbered::\ndiff --git a/builtin-log.c b/builtin-log.c\nindex fc5e4da..93987ee 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -426,7 +426,7 @@ static int istitlechar(char c)\n \n static const char *fmt_patch_suffix = \".patch\";\n static int numbered = 0;\n-static int auto_number = 0;\n+static int auto_number = 1;\n \n static char **extra_hdr;\n static int extra_hdr_nr;\n@@ -485,6 +485,7 @@ static int git_format_config(const char *var, const char *value, void *cb)\n \t\t\treturn 0;\n \t\t}\n \t\tnumbered = git_config_bool(var, value);\n+\t\tauto_number &&= numbered;\n \t\treturn 0;\n \t}\n \n-- \n1.6.0.2.589.gcd70\n"},{"id":"92196","messageId":"7782583C-90DA-4D79-89FD-3550ADC52B0F@silverinsanity.com","threadId":"15754","inReplyTo":"20081002204145.GA98400@Hermes","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2008-10-02T20:50:55Z","receivedAt":"2008-10-02T20:50:55Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"Okay, I should wait for my test build to finish before I send the \npatch. This doesn't build. Nor does it pass the tests, since they \ntest the old behavior.\n\nI'll fix the build error, but I'm not inclined to spend the time \nfixing the tests since I don't actually care about changing the default.\n\nOn Oct 2, 2008, at 4:41 PM, Brian Gernhardt wrote:\n\n>\n> format-patch is most commonly used for multiple patches at once when\n> sending a patchset, in which case we want to number the patches; on\n> the other hand, single patches are not usually expected to be\n> numbered.\n>\n> In other words, the typical behavior expected from format-patch is the\n> one obtained by enabling autonumber, so we set it to be the default.\n>\n> Users that want to disable numbering for a particular patchset can do\n> so with the existing -N command-line switch. Users that want to\n> change the default behavior can use the format.numbering config key.\n>\n> Signed-off-by: Brian Gernhardt \n> ---\n>\n> This is what I was talking about. The appropriate setting to turn \n> it off is\n> \"false\", not \"noauto\".\n>\n> Re-sending with the correct CC list.\n>\n> Documentation/config.txt | 9 +++++----\n> Documentation/git-format-patch.txt | 8 +++++---\n> builtin-log.c | 3 ++-\n> 3 files changed, 12 insertions(+), 8 deletions(-)\n>\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index da18a54..5ba3ffa 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -640,10 +640,11 @@ fetch.unpackLimit::\n> \t`transfer.unpackLimit` is used instead.\n>\n> format.numbered::\n> -\tA boolean which can enable sequence numbers in patch subjects.\n> -\tSetting this option to \"auto\" will enable it only if there is\n> -\tmore than one patch. See --numbered option in\n> -\tlinkgit:git-format-patch[1].\n> +\tA boolean which can enable or disable sequence numbers in patch\n> +\tsubjects. It defaults to \"auto\" which enables it only if there\n> +\tis more than one patch. It can be enabled or disabled for all\n> +\tmessages by setting it to \"true\" or \"false\". See --numbered\n> +\toption in linkgit:git-format-patch[1].\n>\n> format.headers::\n> \tAdditional email headers to include in a patch to be submitted\n> diff --git a/Documentation/git-format-patch.txt b/Documentation/git- \n> format-patch.txt\n> index adb4ea7..ac36ce8 100644\n> --- a/Documentation/git-format-patch.txt\n> +++ b/Documentation/git-format-patch.txt\n> @@ -58,8 +58,10 @@ output, unless the --stdout option is specified.\n> If -o is specified, output files are created in . Otherwise\n> they are created in the current working directory.\n>\n> -If -n is specified, instead of \"[PATCH] Subject\", the first line\n> -is formatted as \"[PATCH n/m] Subject\".\n> +By default, the subject of a single patch is \"[PATCH] First Line\" and\n> +the subject when multiple patches are output is \"[PATCH n/m] First\n> +Line\". To force 1/1 to be added for a single patch, use -n. To omit\n> +patch numbers from the subject, use -N\n>\n> If given --thread, 'git-format-patch' will generate In-Reply-To and\n> References headers to make the second and subsequent patch mails \n> appear\n> @@ -81,7 +83,7 @@ include::diff-options.txt[]\n>\n> -n::\n> --numbered::\n> -\tName output in '[PATCH n/m]' format.\n> +\tName output in '[PATCH n/m]' format, even with a single patch.\n>\n> -N::\n> --no-numbered::\n> diff --git a/builtin-log.c b/builtin-log.c\n> index fc5e4da..93987ee 100644\n> --- a/builtin-log.c\n> +++ b/builtin-log.c\n> @@ -426,7 +426,7 @@ static int istitlechar(char c)\n>\n> static const char *fmt_patch_suffix = \".patch\";\n> static int numbered = 0;\n> -static int auto_number = 0;\n> +static int auto_number = 1;\n>\n> static char **extra_hdr;\n> static int extra_hdr_nr;\n> @@ -485,6 +485,7 @@ static int git_format_config(const char *var, \n> const char *value, void *cb)\n> \t\t\treturn 0;\n> \t\t}\n> \t\tnumbered = git_config_bool(var, value);\n> +\t\tauto_number &&= numbered;\n> \t\treturn 0;\n> \t}\n>\n> -- \n> 1.6.0.2.589.gcd70\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n"},{"id":"92198","messageId":"20081002205539.GA36768@Hermes","threadId":"15754","inReplyTo":"91634D16-B28A-4458-97A9-C469B5AF4E5D@silverinsanity.com","subject":"[PATCH v2] format-patch: autonumber by default","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2008-10-02T20:55:39Z","receivedAt":"2008-10-02T20:55:39Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"format-patch is most commonly used for multiple patches at once when\nsending a patchset, in which case we want to number the patches; on\nthe other hand, single patches are not usually expected to be\nnumbered.\n\nIn other words, the typical behavior expected from format-patch is the\none obtained by enabling autonumber, so we set it to be the default.\n\nUsers that want to disable numbering for a particular patchset can do\nso with the existing -N command-line switch. Users that want to\nchange the default behavior can use the format.numbering config key.\n\nSigned-off-by: Brian Gernhardt \n---\n\n _This_ patch changes the default and makes the config variable act\n properly. Does not pass tests. 4014 and 4021 would have to be\n updated for the new defaults.\n\n Documentation/config.txt | 9 +++++----\n Documentation/git-format-patch.txt | 8 +++++---\n builtin-log.c | 3 ++-\n 3 files changed, 12 insertions(+), 8 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex da18a54..5ba3ffa 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -640,10 +640,11 @@ fetch.unpackLimit::\n \t`transfer.unpackLimit` is used instead.\n \n format.numbered::\n-\tA boolean which can enable sequence numbers in patch subjects.\n-\tSetting this option to \"auto\" will enable it only if there is\n-\tmore than one patch. See --numbered option in\n-\tlinkgit:git-format-patch[1].\n+\tA boolean which can enable or disable sequence numbers in patch\n+\tsubjects. It defaults to \"auto\" which enables it only if there\n+\tis more than one patch. It can be enabled or disabled for all\n+\tmessages by setting it to \"true\" or \"false\". See --numbered\n+\toption in linkgit:git-format-patch[1].\n \n format.headers::\n \tAdditional email headers to include in a patch to be submitted\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex adb4ea7..ac36ce8 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -58,8 +58,10 @@ output, unless the --stdout option is specified.\n If -o is specified, output files are created in . Otherwise\n they are created in the current working directory.\n \n-If -n is specified, instead of \"[PATCH] Subject\", the first line\n-is formatted as \"[PATCH n/m] Subject\".\n+By default, the subject of a single patch is \"[PATCH] First Line\" and\n+the subject when multiple patches are output is \"[PATCH n/m] First\n+Line\". To force 1/1 to be added for a single patch, use -n. To omit\n+patch numbers from the subject, use -N\n \n If given --thread, 'git-format-patch' will generate In-Reply-To and\n References headers to make the second and subsequent patch mails appear\n@@ -81,7 +83,7 @@ include::diff-options.txt[]\n \n -n::\n --numbered::\n-\tName output in '[PATCH n/m]' format.\n+\tName output in '[PATCH n/m]' format, even with a single patch.\n \n -N::\n --no-numbered::\ndiff --git a/builtin-log.c b/builtin-log.c\nindex fc5e4da..ee7c34e 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -426,7 +426,7 @@ static int istitlechar(char c)\n \n static const char *fmt_patch_suffix = \".patch\";\n static int numbered = 0;\n-static int auto_number = 0;\n+static int auto_number = 1;\n \n static char **extra_hdr;\n static int extra_hdr_nr;\n@@ -485,6 +485,7 @@ static int git_format_config(const char *var, const char *value, void *cb)\n \t\t\treturn 0;\n \t\t}\n \t\tnumbered = git_config_bool(var, value);\n+\t\tauto_number = auto_number && numbered;\n \t\treturn 0;\n \t}\n \n-- \n1.6.0.2.589.gcd70\n"},{"id":"92200","messageId":"20081002210611.GA29480@coredump.intra.peff.net","threadId":"15754","inReplyTo":"1222978500-5780-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] format-patch: autonumber by default","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-10-02T21:06:12Z","receivedAt":"2008-10-02T21:06:12Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Oct 02, 2008 at 10:15:00PM +0200, Giuseppe Bilotta wrote:\n\n> Documentation/config.txt | 5 +++--\n> Documentation/git-format-patch.txt | 9 ++++++---\n> builtin-log.c | 6 +++++-\n> 3 files changed, 14 insertions(+), 6 deletions(-)\n\nThanks, the documentation updates look good to me. There are also some\nupdates required in t4013 (since the expected outputs for some instances\nwill now be numbered) and t4020 (which explicitly checks that the\ndefault is no numbering). Probably t4020 should be modified in light of\nthe new default, like so:\n\n---\n t/t4021-format-patch-numbered.sh | 15 ++++++++++-----\n 1 files changed, 10 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t4021-format-patch-numbered.sh b/t/t4021-format-patch-numbered.sh\nindex 43d64bb..390af23 100755\n--- a/t/t4021-format-patch-numbered.sh\n+++ b/t/t4021-format-patch-numbered.sh\n@@ -45,17 +45,22 @@ test_numbered() {\n \tgrep \"^Subject: \\[PATCH 2/2\\]\" $1\n }\n \n-test_expect_success 'Default: no numbered' '\n+test_expect_success 'single patch defaults to no numbers' '\n+\tgit format-patch --stdout HEAD~1 >patch0.single &&\n+\ttest_single_no_numbered patch0.single\n+'\n+\n+test_expect_success 'multiple patch defaults to numbered' '\n \n-\tgit format-patch --stdout HEAD~2 >patch0 &&\n-\ttest_no_numbered patch0\n+\tgit format-patch --stdout HEAD~2 >patch0.multiple &&\n+\ttest_numbered patch0.multiple\n \n '\n \n test_expect_success 'Use --numbered' '\n \n-\tgit format-patch --numbered --stdout HEAD~2 >patch1 &&\n-\ttest_numbered patch1\n+\tgit format-patch --numbered --stdout HEAD~1 >patch1 &&\n+\ttest_single_numbered patch1\n \n '\n \n-- \n1.6.0.2.570.g2c958\n"},{"id":"126758","messageId":"m1ws261qqi.fsf@fess.ebiederm.org","threadId":"15754","inReplyTo":"20081002205539.GA36768@Hermes","subject":"Re: [PATCH v2] format-patch: autonumber by default","fromName":"Eric W. Biederman","fromEmail":"ebiederm@xmission.com","sentAt":"2009-11-04T11:20:05Z","receivedAt":"2009-11-04T11:20:05Z","isPatch":true,"sender":{"key":"ebiederm@xmission.com","avatar":"https://avatars.githubusercontent.com/u/7477136?v=4"},"body":"\nBrian Gernhardt writes:\n\n> format-patch is most commonly used for multiple patches at once when\n> sending a patchset, in which case we want to number the patches; on\n> the other hand, single patches are not usually expected to be\n> numbered.\n>\n> In other words, the typical behavior expected from format-patch is the\n> one obtained by enabling autonumber, so we set it to be the default.\n>\n> Users that want to disable numbering for a particular patchset can do\n> so with the existing -N command-line switch. Users that want to\n> change the default behavior can use the format.numbering config key.\n>\n> Signed-off-by: Brian Gernhardt \n> ---\n\n\nGrumble. I updated git last night and this change just bit me.\nGrumble.\nGrumble.\n\nIt is probably a good change, but it was unexpected.\nGrumble. Grumble. Grumble.\n\n\nEric\n"},{"id":"126777","messageId":"7vskcui40g.fsf@alter.siamese.dyndns.org","threadId":"15754","inReplyTo":"m1ws261qqi.fsf@fess.ebiederm.org","subject":"Re: [PATCH v2] format-patch: autonumber by default","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-11-04T17:38:55Z","receivedAt":"2009-11-04T17:38:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"ebiederm@xmission.com (Eric W. Biederman) writes:\n\n> Brian Gernhardt writes:\n>\n>> format-patch is most commonly used for multiple patches at once when\n>> sending a patchset, in which case we want to number the patches; on\n>> the other hand, single patches are not usually expected to be\n>> numbered.\n>>\n>> In other words, the typical behavior expected from format-patch is the\n>> one obtained by enabling autonumber, so we set it to be the default.\n>>\n>> Users that want to disable numbering for a particular patchset can do\n>> so with the existing -N command-line switch. Users that want to\n>> change the default behavior can use the format.numbering config key.\n>>\n>> Signed-off-by: Brian Gernhardt \n>> ---\n>\n>\n> Grumble. I updated git last night and this change just bit me.\n> Grumble.\n> Grumble.\n>\n> It is probably a good change, but it was unexpected.\n> Grumble. Grumble. Grumble.\n\nThat change was in 1.6.1.1 or so, no? Welcome to year 2009 ;-)\n\nOut of curiousity, which version did you update _from_?\n"},{"id":"126780","messageId":"EC82292D-1A52-4EFB-8E56-33E18A343AE0@silverinsanity.com","threadId":"15754","inReplyTo":"m1ws261qqi.fsf@fess.ebiederm.org","subject":"Re: [PATCH v2] format-patch: autonumber by default","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2009-11-04T17:48:34Z","receivedAt":"2009-11-04T17:48:34Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Nov 4, 2009, at 6:20 AM, Eric W. Biederman wrote:\n\n> Grumble. I updated git last night and this change just bit me.\n> Grumble.\n> Grumble.\n>\n> It is probably a good change, but it was unexpected.\n> Grumble. Grumble. Grumble.\n\nThe change is a year old, and mentioned in the release notes from \n1.6.1. If you're updating from old versions of git, it can be \nextremely useful to read the release notes as we do periodically have \nchanges like this. (In the git repository, they can be found as \nDocumentation/RelNotes-*.txt)\n\nIf you wish to go back to the old default for a single project, use \n`git config format.numbered false`. If you use the --global flag, it \nwill set it for you all the time. For a single set of unrelated \npatches being output at once, use the --no-numbered (short: -N) option \nto format-patch.\n\nSorry it caught you unawares. Having it auto-number seemed like the \nmost useful default.\n\n~~ Brian\n"}]}