{"thread":{"id":"15748","subject":"[PATCH] run-command.c: remove run_command_v_opt_cd()","startedAt":"2008-10-02T10:14:25Z","lastAt":"2008-10-02T11:09:01Z","messageCount":3,"participants":["Nanako Shiraishi","Johannes Sixt","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"92128","messageId":"20081002191425.6117@nanako3.lavabit.com","threadId":"15748","inReplyTo":null,"subject":"[PATCH] run-command.c: remove run_command_v_opt_cd()","fromName":"Nanako Shiraishi","fromEmail":"nanako3@lavabit.com","sentAt":"2008-10-02T10:14:25Z","receivedAt":"2008-10-02T10:14:25Z","isPatch":true,"sender":{"key":"nanako3@lavabit.com","avatar":"https://gravatar.com/avatar/3777b9e201c5883a62b1a6fdf7c53f2d712d1d80989146063ea861e33aad72a8?d=mp&s=160"},"body":"This function is not used anywhere.\n\nSigned-off-by: Nanako Shiraishi <nanako3@lavabit.com>\n---\n run-command.c |    8 --------\n run-command.h |    1 -\n 2 files changed, 0 insertions(+), 9 deletions(-)\n\ndiff --git a/run-command.c b/run-command.c\nindex caab374..c90cdc5 100644\n--- a/run-command.c\n+++ b/run-command.c\n@@ -273,14 +273,6 @@ int run_command_v_opt(const char **argv, int opt)\n \treturn run_command(&cmd);\n }\n \n-int run_command_v_opt_cd(const char **argv, int opt, const char *dir)\n-{\n-\tstruct child_process cmd;\n-\tprepare_run_command_v_opt(&cmd, argv, opt);\n-\tcmd.dir = dir;\n-\treturn run_command(&cmd);\n-}\n-\n int run_command_v_opt_cd_env(const char **argv, int opt, const char *dir, const char *const *env)\n {\n \tstruct child_process cmd;\ndiff --git a/run-command.h b/run-command.h\nindex 4f2b7d7..a8b0c20 100644\n--- a/run-command.h\n+++ b/run-command.h\n@@ -53,7 +53,6 @@ int run_command(struct child_process *);\n #define RUN_GIT_CMD\t     2\t/*If this is to be git sub-command */\n #define RUN_COMMAND_STDOUT_TO_STDERR 4\n int run_command_v_opt(const char **argv, int opt);\n-int run_command_v_opt_cd(const char **argv, int opt, const char *dir);\n \n /*\n  * env (the environment) is to be formatted like environ: \"VAR=VALUE\".\n-- \n1.6.0.2\n\n-- \nNanako Shiraishi\nhttp://ivory.ap.teacup.com/nanako3/\n"},{"id":"92136","messageId":"48E4A878.2090704@viscovery.net","threadId":"15748","inReplyTo":"20081002191425.6117@nanako3.lavabit.com","subject":"Re: [PATCH] run-command.c: remove run_command_v_opt_cd()","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2008-10-02T10:54:48Z","receivedAt":"2008-10-02T10:54:48Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Nanako Shiraishi schrieb:\n> This function is not used anywhere.\n\nIndeed. Future callers can use run_command_v_opt_cd_env() instead.\n\nThe function is also mentioned in\nDocumentation/technical/api-run-command.txt, where you should remove it, too.\n\n-- Hannes\n"},{"id":"92137","messageId":"alpine.DEB.1.00.0810021304360.22125@pacific.mpi-cbg.de.mpi-cbg.de","threadId":"15748","inReplyTo":"20081002191425.6117@nanako3.lavabit.com","subject":"Re: [PATCH] run-command.c: remove run_command_v_opt_cd()","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-10-02T11:09:01Z","receivedAt":"2008-10-02T11:09:01Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 2 Oct 2008, Nanako Shiraishi wrote:\n\n> This function is not used anywhere.\n\nI have to say that it fills me with sorrow, seeing that the direction \nthese patches take is the _opposite_ of libifying Git.  So far I was only \ndisappointed that nobody pushed this goal, but now I am concerned that \nanybody thinking about it is actively discouraged.\n\nJust think about Git Cheetah: if it were ever to benefit from an official \nlibgit, then the function you remove would be _ideal_.  By removing that \nfunction, you make it even less attractive to try to use Git as a proper \nlibrary.\n\nCiao,\nDscho\n"}]}