{"thread":{"id":"15741","subject":"[PATCH] Solaris: Use OLD_ICONV to avoid compile warnings","startedAt":"2008-10-02T00:08:47Z","lastAt":"2008-10-02T15:25:16Z","messageCount":4,"participants":["David Soria Parra","Jeff King","Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"92104","messageId":"1222906127-16900-1-git-send-email-sn_@gmx.net","threadId":"15741","inReplyTo":null,"subject":"[PATCH] Solaris: Use OLD_ICONV to avoid compile warnings","fromName":"David Soria Parra","fromEmail":"sn_@gmx.net","sentAt":"2008-10-02T00:08:47Z","receivedAt":"2008-10-02T00:08:47Z","isPatch":true,"sender":{"key":"sn_@gmx.net","avatar":"https://gravatar.com/avatar/b1075ecdd33ea094cbc23798fe8b95c73ec1ccf7bb213ac8260c719e2dd97b55?d=mp&s=160"},"body":"From: David Soria Parra <dsp@php.net>\n\nSolaris systems use the old styled iconv(3) call and therefore\nthe OLD_ICONV variable should be set. Otherwise we get annoying compile\nwarnings.\n\nSigned-off-by: David Soria Parra <dsp@php.net>\n---\n Makefile |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 7db2ccc..3abbb4e 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -649,6 +649,7 @@ ifeq ($(uname_S),SunOS)\n \tNO_MEMMEM = YesPlease\n \tNO_HSTRERROR = YesPlease\n \tNO_MKDTEMP = YesPlease\n+\tOLD_ICONV = UnfortunatelyYes\n \tifeq ($(uname_R),5.8)\n \t\tNEEDS_LIBICONV = YesPlease\n \t\tNO_UNSETENV = YesPlease\n-- \n1.6.0.2.569.g798a2a\n"},{"id":"92112","messageId":"20081002010816.GA27415@coredump.intra.peff.net","threadId":"15741","inReplyTo":"1222906127-16900-1-git-send-email-sn_@gmx.net","subject":"Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-10-02T01:08:17Z","receivedAt":"2008-10-02T01:08:17Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote:\n\n> Solaris systems use the old styled iconv(3) call and therefore\n> the OLD_ICONV variable should be set. Otherwise we get annoying compile\n> warnings.\n\nAcked-by: Jeff King <peff@peff.net>\n\nI set OLD_ICONV on my Solaris build.\n\nDo you also unset NEEDS_LIBICONV (and which version of Solaris are you\nrunning)?  Our Makefile sets it to \"yes\" for Solaris 8, but my build box\nrequires that it be unset. I'm not sure if my setup is somehow\ndeficient, or if it is only other versions that need it.\n\n-Peff\n"},{"id":"92127","messageId":"48E49DD6.7000708@gmx.net","threadId":"15741","inReplyTo":"20081002010816.GA27415@coredump.intra.peff.net","subject":"Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings","fromName":"David Soria Parra","fromEmail":"sn_@gmx.net","sentAt":"2008-10-02T10:09:26Z","receivedAt":"2008-10-02T10:09:26Z","isPatch":true,"sender":{"key":"sn_@gmx.net","avatar":"https://gravatar.com/avatar/b1075ecdd33ea094cbc23798fe8b95c73ec1ccf7bb213ac8260c719e2dd97b55?d=mp&s=160"},"body":"Jeff King schrieb:\n> Do you also unset NEEDS_LIBICONV (and which version of Solaris are you\n> running)?  Our Makefile sets it to \"yes\" for Solaris 8, but my build box\n> requires that it be unset. I'm not sure if my setup is somehow\n> deficient, or if it is only other versions that need it.\n\nI'm using OpenSolaris which is identified as SunOS 5.11. Therefore the \nMakefile doesn't set NEEDS_LIBICONV. I'm not sure if it's needed on \nSolaris 8 or not, but it's not needed on OpenSolaris.\n\nDavid\n"},{"id":"92180","messageId":"5A1KxlhmUIHe8iXPxnXYuNXsq0Yjlbwkz2eBin3z7ELuL9nK-4tSpw@cipher.nrlssc.navy.mil","threadId":"15741","inReplyTo":"20081002010816.GA27415@coredump.intra.peff.net","subject":"Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-10-02T15:25:16Z","receivedAt":"2008-10-02T15:25:16Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Jeff King wrote:\n> On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote:\n> \n>> Solaris systems use the old styled iconv(3) call and therefore\n>> the OLD_ICONV variable should be set. Otherwise we get annoying compile\n>> warnings.\n> \n> Acked-by: Jeff King <peff@peff.net>\n> \n> I set OLD_ICONV on my Solaris build.\n\nDitto here on 7.\n\n> \n> Do you also unset NEEDS_LIBICONV (and which version of Solaris are you\n> running)?\n\nI do not set NEEDS_LIBICONV.\n\n-brandon\n"}]}