{"thread":{"id":"15725","subject":"[PATCH] Improve git-log documentation wrt file filters","startedAt":"2008-09-30T14:36:12Z","lastAt":"2008-09-30T19:57:50Z","messageCount":3,"participants":["martin f. krafft","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"91950","messageId":"1222785372-32336-1-git-send-email-madduck@madduck.net","threadId":"15725","inReplyTo":null,"subject":"[PATCH] Improve git-log documentation wrt file filters","fromName":"martin f. krafft","fromEmail":"madduck@madduck.net","sentAt":"2008-09-30T14:36:12Z","receivedAt":"2008-09-30T14:36:12Z","isPatch":true,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"The need for \"--\" in the git-log synopsis was previously unclear and\nconfusing. This patch makes it a little clearer.\n\nThanks to hyy <yiyihu@gmail.com> for his help.\n\nSigned-off-by: martin f. krafft <madduck@madduck.net>\n---\n Documentation/git-log.txt |    8 +++++---\n 1 files changed, 5 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\nindex 0446bad..b7409f8 100644\n--- a/Documentation/git-log.txt\n+++ b/Documentation/git-log.txt\n@@ -8,7 +8,7 @@ git-log - Show commit logs\n \n SYNOPSIS\n --------\n-'git log' <option>...\n+'git log' [<options>] [<since>..<until>] [[--] <path>...]\n \n DESCRIPTION\n -----------\n@@ -57,8 +57,10 @@ include::diff-options.txt[]\n \tNote that only message is considered, if also a diff is shown\n \tits size is not included.\n \n-<path>...::\n-\tShow only commits that affect any of the specified paths.\n+-- <path>...::\n+\tShow only commits that affect any of the specified paths. To\n+        prevent confusion with options and branch names, paths should be\n+        prefixed with \"-- \" to separate them from options or refnames.\n \n \n include::rev-list-options.txt[]\n-- \n1.5.6.5\n"},{"id":"91975","messageId":"20080930192553.GI21310@spearce.org","threadId":"15725","inReplyTo":"1222785372-32336-1-git-send-email-madduck@madduck.net","subject":"Re: [PATCH] Improve git-log documentation wrt file filters","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-09-30T19:25:53Z","receivedAt":"2008-09-30T19:25:53Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"\"martin f. krafft\" <madduck@madduck.net> wrote:\n> The need for \"--\" in the git-log synopsis was previously unclear and\n> confusing. This patch makes it a little clearer.\n \n> diff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\n> index 0446bad..b7409f8 100644\n> --- a/Documentation/git-log.txt\n> +++ b/Documentation/git-log.txt\n> @@ -8,7 +8,7 @@ git-log - Show commit logs\n>  \n>  SYNOPSIS\n>  --------\n> -'git log' <option>...\n> +'git log' [<options>] [<since>..<until>] [[--] <path>...]\n\nThis part is really useful.\n\n>  DESCRIPTION\n>  -----------\n> @@ -57,8 +57,10 @@ include::diff-options.txt[]\n>  \tNote that only message is considered, if also a diff is shown\n>  \tits size is not included.\n>  \n> -<path>...::\n> -\tShow only commits that affect any of the specified paths.\n> +-- <path>...::\n> +\tShow only commits that affect any of the specified paths. To\n> +        prevent confusion with options and branch names, paths should be\n> +        prefixed with \"-- \" to separate them from options or refnames.\n\nIndentation here looks wrong, especially on the last two lines.\n\nI'm also not sure we want to say \"-- <path>\" in the header for\nthis section.  The -- is optional but I'm reading this as though it\nis required.  Maybe \"... paths can be prefixed with -- ...\" instead?\n\n-- \nShawn.\n"},{"id":"91979","messageId":"1222804670-2833-1-git-send-email-madduck@madduck.net","threadId":"15725","inReplyTo":"20080930192553.GI21310@spearce.org","subject":"[PATCH] Improve git-log documentation wrt file filters","fromName":"martin f. krafft","fromEmail":"madduck@madduck.net","sentAt":"2008-09-30T19:57:50Z","receivedAt":"2008-09-30T19:57:50Z","isPatch":true,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"The need for \"--\" in the git-log synopsis was previously unclear and\nconfusing. This patch makes it a little clearer.\n\nThanks to hyy <yiyihu@gmail.com> for his help.\n\nSigned-off-by: martin f. krafft <madduck@madduck.net>\n---\n Documentation/git-log.txt |    8 +++++---\n 1 files changed, 5 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\nindex 0446bad..5a3a625 100644\n--- a/Documentation/git-log.txt\n+++ b/Documentation/git-log.txt\n@@ -8,7 +8,7 @@ git-log - Show commit logs\n \n SYNOPSIS\n --------\n-'git log' <option>...\n+'git log' [<options>] [<since>..<until>] [[--] <path>...]\n \n DESCRIPTION\n -----------\n@@ -57,8 +57,10 @@ include::diff-options.txt[]\n \tNote that only message is considered, if also a diff is shown\n \tits size is not included.\n \n-<path>...::\n-\tShow only commits that affect any of the specified paths.\n+[--] <path>...::\n+\tShow only commits that affect any of the specified paths. To\n+\tprevent confusion with options and branch names, paths may need to be\n+\tprefixed with \"-- \" to separate them from options or refnames.\n \n \n include::rev-list-options.txt[]\n-- \n1.5.6.5\n"}]}