{"thread":{"id":"15703","subject":"[PATCH] git-svn: call 'fatal' correctly in set-tree","startedAt":"2008-09-29T13:58:18Z","lastAt":"2008-10-12T05:34:06Z","messageCount":2,"participants":["Luc Heinrich","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"91840","messageId":"1222696698-97356-1-git-send-email-luc@honk-honk.com","threadId":"15703","inReplyTo":null,"subject":"[PATCH] git-svn: call 'fatal' correctly in set-tree","fromName":"Luc Heinrich","fromEmail":"luc@honk-honk.com","sentAt":"2008-09-29T13:58:18Z","receivedAt":"2008-09-29T13:58:18Z","isPatch":true,"sender":{"key":"luc@honk-honk.com","avatar":null},"body":"When doing a set-tree and there is no revision to commit to, the following unrelated error message is displayed: \"Undefined subroutine &Git::SVN::fatal called at /opt/local/libexec/git-core/git-svn line 2575.\" The following patch fixes the problem and allows the real error message to be shown.\n\nSigned-off-by: Luc Heinrich <luc@honk-honk.com>\n---\n git-svn.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 80a5728..7609a83 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -2591,7 +2591,7 @@ sub set_tree {\n \tmy ($self, $tree) = (shift, shift);\n \tmy $log_entry = ::get_commit_entry($tree);\n \tunless ($self->{last_rev}) {\n-\t\tfatal(\"Must have an existing revision to commit\");\n+\t\t::fatal(\"Must have an existing revision to commit\");\n \t}\n \tmy %ed_opts = ( r => $self->{last_rev},\n \t                log => $log_entry->{log},\n-- \n1.6.0.2\n"},{"id":"92821","messageId":"7v63nyidgx.fsf@gitster.siamese.dyndns.org","threadId":"15703","inReplyTo":"1222696698-97356-1-git-send-email-luc@honk-honk.com","subject":"Re: [PATCH] git-svn: call 'fatal' correctly in set-tree","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-10-12T05:34:06Z","receivedAt":"2008-10-12T05:34:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luc Heinrich <luc@honk-honk.com> writes:\n\n> When doing a set-tree and there is no revision to commit to, the\n> following unrelated error message is displayed: \"Undefined subroutine\n> &Git::SVN::fatal called at /opt/local/libexec/git-core/git-svn line\n> 2575.\" The following patch fixes the problem and allows the real error\n> message to be shown.\n>\n> Signed-off-by: Luc Heinrich <luc@honk-honk.com>\n> ---\n>  git-svn.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/git-svn.perl b/git-svn.perl\n> index 80a5728..7609a83 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -2591,7 +2591,7 @@ sub set_tree {\n>  \tmy ($self, $tree) = (shift, shift);\n>  \tmy $log_entry = ::get_commit_entry($tree);\n>  \tunless ($self->{last_rev}) {\n> -\t\tfatal(\"Must have an existing revision to commit\");\n> +\t\t::fatal(\"Must have an existing revision to commit\");\n>  \t}\n>  \tmy %ed_opts = ( r => $self->{last_rev},\n>  \t                log => $log_entry->{log},\n\nShouldn't the same change be done for the fatal call from apply_diff in\nSVN::Git::Editor package?\n"}]}