{"thread":{"id":"1570","subject":"[PATCH] gitweb - Use <description> instead of <content:encoded>.","startedAt":"2005-08-18T14:30:41Z","lastAt":"2005-08-18T16:52:19Z","messageCount":5,"participants":["Yasushi SHOJI","Sven Verdoolaege","Kay Sievers"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"7502","messageId":"87ll2zwc4u.wl@mail2.atmark-techno.com","threadId":"1570","inReplyTo":null,"subject":"[PATCH] gitweb - Use <description> instead of <content:encoded>.","fromName":"Yasushi SHOJI","fromEmail":"yashi@atmark-techno.com","sentAt":"2005-08-18T14:30:41Z","receivedAt":"2005-08-18T14:30:41Z","isPatch":true,"sender":{"key":"yashi@atmark-techno.com","avatar":"https://gravatar.com/avatar/4817e8703ac4379935834d87453faa9d0c94b9dc19d83fcc54c67875eb133e59?d=mp&s=160"},"body":"Use <description> instead of <content:encoded>.\n\nRSS 2.0 Specification doesn't have <content:encoded>.\nsee http://blogs.law.harvard.edu/tech/rss\n\nI've tested this with Mozilla Thunderbird version 1.0.6 (20050802),\nand seems to be working well.\n\nSigned-off-by: Yasushi SHOJI <yashi@atmark-techno.com>\n---\n\n gitweb.cgi |    5 ++---\n 1 files changed, 2 insertions(+), 3 deletions(-)\n\n8a489f354a5412e44ddaf7443aaecb47a81167f8\ndiff --git a/gitweb.cgi b/gitweb.cgi\n--- a/gitweb.cgi\n+++ b/gitweb.cgi\n@@ -1426,8 +1426,7 @@ sub git_rss {\n \t\t      \"</title>\\n\" .\n \t\t      \"<pubDate>$cd{'rfc2822'}</pubDate>\\n\" .\n \t\t      \"<link>\" . escapeHTML(\"$my_url?p=$project;a=commit;h=$commit\") . \"</link>\\n\" .\n-\t\t      \"<description>\" . escapeHTML($co{'title'}) . \"</description>\\n\" .\n-\t\t      \"<content:encoded>\" .\n+\t\t      \"<description>\" .\n \t\t      \"<![CDATA[\\n\";\n \t\tmy $comment = $co{'comment'};\n \t\tforeach my $line (@$comment) {\n@@ -1442,7 +1441,7 @@ sub git_rss {\n \t\t\tprint \"$file<br/>\\n\";\n \t\t}\n \t\tprint \"]]>\\n\" .\n-\t\t      \"</content:encoded>\\n\" .\n+\t\t      \"</description>\\n\" .\n \t\t      \"</item>\\n\";\n \t}\n \tprint \"</channel></rss>\";\n"},{"id":"7506","messageId":"20050818153607.GX11882MdfPADPa@garage.linux.student.kuleuven.ac.be","threadId":"1570","inReplyTo":"87ll2zwc4u.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] gitweb - Use <description> instead of <content:encoded>.","fromName":"Sven Verdoolaege","fromEmail":"skimo@kotnet.org","sentAt":"2005-08-18T15:36:07Z","receivedAt":"2005-08-18T15:36:07Z","isPatch":true,"sender":{"key":"skimo@kotnet.org","avatar":null},"body":"On Thu, Aug 18, 2005 at 11:30:41PM +0900, Yasushi SHOJI wrote:\n> Use <description> instead of <content:encoded>.\n> \n\nHmm.... in snownews this gets displayed as \"Use  instead of .\".\n(http://www.liacs.nl/~sverdool/gitweb.cgi?p=gitweb.git;a=rss)\n\nIs that a problem with snownews or with gitweb ?\n\nskimo\n"},{"id":"7507","messageId":"20050818160109.GA7237@vrfy.org","threadId":"1570","inReplyTo":"87ll2zwc4u.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] gitweb - Use <description> instead of <content:encoded>.","fromName":"Kay Sievers","fromEmail":"kay.sievers@vrfy.org","sentAt":"2005-08-18T16:01:09Z","receivedAt":"2005-08-18T16:01:09Z","isPatch":true,"sender":{"key":"kay.sievers@vrfy.org","avatar":null},"body":"On Thu, Aug 18, 2005 at 11:30:41PM +0900, Yasushi SHOJI wrote:\n> Use <description> instead of <content:encoded>.\n> \n> RSS 2.0 Specification doesn't have <content:encoded>.\n> see http://blogs.law.harvard.edu/tech/rss\n\nSee here:\n  http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ\n\n  The <description> element is designed to contain plain text ONLY. When\n  the content of your items contains anything other than plain text i.e.\n  HTML or XHTML the <content:encoded> element should be used.\n\nHmm, there was a request to change it to \"encoded\" and the mentioned page\nsounded reasonable to me. I will happily change it to the \"correct\"\nformat, if you provide _authoritative_ information that we can trust.\n\"It works in XY-reader\" does not count. :)\n\nThanks,\nKay\n"},{"id":"7509","messageId":"87hddnw6r7.wl@mail2.atmark-techno.com","threadId":"1570","inReplyTo":"20050818160109.GA7237@vrfy.org","subject":"Re: [PATCH] gitweb - Use <description> instead of <content:encoded>.","fromName":"Yasushi SHOJI","fromEmail":"yashi@atmark-techno.com","sentAt":"2005-08-18T16:26:52Z","receivedAt":"2005-08-18T16:26:52Z","isPatch":true,"sender":{"key":"yashi@atmark-techno.com","avatar":"https://gravatar.com/avatar/4817e8703ac4379935834d87453faa9d0c94b9dc19d83fcc54c67875eb133e59?d=mp&s=160"},"body":"At Thu, 18 Aug 2005 18:01:09 +0200,\nKay Sievers wrote:\n> \n> On Thu, Aug 18, 2005 at 11:30:41PM +0900, Yasushi SHOJI wrote:\n> > Use <description> instead of <content:encoded>.\n> > \n> > RSS 2.0 Specification doesn't have <content:encoded>.\n> > see http://blogs.law.harvard.edu/tech/rss\n> \n> See here:\n>   http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ\n> \n>   The <description> element is designed to contain plain text ONLY. When\n>   the content of your items contains anything other than plain text i.e.\n>   HTML or XHTML the <content:encoded> element should be used.\n> \n> Hmm, there was a request to change it to \"encoded\" and the mentioned page\n> sounded reasonable to me. I will happily change it to the \"correct\"\n> format, if you provide _authoritative_ information that we can trust.\n\nhmm... I'm not an rss guy.  so not sure for anything.\n\nat least, the link you gave me points to the rss 2.0 spec site I put\nin the log as \"RSS v2.0\".  that can be seen as \"more trust'able\"\n\nalso, in the rss 2.0 spec site, you can find 2.0 sample under \"Sapmple\nfiles\", which contain _escaped tag_ in <description>.\n\nthat's all I can say :<  can any one help?\n\n> \"It works in XY-reader\" does not count. :)\n\nagreed.\n--\n         yashi\n"},{"id":"7511","messageId":"87fyt7w5ks.wl@mail2.atmark-techno.com","threadId":"1570","inReplyTo":"20050818153607.GX11882MdfPADPa@garage.linux.student.kuleuven.ac.be","subject":"Re: [PATCH] gitweb - Use <description> instead of <content:encoded>.","fromName":"Yasushi SHOJI","fromEmail":"yashi@atmark-techno.com","sentAt":"2005-08-18T16:52:19Z","receivedAt":"2005-08-18T16:52:19Z","isPatch":true,"sender":{"key":"yashi@atmark-techno.com","avatar":"https://gravatar.com/avatar/4817e8703ac4379935834d87453faa9d0c94b9dc19d83fcc54c67875eb133e59?d=mp&s=160"},"body":"At Thu, 18 Aug 2005 17:36:07 +0200,\nSven Verdoolaege wrote:\n> \n> On Thu, Aug 18, 2005 at 11:30:41PM +0900, Yasushi SHOJI wrote:\n> > Use <description> instead of <content:encoded>.\n> > \n> \n> Hmm.... in snownews this gets displayed as \"Use  instead of .\".\n> (http://www.liacs.nl/~sverdool/gitweb.cgi?p=gitweb.git;a=rss)\n> \n> Is that a problem with snownews or with gitweb ?\n\nwe are not sure.  As Kay said, we need to find out _authoritative_\ninformation for this.\n\nregards,\n--\n        yashi\n"}]}