{"thread":{"id":"15692","subject":"[PATCH 7/8] Docs: send-email: Added all config variables to man end","startedAt":"2008-09-28T01:09:49Z","lastAt":"2008-10-01T20:36:51Z","messageCount":45,"participants":["Michael Witten","Jeff King","Teemu Likonen","Miklos Vajna","Jakub Narebski","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":8},"messages":[{"id":"91760","messageId":"1222564196-84202-1-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":null,"subject":"[PATCH 1/8] Docs: send-email's usage text and man page mention same options","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T01:09:49Z","receivedAt":"2008-09-28T01:09:49Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"Specifically, boolean options are now listed in the form\n\n --[no-]option\n\nand both forms of documentation now consistently use\n\n --[no-]signed-off-by-cc\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 21 +++++++++++++--------\n git-send-email.perl | 8 ++++----\n 2 files changed, 17 insertions(+), 12 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 3c3e1b0..9b31626 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -40,8 +40,7 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOutput of this command must be single email address per line.\n \tDefault is the value of 'sendemail.cccmd' configuration value.\n \n---chain-reply-to::\n---no-chain-reply-to::\n+--[no-]chain-reply-to::\n \tIf this is set, each email will be sent as a reply to the previous\n \temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n \tthe first will be sent as replies to the first email sent. When using\n@@ -66,8 +65,7 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---signed-off-by-cc::\n---no-signed-off-by-cc::\n+--[no-]signed-off-by-cc::\n If this is set, add emails found in Signed-off-by: or Cc: lines to the\n cc list.\n Default is the value of 'sendemail.signedoffcc' configuration value;\n@@ -146,8 +144,7 @@ user is prompted for a password while the input is masked for privacy.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---suppress-from::\n---no-suppress-from::\n+--[no-]suppress-from::\n If this is set, do not add the From: address to the cc: list.\n Default is the value of 'sendemail.suppressfrom' configuration value;\n if that is unspecified, default to --no-suppress-from.\n@@ -163,8 +160,7 @@ user is prompted for a password while the input is masked for privacy.\n \tif that is unspecified, default to 'self' if --suppress-from is\n \tspecified, as well as 'sob' if --no-signed-off-cc is specified.\n \n---thread::\n---no-thread::\n+--[no-]thread::\n \tIf this is set, the In-Reply-To header will be set on each email sent.\n \tIf disabled with \"--no-thread\", no emails will have the In-Reply-To\n \theader set.\n@@ -183,6 +179,15 @@ user is prompted for a password while the input is masked for privacy.\n \tvariable; if that is unspecified, choosing the envelope sender is left\n \tto your MTA.\n \n+--no-validate::\n+\tDon't perform any sanity checks on patches.\n+\tCurrently, validation means the following:\n++\n+--\n+\t\t*\tWarn of patches that contain lines longer than 998 characters; this\n+\t\t\tis due to SMTP limits as described by http://www.ietf.org/rfc/rfc2821.txt.\n+--\n+\n --to::\n \tSpecify the primary recipient of the emails generated.\n \tGenerally, this will be the upstream maintainer of the\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex d2fd899..9f56162 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -64,11 +64,11 @@ Options:\n Only used if --compose is also set. If --compose is not\n \t\t set, this will be prompted for.\n \n- --chain-reply-to If set, the replies will all be to the previous\n+ --[no-]chain-reply-to If set, the replies will all be to the previous\n email sent, rather than to the first email sent.\n Defaults to on.\n \n- --signed-off-cc Automatically add email addresses that appear in\n+ --[no-]signed-off-by-cc Automatically add email addresses that appear in\n Signed-off-by: or Cc: lines to the cc: list. Defaults to on.\n \n --identity The configuration identity, a subsection to prioritise over\n@@ -95,9 +95,9 @@ Options:\n \t\t 'cccmd' for the output of the cccmd, or 'all' to suppress\n \t\t all of these.\n \n- --suppress-from Suppress sending emails to yourself. Defaults to off.\n+ --[no-]suppress-from Suppress sending emails to yourself. Defaults to off.\n \n- --thread Specify that the \"In-Reply-To:\" header should be set on all\n+ --[no-]thread Specify that the \"In-Reply-To:\" header should be set on all\n emails. Defaults to on.\n \n --quiet\t Make git-send-email less verbose. One line per email\n-- \n1.6.0.2.304.g577ee\n"},{"id":"91756","messageId":"1222564196-84202-2-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222564196-84202-1-git-send-email-mfwitten@mit.edu","subject":"[PATCH 2/8] Docs: send-email usage text much sexier","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T01:09:50Z","receivedAt":"2008-09-28T01:09:50Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"All of the descriptions are aligned, shorter,\nbetter arranged, and no line is greater than\n78 columns.\n\nSigned-off-by: Michael Witten \n---\n git-send-email.perl | 94 ++++++++++++++-------------------------------------\n 1 files changed, 26 insertions(+), 68 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 9f56162..2c31a25 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -40,74 +40,32 @@ sub usage {\n \tprint <...\n Options:\n- --from Specify the \"From:\" line of the email to be sent.\n-\n- --to Specify the primary \"To:\" line of the email.\n-\n- --cc Specify an initial \"Cc:\" list for the entire series\n- of emails.\n-\n- --cc-cmd Specify a command to execute per file which adds\n- per file specific cc address entries\n-\n- --bcc Specify a list of email addresses that should be Bcc:\n-\t\t on all the emails.\n-\n- --compose Use \\$GIT_EDITOR, core.editor, \\$EDITOR, or \\$VISUAL to edit\n-\t\t an introductory message for the patch series.\n-\n- --subject Specify the initial \"Subject:\" line.\n- Only necessary if --compose is also set. If --compose\n-\t\t is not set, this will be prompted for.\n-\n- --in-reply-to Specify the first \"In-Reply-To:\" header line.\n- Only used if --compose is also set. If --compose is not\n-\t\t set, this will be prompted for.\n-\n- --[no-]chain-reply-to If set, the replies will all be to the previous\n- email sent, rather than to the first email sent.\n- Defaults to on.\n-\n- --[no-]signed-off-by-cc Automatically add email addresses that appear in\n- Signed-off-by: or Cc: lines to the cc: list. Defaults to on.\n-\n- --identity The configuration identity, a subsection to prioritise over\n- the default section.\n-\n- --smtp-server If set, specifies the outgoing SMTP server to use.\n- Defaults to localhost. Port number can be specified here with\n- hostname:port format or by using --smtp-server-port option.\n-\n- --smtp-server-port Specify a port on the outgoing SMTP server to connect to.\n-\n- --smtp-user The username for SMTP-AUTH.\n-\n- --smtp-pass The password for SMTP-AUTH.\n-\n- --smtp-encryption Specify 'tls' for STARTTLS encryption, or 'ssl' for SSL.\n- Any other value disables the feature.\n-\n- --smtp-ssl Synonym for '--smtp-encryption=ssl'. Deprecated.\n-\n- --suppress-cc Suppress the specified category of auto-CC. The category\n-\t\t can be one of 'author' for the patch author, 'self' to\n-\t\t avoid copying yourself, 'sob' for Signed-off-by lines,\n-\t\t 'cccmd' for the output of the cccmd, or 'all' to suppress\n-\t\t all of these.\n-\n- --[no-]suppress-from Suppress sending emails to yourself. Defaults to off.\n-\n- --[no-]thread Specify that the \"In-Reply-To:\" header should be set on all\n- emails. Defaults to on.\n-\n- --quiet\t Make git-send-email less verbose. One line per email\n- should be all that is output.\n-\n- --dry-run\t Do everything except actually send the emails.\n-\n- --envelope-sender\tSpecify the envelope sender used to send the emails.\n-\n- --no-validate\tDon't perform any sanity checks on patches.\n+ --identity * Use the sendemail. options.\n+ --from * Email From:\n+ --envelope-sender * Email envelope sender.\n+ --to * Email To:\n+ --cc * Email Cc:\n+ --cc-cmd * Email Cc: via ` \\$patch_path`\n+ --bcc * Email Bcc:\n+ --subject * Email \"Subject:\" (only if --compose).\n+ --compose * Open an editor for introduction.\n+ --in-reply-to * First \"In-Reply-To:\" (only if --compose).\n+ --[no-]chain-reply-to * Chain In-Reply-To: fields. Default on.\n+ --[no-]thread * Use In-Reply-To: field. Default on.\n+ --[no-]signed-off-by-cc * Actually send to Cc: and Signed-off-by:\n+ addresses. Default on.\n+ --suppress-cc * author, self, sob, cccmd, all.\n+ --[no-]suppress-from * Don't send email to self. Default off.\n+ --smtp-server * Outgoing SMTP server to use. The port\n+ is optional. Default 'localhost'.\n+ --smtp-server-port * Outgoing SMTP server port.\n+ --smtp-user * The username for SMTP-AUTH.\n+ --smtp-pass * The password for SMTP-AUTH; not necessary.\n+ --smtp-encryption * tls or ssl; anything else disables.\n+ --smtp-ssl * Deprecated. Use '--smtp-encryption ssl'.\n+ --quiet * Output one line of info per email.\n+ --dry-run * Don't actually send the emails.\n+ --no-validate * Don't perform sanity checks on patches.\n \n EOT\n \texit(1);\n-- \n1.6.0.2.304.g577ee\n"},{"id":"91757","messageId":"1222564196-84202-3-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222564196-84202-2-git-send-email-mfwitten@mit.edu","subject":"[PATCH 3/8] Docs: send-email: Man page option ordering","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T01:09:51Z","receivedAt":"2008-09-28T01:09:51Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"Now the man page lists the options in alphabetical\norder (in terms of the 'main' part of an option's\nname).\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 138 ++++++++++++++++++--------------------\n 1 files changed, 66 insertions(+), 72 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 9b31626..0c6dbf6 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -11,7 +11,6 @@ SYNOPSIS\n 'git send-email' [options] [... file|directory]\n \n \n-\n DESCRIPTION\n -----------\n Takes the patches given on the command line and emails them out.\n@@ -45,19 +44,35 @@ The --cc option must be repeated for each user you want on the cc list.\n \temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n \tthe first will be sent as replies to the first email sent. When using\n \tthis, it is recommended that the first file given be an overview of the\n-\tentire patch series.\n-\tDefault is the value of the 'sendemail.chainreplyto' configuration\n-\tvalue; if that is unspecified, default to --chain-reply-to.\n+\tentire patch series. Default is the value of the 'sendemail.chainreplyto'\n+\tconfiguration value; if that is unspecified, default to --chain-reply-to.\n \n --compose::\n \tUse $GIT_EDITOR, core.editor, $VISUAL, or $EDITOR to edit an\n \tintroductory message for the patch series.\n \n+--dry-run::\n+\tDo everything except actually send the emails.\n+\n+--envelope-sender::\n+\tSpecify the envelope sender used to send the emails.\n+\tThis is useful if your default address is not the address that is\n+\tsubscribed to a list. If you use the sendmail binary, you must have\n+\tsuitable privileges for the -f parameter. Default is the value of\n+\tthe 'sendemail.envelopesender' configuration variable; if that is\n+\tunspecified, choosing the envelope sender is left to your MTA.\n+\n --from::\n \tSpecify the sender of the emails. This will default to\n \tthe value GIT_COMMITTER_IDENT, as returned by \"git var -l\".\n \tThe user will still be prompted to confirm this entry.\n \n+--identity::\n+\tA configuration identity. When given, causes values in the\n+\t'sendemail.' subsection to take precedence over\n+\tvalues in the 'sendemail' section. The default identity is\n+\tthe value of 'sendemail.identity'.\n+\n --in-reply-to::\n \tSpecify the contents of the first In-Reply-To header.\n \tSubsequent emails will refer to the previous email\n@@ -65,21 +80,40 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---[no-]signed-off-by-cc::\n- If this is set, add emails found in Signed-off-by: or Cc: lines to the\n- cc list.\n- Default is the value of 'sendemail.signedoffcc' configuration value;\n- if that is unspecified, default to --signed-off-by-cc.\n-\n --quiet::\n \tMake git-send-email less verbose. One line per email should be\n \tall that is output.\n \n---identity::\n-\tA configuration identity. When given, causes values in the\n-\t'sendemail.' subsection to take precedence over\n-\tvalues in the 'sendemail' section. The default identity is\n-\tthe value of 'sendemail.identity'.\n+--[no-]signed-off-by-cc::\n+ If this is set, add emails found in Signed-off-by: or Cc: lines to the\n+ cc list. Default is the value of 'sendemail.signedoffcc' configuration\n+ value; if that is unspecified, default to --signed-off-by-cc.\n+\n+--smtp-encryption::\n+\tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n+\tvalue reverts to plain SMTP. Default is the value of\n+\t'sendemail.smtpencryption'.\n+\n+--smtp-pass::\n+\tPassword for SMTP-AUTH. The argument is optional: If no\n+\targument is specified, then the empty string is used as\n+\tthe password.\n++\n+In place of this option, the following configuration variables\n+can be specified:\n++\n+--\n+\t\t* sendemail.smtppass\n+\t\t* sendemail..smtppass (see sendemail.identity).\n+--\n++\n+However, --smtp-pass always overrides these variables.\n++\n+Furthermore, passwords need not be specified in configuration files\n+or on the command line. If a username has been specified (with\n+--smtp-user or a configuration variable), but no password has been\n+specified (with --smtp-pass or a configuration variable), then the\n+user is prompted for a password while the input is masked for privacy.\n \n --smtp-server::\n \tIf set, specifies the outgoing SMTP server to use (e.g.\n@@ -96,6 +130,9 @@ The --cc option must be repeated for each user you want on the cc list.\n \tservers typically listen to smtp port 25 and ssmtp port\n \t465).\n \n+--smtp-ssl::\n+\tLegacy alias for '--smtp-encryption=ssl'.\n+\n --smtp-user::\n \tUsername for SMTP-AUTH. In place of this option, the following\n \tconfiguration variables can be specified:\n@@ -110,45 +147,11 @@ However, --smtp-user always overrides these variables.\n If a username is not specified (with --smtp-user or a\n configuration variable), then authentication is not attempted.\n \n---smtp-pass::\n-\tPassword for SMTP-AUTH. The argument is optional: If no\n-\targument is specified, then the empty string is used as\n-\tthe password.\n-+\n-In place of this option, the following configuration variables\n-can be specified:\n-+\n---\n-\t\t* sendemail.smtppass\n-\t\t* sendemail..smtppass (see sendemail.identity).\n---\n-+\n-However, --smtp-pass always overrides these variables.\n-+\n-Furthermore, passwords need not be specified in configuration files\n-or on the command line. If a username has been specified (with\n---smtp-user or a configuration variable), but no password has been\n-specified (with --smtp-pass or a configuration variable), then the\n-user is prompted for a password while the input is masked for privacy.\n-\n---smtp-encryption::\n-\tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n-\tvalue reverts to plain SMTP. Default is the value of\n-\t'sendemail.smtpencryption'.\n-\n---smtp-ssl::\n-\tLegacy alias for '--smtp-encryption=ssl'.\n-\n --subject::\n \tSpecify the initial subject of the email thread.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---[no-]suppress-from::\n- If this is set, do not add the From: address to the cc: list.\n- Default is the value of 'sendemail.suppressfrom' configuration value;\n- if that is unspecified, default to --no-suppress-from.\n-\n --suppress-cc::\n \tSpecify an additional category of recipients to suppress the\n \tauto-cc of. 'self' will avoid including the sender, 'author' will\n@@ -160,24 +163,24 @@ user is prompted for a password while the input is masked for privacy.\n \tif that is unspecified, default to 'self' if --suppress-from is\n \tspecified, as well as 'sob' if --no-signed-off-cc is specified.\n \n+--[no-]suppress-from::\n+\tIf this is set, do not add the From: address to the cc: list.\n+\tDefault is the value of 'sendemail.suppressfrom' configuration\n+\tvalue; if that is unspecified, default to --no-suppress-from.\n+\n --[no-]thread::\n \tIf this is set, the In-Reply-To header will be set on each email sent.\n \tIf disabled with \"--no-thread\", no emails will have the In-Reply-To\n-\theader set.\n-\tDefault is the value of the 'sendemail.thread' configuration value;\n-\tif that is unspecified, default to --thread.\n+\theader set. Default is the value of the 'sendemail.thread' configuration\n+\tvalue; if that is unspecified, default to --thread.\n \n---dry-run::\n-\tDo everything except actually send the emails.\n-\n---envelope-sender::\n-\tSpecify the envelope sender used to send the emails.\n-\tThis is useful if your default address is not the address that is\n-\tsubscribed to a list. If you use the sendmail binary, you must have\n-\tsuitable privileges for the -f parameter.\n-\tDefault is the value of the 'sendemail.envelopesender' configuration\n-\tvariable; if that is unspecified, choosing the envelope sender is left\n-\tto your MTA.\n+--to::\n+\tSpecify the primary recipient of the emails generated. Generally, this\n+\twill be the upstream maintainer of the project involved. Default is the\n+\tvalue of the 'sendemail.to' configuration value; if that is unspecified,\n+\tthis will be prompted for.\n++\n+The --to option must be repeated for each user you want on the to list.\n \n --no-validate::\n \tDon't perform any sanity checks on patches.\n@@ -188,15 +191,6 @@ user is prompted for a password while the input is masked for privacy.\n \t\t\tis due to SMTP limits as described by http://www.ietf.org/rfc/rfc2821.txt.\n --\n \n---to::\n-\tSpecify the primary recipient of the emails generated.\n-\tGenerally, this will be the upstream maintainer of the\n-\tproject involved.\n-\tDefault is the value of the 'sendemail.to' configuration value;\n-\tif that is unspecified, this will be prompted for.\n-+\n-The --to option must be repeated for each user you want on the to list.\n-\n \n CONFIGURATION\n -------------\n-- \n1.6.0.2.304.g577ee\n"},{"id":"91758","messageId":"1222564196-84202-4-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222564196-84202-3-git-send-email-mfwitten@mit.edu","subject":"[PATCH 4/8] send-email: change --no-validate to boolean --[no-]validate","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T01:09:52Z","receivedAt":"2008-09-28T01:09:52Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"There is also now a configuration variable:\n\n sendemail[.].validate\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 9 +++++++--\n git-send-email.perl | 9 +++++----\n 2 files changed, 12 insertions(+), 6 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 0c6dbf6..81970f3 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -182,14 +182,16 @@ configuration variable), then authentication is not attempted.\n +\n The --to option must be repeated for each user you want on the to list.\n \n---no-validate::\n-\tDon't perform any sanity checks on patches.\n+--[no-]validate::\n+\tPerform sanity checks on patches.\n \tCurrently, validation means the following:\n +\n --\n \t\t*\tWarn of patches that contain lines longer than 998 characters; this\n \t\t\tis due to SMTP limits as described by http://www.ietf.org/rfc/rfc2821.txt.\n --\n++\n+This option can be set with sendemail[.].validate; default to --validate\n \n \n CONFIGURATION\n@@ -242,6 +244,9 @@ sendemail.smtpencryption::\n sendemail.smtpssl::\n \tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n \n+sendemail.validate::\n+ Boolean override for --[no-]validate.\n+\n Author\n ------\n Written by Ryan Anderson \ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 2c31a25..3467cf1 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -65,7 +65,7 @@ Options:\n --smtp-ssl * Deprecated. Use '--smtp-encryption ssl'.\n --quiet * Output one line of info per email.\n --dry-run * Don't actually send the emails.\n- --no-validate * Don't perform sanity checks on patches.\n+ --[no-]validate * Perform patch sanity checks. Default on.\n \n EOT\n \texit(1);\n@@ -147,7 +147,7 @@ my ($quiet, $dry_run) = (0, 0);\n my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd);\n my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption);\n my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts);\n-my ($no_validate);\n+my ($validate);\n my (@suppress_cc);\n \n my %config_bool_settings = (\n@@ -155,6 +155,7 @@ my %config_bool_settings = (\n \"chainreplyto\" => [\\$chain_reply_to, 1],\n \"suppressfrom\" => [\\$suppress_from, undef],\n \"signedoffcc\" => [\\$signed_off_cc, undef],\n+ \"validate\" => [\\$validate, 1],\n );\n \n my %config_settings = (\n@@ -221,7 +222,7 @@ my $rc = GetOptions(\"sender|from=s\" => \\$sender,\n \t\t \"dry-run\" => \\$dry_run,\n \t\t \"envelope-sender=s\" => \\$envelope_sender,\n \t\t \"thread!\" => \\$thread,\n-\t\t \"no-validate\" => \\$no_validate,\n+\t\t \"validate!\" => \\$validate,\n \t );\n \n unless ($rc) {\n@@ -374,7 +375,7 @@ for my $f (@ARGV) {\n \t}\n }\n \n-if (!$no_validate) {\n+if ($validate) {\n \tforeach my $f (@files) {\n \t\tunless (-p $f) {\n \t\t\tmy $error = validate_patch($f);\n-- \n1.6.0.2.304.g577ee\n"},{"id":"91754","messageId":"1222564196-84202-5-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222564196-84202-4-git-send-email-mfwitten@mit.edu","subject":"[PATCH 5/8] Docs: send-email: --chain_reply_to -> --[no-]chain-reply-to","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T01:09:53Z","receivedAt":"2008-09-28T01:09:53Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"Signed-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 81970f3..6b62032 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -221,7 +221,7 @@ sendemail.bcc::\n \tEmail address (or alias) to always bcc.\n \n sendemail.chainreplyto::\n-\tBoolean value specifying the default to the '--chain_reply_to'\n+\tBoolean value specifying the default to the '--[no-]chain-reply-to'\n \tparameter.\n \n sendemail.smtpserver::\n-- \n1.6.0.2.304.g577ee\n"},{"id":"91755","messageId":"1222564196-84202-6-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222564196-84202-5-git-send-email-mfwitten@mit.edu","subject":"[PATCH 6/8] Docs: Arranged config options in man page","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T01:09:54Z","receivedAt":"2008-09-28T01:09:54Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"Signed-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 44 +++++++++++++++++++-------------------\n 1 files changed, 22 insertions(+), 22 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 6b62032..8aa5098 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -196,13 +196,6 @@ This option can be set with sendemail[.].validate; default to --valida\n \n CONFIGURATION\n -------------\n-sendemail.identity::\n-\tThe default configuration identity. When specified,\n-\t'sendemail..' will have higher precedence than\n-\t'sendemail.'. This is useful to declare multiple SMTP\n-\tidentities and to hoist sensitive authentication information\n-\tout of the repository and into the global configuration file.\n-\n sendemail.aliasesfile::\n \tTo avoid typing long email addresses, point this to one or more\n \temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n@@ -211,38 +204,45 @@ sendemail.aliasfiletype::\n \tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n \tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n \n-sendemail.to::\n-\tEmail address (or alias) to always send to.\n+sendemail.bcc::\n+\tEmail address (or alias) to always bcc.\n \n sendemail.cccmd::\n \tCommand to execute to generate per patch file specific \"Cc:\"s.\n \n-sendemail.bcc::\n-\tEmail address (or alias) to always bcc.\n-\n sendemail.chainreplyto::\n \tBoolean value specifying the default to the '--[no-]chain-reply-to'\n \tparameter.\n \n+sendemail.identity::\n+\tThe default configuration identity. When specified,\n+\t'sendemail..' will have higher precedence than\n+\t'sendemail.'. This is useful to declare multiple SMTP\n+\tidentities and to hoist sensitive authentication information\n+\tout of the repository and into the global configuration file.\n+\n+sendemail.smtpencryption::\n+\tDefault encryption method. Use 'ssl' for SSL (and specify an\n+\tappropriate port), or 'tls' for TLS. Takes precedence over\n+\t'smtpssl' if both are specified.\n+\n+sendemail.smtppass::\n+\tDefault SMTP-AUTH password.\n+\n sendemail.smtpserver::\n \tDefault SMTP server to use.\n \n sendemail.smtpserverport::\n \tDefault SMTP server port to use.\n \n+sendemail.smtpssl::\n+\tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n+\n sendemail.smtpuser::\n \tDefault SMTP-AUTH username.\n \n-sendemail.smtppass::\n-\tDefault SMTP-AUTH password.\n-\n-sendemail.smtpencryption::\n-\tDefault encryption method. Use 'ssl' for SSL (and specify an\n-\tappropriate port), or 'tls' for TLS. Takes precedence over\n-\t'smtpssl' if both are specified.\n-\n-sendemail.smtpssl::\n-\tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n+sendemail.to::\n+\tEmail address (or alias) to always send to.\n \n sendemail.validate::\n Boolean override for --[no-]validate.\n-- \n1.6.0.2.304.g577ee\n"},{"id":"91753","messageId":"1222564196-84202-7-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222564196-84202-6-git-send-email-mfwitten@mit.edu","subject":"[PATCH 7/8] Docs: send-email: Added all config variables to man end","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T01:09:55Z","receivedAt":"2008-09-28T01:09:55Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"Admittedly, I didn't take much pride in my work, but\nI'm not trying to solve this problem.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 18 ++++++++++++++++++\n 1 files changed, 18 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 8aa5098..ee89e03 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -207,6 +207,9 @@ sendemail.aliasfiletype::\n sendemail.bcc::\n \tEmail address (or alias) to always bcc.\n \n+sendemail.cc::\n+ Default for --cc\n+\n sendemail.cccmd::\n \tCommand to execute to generate per patch file specific \"Cc:\"s.\n \n@@ -214,6 +217,9 @@ sendemail.chainreplyto::\n \tBoolean value specifying the default to the '--[no-]chain-reply-to'\n \tparameter.\n \n+sendemail.envelopesender\n+ Default for --envelope-sender.\n+\n sendemail.identity::\n \tThe default configuration identity. When specified,\n \t'sendemail..' will have higher precedence than\n@@ -221,6 +227,9 @@ sendemail.identity::\n \tidentities and to hoist sensitive authentication information\n \tout of the repository and into the global configuration file.\n \n+sendemail.signedoffcc::\n+ Default for --[no-]signed-off-by-cc.\n+\n sendemail.smtpencryption::\n \tDefault encryption method. Use 'ssl' for SSL (and specify an\n \tappropriate port), or 'tls' for TLS. Takes precedence over\n@@ -241,6 +250,15 @@ sendemail.smtpssl::\n sendemail.smtpuser::\n \tDefault SMTP-AUTH username.\n \n+sendemail.suppresscc::\n+ Default for --supress-cc.\n+\n+sendemail.suppressfrom::\n+ Default for --[no-]suppress-from\n+\n+sendemail.thread::\n+ Default for --[no-]thread\n+\n sendemail.to::\n \tEmail address (or alias) to always send to.\n \n-- \n1.6.0.2.304.g577ee\n"},{"id":"91759","messageId":"1222564196-84202-8-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222564196-84202-7-git-send-email-mfwitten@mit.edu","subject":"[PATCH 8/8] Docs: config: send-email config options included","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T01:09:56Z","receivedAt":"2008-09-28T01:09:56Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"I just copied what is in the send-email man text.\n\nSigned-off-by: Michael Witten \n---\n Documentation/config.txt | 69 ++++++++++++++++++++++++++++++++++++++++++++++\n 1 files changed, 69 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex bea867d..3fc1bb1 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1075,6 +1075,75 @@ repack.usedeltabaseoffset::\n \t\"false\" and repack. Access from old git versions over the\n \tnative protocol are unaffected by this option.\n \n+sendemail.aliasesfile::\n+\tTo avoid typing long email addresses, point this to one or more\n+\temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n+\n+sendemail.aliasfiletype::\n+\tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n+\tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n+\n+sendemail.bcc::\n+\tEmail address (or alias) to always bcc.\n+\n+sendemail.cc::\n+ Default for --cc\n+\n+sendemail.cccmd::\n+\tCommand to execute to generate per patch file specific \"Cc:\"s.\n+\n+sendemail.chainreplyto::\n+\tBoolean value specifying the default to the '--[no-]chain-reply-to'\n+\tparameter.\n+\n+sendemail.envelopesender\n+ Default for --envelope-sender.\n+\n+sendemail.identity::\n+\tThe default configuration identity. When specified,\n+\t'sendemail..' will have higher precedence than\n+\t'sendemail.'. This is useful to declare multiple SMTP\n+\tidentities and to hoist sensitive authentication information\n+\tout of the repository and into the global configuration file.\n+\n+sendemail.signedoffcc::\n+ Default for --[no-]signed-off-by-cc.\n+\n+sendemail.smtpencryption::\n+\tDefault encryption method. Use 'ssl' for SSL (and specify an\n+\tappropriate port), or 'tls' for TLS. Takes precedence over\n+\t'smtpssl' if both are specified.\n+\n+sendemail.smtppass::\n+\tDefault SMTP-AUTH password.\n+\n+sendemail.smtpserver::\n+\tDefault SMTP server to use.\n+\n+sendemail.smtpserverport::\n+\tDefault SMTP server port to use.\n+\n+sendemail.smtpssl::\n+\tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n+\n+sendemail.smtpuser::\n+\tDefault SMTP-AUTH username.\n+\n+sendemail.suppresscc::\n+ Default for --supress-cc.\n+\n+sendemail.suppressfrom::\n+ Default for --[no-]suppress-from\n+\n+sendemail.thread::\n+ Default for --[no-]thread\n+\n+sendemail.to::\n+\tEmail address (or alias) to always send to.\n+\n+sendemail.validate::\n+ Boolean override for --[no-]validate.\n+\n showbranch.default::\n \tThe default set of branches for linkgit:git-show-branch[1].\n \tSee linkgit:git-show-branch[1].\n-- \n1.6.0.2.304.g577ee\n"},{"id":"91767","messageId":"20080928031550.GA15696@sigill.intra.peff.net","threadId":"15692","inReplyTo":"1222564196-84202-6-git-send-email-mfwitten@mit.edu","subject":"Re: [PATCH 6/8] Docs: Arranged config options in man page","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-28T03:15:51Z","receivedAt":"2008-09-28T03:15:51Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Sep 27, 2008 at 08:09:54PM -0500, Michael Witten wrote:\n\n> Signed-off-by: Michael Witten \n> ---\n\nArranged in what way? I assume alphabetized, but please make it clear\nin the commit message.\n\nAlso, Junio is out of touch for a few weeks, so it probably makes sense\nto send your patches to Shawn Pearce in the\ninterim.\n\nAlso also, micronit: we usually use the imperative to describe patch\nchanges (i.e., \"arrange\" instead of \"arranged\").\n\n-Peff\n"},{"id":"91768","messageId":"20080928031822.GB15696@sigill.intra.peff.net","threadId":"15692","inReplyTo":"1222564196-84202-7-git-send-email-mfwitten@mit.edu","subject":"Re: [PATCH 7/8] Docs: send-email: Added all config variables to man end","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-28T03:18:22Z","receivedAt":"2008-09-28T03:18:22Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Sep 27, 2008 at 08:09:55PM -0500, Michael Witten wrote:\n\n> Admittedly, I didn't take much pride in my work, but\n> I'm not trying to solve this problem.\n\nRemember that your commit message is supposed to be convincing us that\nyour patch is worth applying. ;P\n\nIt seems like these are just mechanical \"sendemail.foo is a default for\n--foo\" additions. Maybe it is better to simply make a note of that (or\nmention it in the --foo section).\n\n-Peff\n"},{"id":"91769","messageId":"20080928032407.GC15696@sigill.intra.peff.net","threadId":"15692","inReplyTo":"1222564196-84202-8-git-send-email-mfwitten@mit.edu","subject":"Re: [PATCH 8/8] Docs: config: send-email config options included","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-28T03:24:07Z","receivedAt":"2008-09-28T03:24:07Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Sep 27, 2008 at 08:09:56PM -0500, Michael Witten wrote:\n\n> I just copied what is in the send-email man text.\n\nNAK, this makes things much worse by creating two places which must be\nupdated with any changes. Shouldn't doing it the right way be as simple\nas something like the patch below?\n\nThough it looks like imap.* simply says \"See git-imap-send(1)\" in\nconfig.txt, which would also be OK by me (and makes sense especially if\nwe drop most of the sendemail.* description in favor of just mentioning\nthe config option near the matching command-line option).\n\n---\n Documentation/config.txt | 2 +\n Documentation/git-send-email.txt | 48 +-----------------------------------\n Documentation/sendemail-config.txt | 47 +++++++++++++++++++++++++++++++++++\n 3 files changed, 50 insertions(+), 47 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex c806749..0bb2621 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1173,6 +1173,8 @@ receive.denyNonFastForwards::\n \teven if that push is forced. This configuration variable is\n \tset when initializing a shared repository.\n \n+include::sendemail-config.txt[]\n+\n transfer.unpackLimit::\n \tWhen `fetch.unpackLimit` or `receive.unpackLimit` are\n \tnot set, the value of this variable is used instead.\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 3c3e1b0..465cf56 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -195,53 +195,7 @@ The --to option must be repeated for each user you want on the to list.\n \n CONFIGURATION\n -------------\n-sendemail.identity::\n-\tThe default configuration identity. When specified,\n-\t'sendemail..' will have higher precedence than\n-\t'sendemail.'. This is useful to declare multiple SMTP\n-\tidentities and to hoist sensitive authentication information\n-\tout of the repository and into the global configuration file.\n-\n-sendemail.aliasesfile::\n-\tTo avoid typing long email addresses, point this to one or more\n-\temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n-\n-sendemail.aliasfiletype::\n-\tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n-\tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n-\n-sendemail.to::\n-\tEmail address (or alias) to always send to.\n-\n-sendemail.cccmd::\n-\tCommand to execute to generate per patch file specific \"Cc:\"s.\n-\n-sendemail.bcc::\n-\tEmail address (or alias) to always bcc.\n-\n-sendemail.chainreplyto::\n-\tBoolean value specifying the default to the '--chain_reply_to'\n-\tparameter.\n-\n-sendemail.smtpserver::\n-\tDefault SMTP server to use.\n-\n-sendemail.smtpserverport::\n-\tDefault SMTP server port to use.\n-\n-sendemail.smtpuser::\n-\tDefault SMTP-AUTH username.\n-\n-sendemail.smtppass::\n-\tDefault SMTP-AUTH password.\n-\n-sendemail.smtpencryption::\n-\tDefault encryption method. Use 'ssl' for SSL (and specify an\n-\tappropriate port), or 'tls' for TLS. Takes precedence over\n-\t'smtpssl' if both are specified.\n-\n-sendemail.smtpssl::\n-\tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n+include::sendemail-config.txt[]\n \n Author\n ------\ndiff --git a/Documentation/sendemail-config.txt b/Documentation/sendemail-config.txt\nnew file mode 100644\nindex 0000000..7409534\n--- /dev/null\n+++ b/Documentation/sendemail-config.txt\n@@ -0,0 +1,47 @@\n+sendemail.identity::\n+\tThe default configuration identity. When specified,\n+\t'sendemail..' will have higher precedence than\n+\t'sendemail.'. This is useful to declare multiple SMTP\n+\tidentities and to hoist sensitive authentication information\n+\tout of the repository and into the global configuration file.\n+\n+sendemail.aliasesfile::\n+\tTo avoid typing long email addresses, point this to one or more\n+\temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n+\n+sendemail.aliasfiletype::\n+\tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n+\tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n+\n+sendemail.to::\n+\tEmail address (or alias) to always send to.\n+\n+sendemail.cccmd::\n+\tCommand to execute to generate per patch file specific \"Cc:\"s.\n+\n+sendemail.bcc::\n+\tEmail address (or alias) to always bcc.\n+\n+sendemail.chainreplyto::\n+\tBoolean value specifying the default to the '--chain_reply_to'\n+\tparameter.\n+\n+sendemail.smtpserver::\n+\tDefault SMTP server to use.\n+\n+sendemail.smtpserverport::\n+\tDefault SMTP server port to use.\n+\n+sendemail.smtpuser::\n+\tDefault SMTP-AUTH username.\n+\n+sendemail.smtppass::\n+\tDefault SMTP-AUTH password.\n+\n+sendemail.smtpencryption::\n+\tDefault encryption method. Use 'ssl' for SSL (and specify an\n+\tappropriate port), or 'tls' for TLS. Takes precedence over\n+\t'smtpssl' if both are specified.\n+\n+sendemail.smtpssl::\n+\tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n"},{"id":"91772","messageId":"20080928045121.GA3208@mithlond.arda.local","threadId":"15692","inReplyTo":"1222564196-84202-4-git-send-email-mfwitten@mit.edu","subject":"[PATCH] bash completion: Add --[no-]-validate to \"git send-email\"","fromName":"Teemu Likonen","fromEmail":"tlikonen@iki.fi","sentAt":"2008-09-28T04:51:21Z","receivedAt":"2008-09-28T04:51:21Z","isPatch":true,"sender":{"key":"tlikonen@iki.fi","avatar":null},"body":"Signed-off-by: Teemu Likonen \n---\n\n If your patch is to be applied let's also add the options to bash \n completion.\n\n contrib/completion/git-completion.bash | 3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 93f0881..7284c3b 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1141,7 +1141,8 @@ _git_send_email ()\n \t\t\t--no-suppress-from --no-thread --quiet\n \t\t\t--signed-off-by-cc --smtp-pass --smtp-server\n \t\t\t--smtp-server-port --smtp-ssl --smtp-user --subject\n-\t\t\t--suppress-cc --suppress-from --thread --to\"\n+\t\t\t--suppress-cc --suppress-from --thread --to\n+\t\t\t--validate --no-validate\"\n \t\treturn\n \t\t;;\n \tesac\n-- \n1.6.0.2.371.g15dc6\n"},{"id":"91773","messageId":"20080928050828.GZ23137@genesis.frugalware.org","threadId":"15692","inReplyTo":"1222564196-84202-1-git-send-email-mfwitten@mit.edu","subject":"Re: [PATCH 1/8] Docs: send-email's usage text and man page mention same options","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-09-28T05:08:28Z","receivedAt":"2008-09-28T05:08:28Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sat, Sep 27, 2008 at 08:09:49PM -0500, Michael Witten wrote:\n> Specifically, boolean options are now listed in the form\n> \n> --[no-]option\n> \n> and both forms of documentation now consistently use\n> \n> --[no-]signed-off-by-cc\n\nI don't think documenting --no-foo in the perl script itself is a good\nidea. See c3170a8 (git-merge: exclude unnecessary options from\nOPTIONS_SPEC, 2008-05-12) which removes --no-foo from git-merge as well.\n\nOf course the man page part makes sense.\n"},{"id":"91774","messageId":"gbne1a$8g2$1@ger.gmane.org","threadId":"15692","inReplyTo":"1222564196-84202-3-git-send-email-mfwitten@mit.edu","subject":"Re: [PATCH 3/8] Docs: send-email: Man page option ordering","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-09-28T08:08:09Z","receivedAt":"2008-09-28T08:08:09Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Michael Witten wrote:\n\n> Now the man page lists the options in alphabetical\n> order (in terms of the 'main' part of an option's\n> name).\n\nI know it is a matter of taste, but I prefer having options\non man page in functional order, grouped by function, perhaps\nwith subsections to group them (c.f. git-rev-list man page).\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"91792","messageId":"20080928125500.GB3208@mithlond.arda.local","threadId":"15692","inReplyTo":"20080928045121.GA3208@mithlond.arda.local","subject":"Re: [PATCH] bash completion: Add --[no-]-validate to \"git send-email\"","fromName":"Teemu Likonen","fromEmail":"tlikonen@iki.fi","sentAt":"2008-09-28T12:55:00Z","receivedAt":"2008-09-28T12:55:00Z","isPatch":true,"sender":{"key":"tlikonen@iki.fi","avatar":null},"body":"Teemu Likonen wrote (2008-09-28 07:51 +0300):\n\n> Signed-off-by: Teemu Likonen \n> ---\n> \n> If your patch is to be applied let's also add the options to bash \n> completion.\n\nOne extra hyphen in the subject of my commit message. This is better:\n\n bash completion: Add --[no-]validate to \"git send-email\"\n"},{"id":"91810","messageId":"E7B8D948-EBB0-4D40-B88A-DA893738779B@mit.edu","threadId":"15692","inReplyTo":"20080928031550.GA15696@sigill.intra.peff.net","subject":"Re: [PATCH 6/8] Docs: Arranged config options in man page","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T19:03:19Z","receivedAt":"2008-09-28T19:03:19Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"\nOn 27 Sep 2008, at 10:15 PM, Jeff King wrote:\n\n> On Sat, Sep 27, 2008 at 08:09:54PM -0500, Michael Witten wrote:\n>\n>> Signed-off-by: Michael Witten \n>> ---\n>\n> Arranged in what way? I assume alphabetized, but please make it clear\n> in the commit message.\n\nFair enough; for whatever reason, I thought I had.\n\n> Also, Junio is out of touch for a few weeks, so it probably makes \n> sense\n> to send your patches to Shawn Pearce in the\n> interim.\n\nIndeed. I wish Junio had setup some kind of automatic reply.\n\n> Also also, micronit: we usually use the imperative to describe patch\n> changes (i.e., \"arrange\" instead of \"arranged\").\n\nThen I shall comply.\n"},{"id":"91809","messageId":"C886DB88-EA48-4608-A9DB-B8A11C1240B2@MIT.EDU","threadId":"15692","inReplyTo":"20080928031822.GB15696@sigill.intra.peff.net","subject":"Re: [PATCH 7/8] Docs: send-email: Added all config variables to man end","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T19:03:42Z","receivedAt":"2008-09-28T19:03:42Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"\nOn 27 Sep 2008, at 10:18 PM, Jeff King wrote:\n\n> On Sat, Sep 27, 2008 at 08:09:55PM -0500, Michael Witten wrote:\n>\n>> Admittedly, I didn't take much pride in my work, but\n>> I'm not trying to solve this problem.\n>\n> Remember that your commit message is supposed to be convincing us that\n> your patch is worth applying. ;P\n\nWell, I told the truth ;-)\n\n> It seems like these are just mechanical \"sendemail.foo is a default \n> for\n> --foo\" additions.\n\nThey are indeed!\n\n> Maybe it is better to simply make a note of that (or\n> mention it in the --foo section).\n\nThen it would be better to do away with all but\n\n\tsendemail.aliasesfile\n\tsendemail.aliasfile\n\nwhich sounds OK with me.\n"},{"id":"91811","messageId":"C0DC4F74-6157-44AE-A25A-4C74A415CDDA@mit.edu","threadId":"15692","inReplyTo":"20080928032407.GC15696@sigill.intra.peff.net","subject":"Re: [PATCH 8/8] Docs: config: send-email config options included","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T19:03:59Z","receivedAt":"2008-09-28T19:03:59Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"\nOn 27 Sep 2008, at 10:24 PM, Jeff King wrote:\n\n> On Sat, Sep 27, 2008 at 08:09:56PM -0500, Michael Witten wrote:\n>\n>> I just copied what is in the send-email man text.\n>\n> NAK, this makes things much worse by creating two places which must be\n> updated with any changes. Shouldn't doing it the right way be as \n> simple\n> as something like the patch below?\n\nI also think it is stupid, but I didn't quite understand what you\nmeant before (I must have been skimming).\n\nAlso, the surrounding config variable definitions didn't really make\nit clear that I could (or should) include a file (I didn't even think\nabout it, especially given that I didn't understand your original\nsuggestion).\n\n> Though it looks like imap.* simply says \"See git-imap-send(1)\" in\n> config.txt, which would also be OK by me (and makes sense especially \n> if\n> we drop most of the sendemail.* description in favor of just \n> mentioning\n> the config option near the matching command-line option).\n\nI agree! I think these separate config variable descriptions are\nsuperfluous and dangerously subject to obsolescence; consider\nwhat config.txt says:\n\n> Note that this list is non-comprehensive and not necessarily complete.\n> For command-specific variables, you will find a more detailed \n> description\n> in the appropriate manual page. You will find a description of non- \n> core\n> porcelain configuration variables in the respective porcelain \n> documentation.\n\nI think config.txt is not the place to put this stuff (though I've only\ngiven it a quick glance), and include:: will just cause us to litter\nthe place with tool-config.txt include files, which looks yucky and is\nsubject to neglect.\n"},{"id":"91812","messageId":"55747712-8E21-45F0-B2D2-4B4856568592@mit.edu","threadId":"15692","inReplyTo":"20080928050828.GZ23137@genesis.frugalware.org","subject":"Re: [PATCH 1/8] Docs: send-email's usage text and man page mention same options","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T19:04:30Z","receivedAt":"2008-09-28T19:04:30Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"\nOn 28 Sep 2008, at 12:08 AM, Miklos Vajna wrote:\n\n> On Sat, Sep 27, 2008 at 08:09:49PM -0500, Michael Witten > wrote:\n>> Specifically, boolean options are now listed in the form\n>>\n>> --[no-]option\n>>\n>> and both forms of documentation now consistently use\n>>\n>> --[no-]signed-off-by-cc\n>\n> I don't think documenting --no-foo in the perl script itself is a good\n> idea. See c3170a8 (git-merge: exclude unnecessary options from\n> OPTIONS_SPEC, 2008-05-12) which removes --no-foo from git-merge as \n> well.\n>\n> Of course the man page part makes sense.\n\nI like that it's in the help usage text, because it makes it clear how\nit should be used.\n\nBesides, I basically removed the same kind of cruft that was removed\nwith c3170a8, but I still managed to include the same information.\n"},{"id":"91808","messageId":"FB3A852B-728F-4183-A5AF-BA8F8D995AD7@mit.edu","threadId":"15692","inReplyTo":"gbne1a$8g2$1@ger.gmane.org","subject":"Re: [PATCH 3/8] Docs: send-email: Man page option ordering","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-28T19:04:36Z","receivedAt":"2008-09-28T19:04:36Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"\nOn 28 Sep 2008, at 3:08 AM, Jakub Narebski wrote:\n\n> Michael Witten wrote:\n>\n>> Now the man page lists the options in alphabetical\n>> order (in terms of the 'main' part of an option's\n>> name).\n>\n> I know it is a matter of taste, but I prefer having options\n> on man page in functional order, grouped by function, perhaps\n> with subsections to group them (c.f. git-rev-list man page).\n\nSee: http://marc.info/?l=git&m=122246885210923&w=2\n"},{"id":"91813","messageId":"20080928190615.GA32380@coredump.intra.peff.net","threadId":"15692","inReplyTo":"C0DC4F74-6157-44AE-A25A-4C74A415CDDA@mit.edu","subject":"Re: [PATCH 8/8] Docs: config: send-email config options included","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-28T19:06:15Z","receivedAt":"2008-09-28T19:06:15Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Sep 28, 2008 at 02:03:59PM -0500, Michael Witten wrote:\n\n>> Note that this list is non-comprehensive and not necessarily complete.\n>> For command-specific variables, you will find a more detailed \n>> description\n>> in the appropriate manual page. You will find a description of non-core\n>> porcelain configuration variables in the respective porcelain \n>> documentation.\n>\n> I think config.txt is not the place to put this stuff (though I've only\n> given it a quick glance), and include:: will just cause us to litter\n> the place with tool-config.txt include files, which looks yucky and is\n> subject to neglect.\n\nAh, I hadn't read that before. So yes, I agree that it should go into\ngit-send-email.txt. I do think putting a note (similar to the one for\nimap.*) into config.txt would be a nice addition, but it is obviously\nindependent of your other changes.\n\n-Peff\n"},{"id":"91814","messageId":"20080928190833.GA32418@coredump.intra.peff.net","threadId":"15692","inReplyTo":"C886DB88-EA48-4608-A9DB-B8A11C1240B2@MIT.EDU","subject":"Re: [PATCH 7/8] Docs: send-email: Added all config variables to man end","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-28T19:08:33Z","receivedAt":"2008-09-28T19:08:33Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Sep 28, 2008 at 02:03:42PM -0500, Michael Witten wrote:\n\n>> Maybe it is better to simply make a note of that (or\n>> mention it in the --foo section).\n>\n> Then it would be better to do away with all but\n>\n> \tsendemail.aliasesfile\n> \tsendemail.aliasfile\n>\n> which sounds OK with me.\n\nYes, that was exactly what I meant (but I hadn't bothered to see how\nmany, if any, options didn't directly correspond to a command line\noption).\n\n-Peff\n"},{"id":"91817","messageId":"200809290210.33880.jnareb@gmail.com","threadId":"15692","inReplyTo":"FB3A852B-728F-4183-A5AF-BA8F8D995AD7@mit.edu","subject":"Re: [PATCH 3/8] Docs: send-email: Man page option ordering","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-09-29T00:10:31Z","receivedAt":"2008-09-29T00:10:31Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Sun, 28 Sep 2008 21:04, Michael Witten wrote:\n> On 28 Sep 2008, at 3:08 AM, Jakub Narebski wrote:\n>> Michael Witten wrote:\n>>\n>>> Now the man page lists the options in alphabetical\n>>> order (in terms of the 'main' part of an option's\n>>> name).\n>>\n>> I know it is a matter of taste, but I prefer having options\n>> on man page in functional order, grouped by function, perhaps\n>> with subsections to group them (c.f. git-rev-list man page).\n> \n> See: http://marc.info/?l=git&m=122246885210923&w=2\n\nYou meant the following comment by Jeff King?\n\npeff> 4/6: I am not sure about making the order of options the same, \npeff> the two formats serve different purposes. I think\npeff> \"git send-email --foo\" should present the options based on\npeff> commonality of use. You clearly got the usage wrong, so\npeff> I think it is helping you to figure out quickly what you\npeff> probably meant. \n\nThis agrees with Gnits (GNU Coding Standard expanded) about --help\nhttp://www.gnu.org/software/womb/gnits/Help-Output.html#Help-Output\n\n# When a program has many options, try regrouping options logically,\n instead of listing them all alphabetically (say), as the mere\n regrouping is a succint way to convey much information. Present each\n group of options in its own subtable, suitably introduced by some few\n words. Separate groups by white lines for making the overall structure\n more easy to grasp by the reader. Here is an excerpt from a relatively\n big `--help' output:\n\n Main operation mode:\n -t, --list list the contents of an archive\n -x, --extract, --get extract files from an archive\n -c, --create create a new archive\n -d, --diff, --compare find differences between archive and file system\n -r, --append append files to the end of an archive\n -u, --update only append files newer than copy in archive\n -A, --catenate append tar files to an archive\n --concatenate same as -A\n --delete delete from the archive (not on mag tapes!)\n \n Device blocking:\n -b, --blocking-factor=BLOCKS BLOCKS x 512 bytes per record\n --record-size=SIZE SIZE bytes per record, multiple of 512\n -i, --ignore-zeros ignore zeroed blocks in archive (means EOF)\n -B, --read-full-records reblock as we read (for 4.2BSD pipes)\n\n\npeff> The manpage, on the other hand, is a comprehensive reference\npeff> and so should probably be alphabetized for easy reading.\n \nI haven't found definitive guide or definitive suggestion whether\noptions in man page should be alphabetized or put in some functional\norder. GNU Coding Standards doesn't say anything; at least I haven't\nfound anything on this topic.\n\nFirst, git lacks structured texinfo documentation, so manpages serves\n_both_ as reference, and _as learning tool_. For learning you would\nwant options grouped by function, perhaps sorted alphabetically in\ngroup. If you want to find some option, you can always use search\nand incremental search capabilities of manpages pager.\n\nSecond, large manpages with large number of options are usually divided\ninto sections, see git-rev-list(1) manpage, or rpmbuild(8) manpage. So\nthere is precedent for that. And I think it is good precedent.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"91818","messageId":"20080929003636.GA18552@coredump.intra.peff.net","threadId":"15692","inReplyTo":"200809290210.33880.jnareb@gmail.com","subject":"Re: [PATCH 3/8] Docs: send-email: Man page option ordering","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-29T00:36:36Z","receivedAt":"2008-09-29T00:36:36Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Sep 29, 2008 at 02:10:31AM +0200, Jakub Narebski wrote:\n\n> peff> The manpage, on the other hand, is a comprehensive reference\n> peff> and so should probably be alphabetized for easy reading.\n> \n> [...]\n> \n> Second, large manpages with large number of options are usually divided\n> into sections, see git-rev-list(1) manpage, or rpmbuild(8) manpage. So\n> there is precedent for that. And I think it is good precedent.\n\nI am not opposed to dividing it into sections, with options alphabetized\nin each section, as long as the section divisions make sense (e.g., in\nrev-list, an obvious section is \"commit formatting options\"). I just\ndidn't think we had enough here to bother subdividing.\n\nEither way will be in improvement on the current status, which is\napparently random (it looks like it was probably alphabetized at one\npoint, and then new options were added to the end).\n\n-Peff\n"},{"id":"91822","messageId":"1222664892-55810-1-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"20080929003636.GA18552@coredump.intra.peff.net","subject":"[RFC 6/9] Docs: send-email: Remove unnecessary config variable description","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-29T05:08:09Z","receivedAt":"2008-09-29T05:08:09Z","isPatch":false,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The config variables are mentioned within the descriptions of the\ncommand line options with which they are associated.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 91 +++++++-------------------------------\n 1 files changed, 16 insertions(+), 75 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 6b62032..0d6ac4a 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -24,7 +24,8 @@ OPTIONS\n The options available are:\n \n --bcc::\n-\tSpecify a \"Bcc:\" value for each email.\n+\tSpecify a \"Bcc:\" value for each email. Default is the value of\n+\t'sendemail.bcc'.\n +\n The --bcc option must be repeated for each user you want on the bcc list.\n \n@@ -85,9 +86,9 @@ The --cc option must be repeated for each user you want on the cc list.\n \tall that is output.\n \n --[no-]signed-off-by-cc::\n- If this is set, add emails found in Signed-off-by: or Cc: lines to the\n- cc list. Default is the value of 'sendemail.signedoffcc' configuration\n- value; if that is unspecified, default to --signed-off-by-cc.\n+\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n+\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n+\tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n --smtp-encryption::\n \tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n@@ -97,22 +98,13 @@ The --cc option must be repeated for each user you want on the cc list.\n --smtp-pass::\n \tPassword for SMTP-AUTH. The argument is optional: If no\n \targument is specified, then the empty string is used as\n-\tthe password.\n-+\n-In place of this option, the following configuration variables\n-can be specified:\n-+\n---\n-\t\t* sendemail.smtppass\n-\t\t* sendemail..smtppass (see sendemail.identity).\n---\n-+\n-However, --smtp-pass always overrides these variables.\n+\tthe password. Default is the value of 'sendemail.smtppass',\n+\thowever '--smtp-pass' always overrides this value.\n +\n Furthermore, passwords need not be specified in configuration files\n or on the command line. If a username has been specified (with\n---smtp-user or a configuration variable), but no password has been\n-specified (with --smtp-pass or a configuration variable), then the\n+'--smtp-user' or a 'sendemail.smtpuser'), but no password has been\n+specified (with '--smtp-pass' or 'sendemail.smtppass'), then the\n user is prompted for a password while the input is masked for privacy.\n \n --smtp-server::\n@@ -128,24 +120,15 @@ user is prompted for a password while the input is masked for privacy.\n --smtp-server-port::\n \tSpecifies a port different from the default port (SMTP\n \tservers typically listen to smtp port 25 and ssmtp port\n-\t465).\n+\t465). This can be set with 'sendemail.smtpserverport'.\n \n --smtp-ssl::\n-\tLegacy alias for '--smtp-encryption=ssl'.\n+\tLegacy alias for '--smtp-encryption ssl'.\n \n --smtp-user::\n-\tUsername for SMTP-AUTH. In place of this option, the following\n-\tconfiguration variables can be specified:\n-+\n---\n-\t\t* sendemail.smtpuser\n-\t\t* sendemail..smtpuser (see sendemail.identity).\n---\n-+\n-However, --smtp-user always overrides these variables.\n-+\n-If a username is not specified (with --smtp-user or a\n-configuration variable), then authentication is not attempted.\n+\tUsername for SMTP-AUTH. Default is the value of 'sendemail.smtpuser';\n+\tif a username is not specified (with '--smtp-user' or 'sendemail.smtpuser'),\n+\tthen authentication is not attempted.\n \n --subject::\n \tSpecify the initial subject of the email thread.\n@@ -191,18 +174,12 @@ The --to option must be repeated for each user you want on the to list.\n \t\t\tis due to SMTP limits as described by http://www.ietf.org/rfc/rfc2821.txt.\n --\n +\n-This option can be set with sendemail[.].validate; default to --validate\n+Default is the value of 'sendemail.validate'; if this is not set,\n+default to '--validate'.\n \n \n CONFIGURATION\n -------------\n-sendemail.identity::\n-\tThe default configuration identity. When specified,\n-\t'sendemail..' will have higher precedence than\n-\t'sendemail.'. This is useful to declare multiple SMTP\n-\tidentities and to hoist sensitive authentication information\n-\tout of the repository and into the global configuration file.\n-\n sendemail.aliasesfile::\n \tTo avoid typing long email addresses, point this to one or more\n \temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n@@ -211,42 +188,6 @@ sendemail.aliasfiletype::\n \tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n \tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n \n-sendemail.to::\n-\tEmail address (or alias) to always send to.\n-\n-sendemail.cccmd::\n-\tCommand to execute to generate per patch file specific \"Cc:\"s.\n-\n-sendemail.bcc::\n-\tEmail address (or alias) to always bcc.\n-\n-sendemail.chainreplyto::\n-\tBoolean value specifying the default to the '--[no-]chain-reply-to'\n-\tparameter.\n-\n-sendemail.smtpserver::\n-\tDefault SMTP server to use.\n-\n-sendemail.smtpserverport::\n-\tDefault SMTP server port to use.\n-\n-sendemail.smtpuser::\n-\tDefault SMTP-AUTH username.\n-\n-sendemail.smtppass::\n-\tDefault SMTP-AUTH password.\n-\n-sendemail.smtpencryption::\n-\tDefault encryption method. Use 'ssl' for SSL (and specify an\n-\tappropriate port), or 'tls' for TLS. Takes precedence over\n-\t'smtpssl' if both are specified.\n-\n-sendemail.smtpssl::\n-\tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n-\n-sendemail.validate::\n- Boolean override for --[no-]validate.\n-\n Author\n ------\n Written by Ryan Anderson \n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91823","messageId":"1222664892-55810-2-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222664892-55810-1-git-send-email-mfwitten@mit.edu","subject":"[RFC 7/9] send-email: Completely replace --signed-off-cc with --signed-off-by-cc","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-29T05:08:10Z","receivedAt":"2008-09-29T05:08:10Z","isPatch":false,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"This breaks backwards compatibility, but so what---get off your\nlazy arses and remove the cruft.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 2 +-\n git-send-email.perl | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 0d6ac4a..8ffe525 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -87,7 +87,7 @@ The --cc option must be repeated for each user you want on the cc list.\n \n --[no-]signed-off-by-cc::\n \tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n-\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n+\tcc list. Default is the value of 'sendemail.signedoffbycc' configuration\n \tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n --smtp-encryption::\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 3467cf1..4662d28 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -144,7 +144,7 @@ if ($@) {\n my ($quiet, $dry_run) = (0, 0);\n \n # Variables with corresponding config settings\n-my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd);\n+my ($thread, $chain_reply_to, $suppress_from, $signed_off_by_cc, $cc_cmd);\n my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption);\n my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts);\n my ($validate);\n@@ -154,7 +154,7 @@ my %config_bool_settings = (\n \"thread\" => [\\$thread, 1],\n \"chainreplyto\" => [\\$chain_reply_to, 1],\n \"suppressfrom\" => [\\$suppress_from, undef],\n- \"signedoffcc\" => [\\$signed_off_cc, undef],\n+ \"signedoffbycc\" => [\\$signed_off_by_cc, undef],\n \"validate\" => [\\$validate, 1],\n );\n \n@@ -218,7 +218,7 @@ my $rc = GetOptions(\"sender|from=s\" => \\$sender,\n \t\t \"cc-cmd=s\" => \\$cc_cmd,\n \t\t \"suppress-from!\" => \\$suppress_from,\n \t\t \"suppress-cc=s\" => \\@suppress_cc,\n-\t\t \"signed-off-cc|signed-off-by-cc!\" => \\$signed_off_cc,\n+\t\t \"signed-off-by-cc!\" => \\$signed_off_by_cc,\n \t\t \"dry-run\" => \\$dry_run,\n \t\t \"envelope-sender=s\" => \\$envelope_sender,\n \t\t \"thread!\" => \\$thread,\n@@ -294,7 +294,7 @@ if ($suppress_cc{'all'}) {\n \n # If explicit old-style ones are specified, they trump --suppress-cc.\n $suppress_cc{'self'} = $suppress_from if defined $suppress_from;\n-$suppress_cc{'sob'} = !$signed_off_cc if defined $signed_off_cc;\n+$suppress_cc{'sob'} = !$signed_off_by_cc if defined $signed_off_by_cc;\n \n # Debugging, print out the suppressions.\n if (0) {\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91825","messageId":"1222664892-55810-3-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222664892-55810-2-git-send-email-mfwitten@mit.edu","subject":"[RFC 8/9] Docs: send-email: Create logical groupings for --help text","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-29T05:08:11Z","receivedAt":"2008-09-29T05:08:11Z","isPatch":false,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The options are partitioned into more digestible groups.\n\nSigned-off-by: Michael Witten \n---\n git-send-email.perl | 61 ++++++++++++++++++++++++++++----------------------\n 1 files changed, 34 insertions(+), 27 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 4662d28..127acb7 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -39,33 +39,40 @@ package main;\n sub usage {\n \tprint <...\n-Options:\n- --identity * Use the sendemail. options.\n- --from * Email From:\n- --envelope-sender * Email envelope sender.\n- --to * Email To:\n- --cc * Email Cc:\n- --cc-cmd * Email Cc: via ` \\$patch_path`\n- --bcc * Email Bcc:\n- --subject * Email \"Subject:\" (only if --compose).\n- --compose * Open an editor for introduction.\n- --in-reply-to * First \"In-Reply-To:\" (only if --compose).\n- --[no-]chain-reply-to * Chain In-Reply-To: fields. Default on.\n- --[no-]thread * Use In-Reply-To: field. Default on.\n- --[no-]signed-off-by-cc * Actually send to Cc: and Signed-off-by:\n- addresses. Default on.\n- --suppress-cc * author, self, sob, cccmd, all.\n- --[no-]suppress-from * Don't send email to self. Default off.\n- --smtp-server * Outgoing SMTP server to use. The port\n- is optional. Default 'localhost'.\n- --smtp-server-port * Outgoing SMTP server port.\n- --smtp-user * The username for SMTP-AUTH.\n- --smtp-pass * The password for SMTP-AUTH; not necessary.\n- --smtp-encryption * tls or ssl; anything else disables.\n- --smtp-ssl * Deprecated. Use '--smtp-encryption ssl'.\n- --quiet * Output one line of info per email.\n- --dry-run * Don't actually send the emails.\n- --[no-]validate * Perform patch sanity checks. Default on.\n+\n+ Composing:\n+ --from * Email From:\n+ --to * Email To:\n+ --cc * Email Cc:\n+ --bcc * Email Bcc:\n+ --subject * Email \"Subject:\"\n+ --in-reply-to * Email \"In-Reply-To:\"\n+ --compose * Open an editor for introduction.\n+\n+ Sending:\n+ --envelope-sender * Email envelope sender.\n+ --smtp-server * Outgoing SMTP server to use. The port\n+ is optional. Default 'localhost'.\n+ --smtp-server-port * Outgoing SMTP server port.\n+ --smtp-user * Username for SMTP-AUTH.\n+ --smtp-pass * Password for SMTP-AUTH; not necessary.\n+ --smtp-encryption * tls or ssl; anything else disables.\n+ --smtp-ssl * Deprecated. Use '--smtp-encryption ssl'.\n+\n+ Automating:\n+ --identity * Use the sendemail. options.\n+ --cc-cmd * Email Cc: via ` \\$patch_path`\n+ --suppress-cc * author, self, sob, cccmd, all.\n+ --[no-]signed-off-by-cc * Send to Cc: and Signed-off-by:\n+ addresses. Default on.\n+ --[no-]suppress-from * Send to self. Default off.\n+ --[no-]chain-reply-to * Chain In-Reply-To: fields. Default on.\n+ --[no-]thread * Use In-Reply-To: field. Default on.\n+\n+ Administering:\n+ --quiet * Output one line of info per email.\n+ --dry-run * Don't actually send the emails.\n+ --[no-]validate * Perform patch sanity checks. Default on.\n \n EOT\n \texit(1);\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91824","messageId":"1222664892-55810-4-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222664892-55810-3-git-send-email-mfwitten@mit.edu","subject":"[RFC 9/9] Docs: send-email: Create logical groupings for man text","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-29T05:08:12Z","receivedAt":"2008-09-29T05:08:12Z","isPatch":false,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The options are partitioned into more digestible groups.\nWithin these groups, the options are sorted alphabetically.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 119 ++++++++++++++++++++++----------------\n 1 files changed, 69 insertions(+), 50 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 8ffe525..82f5056 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -19,9 +19,12 @@ The header of the email is configurable by command line options. If not\n specified on the command line, the user will be prompted with a ReadLine\n enabled interface to provide the necessary information.\n \n+\n OPTIONS\n -------\n-The options available are:\n+\n+Composing\n+~~~~~~~~~\n \n --bcc::\n \tSpecify a \"Bcc:\" value for each email. Default is the value of\n@@ -34,46 +37,15 @@ The --bcc option must be repeated for each user you want on the bcc list.\n +\n The --cc option must be repeated for each user you want on the cc list.\n \n---cc-cmd::\n-\tSpecify a command to execute once per patch file which\n-\tshould generate patch file specific \"Cc:\" entries.\n-\tOutput of this command must be single email address per line.\n-\tDefault is the value of 'sendemail.cccmd' configuration value.\n-\n---[no-]chain-reply-to::\n-\tIf this is set, each email will be sent as a reply to the previous\n-\temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n-\tthe first will be sent as replies to the first email sent. When using\n-\tthis, it is recommended that the first file given be an overview of the\n-\tentire patch series. Default is the value of the 'sendemail.chainreplyto'\n-\tconfiguration value; if that is unspecified, default to --chain-reply-to.\n-\n --compose::\n \tUse $GIT_EDITOR, core.editor, $VISUAL, or $EDITOR to edit an\n \tintroductory message for the patch series.\n \n---dry-run::\n-\tDo everything except actually send the emails.\n-\n---envelope-sender::\n-\tSpecify the envelope sender used to send the emails.\n-\tThis is useful if your default address is not the address that is\n-\tsubscribed to a list. If you use the sendmail binary, you must have\n-\tsuitable privileges for the -f parameter. Default is the value of\n-\tthe 'sendemail.envelopesender' configuration variable; if that is\n-\tunspecified, choosing the envelope sender is left to your MTA.\n-\n --from::\n \tSpecify the sender of the emails. This will default to\n \tthe value GIT_COMMITTER_IDENT, as returned by \"git var -l\".\n \tThe user will still be prompted to confirm this entry.\n \n---identity::\n-\tA configuration identity. When given, causes values in the\n-\t'sendemail.' subsection to take precedence over\n-\tvalues in the 'sendemail' section. The default identity is\n-\tthe value of 'sendemail.identity'.\n-\n --in-reply-to::\n \tSpecify the contents of the first In-Reply-To header.\n \tSubsequent emails will refer to the previous email\n@@ -81,14 +53,30 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---quiet::\n-\tMake git-send-email less verbose. One line per email should be\n-\tall that is output.\n+--subject::\n+\tSpecify the initial subject of the email thread.\n+\tOnly necessary if --compose is also set. If --compose\n+\tis not set, this will be prompted for.\n \n---[no-]signed-off-by-cc::\n-\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n-\tcc list. Default is the value of 'sendemail.signedoffbycc' configuration\n-\tvalue; if that is unspecified, default to --signed-off-by-cc.\n+--to::\n+\tSpecify the primary recipient of the emails generated. Generally, this\n+\twill be the upstream maintainer of the project involved. Default is the\n+\tvalue of the 'sendemail.to' configuration value; if that is unspecified,\n+\tthis will be prompted for.\n++\n+The --to option must be repeated for each user you want on the to list.\n+\n+\n+Sending\n+~~~~~~~\n+\n+--envelope-sender::\n+\tSpecify the envelope sender used to send the emails.\n+\tThis is useful if your default address is not the address that is\n+\tsubscribed to a list. If you use the sendmail binary, you must have\n+\tsuitable privileges for the -f parameter. Default is the value of\n+\tthe 'sendemail.envelopesender' configuration variable; if that is\n+\tunspecified, choosing the envelope sender is left to your MTA.\n \n --smtp-encryption::\n \tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n@@ -130,10 +118,34 @@ user is prompted for a password while the input is masked for privacy.\n \tif a username is not specified (with '--smtp-user' or 'sendemail.smtpuser'),\n \tthen authentication is not attempted.\n \n---subject::\n-\tSpecify the initial subject of the email thread.\n-\tOnly necessary if --compose is also set. If --compose\n-\tis not set, this will be prompted for.\n+\n+Automating\n+~~~~~~~~~~\n+\n+--cc-cmd::\n+\tSpecify a command to execute once per patch file which\n+\tshould generate patch file specific \"Cc:\" entries.\n+\tOutput of this command must be single email address per line.\n+\tDefault is the value of 'sendemail.cccmd' configuration value.\n+\n+--[no-]chain-reply-to::\n+\tIf this is set, each email will be sent as a reply to the previous\n+\temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n+\tthe first will be sent as replies to the first email sent. When using\n+\tthis, it is recommended that the first file given be an overview of the\n+\tentire patch series. Default is the value of the 'sendemail.chainreplyto'\n+\tconfiguration value; if that is unspecified, default to --chain-reply-to.\n+\n+--identity::\n+\tA configuration identity. When given, causes values in the\n+\t'sendemail.' subsection to take precedence over\n+\tvalues in the 'sendemail' section. The default identity is\n+\tthe value of 'sendemail.identity'.\n+\n+--[no-]signed-off-by-cc::\n+\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n+\tcc list. Default is the value of 'sendemail.signedoffbycc' configuration\n+\tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n --suppress-cc::\n \tSpecify an additional category of recipients to suppress the\n@@ -157,13 +169,16 @@ user is prompted for a password while the input is masked for privacy.\n \theader set. Default is the value of the 'sendemail.thread' configuration\n \tvalue; if that is unspecified, default to --thread.\n \n---to::\n-\tSpecify the primary recipient of the emails generated. Generally, this\n-\twill be the upstream maintainer of the project involved. Default is the\n-\tvalue of the 'sendemail.to' configuration value; if that is unspecified,\n-\tthis will be prompted for.\n-+\n-The --to option must be repeated for each user you want on the to list.\n+\n+Administering\n+~~~~~~~~~~~~~\n+\n+--dry-run::\n+\tDo everything except actually send the emails.\n+\n+--quiet::\n+\tMake git-send-email less verbose. One line per email should be\n+\tall that is output.\n \n --[no-]validate::\n \tPerform sanity checks on patches.\n@@ -180,6 +195,7 @@ default to '--validate'.\n \n CONFIGURATION\n -------------\n+\n sendemail.aliasesfile::\n \tTo avoid typing long email addresses, point this to one or more\n \temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n@@ -188,6 +204,7 @@ sendemail.aliasfiletype::\n \tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n \tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n \n+\n Author\n ------\n Written by Ryan Anderson \n@@ -195,10 +212,12 @@ Written by Ryan Anderson \n git-send-email is originally based upon\n send_lots_of_email.pl by Greg Kroah-Hartman.\n \n+\n Documentation\n --------------\n Documentation by Ryan Anderson\n \n+\n GIT\n ---\n Part of the linkgit:git[1] suite\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91859","messageId":"20080929162536.GA2784@coredump.intra.peff.net","threadId":"15692","inReplyTo":"1222664892-55810-3-git-send-email-mfwitten@mit.edu","subject":"Re: [RFC 8/9] Docs: send-email: Create logical groupings for --help text","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-29T16:25:37Z","receivedAt":"2008-09-29T16:25:37Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Sep 29, 2008 at 12:08:11AM -0500, Michael Witten wrote:\n\n> The options are partitioned into more digestible groups.\n\nWith patches 6, 8, and 9, the output is much improved. I'm not sure I\nagree with all of the heading classification choices, but I first read\nthose options long enough ago that I no longer have any idea where I\nwould _expect_ to find them. So I will let others comment on that if\nthey want.\n\n-Peff\n"},{"id":"91860","messageId":"20080929162935.GA2628@coredump.intra.peff.net","threadId":"15692","inReplyTo":"1222664781-55763-2-git-send-email-mfwitten@mit.edu","subject":"Re: [RFC 7/9] send-email: Completely replace --signed-off-cc with --signed-off-by-cc","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-29T16:29:36Z","receivedAt":"2008-09-29T16:29:36Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Sep 29, 2008 at 12:06:19AM -0500, Michael Witten wrote:\n\n> This breaks backwards compatibility, but so what---get off your\n> lazy arses and remove the cruft.\n\nSorry, but try to be a lot more careful than that about breaking\ncompatibility. The right sequence is:\n\n 1. Introduce new option (which has already been done for the command\n line, but it looks like you are adding a new config variable).\n\n Mention the new option in the documentation as the \"right way\".\n\n Possibly mention the old version as \"deprecated\".\n\n 2. Wait a long time, possibly forever. This gives people a chance to\n adjust, and it lets us wait for a major version bump where such an\n incompatibility might be more expected.\n\n 3. Remove the old option.\n\nSo I think you are skipping straight to '3' here. However, I think your\nreal purpose is to simply clean up the documentation, so why not just do\nthat? We can still support the old options for historical setups, and\njust advertise the new ones in the docs.\n\n-Peff\n"},{"id":"91863","messageId":"1222710066-57768-1-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"20080929162935.GA2628@coredump.intra.peff.net","subject":"[RFC2 8/9] Docs: send-email: Create logical groupings for man text","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-29T17:41:05Z","receivedAt":"2008-09-29T17:41:05Z","isPatch":false,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The options are partitioned into more digestible groups.\nWithin these groups, the options are sorted alphabetically.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 119 ++++++++++++++++++++++----------------\n 1 files changed, 69 insertions(+), 50 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 0d6ac4a..d566c34 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -19,9 +19,12 @@ The header of the email is configurable by command line options. If not\n specified on the command line, the user will be prompted with a ReadLine\n enabled interface to provide the necessary information.\n \n+\n OPTIONS\n -------\n-The options available are:\n+\n+Composing\n+~~~~~~~~~\n \n --bcc::\n \tSpecify a \"Bcc:\" value for each email. Default is the value of\n@@ -34,46 +37,15 @@ The --bcc option must be repeated for each user you want on the bcc list.\n +\n The --cc option must be repeated for each user you want on the cc list.\n \n---cc-cmd::\n-\tSpecify a command to execute once per patch file which\n-\tshould generate patch file specific \"Cc:\" entries.\n-\tOutput of this command must be single email address per line.\n-\tDefault is the value of 'sendemail.cccmd' configuration value.\n-\n---[no-]chain-reply-to::\n-\tIf this is set, each email will be sent as a reply to the previous\n-\temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n-\tthe first will be sent as replies to the first email sent. When using\n-\tthis, it is recommended that the first file given be an overview of the\n-\tentire patch series. Default is the value of the 'sendemail.chainreplyto'\n-\tconfiguration value; if that is unspecified, default to --chain-reply-to.\n-\n --compose::\n \tUse $GIT_EDITOR, core.editor, $VISUAL, or $EDITOR to edit an\n \tintroductory message for the patch series.\n \n---dry-run::\n-\tDo everything except actually send the emails.\n-\n---envelope-sender::\n-\tSpecify the envelope sender used to send the emails.\n-\tThis is useful if your default address is not the address that is\n-\tsubscribed to a list. If you use the sendmail binary, you must have\n-\tsuitable privileges for the -f parameter. Default is the value of\n-\tthe 'sendemail.envelopesender' configuration variable; if that is\n-\tunspecified, choosing the envelope sender is left to your MTA.\n-\n --from::\n \tSpecify the sender of the emails. This will default to\n \tthe value GIT_COMMITTER_IDENT, as returned by \"git var -l\".\n \tThe user will still be prompted to confirm this entry.\n \n---identity::\n-\tA configuration identity. When given, causes values in the\n-\t'sendemail.' subsection to take precedence over\n-\tvalues in the 'sendemail' section. The default identity is\n-\tthe value of 'sendemail.identity'.\n-\n --in-reply-to::\n \tSpecify the contents of the first In-Reply-To header.\n \tSubsequent emails will refer to the previous email\n@@ -81,14 +53,30 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---quiet::\n-\tMake git-send-email less verbose. One line per email should be\n-\tall that is output.\n+--subject::\n+\tSpecify the initial subject of the email thread.\n+\tOnly necessary if --compose is also set. If --compose\n+\tis not set, this will be prompted for.\n \n---[no-]signed-off-by-cc::\n-\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n-\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n-\tvalue; if that is unspecified, default to --signed-off-by-cc.\n+--to::\n+\tSpecify the primary recipient of the emails generated. Generally, this\n+\twill be the upstream maintainer of the project involved. Default is the\n+\tvalue of the 'sendemail.to' configuration value; if that is unspecified,\n+\tthis will be prompted for.\n++\n+The --to option must be repeated for each user you want on the to list.\n+\n+\n+Sending\n+~~~~~~~\n+\n+--envelope-sender::\n+\tSpecify the envelope sender used to send the emails.\n+\tThis is useful if your default address is not the address that is\n+\tsubscribed to a list. If you use the sendmail binary, you must have\n+\tsuitable privileges for the -f parameter. Default is the value of\n+\tthe 'sendemail.envelopesender' configuration variable; if that is\n+\tunspecified, choosing the envelope sender is left to your MTA.\n \n --smtp-encryption::\n \tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n@@ -130,10 +118,34 @@ user is prompted for a password while the input is masked for privacy.\n \tif a username is not specified (with '--smtp-user' or 'sendemail.smtpuser'),\n \tthen authentication is not attempted.\n \n---subject::\n-\tSpecify the initial subject of the email thread.\n-\tOnly necessary if --compose is also set. If --compose\n-\tis not set, this will be prompted for.\n+\n+Automating\n+~~~~~~~~~~\n+\n+--cc-cmd::\n+\tSpecify a command to execute once per patch file which\n+\tshould generate patch file specific \"Cc:\" entries.\n+\tOutput of this command must be single email address per line.\n+\tDefault is the value of 'sendemail.cccmd' configuration value.\n+\n+--[no-]chain-reply-to::\n+\tIf this is set, each email will be sent as a reply to the previous\n+\temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n+\tthe first will be sent as replies to the first email sent. When using\n+\tthis, it is recommended that the first file given be an overview of the\n+\tentire patch series. Default is the value of the 'sendemail.chainreplyto'\n+\tconfiguration value; if that is unspecified, default to --chain-reply-to.\n+\n+--identity::\n+\tA configuration identity. When given, causes values in the\n+\t'sendemail.' subsection to take precedence over\n+\tvalues in the 'sendemail' section. The default identity is\n+\tthe value of 'sendemail.identity'.\n+\n+--[no-]signed-off-by-cc::\n+\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n+\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n+\tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n --suppress-cc::\n \tSpecify an additional category of recipients to suppress the\n@@ -157,13 +169,16 @@ user is prompted for a password while the input is masked for privacy.\n \theader set. Default is the value of the 'sendemail.thread' configuration\n \tvalue; if that is unspecified, default to --thread.\n \n---to::\n-\tSpecify the primary recipient of the emails generated. Generally, this\n-\twill be the upstream maintainer of the project involved. Default is the\n-\tvalue of the 'sendemail.to' configuration value; if that is unspecified,\n-\tthis will be prompted for.\n-+\n-The --to option must be repeated for each user you want on the to list.\n+\n+Administering\n+~~~~~~~~~~~~~\n+\n+--dry-run::\n+\tDo everything except actually send the emails.\n+\n+--quiet::\n+\tMake git-send-email less verbose. One line per email should be\n+\tall that is output.\n \n --[no-]validate::\n \tPerform sanity checks on patches.\n@@ -180,6 +195,7 @@ default to '--validate'.\n \n CONFIGURATION\n -------------\n+\n sendemail.aliasesfile::\n \tTo avoid typing long email addresses, point this to one or more\n \temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n@@ -188,6 +204,7 @@ sendemail.aliasfiletype::\n \tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n \tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n \n+\n Author\n ------\n Written by Ryan Anderson \n@@ -195,10 +212,12 @@ Written by Ryan Anderson \n git-send-email is originally based upon\n send_lots_of_email.pl by Greg Kroah-Hartman.\n \n+\n Documentation\n --------------\n Documentation by Ryan Anderson\n \n+\n GIT\n ---\n Part of the linkgit:git[1] suite\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91864","messageId":"1222710066-57768-2-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222710066-57768-1-git-send-email-mfwitten@mit.edu","subject":"[RFC2 9/9] send-email: signedoffcc -> signedoffbycc, but handle both","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-29T17:41:06Z","receivedAt":"2008-09-29T17:41:06Z","isPatch":false,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The documentation now mentions sendemail.signedoffbycc instead\nof sendemail.signedoffcc in order to match with the options\n--signed-off-by-cc; the code has been updated to reflect this\nas well, but sendemail.signedoffcc is still handled.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 2 +-\n git-send-email.perl | 9 +++++----\n 2 files changed, 6 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex d566c34..82f5056 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -144,7 +144,7 @@ Automating\n \n --[no-]signed-off-by-cc::\n \tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n-\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n+\tcc list. Default is the value of 'sendemail.signedoffbycc' configuration\n \tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n --suppress-cc::\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 80dae88..bdbfac6 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -151,7 +151,7 @@ if ($@) {\n my ($quiet, $dry_run) = (0, 0);\n \n # Variables with corresponding config settings\n-my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd);\n+my ($thread, $chain_reply_to, $suppress_from, $signed_off_by_cc, $cc_cmd);\n my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption);\n my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts);\n my ($validate);\n@@ -161,7 +161,8 @@ my %config_bool_settings = (\n \"thread\" => [\\$thread, 1],\n \"chainreplyto\" => [\\$chain_reply_to, 1],\n \"suppressfrom\" => [\\$suppress_from, undef],\n- \"signedoffcc\" => [\\$signed_off_cc, undef],\n+ \"signedoffbycc\" => [\\$signed_off_by_cc, undef],\n+ \"signedoffcc\" => [\\$signed_off_by_cc, undef], # Deprecated\n \"validate\" => [\\$validate, 1],\n );\n \n@@ -225,7 +226,7 @@ my $rc = GetOptions(\"sender|from=s\" => \\$sender,\n \t\t \"cc-cmd=s\" => \\$cc_cmd,\n \t\t \"suppress-from!\" => \\$suppress_from,\n \t\t \"suppress-cc=s\" => \\@suppress_cc,\n-\t\t \"signed-off-cc|signed-off-by-cc!\" => \\$signed_off_cc,\n+\t\t \"signed-off-cc|signed-off-by-cc!\" => \\$signed_off_by_cc,\n \t\t \"dry-run\" => \\$dry_run,\n \t\t \"envelope-sender=s\" => \\$envelope_sender,\n \t\t \"thread!\" => \\$thread,\n@@ -301,7 +302,7 @@ if ($suppress_cc{'all'}) {\n \n # If explicit old-style ones are specified, they trump --suppress-cc.\n $suppress_cc{'self'} = $suppress_from if defined $suppress_from;\n-$suppress_cc{'sob'} = !$signed_off_cc if defined $signed_off_cc;\n+$suppress_cc{'sob'} = !$signed_off_by_cc if defined $signed_off_by_cc;\n \n # Debugging, print out the suppressions.\n if (0) {\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91865","messageId":"20080929174445.GA6015@coredump.intra.peff.net","threadId":"15692","inReplyTo":"1222710066-57768-2-git-send-email-mfwitten@mit.edu","subject":"Re: [RFC2 9/9] send-email: signedoffcc -> signedoffbycc, but handle both","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-09-29T17:44:45Z","receivedAt":"2008-09-29T17:44:45Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Sep 29, 2008 at 12:41:06PM -0500, Michael Witten wrote:\n\n> The documentation now mentions sendemail.signedoffbycc instead\n> of sendemail.signedoffcc in order to match with the options\n> --signed-off-by-cc; the code has been updated to reflect this\n> as well, but sendemail.signedoffcc is still handled.\n\nThis new series looks fine to me.\n\n-Peff\n"},{"id":"91942","messageId":"1222779512-58936-1-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"20080929174445.GA6015@coredump.intra.peff.net","subject":"[PATCH 1/9] Docs: send-email's usage text and man page mention same options","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:24Z","receivedAt":"2008-09-30T12:58:24Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"Specifically, boolean options are now listed in the form\n\n --[no-]option\n\nand both forms of documentation now consistently use\n\n --[no-]signed-off-by-cc\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 21 +++++++++++++--------\n git-send-email.perl | 8 ++++----\n 2 files changed, 17 insertions(+), 12 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 3c3e1b0..9b31626 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -40,8 +40,7 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOutput of this command must be single email address per line.\n \tDefault is the value of 'sendemail.cccmd' configuration value.\n \n---chain-reply-to::\n---no-chain-reply-to::\n+--[no-]chain-reply-to::\n \tIf this is set, each email will be sent as a reply to the previous\n \temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n \tthe first will be sent as replies to the first email sent. When using\n@@ -66,8 +65,7 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---signed-off-by-cc::\n---no-signed-off-by-cc::\n+--[no-]signed-off-by-cc::\n If this is set, add emails found in Signed-off-by: or Cc: lines to the\n cc list.\n Default is the value of 'sendemail.signedoffcc' configuration value;\n@@ -146,8 +144,7 @@ user is prompted for a password while the input is masked for privacy.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---suppress-from::\n---no-suppress-from::\n+--[no-]suppress-from::\n If this is set, do not add the From: address to the cc: list.\n Default is the value of 'sendemail.suppressfrom' configuration value;\n if that is unspecified, default to --no-suppress-from.\n@@ -163,8 +160,7 @@ user is prompted for a password while the input is masked for privacy.\n \tif that is unspecified, default to 'self' if --suppress-from is\n \tspecified, as well as 'sob' if --no-signed-off-cc is specified.\n \n---thread::\n---no-thread::\n+--[no-]thread::\n \tIf this is set, the In-Reply-To header will be set on each email sent.\n \tIf disabled with \"--no-thread\", no emails will have the In-Reply-To\n \theader set.\n@@ -183,6 +179,15 @@ user is prompted for a password while the input is masked for privacy.\n \tvariable; if that is unspecified, choosing the envelope sender is left\n \tto your MTA.\n \n+--no-validate::\n+\tDon't perform any sanity checks on patches.\n+\tCurrently, validation means the following:\n++\n+--\n+\t\t*\tWarn of patches that contain lines longer than 998 characters; this\n+\t\t\tis due to SMTP limits as described by http://www.ietf.org/rfc/rfc2821.txt.\n+--\n+\n --to::\n \tSpecify the primary recipient of the emails generated.\n \tGenerally, this will be the upstream maintainer of the\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex d2fd899..9f56162 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -64,11 +64,11 @@ Options:\n Only used if --compose is also set. If --compose is not\n \t\t set, this will be prompted for.\n \n- --chain-reply-to If set, the replies will all be to the previous\n+ --[no-]chain-reply-to If set, the replies will all be to the previous\n email sent, rather than to the first email sent.\n Defaults to on.\n \n- --signed-off-cc Automatically add email addresses that appear in\n+ --[no-]signed-off-by-cc Automatically add email addresses that appear in\n Signed-off-by: or Cc: lines to the cc: list. Defaults to on.\n \n --identity The configuration identity, a subsection to prioritise over\n@@ -95,9 +95,9 @@ Options:\n \t\t 'cccmd' for the output of the cccmd, or 'all' to suppress\n \t\t all of these.\n \n- --suppress-from Suppress sending emails to yourself. Defaults to off.\n+ --[no-]suppress-from Suppress sending emails to yourself. Defaults to off.\n \n- --thread Specify that the \"In-Reply-To:\" header should be set on all\n+ --[no-]thread Specify that the \"In-Reply-To:\" header should be set on all\n emails. Defaults to on.\n \n --quiet\t Make git-send-email less verbose. One line per email\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91938","messageId":"1222779512-58936-2-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222779512-58936-1-git-send-email-mfwitten@mit.edu","subject":"[PATCH 2/9] Docs: send-email usage text much sexier","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:25Z","receivedAt":"2008-09-30T12:58:25Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"All of the descriptions are aligned, shorter,\nbetter arranged, and no line is greater than\n78 columns.\n\nSigned-off-by: Michael Witten \n---\n git-send-email.perl | 94 ++++++++++++++-------------------------------------\n 1 files changed, 26 insertions(+), 68 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 9f56162..2c31a25 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -40,74 +40,32 @@ sub usage {\n \tprint <...\n Options:\n- --from Specify the \"From:\" line of the email to be sent.\n-\n- --to Specify the primary \"To:\" line of the email.\n-\n- --cc Specify an initial \"Cc:\" list for the entire series\n- of emails.\n-\n- --cc-cmd Specify a command to execute per file which adds\n- per file specific cc address entries\n-\n- --bcc Specify a list of email addresses that should be Bcc:\n-\t\t on all the emails.\n-\n- --compose Use \\$GIT_EDITOR, core.editor, \\$EDITOR, or \\$VISUAL to edit\n-\t\t an introductory message for the patch series.\n-\n- --subject Specify the initial \"Subject:\" line.\n- Only necessary if --compose is also set. If --compose\n-\t\t is not set, this will be prompted for.\n-\n- --in-reply-to Specify the first \"In-Reply-To:\" header line.\n- Only used if --compose is also set. If --compose is not\n-\t\t set, this will be prompted for.\n-\n- --[no-]chain-reply-to If set, the replies will all be to the previous\n- email sent, rather than to the first email sent.\n- Defaults to on.\n-\n- --[no-]signed-off-by-cc Automatically add email addresses that appear in\n- Signed-off-by: or Cc: lines to the cc: list. Defaults to on.\n-\n- --identity The configuration identity, a subsection to prioritise over\n- the default section.\n-\n- --smtp-server If set, specifies the outgoing SMTP server to use.\n- Defaults to localhost. Port number can be specified here with\n- hostname:port format or by using --smtp-server-port option.\n-\n- --smtp-server-port Specify a port on the outgoing SMTP server to connect to.\n-\n- --smtp-user The username for SMTP-AUTH.\n-\n- --smtp-pass The password for SMTP-AUTH.\n-\n- --smtp-encryption Specify 'tls' for STARTTLS encryption, or 'ssl' for SSL.\n- Any other value disables the feature.\n-\n- --smtp-ssl Synonym for '--smtp-encryption=ssl'. Deprecated.\n-\n- --suppress-cc Suppress the specified category of auto-CC. The category\n-\t\t can be one of 'author' for the patch author, 'self' to\n-\t\t avoid copying yourself, 'sob' for Signed-off-by lines,\n-\t\t 'cccmd' for the output of the cccmd, or 'all' to suppress\n-\t\t all of these.\n-\n- --[no-]suppress-from Suppress sending emails to yourself. Defaults to off.\n-\n- --[no-]thread Specify that the \"In-Reply-To:\" header should be set on all\n- emails. Defaults to on.\n-\n- --quiet\t Make git-send-email less verbose. One line per email\n- should be all that is output.\n-\n- --dry-run\t Do everything except actually send the emails.\n-\n- --envelope-sender\tSpecify the envelope sender used to send the emails.\n-\n- --no-validate\tDon't perform any sanity checks on patches.\n+ --identity * Use the sendemail. options.\n+ --from * Email From:\n+ --envelope-sender * Email envelope sender.\n+ --to * Email To:\n+ --cc * Email Cc:\n+ --cc-cmd * Email Cc: via ` \\$patch_path`\n+ --bcc * Email Bcc:\n+ --subject * Email \"Subject:\" (only if --compose).\n+ --compose * Open an editor for introduction.\n+ --in-reply-to * First \"In-Reply-To:\" (only if --compose).\n+ --[no-]chain-reply-to * Chain In-Reply-To: fields. Default on.\n+ --[no-]thread * Use In-Reply-To: field. Default on.\n+ --[no-]signed-off-by-cc * Actually send to Cc: and Signed-off-by:\n+ addresses. Default on.\n+ --suppress-cc * author, self, sob, cccmd, all.\n+ --[no-]suppress-from * Don't send email to self. Default off.\n+ --smtp-server * Outgoing SMTP server to use. The port\n+ is optional. Default 'localhost'.\n+ --smtp-server-port * Outgoing SMTP server port.\n+ --smtp-user * The username for SMTP-AUTH.\n+ --smtp-pass * The password for SMTP-AUTH; not necessary.\n+ --smtp-encryption * tls or ssl; anything else disables.\n+ --smtp-ssl * Deprecated. Use '--smtp-encryption ssl'.\n+ --quiet * Output one line of info per email.\n+ --dry-run * Don't actually send the emails.\n+ --no-validate * Don't perform sanity checks on patches.\n \n EOT\n \texit(1);\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91945","messageId":"1222779512-58936-3-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222779512-58936-2-git-send-email-mfwitten@mit.edu","subject":"[PATCH 3/9] Docs: send-email: Man page option ordering","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:26Z","receivedAt":"2008-09-30T12:58:26Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"Now the man page lists the options in alphabetical\norder (in terms of the 'main' part of an option's\nname).\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 138 ++++++++++++++++++--------------------\n 1 files changed, 66 insertions(+), 72 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 9b31626..0c6dbf6 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -11,7 +11,6 @@ SYNOPSIS\n 'git send-email' [options] [... file|directory]\n \n \n-\n DESCRIPTION\n -----------\n Takes the patches given on the command line and emails them out.\n@@ -45,19 +44,35 @@ The --cc option must be repeated for each user you want on the cc list.\n \temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n \tthe first will be sent as replies to the first email sent. When using\n \tthis, it is recommended that the first file given be an overview of the\n-\tentire patch series.\n-\tDefault is the value of the 'sendemail.chainreplyto' configuration\n-\tvalue; if that is unspecified, default to --chain-reply-to.\n+\tentire patch series. Default is the value of the 'sendemail.chainreplyto'\n+\tconfiguration value; if that is unspecified, default to --chain-reply-to.\n \n --compose::\n \tUse $GIT_EDITOR, core.editor, $VISUAL, or $EDITOR to edit an\n \tintroductory message for the patch series.\n \n+--dry-run::\n+\tDo everything except actually send the emails.\n+\n+--envelope-sender::\n+\tSpecify the envelope sender used to send the emails.\n+\tThis is useful if your default address is not the address that is\n+\tsubscribed to a list. If you use the sendmail binary, you must have\n+\tsuitable privileges for the -f parameter. Default is the value of\n+\tthe 'sendemail.envelopesender' configuration variable; if that is\n+\tunspecified, choosing the envelope sender is left to your MTA.\n+\n --from::\n \tSpecify the sender of the emails. This will default to\n \tthe value GIT_COMMITTER_IDENT, as returned by \"git var -l\".\n \tThe user will still be prompted to confirm this entry.\n \n+--identity::\n+\tA configuration identity. When given, causes values in the\n+\t'sendemail.' subsection to take precedence over\n+\tvalues in the 'sendemail' section. The default identity is\n+\tthe value of 'sendemail.identity'.\n+\n --in-reply-to::\n \tSpecify the contents of the first In-Reply-To header.\n \tSubsequent emails will refer to the previous email\n@@ -65,21 +80,40 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---[no-]signed-off-by-cc::\n- If this is set, add emails found in Signed-off-by: or Cc: lines to the\n- cc list.\n- Default is the value of 'sendemail.signedoffcc' configuration value;\n- if that is unspecified, default to --signed-off-by-cc.\n-\n --quiet::\n \tMake git-send-email less verbose. One line per email should be\n \tall that is output.\n \n---identity::\n-\tA configuration identity. When given, causes values in the\n-\t'sendemail.' subsection to take precedence over\n-\tvalues in the 'sendemail' section. The default identity is\n-\tthe value of 'sendemail.identity'.\n+--[no-]signed-off-by-cc::\n+ If this is set, add emails found in Signed-off-by: or Cc: lines to the\n+ cc list. Default is the value of 'sendemail.signedoffcc' configuration\n+ value; if that is unspecified, default to --signed-off-by-cc.\n+\n+--smtp-encryption::\n+\tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n+\tvalue reverts to plain SMTP. Default is the value of\n+\t'sendemail.smtpencryption'.\n+\n+--smtp-pass::\n+\tPassword for SMTP-AUTH. The argument is optional: If no\n+\targument is specified, then the empty string is used as\n+\tthe password.\n++\n+In place of this option, the following configuration variables\n+can be specified:\n++\n+--\n+\t\t* sendemail.smtppass\n+\t\t* sendemail..smtppass (see sendemail.identity).\n+--\n++\n+However, --smtp-pass always overrides these variables.\n++\n+Furthermore, passwords need not be specified in configuration files\n+or on the command line. If a username has been specified (with\n+--smtp-user or a configuration variable), but no password has been\n+specified (with --smtp-pass or a configuration variable), then the\n+user is prompted for a password while the input is masked for privacy.\n \n --smtp-server::\n \tIf set, specifies the outgoing SMTP server to use (e.g.\n@@ -96,6 +130,9 @@ The --cc option must be repeated for each user you want on the cc list.\n \tservers typically listen to smtp port 25 and ssmtp port\n \t465).\n \n+--smtp-ssl::\n+\tLegacy alias for '--smtp-encryption=ssl'.\n+\n --smtp-user::\n \tUsername for SMTP-AUTH. In place of this option, the following\n \tconfiguration variables can be specified:\n@@ -110,45 +147,11 @@ However, --smtp-user always overrides these variables.\n If a username is not specified (with --smtp-user or a\n configuration variable), then authentication is not attempted.\n \n---smtp-pass::\n-\tPassword for SMTP-AUTH. The argument is optional: If no\n-\targument is specified, then the empty string is used as\n-\tthe password.\n-+\n-In place of this option, the following configuration variables\n-can be specified:\n-+\n---\n-\t\t* sendemail.smtppass\n-\t\t* sendemail..smtppass (see sendemail.identity).\n---\n-+\n-However, --smtp-pass always overrides these variables.\n-+\n-Furthermore, passwords need not be specified in configuration files\n-or on the command line. If a username has been specified (with\n---smtp-user or a configuration variable), but no password has been\n-specified (with --smtp-pass or a configuration variable), then the\n-user is prompted for a password while the input is masked for privacy.\n-\n---smtp-encryption::\n-\tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n-\tvalue reverts to plain SMTP. Default is the value of\n-\t'sendemail.smtpencryption'.\n-\n---smtp-ssl::\n-\tLegacy alias for '--smtp-encryption=ssl'.\n-\n --subject::\n \tSpecify the initial subject of the email thread.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---[no-]suppress-from::\n- If this is set, do not add the From: address to the cc: list.\n- Default is the value of 'sendemail.suppressfrom' configuration value;\n- if that is unspecified, default to --no-suppress-from.\n-\n --suppress-cc::\n \tSpecify an additional category of recipients to suppress the\n \tauto-cc of. 'self' will avoid including the sender, 'author' will\n@@ -160,24 +163,24 @@ user is prompted for a password while the input is masked for privacy.\n \tif that is unspecified, default to 'self' if --suppress-from is\n \tspecified, as well as 'sob' if --no-signed-off-cc is specified.\n \n+--[no-]suppress-from::\n+\tIf this is set, do not add the From: address to the cc: list.\n+\tDefault is the value of 'sendemail.suppressfrom' configuration\n+\tvalue; if that is unspecified, default to --no-suppress-from.\n+\n --[no-]thread::\n \tIf this is set, the In-Reply-To header will be set on each email sent.\n \tIf disabled with \"--no-thread\", no emails will have the In-Reply-To\n-\theader set.\n-\tDefault is the value of the 'sendemail.thread' configuration value;\n-\tif that is unspecified, default to --thread.\n+\theader set. Default is the value of the 'sendemail.thread' configuration\n+\tvalue; if that is unspecified, default to --thread.\n \n---dry-run::\n-\tDo everything except actually send the emails.\n-\n---envelope-sender::\n-\tSpecify the envelope sender used to send the emails.\n-\tThis is useful if your default address is not the address that is\n-\tsubscribed to a list. If you use the sendmail binary, you must have\n-\tsuitable privileges for the -f parameter.\n-\tDefault is the value of the 'sendemail.envelopesender' configuration\n-\tvariable; if that is unspecified, choosing the envelope sender is left\n-\tto your MTA.\n+--to::\n+\tSpecify the primary recipient of the emails generated. Generally, this\n+\twill be the upstream maintainer of the project involved. Default is the\n+\tvalue of the 'sendemail.to' configuration value; if that is unspecified,\n+\tthis will be prompted for.\n++\n+The --to option must be repeated for each user you want on the to list.\n \n --no-validate::\n \tDon't perform any sanity checks on patches.\n@@ -188,15 +191,6 @@ user is prompted for a password while the input is masked for privacy.\n \t\t\tis due to SMTP limits as described by http://www.ietf.org/rfc/rfc2821.txt.\n --\n \n---to::\n-\tSpecify the primary recipient of the emails generated.\n-\tGenerally, this will be the upstream maintainer of the\n-\tproject involved.\n-\tDefault is the value of the 'sendemail.to' configuration value;\n-\tif that is unspecified, this will be prompted for.\n-+\n-The --to option must be repeated for each user you want on the to list.\n-\n \n CONFIGURATION\n -------------\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91941","messageId":"1222779512-58936-4-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222779512-58936-3-git-send-email-mfwitten@mit.edu","subject":"[PATCH 4/9] send-email: change --no-validate to boolean --[no-]validate","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:27Z","receivedAt":"2008-09-30T12:58:27Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"There is also now a configuration variable:\n\n sendemail[.].validate\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 9 +++++++--\n git-send-email.perl | 9 +++++----\n 2 files changed, 12 insertions(+), 6 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 0c6dbf6..81970f3 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -182,14 +182,16 @@ configuration variable), then authentication is not attempted.\n +\n The --to option must be repeated for each user you want on the to list.\n \n---no-validate::\n-\tDon't perform any sanity checks on patches.\n+--[no-]validate::\n+\tPerform sanity checks on patches.\n \tCurrently, validation means the following:\n +\n --\n \t\t*\tWarn of patches that contain lines longer than 998 characters; this\n \t\t\tis due to SMTP limits as described by http://www.ietf.org/rfc/rfc2821.txt.\n --\n++\n+This option can be set with sendemail[.].validate; default to --validate\n \n \n CONFIGURATION\n@@ -242,6 +244,9 @@ sendemail.smtpencryption::\n sendemail.smtpssl::\n \tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n \n+sendemail.validate::\n+ Boolean override for --[no-]validate.\n+\n Author\n ------\n Written by Ryan Anderson \ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 2c31a25..3467cf1 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -65,7 +65,7 @@ Options:\n --smtp-ssl * Deprecated. Use '--smtp-encryption ssl'.\n --quiet * Output one line of info per email.\n --dry-run * Don't actually send the emails.\n- --no-validate * Don't perform sanity checks on patches.\n+ --[no-]validate * Perform patch sanity checks. Default on.\n \n EOT\n \texit(1);\n@@ -147,7 +147,7 @@ my ($quiet, $dry_run) = (0, 0);\n my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd);\n my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption);\n my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts);\n-my ($no_validate);\n+my ($validate);\n my (@suppress_cc);\n \n my %config_bool_settings = (\n@@ -155,6 +155,7 @@ my %config_bool_settings = (\n \"chainreplyto\" => [\\$chain_reply_to, 1],\n \"suppressfrom\" => [\\$suppress_from, undef],\n \"signedoffcc\" => [\\$signed_off_cc, undef],\n+ \"validate\" => [\\$validate, 1],\n );\n \n my %config_settings = (\n@@ -221,7 +222,7 @@ my $rc = GetOptions(\"sender|from=s\" => \\$sender,\n \t\t \"dry-run\" => \\$dry_run,\n \t\t \"envelope-sender=s\" => \\$envelope_sender,\n \t\t \"thread!\" => \\$thread,\n-\t\t \"no-validate\" => \\$no_validate,\n+\t\t \"validate!\" => \\$validate,\n \t );\n \n unless ($rc) {\n@@ -374,7 +375,7 @@ for my $f (@ARGV) {\n \t}\n }\n \n-if (!$no_validate) {\n+if ($validate) {\n \tforeach my $f (@files) {\n \t\tunless (-p $f) {\n \t\t\tmy $error = validate_patch($f);\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91944","messageId":"1222779512-58936-5-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222779512-58936-4-git-send-email-mfwitten@mit.edu","subject":"[PATCH 5/9] Docs: send-email: --chain_reply_to -> --[no-]chain-reply-to","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:28Z","receivedAt":"2008-09-30T12:58:28Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"Signed-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 81970f3..6b62032 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -221,7 +221,7 @@ sendemail.bcc::\n \tEmail address (or alias) to always bcc.\n \n sendemail.chainreplyto::\n-\tBoolean value specifying the default to the '--chain_reply_to'\n+\tBoolean value specifying the default to the '--[no-]chain-reply-to'\n \tparameter.\n \n sendemail.smtpserver::\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91937","messageId":"1222779512-58936-6-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222779512-58936-5-git-send-email-mfwitten@mit.edu","subject":"[PATCH 6/9] Docs: send-email: Remove unnecessary config variable description","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:29Z","receivedAt":"2008-09-30T12:58:29Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The config variables are mentioned within the descriptions of the\ncommand line options with which they are associated.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 91 +++++++-------------------------------\n 1 files changed, 16 insertions(+), 75 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 6b62032..0d6ac4a 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -24,7 +24,8 @@ OPTIONS\n The options available are:\n \n --bcc::\n-\tSpecify a \"Bcc:\" value for each email.\n+\tSpecify a \"Bcc:\" value for each email. Default is the value of\n+\t'sendemail.bcc'.\n +\n The --bcc option must be repeated for each user you want on the bcc list.\n \n@@ -85,9 +86,9 @@ The --cc option must be repeated for each user you want on the cc list.\n \tall that is output.\n \n --[no-]signed-off-by-cc::\n- If this is set, add emails found in Signed-off-by: or Cc: lines to the\n- cc list. Default is the value of 'sendemail.signedoffcc' configuration\n- value; if that is unspecified, default to --signed-off-by-cc.\n+\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n+\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n+\tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n --smtp-encryption::\n \tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n@@ -97,22 +98,13 @@ The --cc option must be repeated for each user you want on the cc list.\n --smtp-pass::\n \tPassword for SMTP-AUTH. The argument is optional: If no\n \targument is specified, then the empty string is used as\n-\tthe password.\n-+\n-In place of this option, the following configuration variables\n-can be specified:\n-+\n---\n-\t\t* sendemail.smtppass\n-\t\t* sendemail..smtppass (see sendemail.identity).\n---\n-+\n-However, --smtp-pass always overrides these variables.\n+\tthe password. Default is the value of 'sendemail.smtppass',\n+\thowever '--smtp-pass' always overrides this value.\n +\n Furthermore, passwords need not be specified in configuration files\n or on the command line. If a username has been specified (with\n---smtp-user or a configuration variable), but no password has been\n-specified (with --smtp-pass or a configuration variable), then the\n+'--smtp-user' or a 'sendemail.smtpuser'), but no password has been\n+specified (with '--smtp-pass' or 'sendemail.smtppass'), then the\n user is prompted for a password while the input is masked for privacy.\n \n --smtp-server::\n@@ -128,24 +120,15 @@ user is prompted for a password while the input is masked for privacy.\n --smtp-server-port::\n \tSpecifies a port different from the default port (SMTP\n \tservers typically listen to smtp port 25 and ssmtp port\n-\t465).\n+\t465). This can be set with 'sendemail.smtpserverport'.\n \n --smtp-ssl::\n-\tLegacy alias for '--smtp-encryption=ssl'.\n+\tLegacy alias for '--smtp-encryption ssl'.\n \n --smtp-user::\n-\tUsername for SMTP-AUTH. In place of this option, the following\n-\tconfiguration variables can be specified:\n-+\n---\n-\t\t* sendemail.smtpuser\n-\t\t* sendemail..smtpuser (see sendemail.identity).\n---\n-+\n-However, --smtp-user always overrides these variables.\n-+\n-If a username is not specified (with --smtp-user or a\n-configuration variable), then authentication is not attempted.\n+\tUsername for SMTP-AUTH. Default is the value of 'sendemail.smtpuser';\n+\tif a username is not specified (with '--smtp-user' or 'sendemail.smtpuser'),\n+\tthen authentication is not attempted.\n \n --subject::\n \tSpecify the initial subject of the email thread.\n@@ -191,18 +174,12 @@ The --to option must be repeated for each user you want on the to list.\n \t\t\tis due to SMTP limits as described by http://www.ietf.org/rfc/rfc2821.txt.\n --\n +\n-This option can be set with sendemail[.].validate; default to --validate\n+Default is the value of 'sendemail.validate'; if this is not set,\n+default to '--validate'.\n \n \n CONFIGURATION\n -------------\n-sendemail.identity::\n-\tThe default configuration identity. When specified,\n-\t'sendemail..' will have higher precedence than\n-\t'sendemail.'. This is useful to declare multiple SMTP\n-\tidentities and to hoist sensitive authentication information\n-\tout of the repository and into the global configuration file.\n-\n sendemail.aliasesfile::\n \tTo avoid typing long email addresses, point this to one or more\n \temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n@@ -211,42 +188,6 @@ sendemail.aliasfiletype::\n \tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n \tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n \n-sendemail.to::\n-\tEmail address (or alias) to always send to.\n-\n-sendemail.cccmd::\n-\tCommand to execute to generate per patch file specific \"Cc:\"s.\n-\n-sendemail.bcc::\n-\tEmail address (or alias) to always bcc.\n-\n-sendemail.chainreplyto::\n-\tBoolean value specifying the default to the '--[no-]chain-reply-to'\n-\tparameter.\n-\n-sendemail.smtpserver::\n-\tDefault SMTP server to use.\n-\n-sendemail.smtpserverport::\n-\tDefault SMTP server port to use.\n-\n-sendemail.smtpuser::\n-\tDefault SMTP-AUTH username.\n-\n-sendemail.smtppass::\n-\tDefault SMTP-AUTH password.\n-\n-sendemail.smtpencryption::\n-\tDefault encryption method. Use 'ssl' for SSL (and specify an\n-\tappropriate port), or 'tls' for TLS. Takes precedence over\n-\t'smtpssl' if both are specified.\n-\n-sendemail.smtpssl::\n-\tLegacy boolean that sets 'smtpencryption=ssl' if enabled.\n-\n-sendemail.validate::\n- Boolean override for --[no-]validate.\n-\n Author\n ------\n Written by Ryan Anderson \n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91939","messageId":"1222779512-58936-7-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222779512-58936-6-git-send-email-mfwitten@mit.edu","subject":"[PATCH 7/9] Docs: send-email: Create logical groupings for --help text","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:30Z","receivedAt":"2008-09-30T12:58:30Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The options are partitioned into more digestible groups.\n\nSigned-off-by: Michael Witten \n---\n git-send-email.perl | 61 ++++++++++++++++++++++++++++----------------------\n 1 files changed, 34 insertions(+), 27 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 3467cf1..80dae88 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -39,33 +39,40 @@ package main;\n sub usage {\n \tprint <...\n-Options:\n- --identity * Use the sendemail. options.\n- --from * Email From:\n- --envelope-sender * Email envelope sender.\n- --to * Email To:\n- --cc * Email Cc:\n- --cc-cmd * Email Cc: via ` \\$patch_path`\n- --bcc * Email Bcc:\n- --subject * Email \"Subject:\" (only if --compose).\n- --compose * Open an editor for introduction.\n- --in-reply-to * First \"In-Reply-To:\" (only if --compose).\n- --[no-]chain-reply-to * Chain In-Reply-To: fields. Default on.\n- --[no-]thread * Use In-Reply-To: field. Default on.\n- --[no-]signed-off-by-cc * Actually send to Cc: and Signed-off-by:\n- addresses. Default on.\n- --suppress-cc * author, self, sob, cccmd, all.\n- --[no-]suppress-from * Don't send email to self. Default off.\n- --smtp-server * Outgoing SMTP server to use. The port\n- is optional. Default 'localhost'.\n- --smtp-server-port * Outgoing SMTP server port.\n- --smtp-user * The username for SMTP-AUTH.\n- --smtp-pass * The password for SMTP-AUTH; not necessary.\n- --smtp-encryption * tls or ssl; anything else disables.\n- --smtp-ssl * Deprecated. Use '--smtp-encryption ssl'.\n- --quiet * Output one line of info per email.\n- --dry-run * Don't actually send the emails.\n- --[no-]validate * Perform patch sanity checks. Default on.\n+\n+ Composing:\n+ --from * Email From:\n+ --to * Email To:\n+ --cc * Email Cc:\n+ --bcc * Email Bcc:\n+ --subject * Email \"Subject:\"\n+ --in-reply-to * Email \"In-Reply-To:\"\n+ --compose * Open an editor for introduction.\n+\n+ Sending:\n+ --envelope-sender * Email envelope sender.\n+ --smtp-server * Outgoing SMTP server to use. The port\n+ is optional. Default 'localhost'.\n+ --smtp-server-port * Outgoing SMTP server port.\n+ --smtp-user * Username for SMTP-AUTH.\n+ --smtp-pass * Password for SMTP-AUTH; not necessary.\n+ --smtp-encryption * tls or ssl; anything else disables.\n+ --smtp-ssl * Deprecated. Use '--smtp-encryption ssl'.\n+\n+ Automating:\n+ --identity * Use the sendemail. options.\n+ --cc-cmd * Email Cc: via ` \\$patch_path`\n+ --suppress-cc * author, self, sob, cccmd, all.\n+ --[no-]signed-off-by-cc * Send to Cc: and Signed-off-by:\n+ addresses. Default on.\n+ --[no-]suppress-from * Send to self. Default off.\n+ --[no-]chain-reply-to * Chain In-Reply-To: fields. Default on.\n+ --[no-]thread * Use In-Reply-To: field. Default on.\n+\n+ Administering:\n+ --quiet * Output one line of info per email.\n+ --dry-run * Don't actually send the emails.\n+ --[no-]validate * Perform patch sanity checks. Default on.\n \n EOT\n \texit(1);\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91940","messageId":"1222779512-58936-8-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222779512-58936-7-git-send-email-mfwitten@mit.edu","subject":"[PATCH 8/9] Docs: send-email: Create logical groupings for man text","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:31Z","receivedAt":"2008-09-30T12:58:31Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The options are partitioned into more digestible groups.\nWithin these groups, the options are sorted alphabetically.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 119 ++++++++++++++++++++++----------------\n 1 files changed, 69 insertions(+), 50 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 0d6ac4a..d566c34 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -19,9 +19,12 @@ The header of the email is configurable by command line options. If not\n specified on the command line, the user will be prompted with a ReadLine\n enabled interface to provide the necessary information.\n \n+\n OPTIONS\n -------\n-The options available are:\n+\n+Composing\n+~~~~~~~~~\n \n --bcc::\n \tSpecify a \"Bcc:\" value for each email. Default is the value of\n@@ -34,46 +37,15 @@ The --bcc option must be repeated for each user you want on the bcc list.\n +\n The --cc option must be repeated for each user you want on the cc list.\n \n---cc-cmd::\n-\tSpecify a command to execute once per patch file which\n-\tshould generate patch file specific \"Cc:\" entries.\n-\tOutput of this command must be single email address per line.\n-\tDefault is the value of 'sendemail.cccmd' configuration value.\n-\n---[no-]chain-reply-to::\n-\tIf this is set, each email will be sent as a reply to the previous\n-\temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n-\tthe first will be sent as replies to the first email sent. When using\n-\tthis, it is recommended that the first file given be an overview of the\n-\tentire patch series. Default is the value of the 'sendemail.chainreplyto'\n-\tconfiguration value; if that is unspecified, default to --chain-reply-to.\n-\n --compose::\n \tUse $GIT_EDITOR, core.editor, $VISUAL, or $EDITOR to edit an\n \tintroductory message for the patch series.\n \n---dry-run::\n-\tDo everything except actually send the emails.\n-\n---envelope-sender::\n-\tSpecify the envelope sender used to send the emails.\n-\tThis is useful if your default address is not the address that is\n-\tsubscribed to a list. If you use the sendmail binary, you must have\n-\tsuitable privileges for the -f parameter. Default is the value of\n-\tthe 'sendemail.envelopesender' configuration variable; if that is\n-\tunspecified, choosing the envelope sender is left to your MTA.\n-\n --from::\n \tSpecify the sender of the emails. This will default to\n \tthe value GIT_COMMITTER_IDENT, as returned by \"git var -l\".\n \tThe user will still be prompted to confirm this entry.\n \n---identity::\n-\tA configuration identity. When given, causes values in the\n-\t'sendemail.' subsection to take precedence over\n-\tvalues in the 'sendemail' section. The default identity is\n-\tthe value of 'sendemail.identity'.\n-\n --in-reply-to::\n \tSpecify the contents of the first In-Reply-To header.\n \tSubsequent emails will refer to the previous email\n@@ -81,14 +53,30 @@ The --cc option must be repeated for each user you want on the cc list.\n \tOnly necessary if --compose is also set. If --compose\n \tis not set, this will be prompted for.\n \n---quiet::\n-\tMake git-send-email less verbose. One line per email should be\n-\tall that is output.\n+--subject::\n+\tSpecify the initial subject of the email thread.\n+\tOnly necessary if --compose is also set. If --compose\n+\tis not set, this will be prompted for.\n \n---[no-]signed-off-by-cc::\n-\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n-\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n-\tvalue; if that is unspecified, default to --signed-off-by-cc.\n+--to::\n+\tSpecify the primary recipient of the emails generated. Generally, this\n+\twill be the upstream maintainer of the project involved. Default is the\n+\tvalue of the 'sendemail.to' configuration value; if that is unspecified,\n+\tthis will be prompted for.\n++\n+The --to option must be repeated for each user you want on the to list.\n+\n+\n+Sending\n+~~~~~~~\n+\n+--envelope-sender::\n+\tSpecify the envelope sender used to send the emails.\n+\tThis is useful if your default address is not the address that is\n+\tsubscribed to a list. If you use the sendmail binary, you must have\n+\tsuitable privileges for the -f parameter. Default is the value of\n+\tthe 'sendemail.envelopesender' configuration variable; if that is\n+\tunspecified, choosing the envelope sender is left to your MTA.\n \n --smtp-encryption::\n \tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n@@ -130,10 +118,34 @@ user is prompted for a password while the input is masked for privacy.\n \tif a username is not specified (with '--smtp-user' or 'sendemail.smtpuser'),\n \tthen authentication is not attempted.\n \n---subject::\n-\tSpecify the initial subject of the email thread.\n-\tOnly necessary if --compose is also set. If --compose\n-\tis not set, this will be prompted for.\n+\n+Automating\n+~~~~~~~~~~\n+\n+--cc-cmd::\n+\tSpecify a command to execute once per patch file which\n+\tshould generate patch file specific \"Cc:\" entries.\n+\tOutput of this command must be single email address per line.\n+\tDefault is the value of 'sendemail.cccmd' configuration value.\n+\n+--[no-]chain-reply-to::\n+\tIf this is set, each email will be sent as a reply to the previous\n+\temail sent. If disabled with \"--no-chain-reply-to\", all emails after\n+\tthe first will be sent as replies to the first email sent. When using\n+\tthis, it is recommended that the first file given be an overview of the\n+\tentire patch series. Default is the value of the 'sendemail.chainreplyto'\n+\tconfiguration value; if that is unspecified, default to --chain-reply-to.\n+\n+--identity::\n+\tA configuration identity. When given, causes values in the\n+\t'sendemail.' subsection to take precedence over\n+\tvalues in the 'sendemail' section. The default identity is\n+\tthe value of 'sendemail.identity'.\n+\n+--[no-]signed-off-by-cc::\n+\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n+\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n+\tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n --suppress-cc::\n \tSpecify an additional category of recipients to suppress the\n@@ -157,13 +169,16 @@ user is prompted for a password while the input is masked for privacy.\n \theader set. Default is the value of the 'sendemail.thread' configuration\n \tvalue; if that is unspecified, default to --thread.\n \n---to::\n-\tSpecify the primary recipient of the emails generated. Generally, this\n-\twill be the upstream maintainer of the project involved. Default is the\n-\tvalue of the 'sendemail.to' configuration value; if that is unspecified,\n-\tthis will be prompted for.\n-+\n-The --to option must be repeated for each user you want on the to list.\n+\n+Administering\n+~~~~~~~~~~~~~\n+\n+--dry-run::\n+\tDo everything except actually send the emails.\n+\n+--quiet::\n+\tMake git-send-email less verbose. One line per email should be\n+\tall that is output.\n \n --[no-]validate::\n \tPerform sanity checks on patches.\n@@ -180,6 +195,7 @@ default to '--validate'.\n \n CONFIGURATION\n -------------\n+\n sendemail.aliasesfile::\n \tTo avoid typing long email addresses, point this to one or more\n \temail aliases files. You must also supply 'sendemail.aliasfiletype'.\n@@ -188,6 +204,7 @@ sendemail.aliasfiletype::\n \tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n \tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n \n+\n Author\n ------\n Written by Ryan Anderson \n@@ -195,10 +212,12 @@ Written by Ryan Anderson \n git-send-email is originally based upon\n send_lots_of_email.pl by Greg Kroah-Hartman.\n \n+\n Documentation\n --------------\n Documentation by Ryan Anderson\n \n+\n GIT\n ---\n Part of the linkgit:git[1] suite\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"91943","messageId":"1222779512-58936-9-git-send-email-mfwitten@mit.edu","threadId":"15692","inReplyTo":"1222779512-58936-8-git-send-email-mfwitten@mit.edu","subject":"[PATCH 9/9] send-email: signedoffcc -> signedoffbycc, but handle both","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-09-30T12:58:32Z","receivedAt":"2008-09-30T12:58:32Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The documentation now mentions sendemail.signedoffbycc instead\nof sendemail.signedoffcc in order to match with the options\n--signed-off-by-cc; the code has been updated to reflect this\nas well, but sendemail.signedoffcc is still handled.\n\nSigned-off-by: Michael Witten \n---\n Documentation/git-send-email.txt | 2 +-\n git-send-email.perl | 9 +++++----\n 2 files changed, 6 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex d566c34..82f5056 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -144,7 +144,7 @@ Automating\n \n --[no-]signed-off-by-cc::\n \tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n-\tcc list. Default is the value of 'sendemail.signedoffcc' configuration\n+\tcc list. Default is the value of 'sendemail.signedoffbycc' configuration\n \tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n --suppress-cc::\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 80dae88..bdbfac6 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -151,7 +151,7 @@ if ($@) {\n my ($quiet, $dry_run) = (0, 0);\n \n # Variables with corresponding config settings\n-my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd);\n+my ($thread, $chain_reply_to, $suppress_from, $signed_off_by_cc, $cc_cmd);\n my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption);\n my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts);\n my ($validate);\n@@ -161,7 +161,8 @@ my %config_bool_settings = (\n \"thread\" => [\\$thread, 1],\n \"chainreplyto\" => [\\$chain_reply_to, 1],\n \"suppressfrom\" => [\\$suppress_from, undef],\n- \"signedoffcc\" => [\\$signed_off_cc, undef],\n+ \"signedoffbycc\" => [\\$signed_off_by_cc, undef],\n+ \"signedoffcc\" => [\\$signed_off_by_cc, undef], # Deprecated\n \"validate\" => [\\$validate, 1],\n );\n \n@@ -225,7 +226,7 @@ my $rc = GetOptions(\"sender|from=s\" => \\$sender,\n \t\t \"cc-cmd=s\" => \\$cc_cmd,\n \t\t \"suppress-from!\" => \\$suppress_from,\n \t\t \"suppress-cc=s\" => \\@suppress_cc,\n-\t\t \"signed-off-cc|signed-off-by-cc!\" => \\$signed_off_cc,\n+\t\t \"signed-off-cc|signed-off-by-cc!\" => \\$signed_off_by_cc,\n \t\t \"dry-run\" => \\$dry_run,\n \t\t \"envelope-sender=s\" => \\$envelope_sender,\n \t\t \"thread!\" => \\$thread,\n@@ -301,7 +302,7 @@ if ($suppress_cc{'all'}) {\n \n # If explicit old-style ones are specified, they trump --suppress-cc.\n $suppress_cc{'self'} = $suppress_from if defined $suppress_from;\n-$suppress_cc{'sob'} = !$signed_off_cc if defined $signed_off_cc;\n+$suppress_cc{'sob'} = !$signed_off_by_cc if defined $signed_off_by_cc;\n \n # Debugging, print out the suppressions.\n if (0) {\n-- \n1.6.0.2.304.gdcf23.dirty\n"},{"id":"92015","messageId":"20081001032701.GC24513@coredump.intra.peff.net","threadId":"15692","inReplyTo":"1222779512-58936-3-git-send-email-mfwitten@mit.edu","subject":"Re: [PATCH 3/9] Docs: send-email: Man page option ordering","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-10-01T03:27:02Z","receivedAt":"2008-10-01T03:27:02Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Sep 30, 2008 at 07:58:26AM -0500, Michael Witten wrote:\n\n> Now the man page lists the options in alphabetical\n> order (in terms of the 'main' part of an option's\n> name).\n> \n> Signed-off-by: Michael Witten \n\nAfter following this series through a number of revisions, it looks good\nto me now. So\n\nAcked-by: Jeff King \n\nfor the whole series.\n\nI believe this particular patch is probably redundant, since 8/9 just\nre-orders the manpage again later. So it could be dropped if somebody\nfeels like doing the work to rebase the later patches.\n\n-Peff\n"},{"id":"92091","messageId":"26288097-F87A-4F93-B030-40598D65BEEE@mit.edu","threadId":"15692","inReplyTo":"20081001032701.GC24513@coredump.intra.peff.net","subject":"Re: [PATCH 3/9] Docs: send-email: Man page option ordering","fromName":"Michael Witten","fromEmail":"mfwitten@mit.edu","sentAt":"2008-10-01T20:34:47Z","receivedAt":"2008-10-01T20:34:47Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"\nOn 30 Sep 2008, at 10:27 PM, Jeff King wrote:\n\n> On Tue, Sep 30, 2008 at 07:58:26AM -0500, Michael Witten wrote:\n>\n>> Now the man page lists the options in alphabetical\n>> order (in terms of the 'main' part of an option's\n>> name).\n>>\n>> Signed-off-by: Michael Witten \n>\n> After following this series through a number of revisions,\n> it looks good to me now. So\n>\n> Acked-by: Jeff King \n>\n> for the whole series.\n>\n> I believe this particular patch is probably redundant, since\n> 8/9 just re-orders the manpage again later. So it could be\n> dropped if somebody feels like doing the work to rebase the\n> later patches.\n\nI would suggest just leaving it there; it fixes a genuine\nproblem regardless of what the future patches do.\n"},{"id":"92093","messageId":"20081001203651.GO21310@spearce.org","threadId":"15692","inReplyTo":"26288097-F87A-4F93-B030-40598D65BEEE@mit.edu","subject":"Re: [PATCH 3/9] Docs: send-email: Man page option ordering","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-10-01T20:36:51Z","receivedAt":"2008-10-01T20:36:51Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Michael Witten wrote:\n> On 30 Sep 2008, at 10:27 PM, Jeff King wrote:\n>>\n>> I believe this particular patch is probably redundant, since\n>> 8/9 just re-orders the manpage again later. So it could be\n>> dropped if somebody feels like doing the work to rebase the\n>> later patches.\n>\n> I would suggest just leaving it there; it fixes a genuine\n> problem regardless of what the future patches do.\n\nNot only that but the series is already merged into next. I won't\nbe happy about having to revert it, rewrite history, and merge it\nback into next. :-)\n\n-- \nShawn.\n"}]}