{"thread":{"id":"15632","subject":"[QGit] Can't compile under windows (MSVC2008)","startedAt":"2008-09-23T11:31:29Z","lastAt":"2008-10-07T11:55:24Z","messageCount":21,"participants":["Abdelrazak Younes","Li Frank-B20596","Marco Costalba"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"91380","messageId":"gbak2u$v9b$1@ger.gmane.org","threadId":"15632","inReplyTo":null,"subject":"[QGit] Can't compile under windows (MSVC2008)","fromName":"Abdelrazak Younes","fromEmail":"younes@lyx.org","sentAt":"2008-09-23T11:31:29Z","receivedAt":"2008-09-23T11:31:29Z","isPatch":false,"sender":{"key":"younes@lyx.org","avatar":null},"body":"Hello,\n\nI tried to follow README_WIN.txt:\n\nC:\\devel\\qgit\\qgit4>qmake qgit.pro\n\nThe Makefile (attached to this mail) seems to be correctly generated in \nthe same directory (C:\\devel\\qgit\\qgit4).\n\nThen, under MSVC2008 Express, I get this error:\n\n1>------ Début de la génération : Projet : qgit, Configuration : Debug \nWin32 ------\n1>Actions de projet Makefile en cours\n1>Microsoft (R) Program Maintenance Utility Version 9.00.21022.08\n1>Copyright (C) Microsoft Corporation. Tous droits rÚservÚs.\n1> cd src\\ && \"C:\\Program Files\\Microsoft Visual Studio \n9.0\\VC\\bin\\nmake.exe\" debug\n1>Microsoft (R) Program Maintenance Utility Version 9.00.21022.08\n1>Copyright (C) Microsoft Corporation. Tous droits rÚservÚs.\n1>NMAKE : fatal error U1073: incapable d'obtenir 'src\\\\Makefile'\n1>Stop.\n1>NMAKE : fatal error U1077: 'cd'á: code retour '0x2'\n1>Stop.\n1>Project : error PRJ0019: Un outil a retourné un code d'erreur à partir \nde \"Actions de projet Makefile en cours\"\n1>Le journal de génération a été enregistré à l'emplacement \n\"file://c:\\devel\\qgit\\qgit4\\Debug\\BuildLog.htm\"\n1>qgit - 3 erreur(s), 0 avertissement(s)\n========== Génération : 0 a réussi, 1 a échoué, 0 mis à jour, 0 a été \nignoré ==========\n\nIdea someone?\n\nWouldn't it be nice to use CMake instead of qmake so that the MSVC \nsolution is generated directly?\n\nAbdel.\n\n\n#############################################################################\n# Makefile for building: qgit\n# Generated by qmake (2.01a) (Qt 4.4.2-snapshot-20080730) on: mar. 23. sept. 13:26:35 2008\n# Project: qgit.pro\n# Template: subdirs\n# Command: c:\\devel\\qt\\4.4\\bin\\qmake.exe -win32 -o Makefile qgit.pro\n#############################################################################\n\nfirst: make_default\nMAKEFILE = Makefile\nQMAKE = c:\\devel\\qt\\4.4\\bin\\qmake.exe\nDEL_FILE = del\nCHK_DIR_EXISTS= if not exist\nMKDIR = mkdir\nCOPY = copy /y\nCOPY_FILE = $(COPY)\nCOPY_DIR = xcopy /s /q /y /i\nINSTALL_FILE = $(COPY_FILE)\nINSTALL_PROGRAM = $(COPY_FILE)\nINSTALL_DIR = $(COPY_DIR)\nDEL_FILE = del\nSYMLINK = \nDEL_DIR = rmdir\nMOVE = move\nCHK_DIR_EXISTS= if not exist\nMKDIR = mkdir\nSUBTARGETS = \\\n\t\tsub-src\n\nsrc\\$(MAKEFILE): \n\t@$(CHK_DIR_EXISTS) src\\ $(MKDIR) src\\ \n\tcd src\\ && $(QMAKE) src.pro -win32 -o $(MAKEFILE)\nsub-src-qmake_all: FORCE\n\t@$(CHK_DIR_EXISTS) src\\ $(MKDIR) src\\ \n\tcd src\\ && $(QMAKE) src.pro -win32 -o $(MAKEFILE)\nsub-src: src\\$(MAKEFILE) FORCE\n\tcd src\\ && $(MAKE) -f $(MAKEFILE)\nsub-src-make_default: src\\$(MAKEFILE) FORCE\n\tcd src\\ && $(MAKE) -f $(MAKEFILE) \nsub-src-make_first: src\\$(MAKEFILE) FORCE\n\tcd src\\ && $(MAKE) -f $(MAKEFILE) first\nsub-src-all: src\\$(MAKEFILE) FORCE\n\tcd src\\ && $(MAKE) -f $(MAKEFILE) all\nsub-src-clean: src\\$(MAKEFILE) FORCE\n\tcd src\\ && $(MAKE) -f $(MAKEFILE) clean\nsub-src-distclean: src\\$(MAKEFILE) FORCE\n\tcd src\\ && $(MAKE) -f $(MAKEFILE) distclean\nsub-src-install_subtargets: src\\$(MAKEFILE) FORCE\n\tcd src\\ && $(MAKE) -f $(MAKEFILE) install\nsub-src-uninstall_subtargets: src\\$(MAKEFILE) FORCE\n\tcd src\\ && $(MAKE) -f $(MAKEFILE) uninstall\n\nMakefile: qgit.pro ..\\..\\qt\\4.4\\mkspecs\\default\\qmake.conf ..\\..\\qt\\4.4\\mkspecs\\qconfig.pri \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\qt_functions.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\qt_config.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\exclusive_builds.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\default_pre.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\win32\\default_pre.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\debug.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\debug_and_release.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\default_post.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\win32\\rtti.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\win32\\exceptions.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\shared.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\win32\\embed_manifest_exe.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\win32\\embed_manifest_dll.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\warn_on.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\qt.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\win32\\thread.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\moc.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\win32\\windows.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\win32\\stl_off.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\resources.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\uic.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\yacc.prf \\\n\t\t..\\..\\qt\\4.4\\mkspecs\\features\\lex.prf\n\t$(QMAKE) -win32 -o Makefile qgit.pro\n..\\..\\qt\\4.4\\mkspecs\\qconfig.pri:\n..\\..\\qt\\4.4\\mkspecs\\features\\qt_functions.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\qt_config.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\exclusive_builds.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\default_pre.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\win32\\default_pre.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\debug.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\debug_and_release.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\default_post.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\win32\\rtti.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\win32\\exceptions.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\shared.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\win32\\embed_manifest_exe.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\win32\\embed_manifest_dll.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\warn_on.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\qt.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\win32\\thread.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\moc.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\win32\\windows.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\win32\\stl_off.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\resources.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\uic.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\yacc.prf:\n..\\..\\qt\\4.4\\mkspecs\\features\\lex.prf:\nqmake: qmake_all FORCE\n\t@$(QMAKE) -win32 -o Makefile qgit.pro\n\nqmake_all: sub-src-qmake_all FORCE\n\nmake_default: sub-src-make_default FORCE\nmake_first: sub-src-make_first FORCE\nall: sub-src-all FORCE\nclean: sub-src-clean FORCE\ndistclean: sub-src-distclean FORCE\n\t-$(DEL_FILE) Makefile\ninstall_subtargets: sub-src-install_subtargets FORCE\nuninstall_subtargets: sub-src-uninstall_subtargets FORCE\n\nsub-src-sub_Debug: src\\\\$(MAKEFILE)\n\tcd src\\ && $(MAKE) debug\ndebug: sub-src-sub_Debug\n\nsub-src-sub_Release: src\\\\$(MAKEFILE)\n\tcd src\\ && $(MAKE) release\nrelease: sub-src-sub_Release\n\nmocclean: compiler_moc_header_clean compiler_moc_source_clean\n\nmocables: compiler_moc_header_make_all compiler_moc_source_make_all\ninstall: install_subtargets FORCE\n\nuninstall: uninstall_subtargets FORCE\n\nFORCE:\n\n"},{"id":"91381","messageId":"48D8D602.7000309@lyx.org","threadId":"15632","inReplyTo":"gbak2u$v9b$1@ger.gmane.org","subject":"Re: [QGit] Can't compile under windows (MSVC2008)","fromName":"Abdelrazak Younes","fromEmail":"younes@lyx.org","sentAt":"2008-09-23T11:41:54Z","receivedAt":"2008-09-23T11:41:54Z","isPatch":false,"sender":{"key":"younes@lyx.org","avatar":null},"body":"On 23/09/2008 13:31, Abdelrazak Younes wrote:\n> Hello,\n>\n> I tried to follow README_WIN.txt:\n>\n> C:\\devel\\qgit\\qgit4>qmake qgit.pro\n>\n> The Makefile (attached to this mail) seems to be correctly generated in\n> the same directory (C:\\devel\\qgit\\qgit4).\n>\n> Then, under MSVC2008 Express, I get this error:\n\nJust wanted to add that command-line compilation with nmake was \nsuccessful and a bin/qgit.exe was generated that seems to work correctly \nwith latest Git-1.6.0.2-preview20080923 for Windows.\n\nThanks to all developers involved.\n\nAbdel.\n"},{"id":"91554","messageId":"7FD1F85C96D70C4A89DA1DF7667EAE96079EDF@zch01exm23.fsl.freescale.net","threadId":"15632","inReplyTo":"gbak2u$v9b$1@ger.gmane.org","subject":"[QGit] Some suggestion","fromName":"Li Frank-B20596","fromEmail":"frank.li@freescale.com","sentAt":"2008-09-25T05:24:11Z","receivedAt":"2008-09-25T05:24:11Z","isPatch":false,"sender":{"key":"frank.li@freescale.com","avatar":null},"body":"Can add below function at qgit?\n===Difference other version===\n\t1. user choose a commit, \n\t2. right click \n\t\tCheck working dir\n\t\tView patch\n\t\t....\n\t\t[Diff with other commit]\n\n\t3. change icon +\n\t4. user choose other commit\n\n\tQGit show list of changed files. \n\tclick one files, call extern diff tool show difference. \n\n=== file view ===\n\tCan use different color to high light current commit change. \t\n\t\n"},{"id":"91583","messageId":"e5bfff550809250451q578b8e10r75c043d307a63f28@mail.gmail.com","threadId":"15632","inReplyTo":"7FD1F85C96D70C4A89DA1DF7667EAE96079EDF@zch01exm23.fsl.freescale.net","subject":"Re: [QGit] Some suggestion","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-09-25T11:51:57Z","receivedAt":"2008-09-25T11:51:57Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Thu, Sep 25, 2008 at 7:24 AM, Li Frank-B20596 wrote:\n> Can add below function at qgit?\n> ===Difference other version===\n> 1. user choose a commit,\n> 2. right click\n> Check working dir\n> View patch\n> ....\n> [Diff with other commit]\n>\n> 3. change icon +\n> 4. user choose other commit\n>\n> QGit show list of changed files.\n> click one files, call extern diff tool show difference.\n>\n> === file view ===\n> Can use different color to high light current commit change.\n>\n\nYou can _already_ do this.\n\n 1. user choose a commit\n\n 2. user choose other commit with CTRL + RIGHT CLICK\n\n\nOne of the problems of qgit is that the features are not immediately\nvisible. This is a conscious choice to avoid cluttering the GUI.\n\nCurrently the _best_ way to have a complete idea of qgit is to read\nthe handbook (press F1 key): it takes only 5 minutes and you can find\ninteresting features otherwise very difficult to find by accident.\n\nMarco\n"},{"id":"91607","messageId":"7FD1F85C96D70C4A89DA1DF7667EAE96079FBB@zch01exm23.fsl.freescale.net","threadId":"15632","inReplyTo":"e5bfff550809250451q578b8e10r75c043d307a63f28@mail.gmail.com","subject":"RE: [QGit] Some suggestion","fromName":"Li Frank-B20596","fromEmail":"frank.li@freescale.com","sentAt":"2008-09-25T15:20:53Z","receivedAt":"2008-09-25T15:20:53Z","isPatch":false,"sender":{"key":"frank.li@freescale.com","avatar":null},"body":"Marco:\n\t\n\tYes, it is really work although it is not nature way.\n\tThis way don't work at file view. \n\n\tCtrl +/- change font size, but how to change source code view\nfont size. \n\t\n\t12. Marcor Costalba 10 #include \n\t12. Marcor Costalba 10 #include \n\n\nBest regards\nFrank Li \n\n-----Original Message-----\nFrom: Marco Costalba [mailto:mcostalba@gmail.com] \nSent: Thursday, September 25, 2008 7:52 PM\nTo: Li Frank-B20596\nCc: git@vger.kernel.org\nSubject: Re: [QGit] Some suggestion\n\nOn Thu, Sep 25, 2008 at 7:24 AM, Li Frank-B20596\n wrote:\n> Can add below function at qgit?\n> ===Difference other version===\n> 1. user choose a commit,\n> 2. right click\n> Check working dir\n> View patch\n> ....\n> [Diff with other commit]\n>\n> 3. change icon +\n> 4. user choose other commit\n>\n> QGit show list of changed files.\n> click one files, call extern diff tool show difference.\n>\n> === file view ===\n> Can use different color to high light current commit change.\n>\n\nYou can _already_ do this.\n\n 1. user choose a commit\n\n 2. user choose other commit with CTRL + RIGHT CLICK\n\n\nOne of the problems of qgit is that the features are not immediately\nvisible. This is a conscious choice to avoid cluttering the GUI.\n\nCurrently the _best_ way to have a complete idea of qgit is to read the\nhandbook (press F1 key): it takes only 5 minutes and you can find\ninteresting features otherwise very difficult to find by accident.\n\nMarco\n"},{"id":"91612","messageId":"e5bfff550809250934l47c48440m332764491ff5391@mail.gmail.com","threadId":"15632","inReplyTo":"7FD1F85C96D70C4A89DA1DF7667EAE96079FBB@zch01exm23.fsl.freescale.net","subject":"Re: [QGit] Some suggestion","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-09-25T16:34:19Z","receivedAt":"2008-09-25T16:34:19Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Thu, Sep 25, 2008 at 4:20 PM, Li Frank-B20596 wrote:\n> Marco:\n>\n> Ctrl +/- change font size, but how to change source code view\n> font size.\n>\n\nEdit->Settings->Fixed width font\n\nYou can choose size, font family, bolding, etc...\n\nFile view and diff view are optimized for source code viewing so use\nfixed pitch fonts, not system default one that normally it is not\nfixed pitch.\n"},{"id":"91654","messageId":"7FD1F85C96D70C4A89DA1DF7667EAE9607A00A@zch01exm23.fsl.freescale.net","threadId":"15632","inReplyTo":"e5bfff550809250934l47c48440m332764491ff5391@mail.gmail.com","subject":"RE: [QGit] Some suggestion","fromName":"Li Frank-B20596","fromEmail":"frank.li@freescale.com","sentAt":"2008-09-26T01:55:16Z","receivedAt":"2008-09-26T01:55:16Z","isPatch":false,"sender":{"key":"frank.li@freescale.com","avatar":null},"body":"Thank you for your support!\nCan I compare with other version at file view?\nI think highlight author at file view is not high light, can use\ndifferent color? \n\n-----Original Message-----\nFrom: Marco Costalba [mailto:mcostalba@gmail.com] \nSent: Friday, September 26, 2008 12:34 AM\nTo: Li Frank-B20596\nCc: git@vger.kernel.org\nSubject: Re: [QGit] Some suggestion\n\nOn Thu, Sep 25, 2008 at 4:20 PM, Li Frank-B20596\n wrote:\n> Marco:\n>\n> Ctrl +/- change font size, but how to change source code view \n> font size.\n>\n\nEdit->Settings->Fixed width font\n\nYou can choose size, font family, bolding, etc...\n\nFile view and diff view are optimized for source code viewing so use\nfixed pitch fonts, not system default one that normally it is not fixed\npitch.\n"},{"id":"91655","messageId":"e5bfff550809252215v72bb4633s17b5c1a8c39f55ff@mail.gmail.com","threadId":"15632","inReplyTo":"7FD1F85C96D70C4A89DA1DF7667EAE9607A00A@zch01exm23.fsl.freescale.net","subject":"Re: [QGit] Some suggestion","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-09-26T05:15:50Z","receivedAt":"2008-09-26T05:15:50Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Fri, Sep 26, 2008 at 3:55 AM, Li Frank-B20596 wrote:\n> Thank you for your support!\n> Can I compare with other version at file view?\n\nAfter selecting with CTRL+RIGHT CLICK as already descrived click on\nthe file name, you'll be pointed to the part of the diff related to\nyour file.\n\nAnother option is to choose one commit, click on a file name in the\nright bottom pane, then press the MAGIC WAND button, then commits will\nbe reloaded with path limiter and you will see only commits that\nmodify the selected file. Toggle magic wand button to restore original\nview.\n\n> I think highlight author at file view is not high light, can use\n> different color?\n\nWhat is the color you would like ? Possibly in RGB format.\n\nMarco\n"},{"id":"91656","messageId":"7FD1F85C96D70C4A89DA1DF7667EAE9607A0D9@zch01exm23.fsl.freescale.net","threadId":"15632","inReplyTo":"e5bfff550809252215v72bb4633s17b5c1a8c39f55ff@mail.gmail.com","subject":"RE: [QGit] Some suggestion","fromName":"Li Frank-B20596","fromEmail":"frank.li@freescale.com","sentAt":"2008-09-26T05:43:14Z","receivedAt":"2008-09-26T05:43:14Z","isPatch":false,"sender":{"key":"frank.li@freescale.com","avatar":null},"body":"I think orange color of \"Working dir changes\" in Rev List view is good. \n\n\"MAGIC WAND\" is google feature. \nI think the message of \"Filter on \" at title omitted by\nuser early. \n\nI have some suggestions. \n\tOption 1: Change \"Rev List\" to \"Rev List Filtered\", or add\nfilter icon before \"Rev List\"\n\tOption 2: Change \"Short Log\" to \"Short Log Filter On\n\"\n\tOption 3: Add bar between tab and list, show current filter\ninformation \n\n-----Original Message-----\nFrom: Marco Costalba [mailto:mcostalba@gmail.com] \nSent: Friday, September 26, 2008 1:16 PM\nTo: Li Frank-B20596\nCc: git@vger.kernel.org\nSubject: Re: [QGit] Some suggestion\n\nOn Fri, Sep 26, 2008 at 3:55 AM, Li Frank-B20596\n wrote:\n> Thank you for your support!\n> Can I compare with other version at file view?\n\nAfter selecting with CTRL+RIGHT CLICK as already descrived click on the\nfile name, you'll be pointed to the part of the diff related to your\nfile.\n\nAnother option is to choose one commit, click on a file name in the\nright bottom pane, then press the MAGIC WAND button, then commits will\nbe reloaded with path limiter and you will see only commits that modify\nthe selected file. Toggle magic wand button to restore original view.\n\n> I think highlight author at file view is not high light, can use \n> different color?\n\nWhat is the color you would like ? Possibly in RGB format.\n\nMarco\n"},{"id":"91673","messageId":"e5bfff550809260337o1523995ele3333c0de9295393@mail.gmail.com","threadId":"15632","inReplyTo":"7FD1F85C96D70C4A89DA1DF7667EAE9607A0D9@zch01exm23.fsl.freescale.net","subject":"Re: [QGit] Some suggestion","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-09-26T10:37:39Z","receivedAt":"2008-09-26T10:37:39Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Fri, Sep 26, 2008 at 7:43 AM, Li Frank-B20596 wrote:\n>\n> I have some suggestions.\n> Option 1: Change \"Rev List\" to \"Rev List Filtered\"\n\nThis is the more correct but we don't have the space to write on what\nfiles it is filtering\n\n\n> Option 2: Change \"Short Log\" to \"Short Log Filter On\n> \"\n\nThis is less correct because short log has nothing to do with\nfiltering, but here there is more space...\n\n\n> Option 3: Add bar between tab and list, show current filter\n> information\n>\n\nToo complicated and space wasteful IMO.\n\nMarco\n"},{"id":"91692","messageId":"7FD1F85C96D70C4A89DA1DF7667EAE9607A1DA@zch01exm23.fsl.freescale.net","threadId":"15632","inReplyTo":"e5bfff550809260337o1523995ele3333c0de9295393@mail.gmail.com","subject":"RE: [QGit] Some suggestion","fromName":"Li Frank-B20596","fromEmail":"frank.li@freescale.com","sentAt":"2008-09-26T14:57:52Z","receivedAt":"2008-09-26T14:57:52Z","isPatch":false,"sender":{"key":"frank.li@freescale.com","avatar":null},"body":"Option 1: \n\tTelling user just filted is better than nothing. Is it possible\nadd tool button tip. \n\tWhen mouse over 'Rev list [Felted]\", show what filtering.\n\nBest regards\nFrank Li \n\n-----Original Message-----\nFrom: Marco Costalba [mailto:mcostalba@gmail.com] \nSent: Friday, September 26, 2008 6:38 PM\nTo: Li Frank-B20596\nCc: git@vger.kernel.org\nSubject: Re: [QGit] Some suggestion\n\nOn Fri, Sep 26, 2008 at 7:43 AM, Li Frank-B20596\n wrote:\n>\n> I have some suggestions.\n> Option 1: Change \"Rev List\" to \"Rev List Filtered\"\n\nThis is the more correct but we don't have the space to write on what\nfiles it is filtering\n\n\n> Option 2: Change \"Short Log\" to \"Short Log Filter On \n> \"\n\nThis is less correct because short log has nothing to do with filtering,\nbut here there is more space...\n\n\n> Option 3: Add bar between tab and list, show current filter \n> information\n>\n\nToo complicated and space wasteful IMO.\n\nMarco\n"},{"id":"91704","messageId":"e5bfff550809260915i50fa3863s9f83369e07ca0387@mail.gmail.com","threadId":"15632","inReplyTo":"7FD1F85C96D70C4A89DA1DF7667EAE9607A1DA@zch01exm23.fsl.freescale.net","subject":"Re: [QGit] Some suggestion","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-09-26T16:15:01Z","receivedAt":"2008-09-26T16:15:01Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Fri, Sep 26, 2008 at 3:57 PM, Li Frank-B20596 wrote:\n> Option 1:\n> Telling user just filted is better than nothing. Is it possible\n> add tool button tip.\n> When mouse over 'Rev list [Felted]\", show what filtering.\n>\n\nOk! I agree.\n\nThanks\nMarco\n"},{"id":"91730","messageId":"7FD1F85C96D70C4A89DA1DF7667EAE9607A217@zch01exm23.fsl.freescale.net","threadId":"15632","inReplyTo":"e5bfff550809260337o1523995ele3333c0de9295393@mail.gmail.com","subject":"[QGit] [PATCH] Modify Highlight Color at File Context View.","fromName":"Li Frank-B20596","fromEmail":"frank.li@freescale.com","sentAt":"2008-09-27T03:44:46Z","receivedAt":"2008-09-27T03:44:46Z","isPatch":true,"sender":{"key":"frank.li@freescale.com","avatar":null},"body":">From 3507b3f0b13287c5a25a31b238527b5920555c5c Mon Sep 17 00:00:00 2001\nFrom: Frank Li \nDate: Sat, 27 Sep 2008 11:41:03 +0800\nSubject: [PATCH] Modify Highlight Color at File Context View.\nAuthor and line number can be easily found when choose special commit.\n\nSigned-off-by: Frank Li \n---\n src/filecontent.cpp | 6 ++++--\n 1 files changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/src/filecontent.cpp b/src/filecontent.cpp\nindex 28e0f91..23c2e95 100644\n--- a/src/filecontent.cpp\n+++ b/src/filecontent.cpp\n@@ -576,12 +576,14 @@ void FileContent::setAnnList() {\n \tlistWidgetAnn->clear();\n \tlistWidgetAnn->addItems(sl);\n \n-\tQBrush b(Qt::darkGray);\n+\tQBrush fore(Qt::darkRed);\n+\tQBrush back(Qt::lightGray);\n \tQFont f(listWidgetAnn->font());\n \tf.setBold(true);\n \tFOREACH (QVector, it, curIdLines) {\n \t\tQListWidgetItem* item = listWidgetAnn->item(*it);\n-\t\titem->setForeground(b);\n+\t\titem->setForeground(fore);\n+\t\titem->setBackground(back);\n \t\titem->setFont(f);\n \t}\n \t/* When listWidgetAnn get focus for the first time the current\n-- \n1.6.0.2.1172.ga5ed0\n"},{"id":"91741","messageId":"e5bfff550809270547n15a210e3y386278db00966945@mail.gmail.com","threadId":"15632","inReplyTo":"7FD1F85C96D70C4A89DA1DF7667EAE9607A217@zch01exm23.fsl.freescale.net","subject":"Re: [QGit] [PATCH] Modify Highlight Color at File Context View.","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-09-27T12:47:34Z","receivedAt":"2008-09-27T12:47:34Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Sat, Sep 27, 2008 at 4:44 AM, Li Frank-B20596 wrote:\n> From 3507b3f0b13287c5a25a31b238527b5920555c5c Mon Sep 17 00:00:00 2001\n> From: Frank Li \n> Date: Sat, 27 Sep 2008 11:41:03 +0800\n> Subject: [PATCH] Modify Highlight Color at File Context View.\n> Author and line number can be easily found when choose special commit.\n>\n> Signed-off-by: Frank Li \n> ---\n\nPatch applied.\n\nThanks\nMarco\n"},{"id":"92034","messageId":"e5bfff550809302347r59621e09sdea5c679ef3794c8@mail.gmail.com","threadId":"15632","inReplyTo":"7FD1F85C96D70C4A89DA1DF7667EAE9605EA4E@zch01exm23.fsl.freescale.net","subject":"Re: [QGit] [PATCH] Modify Highlight Color at File Context View.","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-10-01T06:47:40Z","receivedAt":"2008-10-01T06:47:40Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596 wrote:\n> Marco:\n>\n> I don't get my patch by git-pull.\n> There are not my patch at\n> http://git.kernel.org/?p=qgit/qgit4.git;a=summary.\n>\n> best regards\n> Frank Li\n> ________________________________\n\nI have pushed to my local repo, I will be able to push to public repo\nonly this week end.\n\nMarco\n"},{"id":"92289","messageId":"e5bfff550810032319s57a0cd52m37aeb8d801019150@mail.gmail.com","threadId":"15632","inReplyTo":"e5bfff550809302347r59621e09sdea5c679ef3794c8@mail.gmail.com","subject":"Re: [QGit] [PATCH] Modify Highlight Color at File Context View.","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-10-04T06:19:43Z","receivedAt":"2008-10-04T06:19:43Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Wed, Oct 1, 2008 at 8:47 AM, Marco Costalba wrote:\n> On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596 wrote:\n>> Marco:\n>>\n>> I don't get my patch by git-pull.\n>> There are not my patch at\n>> http://git.kernel.org/?p=qgit/qgit4.git;a=summary.\n>>\n>> best regards\n>> Frank Li\n>> ________________________________\n>\n> I have pushed to my local repo, I will be able to push to public repo\n> only this week end.\n>\n\nOk. Now is pushed to public repo.\n\nFrank, are you sure it works? for me it does not seem to make any difference.\n\nMarco\n"},{"id":"92295","messageId":"7FD1F85C96D70C4A89DA1DF7667EAE9607A45A@zch01exm23.fsl.freescale.net","threadId":"15632","inReplyTo":"e5bfff550810032319s57a0cd52m37aeb8d801019150@mail.gmail.com","subject":"RE: [QGit] [PATCH] Modify Highlight Color at File Context View.","fromName":"Li Frank-B20596","fromEmail":"frank.li@freescale.com","sentAt":"2008-10-04T14:32:09Z","receivedAt":"2008-10-04T14:32:09Z","isPatch":true,"sender":{"key":"frank.li@freescale.com","avatar":null},"body":" \nMarco:\n\t\n\tIt is difference between my patch and you applied patch. \n\nGit diff HEAD^\n-\titem->setForeground(b);\n+\t\titem->setForeground(fore);\n+\t\titem->setForeground(back);\n \t\titem->setFont(f);\n\nIn my patch:\n\n-\t\titem->setForeground(b);\n+\t\titem->setForeground(fore);\n+\t\titem->setBackground(back);\n\nIt should be setBackground(back), not setForeground(back);\n\n\nBest regards\nFrank Li\n\n-----Original Message-----\nFrom: Marco Costalba [mailto:mcostalba@gmail.com] \nSent: Saturday, October 04, 2008 2:20 PM\nTo: Li Frank-B20596\nCc: git@vger.kernel.org\nSubject: Re: [QGit] [PATCH] Modify Highlight Color at File Context View.\n\nOn Wed, Oct 1, 2008 at 8:47 AM, Marco Costalba \nwrote:\n> On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596\n wrote:\n>> Marco:\n>>\n>> I don't get my patch by git-pull.\n>> There are not my patch at\n>> http://git.kernel.org/?p=qgit/qgit4.git;a=summary.\n>>\n>> best regards\n>> Frank Li\n>> ________________________________\n>\n> I have pushed to my local repo, I will be able to push to public repo \n> only this week end.\n>\n\nOk. Now is pushed to public repo.\n\nFrank, are you sure it works? for me it does not seem to make any\ndifference.\n\nMarco\n"},{"id":"92322","messageId":"e5bfff550810050034p59f08945x4256927b54633e66@mail.gmail.com","threadId":"15632","inReplyTo":"7FD1F85C96D70C4A89DA1DF7667EAE9607A45A@zch01exm23.fsl.freescale.net","subject":"Re: [QGit] [PATCH] Modify Highlight Color at File Context View.","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-10-05T07:34:29Z","receivedAt":"2008-10-05T07:34:29Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Sat, Oct 4, 2008 at 4:32 PM, Li Frank-B20596 wrote:\n>\n> It should be setBackground(back), not setForeground(back);\n>\n\nAhaaaa! My bad!\n\nSorry for this. Fix pushed.\n\nThanks\nMarco\n"},{"id":"92512","messageId":"e5bfff550810070414u283f5ccav33712ca1c6212bde@mail.gmail.com","threadId":"15632","inReplyTo":"gbak2u$v9b$1@ger.gmane.org","subject":"Re: [QGit] Can't compile under windows (MSVC2008)","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-10-07T11:14:03Z","receivedAt":"2008-10-07T11:14:03Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"2008/9/23 Abdelrazak Younes :\n> Hello,\n>\n> I tried to follow README_WIN.txt:\n>\n> C:\\devel\\qgit\\qgit4>qmake qgit.pro\n>\n> The Makefile (attached to this mail) seems to be correctly generated in the\n> same directory (C:\\devel\\qgit\\qgit4).\n>\n> Then, under MSVC2008 Express, I get this error:\n>\n> 1>------ Début de la génération : Projet : qgit, Configuration : Debug Win32\n> ------\n> 1>Actions de projet Makefile en cours\n> 1>Microsoft (R) Program Maintenance Utility Version 9.00.21022.08\n> 1>Copyright (C) Microsoft Corporation. Tous droits rÚservÚs.\n> 1> cd src\\ && \"C:\\Program Files\\Microsoft Visual Studio\n> 9.0\\VC\\bin\\nmake.exe\" debug\n> 1>Microsoft (R) Program Maintenance Utility Version 9.00.21022.08\n> 1>Copyright (C) Microsoft Corporation. Tous droits rÚservÚs.\n> 1>NMAKE : fatal error U1073: incapable d'obtenir 'src\\\\Makefile'\n> 1>Stop.\n> 1>NMAKE : fatal error U1077: 'cd'á: code retour '0x2'\n> 1>Stop.\n> 1>Project : error PRJ0019: Un outil a retourné un code d'erreur à partir de\n> \"Actions de projet Makefile en cours\"\n> 1>Le journal de génération a été enregistré à l'emplacement\n> \"file://c:\\devel\\qgit\\qgit4\\Debug\\BuildLog.htm\"\n> 1>qgit - 3 erreur(s), 0 avertissement(s)\n> ========== Génération : 0 a réussi, 1 a échoué, 0 mis à jour, 0 a été ignoré\n> ==========\n>\n> Idea someone?\n>\n\nhave you tried to setup MSVC for custom build ? and pass proper\ncomamnd line with nmake ?\n\nMarco\n"},{"id":"92515","messageId":"48EB4ADF.8010908@lyx.org","threadId":"15632","inReplyTo":"e5bfff550810070414u283f5ccav33712ca1c6212bde@mail.gmail.com","subject":"Re: [QGit] Can't compile under windows (MSVC2008)","fromName":"Abdelrazak Younes","fromEmail":"younes@lyx.org","sentAt":"2008-10-07T11:41:19Z","receivedAt":"2008-10-07T11:41:19Z","isPatch":false,"sender":{"key":"younes@lyx.org","avatar":null},"body":"On 07/10/2008 13:14, Marco Costalba wrote:\n> 2008/9/23 Abdelrazak Younes:\n> \n>> Hello,\n>>\n>> I tried to follow README_WIN.txt:\n>>\n>> C:\\devel\\qgit\\qgit4>qmake qgit.pro\n>>\n>> The Makefile (attached to this mail) seems to be correctly generated in the\n>> same directory (C:\\devel\\qgit\\qgit4).\n>>\n>> Then, under MSVC2008 Express, I get this error:\n>>\n>> 1>------ Début de la génération : Projet : qgit, Configuration : Debug Win32\n>> ------\n>> 1>Actions de projet Makefile en cours\n>> 1>Microsoft (R) Program Maintenance Utility Version 9.00.21022.08\n>> 1>Copyright (C) Microsoft Corporation. Tous droits rÚservÚs.\n>> 1> cd src\\&& \"C:\\Program Files\\Microsoft Visual Studio\n>> 9.0\\VC\\bin\\nmake.exe\" debug\n>> 1>Microsoft (R) Program Maintenance Utility Version 9.00.21022.08\n>> 1>Copyright (C) Microsoft Corporation. Tous droits rÚservÚs.\n>> 1>NMAKE : fatal error U1073: incapable d'obtenir 'src\\\\Makefile'\n>> 1>Stop.\n>> 1>NMAKE : fatal error U1077: 'cd'á: code retour '0x2'\n>> 1>Stop.\n>> 1>Project : error PRJ0019: Un outil a retourné un code d'erreur à partir de\n>> \"Actions de projet Makefile en cours\"\n>> 1>Le journal de génération a été enregistré à l'emplacement\n>> \"file://c:\\devel\\qgit\\qgit4\\Debug\\BuildLog.htm\"\n>> 1>qgit - 3 erreur(s), 0 avertissement(s)\n>> ========== Génération : 0 a réussi, 1 a échoué, 0 mis à jour, 0 a été ignoré\n>> ==========\n>>\n>> Idea someone?\n>>\n>> \n>\n> have you tried to setup MSVC for custom build ?\n\nSorry, I don't follow you.\n\n> and pass proper\n> comamnd line with nmake ?\n> \n\nIn the NMAKE field of the project properties, there is 'nmake /f \nMakefile debug', is that what you mean?\n\nAbdel.\n"},{"id":"92517","messageId":"48EB4E2C.3040405@lyx.org","threadId":"15632","inReplyTo":"48EB4ADF.8010908@lyx.org","subject":"Re: [QGit] Can't compile under windows (MSVC2008)","fromName":"Abdelrazak Younes","fromEmail":"younes@lyx.org","sentAt":"2008-10-07T11:55:24Z","receivedAt":"2008-10-07T11:55:24Z","isPatch":false,"sender":{"key":"younes@lyx.org","avatar":null},"body":"On 07/10/2008 13:41, Abdelrazak Younes wrote:\n> On 07/10/2008 13:14, Marco Costalba wrote:\n>> 2008/9/23 Abdelrazak Younes:\n>>> Hello,\n>>>\n>>> I tried to follow README_WIN.txt:\n>>>\n>>> C:\\devel\\qgit\\qgit4>qmake qgit.pro\n>>>\n>>> The Makefile (attached to this mail) seems to be correctly generated \n>>> in the\n>>> same directory (C:\\devel\\qgit\\qgit4).\n>>>\n>>> Then, under MSVC2008 Express, I get this error:\n>>>\n>>> 1>------ Début de la génération : Projet : qgit, Configuration : \n>>> Debug Win32\n>>> ------\n>>> 1>Actions de projet Makefile en cours\n>>> 1>Microsoft (R) Program Maintenance Utility Version 9.00.21022.08\n>>> 1>Copyright (C) Microsoft Corporation. Tous droits rÚservÚs.\n>>> 1> cd src\\&& \"C:\\Program Files\\Microsoft Visual Studio\n>>> 9.0\\VC\\bin\\nmake.exe\" debug\n>>> 1>Microsoft (R) Program Maintenance Utility Version 9.00.21022.08\n>>> 1>Copyright (C) Microsoft Corporation. Tous droits rÚservÚs.\n>>> 1>NMAKE : fatal error U1073: incapable d'obtenir 'src\\\\Makefile'\n>>> 1>Stop.\n>>> 1>NMAKE : fatal error U1077: 'cd'á: code retour '0x2'\n>>> 1>Stop.\n>>> 1>Project : error PRJ0019: Un outil a retourné un code d'erreur à \n>>> partir de\n>>> \"Actions de projet Makefile en cours\"\n>>> 1>Le journal de génération a été enregistré à l'emplacement\n>>> \"file://c:\\devel\\qgit\\qgit4\\Debug\\BuildLog.htm\"\n>>> 1>qgit - 3 erreur(s), 0 avertissement(s)\n>>> ========== Génération : 0 a réussi, 1 a échoué, 0 mis à jour, 0 a \n>>> été ignoré\n>>> ==========\n>>>\n>>> Idea someone?\n>>>\n>>\n>> have you tried to setup MSVC for custom build ?\n>\n> Sorry, I don't follow you.\n>\n>> and pass proper\n>> comamnd line with nmake ?\n>\n> In the NMAKE field of the project properties, there is 'nmake /f \n> Makefile debug', is that what you mean?\n\nOK, by removing '/f Makefile' I manage to compile qgit from within \nVisual Studio. I also managed to launch it in debug mode by selecting \nthe executable in ../bin/qgit.exe. When launched this way (F5), qgit \nopens up with the qgit repository but the user name and email are still \nnot filled in, I'll try to debug that now.\n\nAbdel.\n"}]}