{"thread":{"id":"15576","subject":"[PATCH] generate-cmdlist.sh: avoid selecting synopsis at wrong place","startedAt":"2008-09-18T16:01:43Z","lastAt":"2008-09-18T16:20:57Z","messageCount":3,"participants":["Nguyễn Thái Ngọc Duy","Santi Béjar","Nguyen Thai Ngoc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"91037","messageId":"1221753703-3331-1-git-send-email-pclouds@gmail.com","threadId":"15576","inReplyTo":null,"subject":"[PATCH] generate-cmdlist.sh: avoid selecting synopsis at wrong place","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2008-09-18T16:01:43Z","receivedAt":"2008-09-18T16:01:43Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"In \"common\" man pages there is luckily no \"NAME\" anywhere except at\nbeginning of documents. If there is another \"NAME\", sed could\nmis-select it and lead to common-cmds.h corruption. So better nail it\nat beginning of line, which would reduce corruption chance.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n generate-cmdlist.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/generate-cmdlist.sh b/generate-cmdlist.sh\nindex a2913c2..75c68d9 100755\n--- a/generate-cmdlist.sh\n+++ b/generate-cmdlist.sh\n@@ -14,7 +14,7 @@ sort |\n while read cmd\n do\n      sed -n '\n-     /NAME/,/git-'\"$cmd\"'/H\n+     /^NAME/,/git-'\"$cmd\"'/H\n      ${\n             x\n             s/.*git-'\"$cmd\"' - \\(.*\\)/  {\"'\"$cmd\"'\", \"\\1\"},/\n-- \n1.6.0.96.g2fad1.dirty\n"},{"id":"91038","messageId":"adf1fd3d0809180909o2043ae36vda7ae2370f900169@mail.gmail.com","threadId":"15576","inReplyTo":"1221753703-3331-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] generate-cmdlist.sh: avoid selecting synopsis at wrong place","fromName":"Santi Béjar","fromEmail":"santi@agolina.net","sentAt":"2008-09-18T16:09:42Z","receivedAt":"2008-09-18T16:09:42Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"On Thu, Sep 18, 2008 at 6:01 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:\n> In \"common\" man pages there is luckily no \"NAME\" anywhere except at\n> beginning of documents. If there is another \"NAME\", sed could\n> mis-select it and lead to common-cmds.h corruption. So better nail it\n> at beginning of line, which would reduce corruption chance.\n>\n\nYou could narrow it even more with /^NAME$/\n\nSanti\n"},{"id":"91041","messageId":"fcaeb9bf0809180920v33af3910h7ce56aec1db09a54@mail.gmail.com","threadId":"15576","inReplyTo":"adf1fd3d0809180909o2043ae36vda7ae2370f900169@mail.gmail.com","subject":"Re: [PATCH] generate-cmdlist.sh: avoid selecting synopsis at wrong place","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2008-09-18T16:20:57Z","receivedAt":"2008-09-18T16:20:57Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On 9/18/08, Santi Béjar <santi@agolina.net> wrote:\n> On Thu, Sep 18, 2008 at 6:01 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:\n>  > In \"common\" man pages there is luckily no \"NAME\" anywhere except at\n>  > beginning of documents. If there is another \"NAME\", sed could\n>  > mis-select it and lead to common-cmds.h corruption. So better nail it\n>  > at beginning of line, which would reduce corruption chance.\n>  >\n>\n>\n> You could narrow it even more with /^NAME$/\n\nThat may miss \"^NAME $\", which is hard to recognize by eyes, although\nI'm pretty sure there is no trailing spaces in git. It's up to Junio\nto decide how strict he wants.\n-- \nDuy\n"}]}