{"thread":{"id":"15429","subject":"Gitk and --no-walk don't play together","startedAt":"2008-09-08T16:25:14Z","lastAt":"2008-09-08T19:19:39Z","messageCount":6,"participants":["Jan Engelhardt","Santi Bejar","Dmitry Potapov","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"90101","messageId":"alpine.LNX.1.10.0809081223360.1621@fbirervta.pbzchgretzou.qr","threadId":"15429","inReplyTo":null,"subject":"Gitk and --no-walk don't play together","fromName":"Jan Engelhardt","fromEmail":"jengelh@medozas.de","sentAt":"2008-09-08T16:25:14Z","receivedAt":"2008-09-08T16:25:14Z","isPatch":false,"sender":{"key":"jengelh@medozas.de","avatar":null},"body":"\nHi,\n\n\nin an attempt to only show only the tags in the graph, gitk barfs:\n\n$ gitk --no-walk v2.6.25 v2.6.26\n[ Error reading commits: child killed: segmentation violation ]\n"},{"id":"90102","messageId":"adf1fd3d0809080934s67b2a8b1w19aeb3d8e5f8b4ab@mail.gmail.com","threadId":"15429","inReplyTo":"alpine.LNX.1.10.0809081223360.1621@fbirervta.pbzchgretzou.qr","subject":"Re: Gitk and --no-walk don't play together","fromName":"Santi Bejar","fromEmail":"santi@agolina.net","sentAt":"2008-09-08T16:34:49Z","receivedAt":"2008-09-08T16:34:49Z","isPatch":false,"sender":{"key":"santi@agolina.net","avatar":null},"body":"On Mon, Sep 8, 2008 at 6:25 PM, Jan Engelhardt wrote:\n>\n> Hi,\n>\n>\n> in an attempt to only show only the tags in the graph, gitk barfs:\n\nUse the \"List references\" in the file menu.\n\n>\n> $ gitk --no-walk v2.6.25 v2.6.26\n> [ Error reading commits: child killed: segmentation violation ]\n\nAt least, you should say the git version, the OS and platform.\n\nIt is the child process that segfaults, you could try \"git rev-list\n--no-walk v2.6.25 v2.6.26\" directly and even try to debug it?\n\nSanti\n\n\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>\n"},{"id":"90106","messageId":"alpine.LNX.1.10.0809081310260.1621@fbirervta.pbzchgretzou.qr","threadId":"15429","inReplyTo":"adf1fd3d0809080934s67b2a8b1w19aeb3d8e5f8b4ab@mail.gmail.com","subject":"Re: Gitk and --no-walk don't play together","fromName":"Jan Engelhardt","fromEmail":"jengelh@medozas.de","sentAt":"2008-09-08T17:25:12Z","receivedAt":"2008-09-08T17:25:12Z","isPatch":false,"sender":{"key":"jengelh@medozas.de","avatar":null},"body":"\nOn Monday 2008-09-08 12:34, Santi Bejar wrote:\n>\n>> in an attempt to only show only the tags in the graph, gitk barfs:\n>\n>Use the \"List references\" in the file menu.\n\nNope, the intention was to have gitk display something like\n\n* Linux 2.6.26\n|\n* Linux 2.6.25\n\nwithout any intermediate commits.\n\n>> $ gitk --no-walk v2.6.25 v2.6.26\n>> [ Error reading commits: child killed: segmentation violation ]\n>\n>At least, you should say the git version, the OS and platform.\n\nRight you are. gitk 1.5.4.3 and Linux 2.6.24.7.\n\n>It is the child process that segfaults, you could try \"git rev-list\n>--no-walk v2.6.25 v2.6.26\" directly and even try to debug it?\n\nrev-list completes without any problems. I straced gitk, and see:\n\n\tgit log --no-color -z --pretty=raw --topo-order\n\t--parents --boundary --no-walk v2.6.25 v2.6.26\n\nTo reproduce:\n\n\tgit log [with all that arguments] >/dev/null; echo $?\n\tSegmentation fault\n\t139\n\nIt is fixed in v1.6.0.1-267-gec3a4ba. Bisect identified that \n3131b71 fixed it:\n\n Add \"--show-all\" revision walker flag for debugging\n\n\nSo case closed and thank you ;-)\nJan\n"},{"id":"90121","messageId":"adf1fd3d0809081153o5ed8f2d8i94c5b23a2f28858@mail.gmail.com","threadId":"15429","inReplyTo":"alpine.LNX.1.10.0809081310260.1621@fbirervta.pbzchgretzou.qr","subject":"Re: Gitk and --no-walk don't play together","fromName":"Santi Bejar","fromEmail":"santi@agolina.net","sentAt":"2008-09-08T18:53:41Z","receivedAt":"2008-09-08T18:53:41Z","isPatch":false,"sender":{"key":"santi@agolina.net","avatar":null},"body":"On Mon, Sep 8, 2008 at 7:25 PM, Jan Engelhardt wrote:\n>\n> On Monday 2008-09-08 12:34, Santi Bejar wrote:\n>>\n>>> in an attempt to only show only the tags in the graph, gitk barfs:\n>>\n>>Use the \"List references\" in the file menu.\n>\n> Nope, the intention was to have gitk display something like\n>\n> * Linux 2.6.26\n> |\n> * Linux 2.6.25\n>\n> without any intermediate commits.\n>\n\nI think the only option is to generate a graft file specifying 2.6.25\nas parent of 2.6.26.\n\nI have an script that generates it. It gives an overview of the\nbranches/tags, where the parents of a branch/tag are the independent\nbranches/tags that are antecesors (search for git-overview in the\nlist). But currently it has a very bad performance, it could be added\nto git itself like the other history simplifications, but I don´t\nknow.\n\nSanti\n"},{"id":"90123","messageId":"20080908190704.GA28210@dpotapov.dyndns.org","threadId":"15429","inReplyTo":"alpine.LNX.1.10.0809081310260.1621@fbirervta.pbzchgretzou.qr","subject":"Re: Gitk and --no-walk don't play together","fromName":"Dmitry Potapov","fromEmail":"dpotapov@gmail.com","sentAt":"2008-09-08T19:07:04Z","receivedAt":"2008-09-08T19:07:04Z","isPatch":false,"sender":{"key":"dpotapov@gmail.com","avatar":"https://avatars.githubusercontent.com/u/6568595?v=4"},"body":"On Mon, Sep 08, 2008 at 01:25:12PM -0400, Jan Engelhardt wrote:\n> rev-list completes without any problems. I straced gitk, and see:\n> \n> \tgit log --no-color -z --pretty=raw --topo-order\n> \t--parents --boundary --no-walk v2.6.25 v2.6.26\n\ngit log crashed when it tried to print the boundary commit.\nIt seems the bug exists in all 1.5.4.x and was fixed in 1.5.5.\nThe commit that fixed the bug is 3131b71 when --show-all was added\nto revision log. The lines that fixed this bug are the following:\n\n> diff --git a/log-tree.c b/log-tree.c\n> index 1f3fcf1..e9ba6df 100644\n> --- a/log-tree.c\n> +++ b/log-tree.c\n> @@ -278,6 +282,9 @@ void show_log(struct rev_info *opt, const char *sep)\n> \t\t}\n> \t}\n> \n> +\tif (!commit->buffer)\n> +\t\treturn;\n> +\n> \t/*\n> \t * And then the pretty-printed message itself\n> \t */\n\nDmitry\n"},{"id":"90125","messageId":"7viqt6fnsk.fsf@gitster.siamese.dyndns.org","threadId":"15429","inReplyTo":"alpine.LNX.1.10.0809081310260.1621@fbirervta.pbzchgretzou.qr","subject":"Re: Gitk and --no-walk don't play together","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-09-08T19:19:39Z","receivedAt":"2008-09-08T19:19:39Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jan Engelhardt writes:\n\n> On Monday 2008-09-08 12:34, Santi Bejar wrote:\n>>\n>>> in an attempt to only show only the tags in the graph, gitk barfs:\n>>\n>>Use the \"List references\" in the file menu.\n>\n> Nope, the intention was to have gitk display something like\n>\n> * Linux 2.6.26\n> |\n> * Linux 2.6.25\n>\n> without any intermediate commits.\n\nAren't you being unreasonable? How would gitk know to draw the line\nbetween .25 and .26 without walking the history?\n"}]}