{"thread":{"id":"15423","subject":"[PATCH] t/t91XX-svn: start removing use of \"git-\" from these tests","startedAt":"2008-09-08T10:02:05Z","lastAt":"2008-09-09T08:40:23Z","messageCount":5,"participants":["Nanako Shiraishi","Abhijit Menon-Sen","Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"90063","messageId":"20080908190205.6117@nanako3.lavabit.com","threadId":"15423","inReplyTo":null,"subject":"[PATCH] t/t91XX-svn: start removing use of \"git-\" from these tests","fromName":"Nanako Shiraishi","fromEmail":"nanako3@lavabit.com","sentAt":"2008-09-08T10:02:05Z","receivedAt":"2008-09-08T10:02:05Z","isPatch":true,"sender":{"key":"nanako3@lavabit.com","avatar":"https://gravatar.com/avatar/3777b9e201c5883a62b1a6fdf7c53f2d712d1d80989146063ea861e33aad72a8?d=mp&s=160"},"body":"Subversion tests use too many \"git-foo\" form, so I am converting them\nin two steps.\n\nThis first step replaces literal strings \"remotes/git-svn\" and \"git-svn-id\"\nby introducing $remotes_git_svn and $git_svn_id constants defined as shell\nvariables.\n\nSigned-off-by: Nanako Shiraishi <nanako3@lavabit.com>\n---\n t/lib-git-svn.sh                              |    3 ++\n t/t9100-git-svn-basic.sh                      |   38 ++++++++++++------------\n t/t9101-git-svn-props.sh                      |   12 ++++----\n t/t9102-git-svn-deep-rmdir.sh                 |    2 +-\n t/t9106-git-svn-commit-diff-clobber.sh        |    6 ++--\n t/t9107-git-svn-migrate.sh                    |   12 ++++----\n t/t9110-git-svn-use-svm-props.sh              |   18 ++++++------\n t/t9111-git-svn-use-svnsync-props.sh          |   18 ++++++------\n t/t9120-git-svn-clone-with-percent-escapes.sh |    2 +-\n t/t9123-git-svn-rebuild-with-rewriteroot.sh   |    2 +-\n 10 files changed, 58 insertions(+), 55 deletions(-)\n\ndiff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh\nindex a841df2..c33dc2d 100644\n--- a/t/lib-git-svn.sh\n+++ b/t/lib-git-svn.sh\n@@ -2,2 +2,5 @@\n \n+remotes_git_svn=remotes/git\"\"-svn\n+git_svn_id=git\"\"-svn-id\n+\n if test -n \"$NO_SVN_TESTS\"\ndiff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh\nindex 843a501..5f4cfb6 100755\n--- a/t/t9100-git-svn-basic.sh\n+++ b/t/t9100-git-svn-basic.sh\n@@ -46,3 +46,3 @@ name='try a deep --rmdir with a commit'\n test_expect_success \"$name\" '\n-\tgit checkout -f -b mybranch remotes/git-svn &&\n+\tgit checkout -f -b mybranch ${remotes_git_svn} &&\n \tmv dir/a/b/c/d/e/file dir/file &&\n@@ -52,3 +52,3 @@ test_expect_success \"$name\" '\n \tgit-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch &&\n+\t\t${remotes_git_svn}..mybranch &&\n \tsvn up \"$SVN_TREE\" &&\n@@ -66,3 +66,3 @@ test_expect_success \"$name\" \"\n \ttest_must_fail git-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch\" || true\n+\t\t${remotes_git_svn}..mybranch\" || true\n \n@@ -72,3 +72,3 @@ test_expect_success \"$name\" '\n \trm -rf dir \"$GIT_DIR\"/index &&\n-\tgit checkout -f -b mybranch2 remotes/git-svn &&\n+\tgit checkout -f -b mybranch2 ${remotes_git_svn} &&\n \tmv bar/zzz zzz &&\n@@ -80,3 +80,3 @@ test_expect_success \"$name\" '\n \ttest_must_fail git-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch2' || true\n+\t\t${remotes_git_svn}..mybranch2' || true\n \n@@ -86,3 +86,3 @@ test_expect_success \"$name\" '\n \trm -f \"$GIT_DIR\"/index &&\n-\tgit checkout -f -b mybranch3 remotes/git-svn &&\n+\tgit checkout -f -b mybranch3 ${remotes_git_svn} &&\n \trm bar/zzz &&\n@@ -94,3 +94,3 @@ test_expect_success \"$name\" '\n \ttest_must_fail git-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch3' || true\n+\t\t${remotes_git_svn}..mybranch3' || true\n \n@@ -100,3 +100,3 @@ test_expect_success \"$name\" '\n \trm -f \"$GIT_DIR\"/index &&\n-\tgit checkout -f -b mybranch4 remotes/git-svn &&\n+\tgit checkout -f -b mybranch4 ${remotes_git_svn} &&\n \trm -rf dir &&\n@@ -108,3 +108,3 @@ test_expect_success \"$name\" '\n \ttest_must_fail git-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch4' || true\n+\t\t${remotes_git_svn}..mybranch4' || true\n \n@@ -114,3 +114,3 @@ test_expect_success \"$name\" '\n \trm -f \"$GIT_DIR\"/index &&\n-\tgit checkout -f -b mybranch5 remotes/git-svn &&\n+\tgit checkout -f -b mybranch5 ${remotes_git_svn} &&\n \tchmod -x exec.sh &&\n@@ -119,3 +119,3 @@ test_expect_success \"$name\" '\n \tgit-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch5 &&\n+\t\t${remotes_git_svn}..mybranch5 &&\n \tsvn up \"$SVN_TREE\" &&\n@@ -130,3 +130,3 @@ test_expect_success \"$name\" '\n \tgit-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch5 &&\n+\t\t${remotes_git_svn}..mybranch5 &&\n \tsvn up \"$SVN_TREE\" &&\n@@ -142,3 +142,3 @@ test_expect_success \"$name\" '\n \tgit-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch5 &&\n+\t\t${remotes_git_svn}..mybranch5 &&\n \tsvn up \"$SVN_TREE\" &&\n@@ -154,3 +154,3 @@ test_expect_success \"$name\" '\n \tgit-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch5 &&\n+\t\t${remotes_git_svn}..mybranch5 &&\n \tsvn up \"$SVN_TREE\" &&\n@@ -167,3 +167,3 @@ test_expect_success \"$name\" '\n \tgit-svn set-tree --find-copies-harder --rmdir \\\n-\t\tremotes/git-svn..mybranch5 &&\n+\t\t${remotes_git_svn}..mybranch5 &&\n \tsvn up \"$SVN_TREE\" &&\n@@ -193,3 +193,3 @@ test_expect_success \"$name\" \\\n     'git-svn init \"$svnrepo\" && git-svn fetch &&\n-     git rev-list --pretty=raw remotes/git-svn | grep ^tree | uniq > a &&\n+     git rev-list --pretty=raw ${remotes_git_svn} | grep ^tree | uniq > a &&\n      git rev-list --pretty=raw remotes/alt | grep ^tree | uniq > b &&\n@@ -217,3 +217,3 @@ test_expect_success 'exit if remote refs are ambigious' \"\n         git config --add svn-remote.svn.fetch \\\n-                              bar:refs/remotes/git-svn &&\n+                              bar:refs/${remotes_git_svn} &&\n \ttest_must_fail git-svn migrate\n@@ -225,3 +225,3 @@ test_expect_success 'exit if init-ing a would clobber a URL' '\n         git config --unset svn-remote.svn.fetch \\\n-                                \"^bar:refs/remotes/git-svn$\" &&\n+                                \"^bar:refs/${remotes_git_svn}$\" &&\n \ttest_must_fail git-svn init \"${svnrepo}2/bar\"\n@@ -235,3 +235,3 @@ test_expect_success \\\n         git config --get svn-remote.svn.fetch \\\n-                              \"^:refs/remotes/git-svn$\"\n+                              \"^:refs/${remotes_git_svn}$\"\n         '\ndiff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh\nindex f420796..02eccc9 100755\n--- a/t/t9101-git-svn-props.sh\n+++ b/t/t9101-git-svn-props.sh\n@@ -73,7 +73,7 @@ name='test svn:keywords ignoring'\n test_expect_success \"$name\" \\\n-\t'git checkout -b mybranch remotes/git-svn &&\n+\t'git checkout -b mybranch ${remotes_git_svn} &&\n \techo Hi again >> kw.c &&\n \tgit commit -a -m \"test keywords ignoring\" &&\n-\tgit-svn set-tree remotes/git-svn..mybranch &&\n-\tgit pull . remotes/git-svn'\n+\tgit-svn set-tree ${remotes_git_svn}..mybranch &&\n+\tgit pull . ${remotes_git_svn}'\n \n@@ -93,3 +93,3 @@ test_expect_success 'fetch and pull latest from svn and checkout a new wc' \\\n \t'git-svn fetch &&\n-\t git pull . remotes/git-svn &&\n+\t git pull . ${remotes_git_svn} &&\n \t svn co \"$svnrepo\" new_wc'\n@@ -115,3 +115,3 @@ cd ..\n test_expect_success 'fetch and pull latest from svn' \\\n-\t'git-svn fetch && git pull . remotes/git-svn'\n+\t'git-svn fetch && git pull . ${remotes_git_svn}'\n \n@@ -163,3 +163,3 @@ EOF\n test_expect_success 'test create-ignore' \"\n-\tgit-svn fetch && git pull . remotes/git-svn &&\n+\tgit-svn fetch && git pull . ${remotes_git_svn} &&\n \tgit-svn create-ignore &&\ndiff --git a/t/t9102-git-svn-deep-rmdir.sh b/t/t9102-git-svn-deep-rmdir.sh\nindex 0e7ce34..0ad6e24 100755\n--- a/t/t9102-git-svn-deep-rmdir.sh\n+++ b/t/t9102-git-svn-deep-rmdir.sh\n@@ -18,3 +18,3 @@ test_expect_success 'mirror via git-svn' '\n \tgit-svn fetch &&\n-\tgit checkout -f -b test-rmdir remotes/git-svn\n+\tgit checkout -f -b test-rmdir ${remotes_git_svn}\n \t'\ndiff --git a/t/t9106-git-svn-commit-diff-clobber.sh b/t/t9106-git-svn-commit-diff-clobber.sh\nindex 83896e9..da559f8 100755\n--- a/t/t9106-git-svn-commit-diff-clobber.sh\n+++ b/t/t9106-git-svn-commit-diff-clobber.sh\n@@ -44,3 +44,3 @@ test_expect_success 'dcommit fails to commit because of conflict' '\n \tgit-svn fetch &&\n-\tgit reset --hard refs/remotes/git-svn &&\n+\tgit reset --hard refs/${remotes_git_svn} &&\n \tsvn co \"$svnrepo\" t.svn &&\n@@ -58,3 +58,3 @@ test_expect_success 'dcommit fails to commit because of conflict' '\n test_expect_success 'dcommit does the svn equivalent of an index merge' \"\n-\tgit reset --hard refs/remotes/git-svn &&\n+\tgit reset --hard refs/${remotes_git_svn} &&\n \techo 'index merge' > file2 &&\n@@ -79,3 +79,3 @@ test_expect_success 'commit another change from svn side' '\n test_expect_success 'multiple dcommit from git-svn will not clobber svn' \"\n-\tgit reset --hard refs/remotes/git-svn &&\n+\tgit reset --hard refs/${remotes_git_svn} &&\n \techo new file >> new-file &&\ndiff --git a/t/t9107-git-svn-migrate.sh b/t/t9107-git-svn-migrate.sh\nindex d9b553a..f3c75fc 100755\n--- a/t/t9107-git-svn-migrate.sh\n+++ b/t/t9107-git-svn-migrate.sh\n@@ -21,5 +21,5 @@ test_expect_success 'setup old-looking metadata' '\n \trmdir \"$GIT_DIR\"/svn &&\n-\tgit update-ref refs/heads/git-svn-HEAD refs/remotes/git-svn &&\n-\tgit update-ref refs/heads/svn-HEAD refs/remotes/git-svn &&\n-\tgit update-ref -d refs/remotes/git-svn refs/remotes/git-svn\n+\tgit update-ref refs/heads/git-svn-HEAD refs/${remotes_git_svn} &&\n+\tgit update-ref refs/heads/svn-HEAD refs/${remotes_git_svn} &&\n+\tgit update-ref -d refs/${remotes_git_svn} refs/${remotes_git_svn}\n \t'\n@@ -35,3 +35,3 @@ test_expect_success 'initialize old-style (v0) git-svn layout' '\n \t! test -d \"$GIT_DIR\"/git-svn &&\n-\tgit rev-parse --verify refs/remotes/git-svn^0 &&\n+\tgit rev-parse --verify refs/${remotes_git_svn}^0 &&\n \tgit rev-parse --verify refs/remotes/svn^0 &&\n@@ -39,3 +39,3 @@ test_expect_success 'initialize old-style (v0) git-svn layout' '\n \ttest `git config --get svn-remote.svn.fetch` = \\\n-             \":refs/remotes/git-svn\"\n+             \":refs/${remotes_git_svn}\"\n \t'\n@@ -96,3 +96,3 @@ test_expect_success 'migrate --minimize on old inited layout' '\n \tgrep \"^tags/0\\.3:refs/remotes/tags/0\\.3$\" fetch.out\n-\tgrep \"^:refs/remotes/git-svn\" fetch.out\n+\tgrep \"^:refs/${remotes_git_svn}\" fetch.out\n \t'\ndiff --git a/t/t9110-git-svn-use-svm-props.sh b/t/t9110-git-svn-use-svm-props.sh\nindex 83bd1cf..211baf4 100755\n--- a/t/t9110-git-svn-use-svm-props.sh\n+++ b/t/t9110-git-svn-use-svm-props.sh\n@@ -24,13 +24,13 @@ test_expect_success 'verify metadata for /bar' \"\n \tgit cat-file commit refs/remotes/bar | \\\n-\t   grep '^git-svn-id: $bar_url@12 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@12 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~1 | \\\n-\t   grep '^git-svn-id: $bar_url@11 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@11 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~2 | \\\n-\t   grep '^git-svn-id: $bar_url@10 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@10 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~3 | \\\n-\t   grep '^git-svn-id: $bar_url@9 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@9 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~4 | \\\n-\t   grep '^git-svn-id: $bar_url@6 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@6 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~5 | \\\n-\t   grep '^git-svn-id: $bar_url@1 $uuid$'\n+\t   grep '^${git_svn_id}: $bar_url@1 $uuid$'\n \t\"\n@@ -40,3 +40,3 @@ test_expect_success 'verify metadata for /dir/a/b/c/d/e' \"\n \tgit cat-file commit refs/remotes/e | \\\n-\t   grep '^git-svn-id: $e_url@1 $uuid$'\n+\t   grep '^${git_svn_id}: $e_url@1 $uuid$'\n \t\"\n@@ -46,5 +46,5 @@ test_expect_success 'verify metadata for /dir' \"\n \tgit cat-file commit refs/remotes/dir | \\\n-\t   grep '^git-svn-id: $dir_url@2 $uuid$' &&\n+\t   grep '^${git_svn_id}: $dir_url@2 $uuid$' &&\n \tgit cat-file commit refs/remotes/dir~1 | \\\n-\t   grep '^git-svn-id: $dir_url@1 $uuid$'\n+\t   grep '^${git_svn_id}: $dir_url@1 $uuid$'\n \t\"\ndiff --git a/t/t9111-git-svn-use-svnsync-props.sh b/t/t9111-git-svn-use-svnsync-props.sh\nindex c5dfd61..aab109c 100755\n--- a/t/t9111-git-svn-use-svnsync-props.sh\n+++ b/t/t9111-git-svn-use-svnsync-props.sh\n@@ -23,13 +23,13 @@ test_expect_success 'verify metadata for /bar' \"\n \tgit cat-file commit refs/remotes/bar | \\\n-\t   grep '^git-svn-id: $bar_url@12 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@12 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~1 | \\\n-\t   grep '^git-svn-id: $bar_url@11 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@11 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~2 | \\\n-\t   grep '^git-svn-id: $bar_url@10 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@10 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~3 | \\\n-\t   grep '^git-svn-id: $bar_url@9 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@9 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~4 | \\\n-\t   grep '^git-svn-id: $bar_url@6 $uuid$' &&\n+\t   grep '^${git_svn_id}: $bar_url@6 $uuid$' &&\n \tgit cat-file commit refs/remotes/bar~5 | \\\n-\t   grep '^git-svn-id: $bar_url@1 $uuid$'\n+\t   grep '^${git_svn_id}: $bar_url@1 $uuid$'\n \t\"\n@@ -39,3 +39,3 @@ test_expect_success 'verify metadata for /dir/a/b/c/d/e' \"\n \tgit cat-file commit refs/remotes/e | \\\n-\t   grep '^git-svn-id: $e_url@1 $uuid$'\n+\t   grep '^${git_svn_id}: $e_url@1 $uuid$'\n \t\"\n@@ -45,5 +45,5 @@ test_expect_success 'verify metadata for /dir' \"\n \tgit cat-file commit refs/remotes/dir | \\\n-\t   grep '^git-svn-id: $dir_url@2 $uuid$' &&\n+\t   grep '^${git_svn_id}: $dir_url@2 $uuid$' &&\n \tgit cat-file commit refs/remotes/dir~1 | \\\n-\t   grep '^git-svn-id: $dir_url@1 $uuid$'\n+\t   grep '^${git_svn_id}: $dir_url@1 $uuid$'\n \t\"\ndiff --git a/t/t9120-git-svn-clone-with-percent-escapes.sh b/t/t9120-git-svn-clone-with-percent-escapes.sh\nindex 5979e13..e5de229 100755\n--- a/t/t9120-git-svn-clone-with-percent-escapes.sh\n+++ b/t/t9120-git-svn-clone-with-percent-escapes.sh\n@@ -23,3 +23,3 @@ else\n \t\tcd clone &&\n-\t\t\tgit rev-parse refs/remotes/git-svn &&\n+\t\t\tgit rev-parse refs/${remotes_git_svn} &&\n \t\tcd ..\ndiff --git a/t/t9123-git-svn-rebuild-with-rewriteroot.sh b/t/t9123-git-svn-rebuild-with-rewriteroot.sh\nindex c18878f..363c1db 100755\n--- a/t/t9123-git-svn-rebuild-with-rewriteroot.sh\n+++ b/t/t9123-git-svn-rebuild-with-rewriteroot.sh\n@@ -19,3 +19,3 @@ test_expect_success 'init, fetch and checkout repository' '\n \tgit svn fetch\n-\tgit checkout -b mybranch remotes/git-svn\n+\tgit checkout -b mybranch ${remotes_git_svn}\n \t'\n-- \n1.6.0.1\n"},{"id":"90065","messageId":"20080908101631.GA6948@toroid.org","threadId":"15423","inReplyTo":"20080908190205.6117@nanako3.lavabit.com","subject":"Re: [PATCH] t/t91XX-svn: start removing use of \"git-\" from these tests","fromName":"Abhijit Menon-Sen","fromEmail":"ams@toroid.org","sentAt":"2008-09-08T10:16:31Z","receivedAt":"2008-09-08T10:16:31Z","isPatch":true,"sender":{"key":"ams@toroid.org","avatar":null},"body":"At 2008-09-08 19:02:05 +0900, nanako3@lavabit.com wrote:\n>\n> This first step replaces literal strings \"remotes/git-svn\" and\n> \"git-svn-id\" by introducing $remotes_git_svn and $git_svn_id\n> constants defined as shell variables.\n\nI'm sorry, but... why? I don't see the point at all. These are not even\ncommands; and, as someone who was just reading the svn tests, the change\ncertainly doesn't make them *easier* to follow.\n\n-- ams\n"},{"id":"90066","messageId":"20080908102759.GC13085@hand.yhbt.net","threadId":"15423","inReplyTo":"20080908101631.GA6948@toroid.org","subject":"Re: [PATCH] t/t91XX-svn: start removing use of \"git-\" from these tests","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2008-09-08T10:27:59Z","receivedAt":"2008-09-08T10:27:59Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Abhijit Menon-Sen <ams@toroid.org> wrote:\n> At 2008-09-08 19:02:05 +0900, nanako3@lavabit.com wrote:\n> >\n> > This first step replaces literal strings \"remotes/git-svn\" and\n> > \"git-svn-id\" by introducing $remotes_git_svn and $git_svn_id\n> > constants defined as shell variables.\n> \n> I'm sorry, but... why? I don't see the point at all. These are not even\n> commands; and, as someone who was just reading the svn tests, the change\n> certainly doesn't make them *easier* to follow.\n\nThey'll show up as false positives when grepping for \"git-\"\n\nThe commit message should've mentioned that, though (assuming I'm\nreading Nanako's mind correctly :)\n\nNanako: I'm fine with the patches, too sleepy and tired to actually test\nthem, though.\n\n-- \nEric Wong\n"},{"id":"90163","messageId":"20080909022343.GB19190@toroid.org","threadId":"15423","inReplyTo":"20080908102759.GC13085@hand.yhbt.net","subject":"Re: [PATCH] t/t91XX-svn: start removing use of \"git-\" from these tests","fromName":"Abhijit Menon-Sen","fromEmail":"ams@toroid.org","sentAt":"2008-09-09T02:23:43Z","receivedAt":"2008-09-09T02:23:43Z","isPatch":true,"sender":{"key":"ams@toroid.org","avatar":null},"body":"At 2008-09-08 03:27:59 -0700, normalperson@yhbt.net wrote:\n>\n> They'll show up as false positives when grepping for \"git-\"\n\nFine, you're the maintainer, but for the record, I think this change is\ndreadful. Changing all \"git-svn blah\" commands to \"git svn blah\" is one\nthing, but obfuscating tests on the off-chance that someone might grep\nfor \"git-\" seems entirely wrong.\n\n-- ams\n"},{"id":"90189","messageId":"7vfxo9af0o.fsf@gitster.siamese.dyndns.org","threadId":"15423","inReplyTo":"20080909022343.GB19190@toroid.org","subject":"Re: [PATCH] t/t91XX-svn: start removing use of \"git-\" from these tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-09-09T08:40:23Z","receivedAt":"2008-09-09T08:40:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Abhijit Menon-Sen <ams@toroid.org> writes:\n\n> At 2008-09-08 03:27:59 -0700, normalperson@yhbt.net wrote:\n>>\n>> They'll show up as false positives when grepping for \"git-\"\n>\n> Fine, you're the maintainer, but for the record, I think this change is\n> dreadful. Changing all \"git-svn blah\" commands to \"git svn blah\" is one\n> thing, but obfuscating tests on the off-chance that someone might grep\n> for \"git-\" seems entirely wrong.\n\nI think the value of this first one is not \"on the off-chance\" thing, but\nthe presense of this change makes it far easier to eyeball the result of\napplying the second, large-ish patch.\n\nIf I were doing this as a series, I would probably have followed them up\nwith a patch that reverts the token replacement this first one does as the\nfinal patch in the series, but I also think leaving this first patch as-is\nis fine.\n"}]}