{"thread":{"id":"15422","subject":"Re: git-p4 and keyword expansion","startedAt":"2008-09-08T08:50:42Z","lastAt":"2008-09-08T08:50:42Z","messageCount":1,"participants":["dhruva"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"90062","messageId":"888021.6870.qm@web95013.mail.in2.yahoo.com","threadId":"15422","inReplyTo":null,"subject":"Re: git-p4 and keyword expansion","fromName":"dhruva","fromEmail":"dhruva@ymail.com","sentAt":"2008-09-08T08:50:42Z","receivedAt":"2008-09-08T08:50:42Z","isPatch":false,"sender":{"key":"dhruva@ymail.com","avatar":null},"body":"Hi,\n Nice to see some traction in this area, motivates me to work harder to solve this problem.\n\n\n\n----- Original Message ----\n> From: Tor Arvid Lund <torarvid@gmail.com>\n> To: dhruva <dhruva@ymail.com>\n> Cc: Git Mailing List <git@vger.kernel.org>\n> Sent: Monday, 8 September, 2008 2:07:05 PM\n> Subject: Re: git-p4 and keyword expansion\n> \n> On Mon, Sep 8, 2008 at 10:27 AM, Tor Arvid Lund wrote:\n> > Hi,\n> >\n> > On Mon, Sep 8, 2008 at 6:25 AM, dhruva wrote:\n> >>  Removing the keyword unexpanding code in 'git-p4' with the following patch \n> makes it work:\n> >\n> > Yes, I have also experienced this problem, and haven't yet come up\n> > with a solution to it. Your solution seems to solve the problem with\n> > submitting to p4, but it would also mean that files cloned from p4\n> > would have diffs in the git database whenever the p4 headers changed.\n> \n> Hmm... Now that I think about it... Maybe we _want_ the extra diff\n> hunks... Personally I don't care much for the keyword expansions, but\n> since they're there in p4, and p4 diff shows a diff hunk there, maybe\n> we should just do the same. In which case your original patch might be\n> just fine. I realise I haven't had my morning coffee yet. Me\n> confused... :-/\n> \n\nI was drafting my reply and saw your response. The only area I am not sure it git-p4 handles is a rename/copy of an existing file. If that depends on heuristics based on diff, that might fail due to keyword expansions. I will look closer into the git-p4 script today.\n\n-dhruva\n\n\n\n      Get an email ID as yourname@ymail.com or yourname@rocketmail..com. Click here http://in.promos.yahoo.com/address\n"}]}