{"thread":{"id":"15357","subject":"[StGIT PATCH] diffcol.sh: Use /bin/bash explicitly","startedAt":"2008-09-03T15:47:17Z","lastAt":"2008-09-05T21:35:46Z","messageCount":3,"participants":["Shinya Kuribayashi","Karl Hasselström","Catalin Marinas"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"89638","messageId":"48BEB185.2080505@ruby.dti.ne.jp","threadId":"15357","inReplyTo":null,"subject":"[StGIT PATCH] diffcol.sh: Use /bin/bash explicitly","fromName":"Shinya Kuribayashi","fromEmail":"skuribay@ruby.dti.ne.jp","sentAt":"2008-09-03T15:47:17Z","receivedAt":"2008-09-03T15:47:17Z","isPatch":true,"sender":{"key":"skuribay@ruby.dti.ne.jp","avatar":null},"body":"Recent Ubuntu uses dash (Debian Almquist Shell; a lightweight POSIX-\ncompliant shell derived from ash) as /bin/sh by default.  In this case\npager=diffcol.sh doesn't work like this:\n\n> skuribay@ubuntu:~/kernel/linux.git$ stg show\n> /home/skuribay/share/stgit/contrib/diffcol.sh: 22: Bad substitution\n\nthis is caused by non-bash-compliant /bin/sh.\n\ndiffcol.sh is based on Quilt, and Quilt is dependent on bash; Actually\nall Quilt scripts use /bin/bash without exceptions.  Then it's good for\ndiffcol.sh to use /bin/bash.\n\nSigned-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>\n---\n contrib/diffcol.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/diffcol.sh b/contrib/diffcol.sh\nindex ea9109d..eecc87a 100755\n--- a/contrib/diffcol.sh\n+++ b/contrib/diffcol.sh\n@@ -1,4 +1,4 @@\n-#!/bin/sh\n+#!/bin/bash\n \n # Code copied from Quilt (http://savannah.nongnu.org/projects/quilt)\n #\n"},{"id":"89639","messageId":"20080903162123.GA874@diana.vm.bytemark.co.uk","threadId":"15357","inReplyTo":"48BEB185.2080505@ruby.dti.ne.jp","subject":"Re: [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2008-09-03T16:21:23Z","receivedAt":"2008-09-03T16:21:23Z","isPatch":true,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2008-09-04 00:47:17 +0900, Shinya Kuribayashi wrote:\n\n> diffcol.sh is based on Quilt, and Quilt is dependent on bash;\n> Actually all Quilt scripts use /bin/bash without exceptions. Then\n> it's good for diffcol.sh to use /bin/bash.\n\nThanks for this, and the other patch you sent. I'll be picking them up\nthis weekend, unless Catalin beats me to it.\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"},{"id":"89874","messageId":"b0943d9e0809051435g23fa3b83u2a1e8f2a3a6b955f@mail.gmail.com","threadId":"15357","inReplyTo":"20080903162123.GA874@diana.vm.bytemark.co.uk","subject":"Re: [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@gmail.com","sentAt":"2008-09-05T21:35:46Z","receivedAt":"2008-09-05T21:35:46Z","isPatch":true,"sender":{"key":"catalin.marinas@gmail.com","avatar":null},"body":"2008/9/3 Karl Hasselström <kha@treskal.com>:\n> On 2008-09-04 00:47:17 +0900, Shinya Kuribayashi wrote:\n>\n>> diffcol.sh is based on Quilt, and Quilt is dependent on bash;\n>> Actually all Quilt scripts use /bin/bash without exceptions. Then\n>> it's good for diffcol.sh to use /bin/bash.\n>\n> Thanks for this, and the other patch you sent. I'll be picking them up\n> this weekend, unless Catalin beats me to it.\n\nBTW, I think at some point we could change to using Git's native\ncolouring. The diffcol.sh script is from the days when Git didn't have\nthis feature. We currently generate a diff string and pass it through\nthe pager but I'm not sure how to do this.\n\n-- \nCatalin\n"}]}