{"thread":{"id":"15295","subject":"Ambiguous -from of git-send-email","startedAt":"2008-08-31T05:57:10Z","lastAt":"2008-09-02T02:51:44Z","messageCount":5,"participants":["Sheng Yang","Ask Bjørn Hansen","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"89287","messageId":"20080831055710.GA644@yukikaze","threadId":"15295","inReplyTo":null,"subject":"Ambiguous -from of git-send-email","fromName":"Sheng Yang","fromEmail":"yasker@gmail.com","sentAt":"2008-08-31T05:57:10Z","receivedAt":"2008-08-31T05:57:10Z","isPatch":false,"sender":{"key":"yasker@gmail.com","avatar":null},"body":"Hi, all\n\nA trivial problem here, but I think it can be handled more clearly.\n\nRecently when I begin to use git-send-email with my private email\naccount, I found it didn't work as I expected. The problem is \"From\" of\nthe patch. I have to specify my company email in the \"From\" which meant\nthe author, but when I go with default value of git-send-email, I found\nit omit the additional \"From\" of patch in the mailbody.\n\nFor example, I specified \"my@company.com\" in patch's \"From: \" when used\ngit-format-patch to generate it. And I use \"my@home.com\" to send the\nmail.  But if I go with default setting of git-send-email, it said the\nmail would be sent as \"from my@company.com\"(of course it can't). At\nlast, the sent mail only got \"From my@home.com\" in mail header, and\n\"From my@company.com\" was omitted.\n\nI've checked the git-send-email code, and found what's the real meaning\nof \"-from\" specify in git-send-email is the email account(sender) rather\nthan the author. And if the sender is the same as the author, the first\nline of patch \"From: xxx\" was omitted. But at least on my machine, the\nfrom specified in the mail would be overwritten by MTA/ISP(well, I am\nnot sure which of them did this), so what's the content of \"-from\" is\nnot important, but if \"-from\" is the same as \"From\" in the patch, the\n\"From\" line in the patch is omitted, otherwise the line is kept.\n\nYeah, it's reasonable. But I think it's not that clear. \"-from\" of\ngit-send-email indicated the sender and \"From\" indicated the author is\nvery ambiguous.  Maybe use \"-sender\" here in parameter is more\nreasonable? And do we need some notes in manual?\n\nAnd can we add a something like \"sendemail.sender\" to specify the\nsender? I think it's not that unusual to make author's email address is\ndifferent from sender, at least I think it's more common than\n\"sendmail.bcc\".\n\nIf you agree, I'd like to offer a patch for \"sendemail.sender\"(maybe\nalso give some note in manual for \"-from\").\n\nThanks!\n\n--\nregards\nYang, Sheng\n"},{"id":"89334","messageId":"1A4402DD-03B5-4951-B8CA-DB8A8E93D8C4@develooper.com","threadId":"15295","inReplyTo":"20080831055710.GA644@yukikaze","subject":"Re: Ambiguous -from of git-send-email","fromName":"Ask Bjørn Hansen","fromEmail":"ask@develooper.com","sentAt":"2008-08-31T19:37:56Z","receivedAt":"2008-08-31T19:37:56Z","isPatch":false,"sender":{"key":"ask@develooper.com","avatar":"https://gravatar.com/avatar/05ce68433216df7d04bb0d82b7d93b11957e2137e6ed23c4b5bc061d78635f2f?d=mp&s=160"},"body":"\nOn Aug 30, 2008, at 22:57, Sheng Yang wrote:\n\n> And can we add a something like \"sendemail.sender\" to specify the\n> sender? I think it's not that unusual to make author's email address  \n> is\n> different from sender, at least I think it's more common than\n> \"sendmail.bcc\".\n\nTry the sendemail.envelopesender option.  I'll make a patch for adding  \nthat to the documentation.\n\n\n  - ask\n\n-- \nhttp://develooper.com/ - http://askask.com/\n"},{"id":"89340","messageId":"1220214763-25790-1-git-send-email-ask@develooper.com","threadId":"15295","inReplyTo":"1A4402DD-03B5-4951-B8CA-DB8A8E93D8C4@develooper.com","subject":"[PATCH] Document sendemail.envelopesender configuration","fromName":"Ask Bjørn Hansen","fromEmail":"ask@develooper.com","sentAt":"2008-08-31T20:32:43Z","receivedAt":"2008-08-31T20:32:43Z","isPatch":true,"sender":{"key":"ask@develooper.com","avatar":"https://gravatar.com/avatar/05ce68433216df7d04bb0d82b7d93b11957e2137e6ed23c4b5bc061d78635f2f?d=mp&s=160"},"body":"\nSigned-off-by: Ask Bjørn Hansen <ask@develooper.com>\n---\n Documentation/git-send-email.txt |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex e2437f3..e3f82da 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -179,6 +179,9 @@ user is prompted for a password while the input is masked for privacy.\n \tThis is useful if your default address is not the address that is\n \tsubscribed to a list. If you use the sendmail binary, you must have\n \tsuitable privileges for the -f parameter.\n+\tDefault is the value of the 'sendemail.envelopesender' configuration\n+ \tvalue; if that is unspecified, choosing the envelope sender is left\n+\tto your MTA.\n \n --to::\n \tSpecify the primary recipient of the emails generated.\n-- \n1.6.0.1.158.ga28da.dirty\n"},{"id":"89342","messageId":"g9f0qk$sp2$1@ger.gmane.org","threadId":"15295","inReplyTo":"1220214763-25790-1-git-send-email-ask@develooper.com","subject":"Re: [PATCH] Document sendemail.envelopesender configuration","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-08-31T21:01:11Z","receivedAt":"2008-08-31T21:01:11Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Ask Bj?rn Hansen wrote:\n\n> +       Default is the value of the 'sendemail.envelopesender' configuration\n> +       value; if that is unspecified, choosing the envelope sender is left\n\ns/configuration value/configuration variable/\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"89475","messageId":"03CD327C-0146-4B62-ADA3-D327C35A056D@develooper.com","threadId":"15295","inReplyTo":"g9f0qk$sp2$1@ger.gmane.org","subject":"Re: [PATCH] Document sendemail.envelopesender configuration","fromName":"Ask Bjørn Hansen","fromEmail":"ask@develooper.com","sentAt":"2008-09-02T02:51:44Z","receivedAt":"2008-09-02T02:51:44Z","isPatch":true,"sender":{"key":"ask@develooper.com","avatar":"https://gravatar.com/avatar/05ce68433216df7d04bb0d82b7d93b11957e2137e6ed23c4b5bc061d78635f2f?d=mp&s=160"},"body":"\nOn Aug 31, 2008, at 14:01, Jakub Narebski wrote:\n\n>> +       Default is the value of the 'sendemail.envelopesender'  \n>> configuration\n>> +       value; if that is unspecified, choosing the envelope sender  \n>> is left\n>\n> s/configuration value/configuration variable/\n\nHi Jakub,\n\nI thought so too, but used value for internal consistency with (most  \nof) the rest of that documentation file.\n\n\n- ask\n\n-- \nhttp://develooper.com/ - http://askask.com/\n"}]}