{"thread":{"id":"15247","subject":"[PATCH] Fix use of hardlinks in \"make install\"","startedAt":"2008-08-28T14:04:29Z","lastAt":"2008-08-30T15:48:50Z","messageCount":8,"participants":["Alex Riesen","Andreas Färber"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"88888","messageId":"81b0412b0808280704h585b6cb4nf03e509de0159a91@mail.gmail.com","threadId":"15247","inReplyTo":null,"subject":"[PATCH] Fix use of hardlinks in \"make install\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-28T14:04:29Z","receivedAt":"2008-08-28T14:04:29Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"The code tried to create a hardlink to the file ($execdir/git-add) it just\nremoved, so ln failed (but because stderr was redirected into /dev/null the\nerror was never seen), and the whole install ended up using \"ln -s\" instead.\n\nSigned-off-by: Alex Riesen \n---\n\nIt created endless symlink loops on cygwin, but obviously nowhere else.\n\n Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n\nFrom 943e0824b9fd1a8c2798ae9fd341b6a9b7429cc1 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen \nDate: Thu, 28 Aug 2008 15:57:32 +0200\nSubject: [PATCH] Fix use of hardlinks in \"make install\"\n\nThe code tried to create a hardlink to the file ($execdir/git-add) it just\nremoved, so ln failed (but because stderr was redirected into /dev/null the\nerror was never seen), and the whole install ended up using \"ln -s\" instead.\n\nSigned-off-by: Alex Riesen \n---\n Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex bf400e6..20a1704 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1380,7 +1380,7 @@ endif\n \t\tln git-add$X \"$$execdir/git-add$X\" 2>/dev/null || \\\n \t\tcp git-add$X \"$$execdir/git-add$X\"; } && \\\n \t{ $(foreach p,$(filter-out git-add,$(BUILT_INS)), $(RM) \"$$execdir/$p\" && \\\n-\t\tln \"$$execdir/git-add$X\" \"$$execdir/$p\" 2>/dev/null || \\\n+\t\tln \"git-add$X\" \"$$execdir/$p\" || \\\n \t\tln -s \"git-add$X\" \"$$execdir/$p\" 2>/dev/null || \\\n \t\tcp \"$$execdir/git-add$X\" \"$$execdir/$p\" || exit;) } && \\\n \t./check_bindir \"z$$bindir\" \"z$$execdir\" \"$$bindir/git-add$X\"\n-- \n1.6.0.1.150.g8307.dirty\n\n"},{"id":"88893","messageId":"81b0412b0808280717u78c5ccf8ne1413c701ed8edd9@mail.gmail.com","threadId":"15247","inReplyTo":"81b0412b0808280704h585b6cb4nf03e509de0159a91@mail.gmail.com","subject":"Re: [PATCH] Fix use of hardlinks in \"make install\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-28T14:17:34Z","receivedAt":"2008-08-28T14:17:34Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"2008/8/28 Alex Riesen :\n> The code tried to create a hardlink to the file ($execdir/git-add) it just\n> removed, so ln failed (but because stderr was redirected into /dev/null the\n> error was never seen), and the whole install ended up using \"ln -s\" instead.\n>\n> Signed-off-by: Alex Riesen \n> ---\n>\n> It created endless symlink loops on cygwin, but obviously nowhere else.\n>\n\nSh@#! Scrap that, there is something else going on in that cygwindows thing...\n"},{"id":"88894","messageId":"81b0412b0808280730m351d409cnab9bbda1f5871938@mail.gmail.com","threadId":"15247","inReplyTo":"81b0412b0808280717u78c5ccf8ne1413c701ed8edd9@mail.gmail.com","subject":"[PATCH] Fix use of hardlinks in \"make install\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-28T14:30:07Z","receivedAt":"2008-08-28T14:30:07Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"The code failed to filter-out git-add properly on platforms were $X is\nnot empty (ATM there is only one such a platform).\n\nThan it tried to create a hardlink to the file ($execdir/git-add) it just\nremoved (because git-add is first in the BUILT_INS), so ln failed (but\nbecause stderr was redirected into /dev/null the error was never seen), and\nthe whole install ended up using \"ln -s\" instead.\n\nSigned-off-by: Alex Riesen \n---\n Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n2008/8/28 Alex Riesen :\n> 2008/8/28 Alex Riesen :\n>>\n>> It created endless symlink loops on cygwin, but obviously nowhere else.\n>>\n>\n> Sh@#! Scrap that, there is something else going on in that cygwindows thing...\n>\n\nWell, as usual, simple fix for trivial typo caused by existence of an\nidiotic platform.\n\n\nFrom 6d83dbb0e3b78bfaad9522b2266d0864e434acce Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen \nDate: Thu, 28 Aug 2008 15:57:32 +0200\nSubject: [PATCH] Fix use of hardlinks in \"make install\"\n\nThe code failed to filter-out git-add properly on platforms were $X is\nnot empty (ATM there is only one such a platform).\n\nThan it tried to create a hardlink to the file ($execdir/git-add) it just\nremoved (because git-add is first in the BUILT_INS), so ln failed (but\nbecause stderr was redirected into /dev/null the error was never seen), and\nthe whole install ended up using \"ln -s\" instead.\n\nSigned-off-by: Alex Riesen \n---\n Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex bf400e6..20f028f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1379,7 +1379,7 @@ endif\n \t{ $(RM) \"$$execdir/git-add$X\" && \\\n \t\tln git-add$X \"$$execdir/git-add$X\" 2>/dev/null || \\\n \t\tcp git-add$X \"$$execdir/git-add$X\"; } && \\\n-\t{ $(foreach p,$(filter-out git-add,$(BUILT_INS)), $(RM) \"$$execdir/$p\" && \\\n+\t{ $(foreach p,$(filter-out git-add$X,$(BUILT_INS)), $(RM) \"$$execdir/$p\" && \\\n \t\tln \"$$execdir/git-add$X\" \"$$execdir/$p\" 2>/dev/null || \\\n \t\tln -s \"git-add$X\" \"$$execdir/$p\" 2>/dev/null || \\\n \t\tcp \"$$execdir/git-add$X\" \"$$execdir/$p\" || exit;) } && \\\n-- \n1.6.0.1.152.g6969c\n\n"},{"id":"89169","messageId":"20080830002032.GA14522@steel.home","threadId":"15247","inReplyTo":"81b0412b0808280717u78c5ccf8ne1413c701ed8edd9@mail.gmail.com","subject":"[PATCH/resend] Fix use of hardlinks in \"make install\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-30T00:20:32Z","receivedAt":"2008-08-30T00:20:32Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"The code failed to filter-out git-add properly on platforms were $X is\nnot empty (ATM there is only one such a platform).\n\nThan it tried to create a hardlink to the file ($execdir/git-add) it just\nremoved (because git-add is first in the BUILT_INS), so ln failed (but\nbecause stderr was redirected into /dev/null the error was never seen), and\nthe whole install ended up using \"ln -s\" instead.\n\nSigned-off-by: Alex Riesen \n---\n2008/8/28 Alex Riesen :\n> 2008/8/28 Alex Riesen :\n>>\n>> It created endless symlink loops on cygwin, but obviously nowhere else.\n>>\n>\n> Sh@#! Scrap that, there is something else going on in that cygwindows thing...\n>\n\nWell, as usual, simple fix for a trivial typo caused by existence of an\nidiotic platform.\n\n Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex bf400e6..20f028f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1379,7 +1379,7 @@ endif\n \t{ $(RM) \"$$execdir/git-add$X\" && \\\n \t\tln git-add$X \"$$execdir/git-add$X\" 2>/dev/null || \\\n \t\tcp git-add$X \"$$execdir/git-add$X\"; } && \\\n-\t{ $(foreach p,$(filter-out git-add,$(BUILT_INS)), $(RM) \"$$execdir/$p\" && \\\n+\t{ $(foreach p,$(filter-out git-add$X,$(BUILT_INS)), $(RM) \"$$execdir/$p\" && \\\n \t\tln \"$$execdir/git-add$X\" \"$$execdir/$p\" 2>/dev/null || \\\n \t\tln -s \"git-add$X\" \"$$execdir/$p\" 2>/dev/null || \\\n \t\tcp \"$$execdir/git-add$X\" \"$$execdir/$p\" || exit;) } && \\\n-- \n1.6.0.1.152.g6969c\n"},{"id":"89192","messageId":"66B007DD-F970-43E5-BA38-6138E553C93A@googlemail.com","threadId":"15247","inReplyTo":"20080830002032.GA14522@steel.home","subject":"Re: [PATCH/resend] Fix use of hardlinks in \"make install\"","fromName":"Andreas Färber","fromEmail":"planche2k@googlemail.com","sentAt":"2008-08-30T08:59:36Z","receivedAt":"2008-08-30T08:59:36Z","isPatch":true,"sender":{"key":"planche2k@googlemail.com","avatar":null},"body":"\nAm 30.08.2008 um 02:20 schrieb Alex Riesen:\n\n> The code failed to filter-out git-add properly on platforms were $X is\n> not empty (ATM there is only one such a platform).\n>\n> Than it tried to create a hardlink to the file ($execdir/git-add) it \n> just\n> removed (because git-add is first in the BUILT_INS), so ln failed (but\n> because stderr was redirected into /dev/null the error was never \n> seen), and\n> the whole install ended up using \"ln -s\" instead.\n>\n> Signed-off-by: Alex Riesen \n> ---\n\n> Well, as usual, simple fix for a trivial typo caused by existence of \n> an\n> idiotic platform.\n>\n> Makefile | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/Makefile b/Makefile\n> index bf400e6..20f028f 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1379,7 +1379,7 @@ endif\n> \t{ $(RM) \"$$execdir/git-add$X\" && \\\n> \t\tln git-add$X \"$$execdir/git-add$X\" 2>/dev/null || \\\n> \t\tcp git-add$X \"$$execdir/git-add$X\"; } && \\\n> -\t{ $(foreach p,$(filter-out git-add,$(BUILT_INS)), $(RM) \"$$execdir/ \n> $p\" && \\\n> +\t{ $(foreach p,$(filter-out git-add$X,$(BUILT_INS)), $(RM) \"$ \n> $execdir/$p\" && \\\n> \t\tln \"$$execdir/git-add$X\" \"$$execdir/$p\" 2>/dev/null || \\\n> \t\tln -s \"git-add$X\" \"$$execdir/$p\" 2>/dev/null || \\\n> \t\tcp \"$$execdir/git-add$X\" \"$$execdir/$p\" || exit;) } && \\\n> -- \n> 1.6.0.1.152.g6969c\n\nYour patch seems to work on Haiku, don't have a MinGW setup to test. \nSorry for the breakage.\n\nAndreas\n"},{"id":"89203","messageId":"81b0412b0808300308m2d03b94ft8601f02b2fea494e@mail.gmail.com","threadId":"15247","inReplyTo":"66B007DD-F970-43E5-BA38-6138E553C93A@googlemail.com","subject":"Re: [PATCH/resend] Fix use of hardlinks in \"make install\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-30T10:08:44Z","receivedAt":"2008-08-30T10:08:44Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"2008/8/30 Andreas Färber :\n> Am 30.08.2008 um 02:20 schrieb Alex Riesen:\n>\n>> Well, as usual, simple fix for a trivial typo caused by existence of an\n>> idiotic platform.\n>>\n> Your patch seems to work on Haiku, don't have a MinGW setup to test. Sorry\n> for the breakage.\n\nWhat?! Haiku uses stupid file extensions to mark executables?\n"},{"id":"89208","messageId":"60597530-B8AC-421E-84DF-BF241CB799C5@googlemail.com","threadId":"15247","inReplyTo":"81b0412b0808300308m2d03b94ft8601f02b2fea494e@mail.gmail.com","subject":"Re: [PATCH/resend] Fix use of hardlinks in \"make install\"","fromName":"Andreas Färber","fromEmail":"planche2k@googlemail.com","sentAt":"2008-08-30T11:39:27Z","receivedAt":"2008-08-30T11:39:27Z","isPatch":true,"sender":{"key":"planche2k@googlemail.com","avatar":null},"body":"\nAm 30.08.2008 um 12:08 schrieb Alex Riesen:\n\n> 2008/8/30 Andreas Färber :\n>> Am 30.08.2008 um 02:20 schrieb Alex Riesen:\n>>\n>>> Well, as usual, simple fix for a trivial typo caused by existence \n>>> of an\n>>> idiotic platform.\n>>>\n>> Your patch seems to work on Haiku, don't have a MinGW setup to \n>> test. Sorry\n>> for the breakage.\n>\n> What?! Haiku uses stupid file extensions to mark executables?\n\nNo, it doesn't. Like BeOS, it uses MIME types stored as BFS attributes \nas well as the standard POSIX executable bit.\n\nSince no one appeared to have replied yet, I confirmed that your \nWindows patch does not break things here and looks reasonable to me as \nco-author of the offending commit.\n\nAndreas\n"},{"id":"89215","messageId":"81b0412b0808300848o7510bbc4u178f32f8d23723d@mail.gmail.com","threadId":"15247","inReplyTo":"60597530-B8AC-421E-84DF-BF241CB799C5@googlemail.com","subject":"Re: [PATCH/resend] Fix use of hardlinks in \"make install\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-30T15:48:50Z","receivedAt":"2008-08-30T15:48:50Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"2008/8/30 Andreas Färber :\n>\n> Since no one appeared to have replied yet, I confirmed that your Windows\n> patch does not break things here and looks reasonable to me as co-author of\n> the offending commit.\n\nOk\n"}]}