{"thread":{"id":"15182","subject":"[PATCH] Makefile: improve customization for supporting HP-UX","startedAt":"2008-08-23T19:41:24Z","lastAt":"2008-08-24T04:33:35Z","messageCount":8,"participants":["Miklos Vajna","Robert Schiele","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"88310","messageId":"1219520484-7712-1-git-send-email-vmiklos@frugalware.org","threadId":"15182","inReplyTo":null,"subject":"[PATCH] Makefile: improve customization for supporting HP-UX","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-08-23T19:41:24Z","receivedAt":"2008-08-23T19:41:24Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"In 81cc66a, customization has been added to Makefile for supporting\nHP-UX, but two minor tweaks are still necessary, at least on older\nversions like 11.11.\n\nSigned-off-by: Miklos Vajna \n---\n\nCc'ing Robert, it would be interesting to know how did he succeed to\nbuild without this patch.\n\n Makefile | 2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 5e944d8..7fb35ca 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -735,6 +735,8 @@ ifeq ($(uname_S),HP-UX)\n \tNO_UNSETENV = YesPlease\n \tNO_HSTRERROR = YesPlease\n \tNO_SYS_SELECT_H = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n+\tSNPRINTF_RETURNS_BOGUS = YesPlease\n endif\n ifneq (,$(findstring MINGW,$(uname_S)))\n \tNO_MMAP = YesPlease\n-- \n1.6.0.rc3.17.gc14c8.dirty\n"},{"id":"88318","messageId":"20080823200928.GA7185@schiele.dyndns.org","threadId":"15182","inReplyTo":"1219520484-7712-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] Makefile: improve customization for supporting HP-UX","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2008-08-23T20:09:28Z","receivedAt":"2008-08-23T20:09:28Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"On Sat, Aug 23, 2008 at 09:41:24PM +0200, Miklos Vajna wrote:\n> Cc'ing Robert, it would be interesting to know how did he succeed to\n> build without this patch.\n\nWell, it just worked though I cannot give a guarantee that there is not a flaw\nsomewhere in the binaries since these machines are not our main development\nmachines and most developers use git itself on another system that shares the\nsame network directory.\n\nThe systems I build on are:\n\n1x HP-UX B.11.11 U 9000/785\n2x HP-UX B.11.23 U ia64\n\nIf you tell us how your specific problem looks like I might have an idea why\nit does not occur to me.\n\nRobert\n\n-- \nRobert Schiele\nDipl.-Wirtsch.informatiker\tmailto:rschiele@gmail.com\n\n\"Quidquid latine dictum sit, altum sonatur.\"\n"},{"id":"88319","messageId":"20080823202601.GF23800@genesis.frugalware.org","threadId":"15182","inReplyTo":"20080823200928.GA7185@schiele.dyndns.org","subject":"Re: [PATCH] Makefile: improve customization for supporting HP-UX","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-08-23T20:26:01Z","receivedAt":"2008-08-23T20:26:01Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sat, Aug 23, 2008 at 10:09:28PM +0200, Robert Schiele wrote:\n> The systems I build on are:\n> \n> 1x HP-UX B.11.11 U 9000/785\n\nThis is the same version I'm using at the moment.\n\nThe NEEDS_LIBICONV is simple, the linker fails to find iconv symbols:\n\n/usr/ccs/bin/ld: Unsatisfied symbols:\n libiconv (first referenced in libgit.a(utf8.o)) (code)\n libiconv_open (first referenced in libgit.a(utf8.o)) (code)\n libiconv_close (first referenced in libgit.a(utf8.o)) (code)\ncollect2: ld returned 1 exit status\ngmake: *** [git] Error 1\n\nThe SNPRINTF_RETURNS_BOGUS is not something you can notice compile-time,\nbut once you try to commit, you get:\n\n$ git commit\nfatal: your vsnprintf is broken\n"},{"id":"88321","messageId":"20080823210243.GB7185@schiele.dyndns.org","threadId":"15182","inReplyTo":"20080823202601.GF23800@genesis.frugalware.org","subject":"Re: [PATCH] Makefile: improve customization for supporting HP-UX","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2008-08-23T21:02:43Z","receivedAt":"2008-08-23T21:02:43Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"On Sat, Aug 23, 2008 at 10:26:01PM +0200, Miklos Vajna wrote:\n> On Sat, Aug 23, 2008 at 10:09:28PM +0200, Robert Schiele wrote:\n> > The systems I build on are:\n> > \n> > 1x HP-UX B.11.11 U 9000/785\n> \n> This is the same version I'm using at the moment.\n> \n> The NEEDS_LIBICONV is simple, the linker fails to find iconv symbols:\n> \n> /usr/ccs/bin/ld: Unsatisfied symbols:\n> libiconv (first referenced in libgit.a(utf8.o)) (code)\n> libiconv_open (first referenced in libgit.a(utf8.o)) (code)\n> libiconv_close (first referenced in libgit.a(utf8.o)) (code)\n> collect2: ld returned 1 exit status\n> gmake: *** [git] Error 1\n\nHuh? Where does the \"lib\" prefix come from on your system? Do you have some\ncustom iconv header file in the way? On my system I see:\n\n[13] % nm /usr/lib/libc.2 | grep ^iconv\niconv | 1255080|extern|entry |\niconv | 1255112|extern|code |$CODE$\niconv_close | 1254800|extern|entry |\niconv_close | 1254832|extern|code |$CODE$\niconv_open | 1255208|extern|entry |\niconv_open | 1255272|extern|code |$CODE$\n[14] % \n\n> The SNPRINTF_RETURNS_BOGUS is not something you can notice compile-time,\n> but once you try to commit, you get:\n> \n> $ git commit\n> fatal: your vsnprintf is broken\n\nOk, I see that as well. Obviously nobody ever committed something on these\nmachines. But since we use these machines mostly for building people need to\nbe able to checkout stuff only in most cases and this is most likely why it\npassed unnoticed.\n\nThus I think the snprintf part of your patch makes sense but the iconv stuff\nseems to be something flawed on your machine.\n\nRobert\n\n-- \nRobert Schiele\nDipl.-Wirtsch.informatiker\tmailto:rschiele@gmail.com\n\n\"Quidquid latine dictum sit, altum sonatur.\"\n"},{"id":"88325","messageId":"20080823220358.GH23800@genesis.frugalware.org","threadId":"15182","inReplyTo":"20080823210243.GB7185@schiele.dyndns.org","subject":"Re: [PATCH] Makefile: improve customization for supporting HP-UX","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-08-23T22:03:58Z","receivedAt":"2008-08-23T22:03:58Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sat, Aug 23, 2008 at 11:02:43PM +0200, Robert Schiele wrote:\n> On Sat, Aug 23, 2008 at 10:26:01PM +0200, Miklos Vajna wrote:\n> > On Sat, Aug 23, 2008 at 10:09:28PM +0200, Robert Schiele wrote:\n> > > The systems I build on are:\n> > > \n> > > 1x HP-UX B.11.11 U 9000/785\n> > \n> > This is the same version I'm using at the moment.\n> > \n> > The NEEDS_LIBICONV is simple, the linker fails to find iconv symbols:\n> > \n> > /usr/ccs/bin/ld: Unsatisfied symbols:\n> > libiconv (first referenced in libgit.a(utf8.o)) (code)\n> > libiconv_open (first referenced in libgit.a(utf8.o)) (code)\n> > libiconv_close (first referenced in libgit.a(utf8.o)) (code)\n> > collect2: ld returned 1 exit status\n> > gmake: *** [git] Error 1\n> \n> Huh? Where does the \"lib\" prefix come from on your system? Do you have some\n> custom iconv header file in the way? On my system I see:\n> \n> [13] % nm /usr/lib/libc.2 | grep ^iconv\n> iconv | 1255080|extern|entry |\n> iconv | 1255112|extern|code |$CODE$\n> iconv_close | 1254800|extern|entry |\n> iconv_close | 1254832|extern|code |$CODE$\n> iconv_open | 1255208|extern|entry |\n> iconv_open | 1255272|extern|code |$CODE$\n> [14] % \n\nAh, OK, that is specific to this machine. If you install the libiconv\npackage, then #include includes /usr/local/include/iconv.h\nwhere iconv is a define to libiconv. So that is not needed generally,\nthanks for pointing out.\n\n> Thus I think the snprintf part of your patch makes sense but the iconv stuff\n> seems to be something flawed on your machine.\n\nOK, I'll send a patch with that part only in a bit.\n"},{"id":"88326","messageId":"1219529275-8194-1-git-send-email-vmiklos@frugalware.org","threadId":"15182","inReplyTo":"20080823220358.GH23800@genesis.frugalware.org","subject":"[PATCH] Makefile: enable SNPRINTF_RETURNS_BOGUS for HP-UX","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-08-23T22:07:55Z","receivedAt":"2008-08-23T22:07:55Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"In 81cc66a, customization has been added to Makefile for supporting\nHP-UX, but git commit is still problematic. This should fix the issue.\n\nSigned-off-by: Miklos Vajna \n---\n Makefile | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 5e944d8..e5a4985 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -735,6 +735,7 @@ ifeq ($(uname_S),HP-UX)\n \tNO_UNSETENV = YesPlease\n \tNO_HSTRERROR = YesPlease\n \tNO_SYS_SELECT_H = YesPlease\n+\tSNPRINTF_RETURNS_BOGUS = YesPlease\n endif\n ifneq (,$(findstring MINGW,$(uname_S)))\n \tNO_MMAP = YesPlease\n-- \n1.6.0.rc3.17.gc14c8.dirty\n"},{"id":"88339","messageId":"7vabf3w7l7.fsf@gitster.siamese.dyndns.org","threadId":"15182","inReplyTo":"1219529275-8194-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] Makefile: enable SNPRINTF_RETURNS_BOGUS for HP-UX","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-08-24T01:00:04Z","receivedAt":"2008-08-24T01:00:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Miklos Vajna writes:\n\n> In 81cc66a, customization has been added to Makefile for supporting\n> HP-UX, but git commit is still problematic. This should fix the issue.\n>\n> Signed-off-by: Miklos Vajna \n\nIs this missing \"Tested-by: Robert\"? I do not mind adding it myself --\njust checking.\n"},{"id":"88348","messageId":"20080824043335.GC7185@schiele.dyndns.org","threadId":"15182","inReplyTo":"7vabf3w7l7.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Makefile: enable SNPRINTF_RETURNS_BOGUS for HP-UX","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2008-08-24T04:33:35Z","receivedAt":"2008-08-24T04:33:35Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"On Sat, Aug 23, 2008 at 06:00:04PM -0700, Junio C Hamano wrote:\n> Miklos Vajna writes:\n> \n> > In 81cc66a, customization has been added to Makefile for supporting\n> > HP-UX, but git commit is still problematic. This should fix the issue.\n> >\n> > Signed-off-by: Miklos Vajna \n> \n> Is this missing \"Tested-by: Robert\"? I do not mind adding it myself --\n> just checking.\n\nIt is tested by me, yes. On HP-UX B.11.11 U 9000/785 and HP-UX B.11.23 U\nia64.\n\nRobert\n\n-- \nRobert Schiele\nDipl.-Wirtsch.informatiker\tmailto:rschiele@gmail.com\n\n\"Quidquid latine dictum sit, altum sonatur.\"\n"}]}