{"thread":{"id":"1518","subject":"[PATCH] Audit rev-parse users.","startedAt":"2005-08-15T09:55:23Z","lastAt":"2005-08-15T09:55:23Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"7293","messageId":"7vacjj1q44.fsf@assigned-by-dhcp.cox.net","threadId":"1518","inReplyTo":null,"subject":"[PATCH] Audit rev-parse users.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-15T09:55:23Z","receivedAt":"2005-08-15T09:55:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Make sure that we say --verify when we want to get a single SHA1\nname.  Also when we say --verify, --revs-only is redundant.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n\n git-rebase-script |    2 +-\n git-reset-script  |    4 ++--\n git-tag-script    |    2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)\n\nfb1dea6f0298f4b47ae6a3dc08a1bc2398ef8053\ndiff --git a/git-rebase-script b/git-rebase-script\n--- a/git-rebase-script\n+++ b/git-rebase-script\n@@ -28,7 +28,7 @@ case \"$#\" in\n esac\n \n git-read-tree -m -u $ours $upstream &&\n-echo \"$upstream\" >\"$GIT_DIR/HEAD\" || exit\n+git-rev-parse --verify \"$upstream^0\" >\"$GIT_DIR/HEAD\" || exit\n \n tmp=.rebase-tmp$$\n fail=$tmp-fail\ndiff --git a/git-reset-script b/git-reset-script\n--- a/git-reset-script\n+++ b/git-reset-script\n@@ -1,7 +1,7 @@\n #!/bin/sh\n . git-sh-setup-script || die \"Not a git archive\"\n-rev=$(git-rev-parse --revs-only --verify --default HEAD \"$@\") || exit\n-rev=$(git-rev-parse --revs-only --verify $rev^0) || exit\n+rev=$(git-rev-parse --verify --default HEAD \"$@\") || exit\n+rev=$(git-rev-parse --verify $rev^0) || exit\n git-read-tree --reset \"$rev\" && {\n \tif orig=$(git-rev-parse --verify HEAD 2>/dev/null)\n \tthen\ndiff --git a/git-tag-script b/git-tag-script\n--- a/git-tag-script\n+++ b/git-tag-script\n@@ -47,7 +47,7 @@ if [ -e \"$GIT_DIR/refs/tags/$name\" -a -z\n fi\n shift\n \n-object=$(git-rev-parse --verify --revs-only --default HEAD \"$@\") || exit 1\n+object=$(git-rev-parse --verify --default HEAD \"$@\") || exit 1\n type=$(git-cat-file -t $object) || exit 1\n tagger=$(git-var GIT_COMMITTER_IDENT) || exit 1\n \n"}]}