{"thread":{"id":"15128","subject":"[JGIT PATCH] Typo in implementation of pack protocol","startedAt":"2008-08-21T10:36:11Z","lastAt":"2008-08-21T15:02:14Z","messageCount":5,"participants":["Mike Ralphson","Shawn O. Pearce","H.Merijn Brand"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"87965","messageId":"1219314971-13445-1-git-send-email-mike@abacus.co.uk","threadId":"15128","inReplyTo":null,"subject":"[JGIT PATCH] Typo in implementation of pack protocol","fromName":"Mike Ralphson","fromEmail":"mike@abacus.co.uk","sentAt":"2008-08-21T10:36:11Z","receivedAt":"2008-08-21T10:36:11Z","isPatch":true,"sender":{"key":"mike@abacus.co.uk","avatar":"https://gravatar.com/avatar/717865f1e9a9197ec082b9f6a12e048210a9da06878e47f165b470c43a9e9175?d=mp&s=160"},"body":"cgit's receive-pack.c has never had the corresponding typo.\nFix up method and member names to match.\n\nSigned-off-by: Mike Ralphson \n---\n .../spearce/jgit/transport/BasePackConnection.java | 2 +-\n .../jgit/transport/BasePackPushConnection.java | 6 +++---\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackConnection.java b/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackConnection.java\nindex 52f3f48..14fffc3 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackConnection.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackConnection.java\n@@ -144,7 +144,7 @@ for (String c : line.substring(nul + 1).split(\" \"))\n \t\t\t\t\tline = line.substring(0, nul);\n \t\t\t\t}\n \n-\t\t\t\tif (line.equals(\"capabilties^{}\")) {\n+\t\t\t\tif (line.equals(\"capabilities^{}\")) {\n \t\t\t\t\t// special line from git-receive-pack to show\n \t\t\t\t\t// capabilities when there are no refs to advertise\n \t\t\t\t\tcontinue;\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackPushConnection.java b/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackPushConnection.java\nindex 6d95eaf..a2d5b6f 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackPushConnection.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackPushConnection.java\n@@ -118,7 +118,7 @@ if (sentCommand && capableReport)\n \n \tprivate void writeCommands(final Collection refUpdates,\n \t\t\tfinal ProgressMonitor monitor) throws IOException {\n-\t\tfinal String capabilties = enableCapabilties();\n+\t\tfinal String capabilities = enableCapabilities();\n \t\tfor (final RemoteRefUpdate rru : refUpdates) {\n \t\t\tif (!capableDeleteRefs && rru.isDelete()) {\n \t\t\t\trru.setStatus(Status.REJECTED_NODELETE);\n@@ -136,7 +136,7 @@ if (!capableDeleteRefs && rru.isDelete()) {\n \t\t\tsb.append(rru.getRemoteName());\n \t\t\tif (!sentCommand) {\n \t\t\t\tsentCommand = true;\n-\t\t\t\tsb.append(capabilties);\n+\t\t\t\tsb.append(capabilities);\n \t\t\t}\n \n \t\t\tpckOut.writeString(sb.toString());\n@@ -151,7 +151,7 @@ if (monitor.isCancelled())\n \t\toutNeedsEnd = false;\n \t}\n \n-\tprivate String enableCapabilties() {\n+\tprivate String enableCapabilities() {\n \t\tfinal StringBuilder line = new StringBuilder();\n \t\tcapableReport = wantCapability(line, CAPABILITY_REPORT_STATUS);\n \t\tcapableDeleteRefs = wantCapability(line, CAPABILITY_DELETE_REFS);\n-- \n1.5.6.4\n"},{"id":"87992","messageId":"20080821145012.GN3483@spearce.org","threadId":"15128","inReplyTo":"1219314971-13445-1-git-send-email-mike@abacus.co.uk","subject":"Re: [JGIT PATCH] Typo in implementation of pack protocol","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-21T14:50:12Z","receivedAt":"2008-08-21T14:50:12Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Mike Ralphson wrote:\n> cgit's receive-pack.c has never had the corresponding typo.\n> Fix up method and member names to match.\n\nWhoops. Thanks.\n \n> -\t\t\t\tif (line.equals(\"capabilties^{}\")) {\n> +\t\t\t\tif (line.equals(\"capabilities^{}\")) {\n> \t\t\t\t\t// special line from git-receive-pack to show\n> \t\t\t\t\t// capabilities when there are no refs to advertise\n\n-- \nShawn.\n"},{"id":"87993","messageId":"20080821170042.457e62f1@pc09.procura.nl","threadId":"15128","inReplyTo":"20080821145012.GN3483@spearce.org","subject":"Re: [JGIT PATCH] Typo in implementation of pack protocol","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2008-08-21T15:00:42Z","receivedAt":"2008-08-21T15:00:42Z","isPatch":true,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Thu, 21 Aug 2008 07:50:12 -0700, \"Shawn O. Pearce\"\n wrote:\n\n> Mike Ralphson wrote:\n> > cgit's receive-pack.c has never had the corresponding typo.\n> > Fix up method and member names to match.\n> \n> Whoops. Thanks.\n> \n> > -\t\t\t\tif (line.equals(\"capabilties^{}\")) {\n> > +\t\t\t\tif (line.equals(\"capabilities^{}\")) {\n> > \t\t\t\t\t// special line from git-receive-pack to show\n> > \t\t\t\t\t// capabilities when there are no refs to advertise\n\nWouldn't it be nice to stick to ANSI Comments?\nI bet AIX xlc will fall over very very fast here\n\n-- \nH.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/\nusing & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,\n11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"87995","messageId":"20080821170200.3ea08b28@pc09.procura.nl","threadId":"15128","inReplyTo":"20080821170042.457e62f1@pc09.procura.nl","subject":"Re: [JGIT PATCH] Typo in implementation of pack protocol","fromName":"H.Merijn Brand","fromEmail":"h.m.brand@xs4all.nl","sentAt":"2008-08-21T15:02:00Z","receivedAt":"2008-08-21T15:02:00Z","isPatch":true,"sender":{"key":"h.m.brand@xs4all.nl","avatar":"https://gravatar.com/avatar/5b8f83ee35c427a646cbea3b104346e00ab3663b99bbf435cddeb75cd4b3857b?d=mp&s=160"},"body":"On Thu, 21 Aug 2008 17:00:42 +0200, \"H.Merijn Brand\"\n wrote:\n\n> On Thu, 21 Aug 2008 07:50:12 -0700, \"Shawn O. Pearce\"\n> wrote:\n> \n> > Mike Ralphson wrote:\n> > > cgit's receive-pack.c has never had the corresponding typo.\n> > > Fix up method and member names to match.\n> > \n> > Whoops. Thanks.\n> > \n> > > -\t\t\t\tif (line.equals(\"capabilties^{}\")) {\n> > > +\t\t\t\tif (line.equals(\"capabilities^{}\")) {\n> > > \t\t\t\t\t// special line from git-receive-pack to show\n> > > \t\t\t\t\t// capabilities when there are no refs to advertise\n> \n> Wouldn't it be nice to stick to ANSI Comments?\n> I bet AIX xlc will fall over very very fast here\n\nIgnore that stupid remark. It's java :(\n\n\n-- \nH.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/\nusing & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,\n11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.\nhttp://mirrors.develooper.com/hpux/ http://www.test-smoke.org/\nhttp://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/\n"},{"id":"87994","messageId":"20080821150214.GQ3483@spearce.org","threadId":"15128","inReplyTo":"20080821170042.457e62f1@pc09.procura.nl","subject":"Re: [JGIT PATCH] Typo in implementation of pack protocol","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-21T15:02:14Z","receivedAt":"2008-08-21T15:02:14Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"\"H.Merijn Brand\" wrote:\n> On Thu, 21 Aug 2008 07:50:12 -0700, \"Shawn O. Pearce\"\n> wrote:\n> \n> > Mike Ralphson wrote:\n> > > cgit's receive-pack.c has never had the corresponding typo.\n> > > Fix up method and member names to match.\n> > \n> > Whoops. Thanks.\n> > \n> > > -\t\t\t\tif (line.equals(\"capabilties^{}\")) {\n> > > +\t\t\t\tif (line.equals(\"capabilities^{}\")) {\n> > > \t\t\t\t\t// special line from git-receive-pack to show\n> > > \t\t\t\t\t// capabilities when there are no refs to advertise\n> \n> Wouldn't it be nice to stick to ANSI Comments?\n> I bet AIX xlc will fall over very very fast here\n\nAIX xlc compiles Java code?\n\nThis is JGIT, written in Java, not git.git, written in ANSI C...\n\n-- \nShawn.\n"}]}