{"thread":{"id":"15124","subject":"[JGit Patch v2 2/7] Add test resources to a new package structured directory","startedAt":"2008-08-21T03:13:08Z","lastAt":"2008-08-23T05:21:51Z","messageCount":11,"participants":["imyousuf@gmail.com","Shawn O. Pearce","Imran M Yousuf"],"isPatch":true,"patchVersion":2,"patchTotal":7},"messages":[{"id":"87932","messageId":"1219288394-1241-1-git-send-email-imyousuf@gmail.com","threadId":"15124","inReplyTo":null,"subject":"[JGit Patch v2 1/7] Add a POM file for setting JGit library as a Maven project","fromName":"","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-21T03:13:08Z","receivedAt":"2008-08-21T03:13:08Z","isPatch":true,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"From: Imran M Yousuf <imyousuf@smartitengineering.com>\n\nSigned-off-by: Imran M Yousuf <imyousuf@smartitengineering.com>\n---\n jgit-maven/jgit/pom.xml |  169 +++++++++++++++++++++++++++++++++++++++++++++++\n 1 files changed, 169 insertions(+), 0 deletions(-)\n create mode 100644 jgit-maven/jgit/pom.xml\n\ndiff --git a/jgit-maven/jgit/pom.xml b/jgit-maven/jgit/pom.xml\nnew file mode 100644\nindex 0000000..c4d7c24\n--- /dev/null\n+++ b/jgit-maven/jgit/pom.xml\n@@ -0,0 +1,169 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!--\n+All rights reserved.\n+Redistribution and use in source and binary forms, with or\n+without modification, are permitted provided that the following\n+conditions are met:\n+\n+Redistributions of source code must retain the above copyright\n+notice, this list of conditions and the following disclaimer.\n+\n+Redistributions in binary form must reproduce the above\n+copyright notice, this list of conditions and the following\n+disclaimer in the documentation and/or other materials provided\n+with the distribution.\n+\n+Neither the name of the Git Development Community nor the\n+names of its contributors may be used to endorse or promote\n+products derived from this software without specific prior\n+written permission.\n+\n+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND\n+CONTRIBUTORS \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES,\n+INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES\n+OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR\n+CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT\n+NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;\n+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,\n+STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF\n+ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+-->\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" \n+        xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" \n+        xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd\">\n+    <modelVersion>4.0.0</modelVersion>\n+    <groupId>org.spearce</groupId>\n+    <artifactId>jgit</artifactId>\n+    <packaging>jar</packaging>\n+    <version>0.4-SNAPSHOT</version>\n+    <name>jgit</name>\n+    <url>http://repo.or.cz/w/egit.git</url>\n+    <mailingLists>\n+        <mailingList>\n+            <name>GIT Mailing List</name>\n+            <post>git@vger.kernel.org</post>\n+            <archive>http://marc.info/?l=git</archive>\n+        </mailingList>\n+    </mailingLists>\n+    <description>Pure Java implementation of Git</description>\n+    <developers>\n+        <developer>\n+            <name>Shawn O. Pearce</name>\n+            <email>spearce@spearce.org</email>\n+            <roles>\n+                <role>Maintainer</role>\n+            </roles>\n+        </developer>\n+        <developer>\n+            <name>Robin Rosenberg</name>\n+            <email>robin.rosenberg@dewire.com</email>\n+            <roles>\n+                <role>Maintainer</role>\n+            </roles>\n+        </developer>\n+        <developer>\n+            <name>Dave Watson</name>\n+            <email>dwatson@mimvista.com</email>\n+            <roles>\n+                <role>Developer</role>\n+            </roles>\n+        </developer>\n+        <developer>\n+            <name>Roger C. Soares</name>\n+            <email>rogersoares@intelinet.com.br</email>\n+            <roles>\n+                <role>Developer</role>\n+            </roles>\n+\t</developer>\n+\t<developer>\n+            <name>Marek Zawirski</name>\n+            <email>marek.zawirski@gmail.com</email>\n+            <roles>\n+                <role>Developer</role>\n+            </roles>\n+        </developer>\n+        <developer>\n+            <name>Imran M Yousuf</name>\n+            <email>imyousuf@smartitengineering.com</email>\n+            <organization>Smart IT Engineering</organization>\n+            <roles>\n+                <role>Contributor</role>\n+            </roles>\n+        </developer>\n+    </developers>\n+    <licenses>\n+        <license>\n+            <name>3-clause (new-style) BSD license.</name>\n+            <comments>\n+                All rights reserved.\n+                Redistribution and use in source and binary forms, with or\n+                without modification, are permitted provided that the following\n+                conditions are met:\n+\n+                Redistributions of source code must retain the above copyright\n+                notice, this list of conditions and the following disclaimer.\n+\n+                Redistributions in binary form must reproduce the above\n+                copyright notice, this list of conditions and the following\n+                disclaimer in the documentation and/or other materials provided\n+                with the distribution.\n+\n+                Neither the name of the Git Development Community nor the\n+                names of its contributors may be used to endorse or promote\n+                products derived from this software without specific prior\n+                written permission.\n+\n+                THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND\n+                CONTRIBUTORS \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES,\n+                INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES\n+                OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+                ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR\n+                CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+                SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT\n+                NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;\n+                LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+                CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,\n+                STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+                ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF\n+                ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+            </comments>\n+        </license>\n+    </licenses>\n+    <build>\n+        <sourceDirectory>../../org.spearce.jgit/src/</sourceDirectory>\n+        <testResources>\n+            <testResource>\n+                <directory>../../org.spearce.jgit.test/tst-rsrc/</directory>\n+            </testResource>\n+        </testResources>\n+        <testSourceDirectory>../../org.spearce.jgit.test/tst/</testSourceDirectory>\n+        <plugins>\n+            <plugin>\n+                <artifactId>maven-compiler-plugin</artifactId>\n+                <version>2.0.2</version>\n+                <configuration>\n+                    <source>1.5</source>\n+                    <target>1.5</target>\n+                </configuration>\n+            </plugin>\n+        </plugins>\n+    </build>\n+    <dependencies>\n+        <dependency>\n+            <groupId>junit</groupId>\n+            <artifactId>junit</artifactId>\n+            <version>3.8.1</version>\n+            <scope>test</scope>\n+        </dependency>\n+        <dependency>\n+            <groupId>com.jcraft</groupId>\n+            <artifactId>jsch</artifactId>\n+            <version>0.1.38</version>\n+            <scope>compile</scope>\n+        </dependency>\n+    </dependencies>\n+</project>\n-- \n1.5.6\n"},{"id":"87930","messageId":"1219288394-1241-2-git-send-email-imyousuf@gmail.com","threadId":"15124","inReplyTo":"1219288394-1241-1-git-send-email-imyousuf@gmail.com","subject":"[JGit Patch v2 2/7] Add test resources to a new package structured directory","fromName":"","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-21T03:13:09Z","receivedAt":"2008-08-21T03:13:09Z","isPatch":true,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"From: Imran M Yousuf <imyousuf@smartitengineering.com>\n\nPreviously the test resources were read from a path in filesystem from now\non it wil be read from classpath and thus resources are added to a java\npackage structured directory.\n\nSigned-off-by: Imran M Yousuf <imyousuf@smartitengineering.com>\n---\n .../org/spearce/jgit/test/resources}/gitgit.index  |  Bin 134799 -> 134799 bytes\n .../spearce/jgit/test/resources}/gitgit.lsfiles    |    0 \n .../org/spearce/jgit/test/resources}/gitgit.lstree |    0 \n ...ck-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx |  Bin 1256 -> 1256 bytes\n ...-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2 |  Bin 1296 -> 1296 bytes\n ...k-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack |  Bin 7811 -> 7811 bytes\n ...ck-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.idx |  Bin 1088 -> 1088 bytes\n ...k-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.pack |  Bin 164 -> 164 bytes\n ...ck-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idx |  Bin 2696 -> 2696 bytes\n ...-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idxV2 |  Bin 2976 -> 2976 bytes\n ...k-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.pack |  Bin 5956 -> 5956 bytes\n ...ck-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.idx |  Bin 1112 -> 1112 bytes\n ...k-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.pack |  Bin 1643 -> 1643 bytes\n .../org/spearce/jgit/test/resources}/pack-huge.idx |  Bin 2368 -> 2368 bytes\n .../org/spearce/jgit/test/resources}/packed-refs   |    0 \n 15 files changed, 0 insertions(+), 0 deletions(-)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/gitgit.index (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/gitgit.lsfiles (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/gitgit.lstree (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2 (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.idx (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.pack (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idx (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idxV2 (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.pack (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.idx (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.pack (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/pack-huge.idx (100%)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/packed-refs (100%)\n\ndiff --git a/org.spearce.jgit.test/tst/gitgit.index b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/gitgit.index\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/gitgit.index\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/gitgit.index\ndiff --git a/org.spearce.jgit.test/tst/gitgit.lsfiles b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/gitgit.lsfiles\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/gitgit.lsfiles\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/gitgit.lsfiles\ndiff --git a/org.spearce.jgit.test/tst/gitgit.lstree b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/gitgit.lstree\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/gitgit.lstree\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/gitgit.lstree\ndiff --git a/org.spearce.jgit.test/tst/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx\ndiff --git a/org.spearce.jgit.test/tst/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2 b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2\ndiff --git a/org.spearce.jgit.test/tst/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack\ndiff --git a/org.spearce.jgit.test/tst/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.idx b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.idx\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.idx\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.idx\ndiff --git a/org.spearce.jgit.test/tst/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.pack b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.pack\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.pack\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745.pack\ndiff --git a/org.spearce.jgit.test/tst/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idx b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idx\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idx\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idx\ndiff --git a/org.spearce.jgit.test/tst/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idxV2 b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idxV2\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idxV2\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idxV2\ndiff --git a/org.spearce.jgit.test/tst/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.pack b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.pack\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.pack\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.pack\ndiff --git a/org.spearce.jgit.test/tst/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.idx b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.idx\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.idx\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.idx\ndiff --git a/org.spearce.jgit.test/tst/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.pack b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.pack\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.pack\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa.pack\ndiff --git a/org.spearce.jgit.test/tst/pack-huge.idx b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-huge.idx\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/pack-huge.idx\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/pack-huge.idx\ndiff --git a/org.spearce.jgit.test/tst/packed-refs b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/packed-refs\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/packed-refs\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/packed-refs\n-- \n1.5.6\n"},{"id":"87931","messageId":"1219288394-1241-3-git-send-email-imyousuf@gmail.com","threadId":"15124","inReplyTo":"1219288394-1241-2-git-send-email-imyousuf@gmail.com","subject":"[JGit Patch v2 3/7] Add test resources directory as a classpath entry","fromName":"","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-21T03:13:10Z","receivedAt":"2008-08-21T03:13:10Z","isPatch":true,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"From: Imran M Yousuf <imyousuf@smartitengineering.com>\n\nSince test resources will be required to be read from classpath thus adding\nrecord to Eclipse's .classpath setting file.\n\nSigned-off-by: Imran M Yousuf <imyousuf@smartitengineering.com>\n---\n org.spearce.jgit.test/.classpath |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/org.spearce.jgit.test/.classpath b/org.spearce.jgit.test/.classpath\nindex 592fa17..a276507 100644\n--- a/org.spearce.jgit.test/.classpath\n+++ b/org.spearce.jgit.test/.classpath\n@@ -1,6 +1,7 @@\n <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n <classpath>\n \t<classpathentry excluding=\"**/*.idx|**/*.pack\" kind=\"src\" path=\"tst\"/>\n+\t<classpathentry kind=\"src\" path=\"tst-rsrc\"/>\n \t<classpathentry kind=\"src\" path=\"exttst\"/>\n \t<classpathentry kind=\"con\" path=\"org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/J2SE-1.5\"/>\n \t<classpathentry combineaccessrules=\"false\" kind=\"src\" path=\"/org.spearce.jgit\"/>\n-- \n1.5.6\n"},{"id":"87933","messageId":"1219288394-1241-4-git-send-email-imyousuf@gmail.com","threadId":"15124","inReplyTo":"1219288394-1241-3-git-send-email-imyousuf@gmail.com","subject":"[JGit Patch v2 4/7] Use test resources from classpath","fromName":"","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-21T03:13:11Z","receivedAt":"2008-08-21T03:13:11Z","isPatch":true,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"From: Imran M Yousuf <imyousuf@smartitengineering.com>\n\nSearched and fixed usage of resources, all tests are now passing and using\nclasspath resources.\n\nA utility class for test classes are created. One of its operation turns\nclasspath resources to File and it is used by all test classes to locate\ntest resources.\n\nSigned-off-by: Imran M Yousuf <imyousuf@smartitengineering.com>\n---\n .../dircache/DirCacheCGitCompatabilityTest.java    |    3 +-\n .../tst/org/spearce/jgit/lib/PackIndexV1Test.java  |    9 +++--\n .../tst/org/spearce/jgit/lib/PackIndexV2Test.java  |    5 ++-\n .../org/spearce/jgit/lib/PackReverseIndexTest.java |    5 +--\n .../tst/org/spearce/jgit/lib/PackWriterTest.java   |    3 +-\n .../org/spearce/jgit/lib/RepositoryTestCase.java   |    7 ++--\n .../org/spearce/jgit/transport/IndexPackTest.java  |    6 ++--\n .../tst/org/spearce/jgit/util/JGitTestUtil.java    |   35 ++++++++++++-------\n 8 files changed, 43 insertions(+), 30 deletions(-)\n copy org.spearce.jgit/src/org/spearce/jgit/util/FS_POSIX_Java5.java => org.spearce.jgit.test/tst/org/spearce/jgit/util/JGitTestUtil.java (70%)\n\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/dircache/DirCacheCGitCompatabilityTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/dircache/DirCacheCGitCompatabilityTest.java\nindex 43b23f6..b052686 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/dircache/DirCacheCGitCompatabilityTest.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/dircache/DirCacheCGitCompatabilityTest.java\n@@ -50,6 +50,7 @@\n import org.spearce.jgit.lib.ObjectId;\n import org.spearce.jgit.lib.RepositoryTestCase;\n import org.spearce.jgit.treewalk.TreeWalk;\n+import org.spearce.jgit.util.JGitTestUtil;\n \n public class DirCacheCGitCompatabilityTest extends RepositoryTestCase {\n \tprivate final File index = pathOf(\"gitgit.index\");\n@@ -138,7 +139,7 @@ assertEquals(ObjectId\n \t}\n \n \tprivate File pathOf(final String name) {\n-\t\treturn new File(\"tst\", name);\n+\t\treturn JGitTestUtil.getTestResourceFile(name);\n \t}\n \n \tprivate Map<String, CGitIndexRecord> readLsFiles() throws Exception {\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackIndexV1Test.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackIndexV1Test.java\nindex 49235ca..645e054 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackIndexV1Test.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackIndexV1Test.java\n@@ -40,18 +40,19 @@\n import java.io.File;\n \n import org.spearce.jgit.errors.MissingObjectException;\n+import org.spearce.jgit.util.JGitTestUtil;\n \n public class PackIndexV1Test extends PackIndexTest {\n \t@Override\n \tpublic File getFileForPack34be9032() {\n-\t\treturn new File(new File(\"tst\"),\n-\t\t\t\t\"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx\");\n+\t\treturn JGitTestUtil.getTestResourceFile(\n+                    \"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx\");\n \t}\n \n \t@Override\n \tpublic File getFileForPackdf2982f28() {\n-\t\treturn new File(new File(\"tst\"),\n-\t\t\t\t\"pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idx\");\n+\t\treturn JGitTestUtil.getTestResourceFile(\n+                    \"pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idx\");\n \t}\n \n \t/**\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackIndexV2Test.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackIndexV2Test.java\nindex c986c49..d95937c 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackIndexV2Test.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackIndexV2Test.java\n@@ -40,17 +40,18 @@\n import java.io.File;\n \n import org.spearce.jgit.errors.MissingObjectException;\n+import org.spearce.jgit.util.JGitTestUtil;\n \n public class PackIndexV2Test extends PackIndexTest {\n \t@Override\n \tpublic File getFileForPack34be9032() {\n-\t\treturn new File(new File(\"tst\"),\n+\t\treturn JGitTestUtil.getTestResourceFile(\n \t\t\t\t\"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2\");\n \t}\n \n \t@Override\n \tpublic File getFileForPackdf2982f28() {\n-\t\treturn new File(new File(\"tst\"),\n+\t\treturn JGitTestUtil.getTestResourceFile(\n \t\t\t\t\"pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.idxV2\");\n \t}\n \ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackReverseIndexTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackReverseIndexTest.java\nindex 52d1282..c66818f 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackReverseIndexTest.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackReverseIndexTest.java\n@@ -37,10 +37,9 @@\n \n package org.spearce.jgit.lib;\n \n-import java.io.File;\n-\n import org.spearce.jgit.errors.CorruptObjectException;\n import org.spearce.jgit.lib.PackIndex.MutableEntry;\n+import org.spearce.jgit.util.JGitTestUtil;\n \n public class PackReverseIndexTest extends RepositoryTestCase {\n \n@@ -54,7 +53,7 @@\n \tpublic void setUp() throws Exception {\n \t\tsuper.setUp();\n \t\t// index with both small (< 2^31) and big offsets\n-\t\tidx = PackIndex.open(new File(new File(\"tst\"),\n+\t\tidx = PackIndex.open(JGitTestUtil.getTestResourceFile(\n \t\t\t\t\"pack-huge.idx\"));\n \t\treverseIdx = new PackReverseIndex(idx);\n \t}\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackWriterTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackWriterTest.java\nindex 4dd4b2a..87ec091 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackWriterTest.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/PackWriterTest.java\n@@ -57,6 +57,7 @@\n import org.spearce.jgit.revwalk.RevWalk;\n import org.spearce.jgit.transport.IndexPack;\n import org.spearce.jgit.util.CountingOutputStream;\n+import org.spearce.jgit.util.JGitTestUtil;\n \n public class PackWriterTest extends RepositoryTestCase {\n \n@@ -239,7 +240,7 @@ public void testWritePack2DeltasCRC32Copy() throws IOException {\n \t\t\t\t\"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack\");\n \t\tfinal File crc32Idx = new File(packDir,\n \t\t\t\t\"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idx\");\n-\t\tcopyFile(new File(new File(\"tst\"),\n+\t\tcopyFile(JGitTestUtil.getTestResourceFile(\n \t\t\t\t\"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2\"),\n \t\t\t\tcrc32Idx);\n \t\tdb.openPack(crc32Pack, crc32Idx);\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\nindex 14e7179..310690a 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n@@ -47,6 +47,7 @@\n import java.io.Reader;\n \n import junit.framework.TestCase;\n+import org.spearce.jgit.util.JGitTestUtil;\n \n public abstract class RepositoryTestCase extends TestCase {\n \n@@ -145,13 +146,13 @@ public void run() {\n \t\tfinal File tst = new File(\"tst\");\n \t\tfinal File packDir = new File(db.getObjectsDirectory(), \"pack\");\n \t\tfor (int k = 0; k < packs.length; k++) {\n-\t\t\tcopyFile(new File(tst, packs[k] + \".pack\"), new File(packDir,\n+\t\t\tcopyFile(JGitTestUtil.getTestResourceFile(packs[k] + \".pack\"), new File(packDir,\n \t\t\t\t\tpacks[k] + \".pack\"));\n-\t\t\tcopyFile(new File(tst, packs[k] + \".idx\"), new File(packDir,\n+\t\t\tcopyFile(JGitTestUtil.getTestResourceFile(packs[k] + \".idx\"), new File(packDir,\n \t\t\t\t\tpacks[k] + \".idx\"));\n \t\t}\n \n-\t\tcopyFile(new File(tst, \"packed-refs\"), new File(trash_git,\"packed-refs\"));\n+\t\tcopyFile(JGitTestUtil.getTestResourceFile(\"packed-refs\"), new File(trash_git,\"packed-refs\"));\n \n \t\tdb.scanForPacks();\n \t}\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/transport/IndexPackTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/transport/IndexPackTest.java\nindex ffa9142..46bd969 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/transport/IndexPackTest.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/transport/IndexPackTest.java\n@@ -47,7 +47,7 @@\n import org.spearce.jgit.lib.PackFile;\n import org.spearce.jgit.lib.RepositoryTestCase;\n import org.spearce.jgit.lib.TextProgressMonitor;\n-import org.spearce.jgit.transport.IndexPack;\n+import org.spearce.jgit.util.JGitTestUtil;\n \n /**\n  * Test indexing of git packs. A pack is read from a stream, copied\n@@ -63,7 +63,7 @@\n \t * @throws IOException\n \t */\n \tpublic void test1() throws  IOException {\n-\t\tFile packFile = new File(\"tst/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack\");\n+\t\tFile packFile = JGitTestUtil.getTestResourceFile(\"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.pack\");\n \t\tfinal InputStream is = new FileInputStream(packFile);\n \t\ttry {\n \t\t\tIndexPack pack = new IndexPack(db, is, new File(trash, \"tmp_pack1\"));\n@@ -89,7 +89,7 @@ public void test1() throws  IOException {\n \t * @throws IOException\n \t */\n \tpublic void test2() throws  IOException {\n-\t\tFile packFile = new File(\"tst/pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.pack\");\n+\t\tFile packFile = JGitTestUtil.getTestResourceFile(\"pack-df2982f284bbabb6bdb59ee3fcc6eb0983e20371.pack\");\n \t\tfinal InputStream is = new FileInputStream(packFile);\n \t\ttry {\n \t\t\tIndexPack pack = new IndexPack(db, is, new File(trash, \"tmp_pack2\"));\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/util/FS_POSIX_Java5.java b/org.spearce.jgit.test/tst/org/spearce/jgit/util/JGitTestUtil.java\nsimilarity index 70%\ncopy from org.spearce.jgit/src/org/spearce/jgit/util/FS_POSIX_Java5.java\ncopy to org.spearce.jgit.test/tst/org/spearce/jgit/util/JGitTestUtil.java\nindex d62b210..161ff78 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/util/FS_POSIX_Java5.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/util/JGitTestUtil.java\n@@ -1,5 +1,5 @@\n /*\n- * Copyright (C) 2008, Shawn O. Pearce <spearce@spearce.org>\n+ * Copyright (C) 2008, Imran M Yousuf <imyousuf@smartitengineering.com>\n  *\n  * All rights reserved.\n  *\n@@ -38,17 +38,26 @@\n package org.spearce.jgit.util;\n \n import java.io.File;\n+import java.net.URL;\n \n-class FS_POSIX_Java5 extends FS {\n-\tpublic boolean supportsExecute() {\n-\t\treturn false;\n-\t}\n-\n-\tpublic boolean canExecute(final File f) {\n-\t\treturn false;\n-\t}\n-\n-\tpublic boolean setExecute(final File f, final boolean canExec) {\n-\t\treturn false;\n-\t}\n+/**\n+ *\n+ * @author imyousuf\n+ */\n+public abstract class JGitTestUtil {\n+    public static final String CLASSPATH_TO_RESOURCES =\n+        \"/org/spearce/jgit/test/resources/\";\n+    private JGitTestUtil() {\n+        throw new AssertionError();\n+    }\n+    \n+    public static File getTestResourceFile(String fileName) {\n+        if(fileName == null || fileName.length() <= 0) {\n+            return null;\n+        }\n+        URL url = JGitTestUtil.class.getResource(\n+            new StringBuilder(CLASSPATH_TO_RESOURCES)\n+                .append(fileName).toString());\n+        return new File(url.getPath());\n+    }\n }\n-- \n1.5.6\n"},{"id":"87934","messageId":"1219288394-1241-5-git-send-email-imyousuf@gmail.com","threadId":"15124","inReplyTo":"1219288394-1241-4-git-send-email-imyousuf@gmail.com","subject":"[JGit Patch v2 5/7] Add script for adding second pack for test purpose","fromName":"","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-21T03:13:12Z","receivedAt":"2008-08-21T03:13:12Z","isPatch":true,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"From: Imran M Yousuf <imyousuf@smartitengineering.com>\n\nForgot to add it last time and thus adding it before removing duplicate\nresources.\n\nSigned-off-by: Imran M Yousuf <imyousuf@smartitengineering.com>\n---\n .../jgit/test/resources}/create-second-pack        |    0 \n 1 files changed, 0 insertions(+), 0 deletions(-)\n copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/create-second-pack (100%)\n\ndiff --git a/org.spearce.jgit.test/tst/create-second-pack b/org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/create-second-pack\nsimilarity index 100%\ncopy from org.spearce.jgit.test/tst/create-second-pack\ncopy to org.spearce.jgit.test/tst-rsrc/org/spearce/jgit/test/resources/create-second-pack\n-- \n1.5.6\n"},{"id":"87935","messageId":"1219288394-1241-7-git-send-email-imyousuf@gmail.com","threadId":"15124","inReplyTo":"1219288394-1241-6-git-send-email-imyousuf@gmail.com","subject":"[JGit Patch v2 7/7] Add ignore list for mavenized JGit","fromName":"","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-21T03:13:14Z","receivedAt":"2008-08-21T03:13:14Z","isPatch":true,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"From: Imran M Yousuf <imyousuf@smartitengineering.com>\n\nSigned-off-by: Imran M Yousuf <imyousuf@smartitengineering.com>\n---\n jgit-maven/.gitignore |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n create mode 100644 jgit-maven/.gitignore\n\ndiff --git a/jgit-maven/.gitignore b/jgit-maven/.gitignore\nnew file mode 100644\nindex 0000000..eb5a316\n--- /dev/null\n+++ b/jgit-maven/.gitignore\n@@ -0,0 +1 @@\n+target\n-- \n1.5.6\n"},{"id":"87996","messageId":"20080821151252.GS3483@spearce.org","threadId":"15124","inReplyTo":"1219288394-1241-5-git-send-email-imyousuf@gmail.com","subject":"Re: [JGit Patch v2 5/7] Add script for adding second pack for test purpose","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-21T15:12:52Z","receivedAt":"2008-08-21T15:12:52Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"imyousuf@gmail.com wrote:\n> From: Imran M Yousuf <imyousuf@smartitengineering.com>\n> \n> Forgot to add it last time and thus adding it before removing duplicate\n> resources.\n\nI would squash this to the one that copies the other resources.\n \n>  1 files changed, 0 insertions(+), 0 deletions(-)\n>  copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/create-second-pack (100%)\n\n-- \nShawn.\n"},{"id":"87997","messageId":"20080821151904.GT3483@spearce.org","threadId":"15124","inReplyTo":"1219288394-1241-4-git-send-email-imyousuf@gmail.com","subject":"Re: [JGit Patch v2 4/7] Use test resources from classpath","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-21T15:19:04Z","receivedAt":"2008-08-21T15:19:04Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"imyousuf@gmail.com wrote:\n> From: Imran M Yousuf <imyousuf@smartitengineering.com>\n> \n> Searched and fixed usage of resources, all tests are now passing and using\n> classpath resources.\n> \n> A utility class for test classes are created. One of its operation turns\n> classpath resources to File and it is used by all test classes to locate\n> test resources.\n\nI would change the way you do this series a little bit.\n\nStart the series with this patch, only have JGitTestUtil do:\n\n\treturn new File(\"test\", name);\n\nlike DirCacheCGitCompatabilityTest.pathOf does.  That way you\nhave the code replacement done in the first step, before you start\nmucking around with the resource locations.\n\nIn the 2nd patch, change JGitTestUtil to get resources from\nthe classpath, move (not copy) the resources, and add the\ntst-rsc directory to the Eclipse .classpath file.\n\nIn the 3rd patch, add your Maven POM file, including the .gitignore\nfor \"target\".\n\nThe tests will always work, and we don't get this weird copy-delete\npair on the resources.\n\n> +/**\n> + *\n> + * @author imyousuf\n> + */\n> +public abstract class JGitTestUtil {\n\nWe don't comment classes like this.  Either document it for real,\nor remove the Javadoc comment entirely.  In \"real\" documentation\nwe do not include @author tags.\n\n> +    public static final String CLASSPATH_TO_RESOURCES =\n> +        \"/org/spearce/jgit/test/resources/\";\n> +    private JGitTestUtil() {\n> +        throw new AssertionError();\n> +    }\n> +    \n> +    public static File getTestResourceFile(String fileName) {\n> +        if(fileName == null || fileName.length() <= 0) {\n\nFormatting error.  We put space between \"if(\".\n\n> +            return null;\n> +        }\n> +        URL url = JGitTestUtil.class.getResource(\n> +            new StringBuilder(CLASSPATH_TO_RESOURCES)\n> +                .append(fileName).toString());\n> +        return new File(url.getPath());\n> +    }\n>  }\n\n-- \nShawn.\n"},{"id":"88076","messageId":"9e85b2570808211952sa903434lacd575388ad2d2d8@mail.gmail.com","threadId":"15124","inReplyTo":"20080821151252.GS3483@spearce.org","subject":"Re: [JGit Patch v2 5/7] Add script for adding second pack for test purpose","fromName":"Imran M Yousuf","fromEmail":"imran@smartitengineering.com","sentAt":"2008-08-22T02:52:39Z","receivedAt":"2008-08-22T02:52:39Z","isPatch":true,"sender":{"key":"imran@smartitengineering.com","avatar":"https://gravatar.com/avatar/a9c5dcee49ab153a94c6fc26c5a1e6efe93261425b46f69ccfb8e0a151aa8a60?d=mp&s=160"},"body":"On Thu, Aug 21, 2008 at 9:12 PM, Shawn O. Pearce <spearce@spearce.org> wrote:\n> imyousuf@gmail.com wrote:\n>> From: Imran M Yousuf <imyousuf@smartitengineering.com>\n>>\n>> Forgot to add it last time and thus adding it before removing duplicate\n>> resources.\n>\n> I would squash this to the one that copies the other resources.\n\nHi Shawn,\n\nI would gladly make the changes (in this patch and the other ones) if\nI am sure that this series does not break the build with Eclipse. I\nwould be extremely grateful if you would please confirm this to me.\n\nBest regards,\n\nImran\n\n>\n>>  1 files changed, 0 insertions(+), 0 deletions(-)\n>>  copy org.spearce.jgit.test/{tst => tst-rsrc/org/spearce/jgit/test/resources}/create-second-pack (100%)\n>\n> --\n> Shawn.\n>\n\n\n\n-- \nImran M Yousuf\nEntrepreneur & Software Engineer\nSmart IT Engineering\nDhaka, Bangladesh\nEmail: imran@smartitengineering.com\nBlog: http://imyousuf-tech.blogs.smartitengineering.com/\nMobile: +880-1711402557\n"},{"id":"88153","messageId":"20080822160651.GI3483@spearce.org","threadId":"15124","inReplyTo":"9e85b2570808211952sa903434lacd575388ad2d2d8@mail.gmail.com","subject":"Re: [JGit Patch v2 5/7] Add script for adding second pack for test purpose","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-22T16:06:51Z","receivedAt":"2008-08-22T16:06:51Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Imran M Yousuf <imran@smartitengineering.com> wrote:\n> On Thu, Aug 21, 2008 at 9:12 PM, Shawn O. Pearce <spearce@spearce.org> wrote:\n> > imyousuf@gmail.com wrote:\n> >> From: Imran M Yousuf <imyousuf@smartitengineering.com>\n> >>\n> >> Forgot to add it last time and thus adding it before removing duplicate\n> >> resources.\n> >\n> > I would squash this to the one that copies the other resources.\n> \n> I would gladly make the changes (in this patch and the other ones) if\n> I am sure that this series does not break the build with Eclipse. I\n> would be extremely grateful if you would please confirm this to me.\n\nOK, so your series end result would be fine, if you squash this into\nit as well.  The \"tst\" variable is no longe rused in one location due\nto the introduction of JGitTestUtil, and you missed one location that\nneeded to be converted from \"tst\" to JGitTestUtil.  Otherwise the end\nresult looks good in Eclipse and in ./make_jgit.sh.\n\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\nindex 310690a..270b90a 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n@@ -143,7 +143,6 @@ public void run() {\n \t\t\t\t\"pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745\",\n \t\t\t\t\"pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa\"\n \t\t};\n-\t\tfinal File tst = new File(\"tst\");\n \t\tfinal File packDir = new File(db.getObjectsDirectory(), \"pack\");\n \t\tfor (int k = 0; k < packs.length; k++) {\n \t\t\tcopyFile(JGitTestUtil.getTestResourceFile(packs[k] + \".pack\"), new File(packDir,\ndiff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java\nindex c036e79..3d81bc4 100644\n--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java\n+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java\n@@ -41,9 +41,11 @@\n import java.io.File;\n import java.io.IOException;\n \n+import org.spearce.jgit.util.JGitTestUtil;\n+\n public class T0004_PackReader extends RepositoryTestCase {\n \tprivate static final String PACK_NAME = \"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f\";\n-\tprivate static final File TEST_PACK = new File(new File(\"tst\"), PACK_NAME + \".pack\");\n+\tprivate static final File TEST_PACK = JGitTestUtil.getTestResourceFile(PACK_NAME + \".pack\");\n \tprivate static final File TEST_IDX = new File(TEST_PACK.getParentFile(), PACK_NAME + \".idx\");\n \n \tpublic void test003_lookupCompressedObject() throws IOException {\n\n\n-- \nShawn.\n"},{"id":"88253","messageId":"9e85b2570808222221k64b95557hc1e808a925ac5a56@mail.gmail.com","threadId":"15124","inReplyTo":"20080822160651.GI3483@spearce.org","subject":"Re: [JGit Patch v2 5/7] Add script for adding second pack for test purpose","fromName":"Imran M Yousuf","fromEmail":"imran@smartitengineering.com","sentAt":"2008-08-23T05:21:51Z","receivedAt":"2008-08-23T05:21:51Z","isPatch":true,"sender":{"key":"imran@smartitengineering.com","avatar":"https://gravatar.com/avatar/a9c5dcee49ab153a94c6fc26c5a1e6efe93261425b46f69ccfb8e0a151aa8a60?d=mp&s=160"},"body":"On Fri, Aug 22, 2008 at 10:06 PM, Shawn O. Pearce <spearce@spearce.org> wrote:\n> Imran M Yousuf <imran@smartitengineering.com> wrote:\n>> On Thu, Aug 21, 2008 at 9:12 PM, Shawn O. Pearce <spearce@spearce.org> wrote:\n>> > imyousuf@gmail.com wrote:\n>> >> From: Imran M Yousuf <imyousuf@smartitengineering.com>\n>> >>\n>> >> Forgot to add it last time and thus adding it before removing duplicate\n>> >> resources.\n>> >\n>> > I would squash this to the one that copies the other resources.\n>>\n>> I would gladly make the changes (in this patch and the other ones) if\n>> I am sure that this series does not break the build with Eclipse. I\n>> would be extremely grateful if you would please confirm this to me.\n>\n> OK, so your series end result would be fine, if you squash this into\n> it as well.  The \"tst\" variable is no longe rused in one location due\n> to the introduction of JGitTestUtil, and you missed one location that\n> needed to be converted from \"tst\" to JGitTestUtil.  Otherwise the end\n> result looks good in Eclipse and in ./make_jgit.sh.\n\nThanks for the confirmation and additional change, for some reason it\nwas not failing thus I could not detect the case. I will now follow\nthe suggestions and will resubmit the patches on Mon/Tuesday.\n\n- Imran\n\n>\n> diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n> index 310690a..270b90a 100644\n> --- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n> +++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java\n> @@ -143,7 +143,6 @@ public void run() {\n>                                \"pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745\",\n>                                \"pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa\"\n>                };\n> -               final File tst = new File(\"tst\");\n>                final File packDir = new File(db.getObjectsDirectory(), \"pack\");\n>                for (int k = 0; k < packs.length; k++) {\n>                        copyFile(JGitTestUtil.getTestResourceFile(packs[k] + \".pack\"), new File(packDir,\n> diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java\n> index c036e79..3d81bc4 100644\n> --- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java\n> +++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java\n> @@ -41,9 +41,11 @@\n>  import java.io.File;\n>  import java.io.IOException;\n>\n> +import org.spearce.jgit.util.JGitTestUtil;\n> +\n>  public class T0004_PackReader extends RepositoryTestCase {\n>        private static final String PACK_NAME = \"pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f\";\n> -       private static final File TEST_PACK = new File(new File(\"tst\"), PACK_NAME + \".pack\");\n> +       private static final File TEST_PACK = JGitTestUtil.getTestResourceFile(PACK_NAME + \".pack\");\n>        private static final File TEST_IDX = new File(TEST_PACK.getParentFile(), PACK_NAME + \".idx\");\n>\n>        public void test003_lookupCompressedObject() throws IOException {\n>\n>\n> --\n> Shawn.\n>\n\n\n\n-- \nImran M Yousuf\nEntrepreneur & Software Engineer\nSmart IT Engineering\nDhaka, Bangladesh\nEmail: imran@smartitengineering.com\nBlog: http://imyousuf-tech.blogs.smartitengineering.com/\nMobile: +880-1711402557\n"}]}