{"thread":{"id":"15120","subject":"[PATCH] revision.h: make show_early_output an extern which is defined in revision.c","startedAt":"2008-08-21T00:34:30Z","lastAt":"2008-08-21T00:34:30Z","messageCount":1,"participants":["Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"87915","messageId":"tafnhasVGgid37Mhftl4QXLlge-grjM8UOkw0dHIRb0@cipher.nrlssc.navy.mil","threadId":"15120","inReplyTo":null,"subject":"[PATCH] revision.h: make show_early_output an extern which is defined in revision.c","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-08-21T00:34:30Z","receivedAt":"2008-08-21T00:34:30Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"\nThe variable show_early_output is defined in revision.c and should be\ndeclared extern in revision.h so that the linker does not complain\nabout multiply defined variables.\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n revision.h |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/revision.h b/revision.h\nindex f64e8ce..1b04566 100644\n--- a/revision.h\n+++ b/revision.h\n@@ -119,7 +119,7 @@ struct rev_info {\n void read_revisions_from_stdin(struct rev_info *revs);\n \n typedef void (*show_early_output_fn_t)(struct rev_info *, struct commit_list *);\n-volatile show_early_output_fn_t show_early_output;\n+extern volatile show_early_output_fn_t show_early_output;\n \n extern void init_revisions(struct rev_info *revs, const char *prefix);\n extern int setup_revisions(int argc, const char **argv, struct rev_info *revs, const char *def);\n-- \n1.6.0.13.ge1c8\n"}]}