{"thread":{"id":"15090","subject":"Stange diff in \"mailinfo: re-fix MIME multipart boundary parsing\"","startedAt":"2008-08-19T17:38:28Z","lastAt":"2008-08-20T13:10:11Z","messageCount":4,"participants":["Marco Costalba","Marcus Griep","Don Zickus"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"87717","messageId":"e5bfff550808191038u645cf4baldca5c2c4bbd02162@mail.gmail.com","threadId":"15090","inReplyTo":null,"subject":"Stange diff in \"mailinfo: re-fix MIME multipart boundary parsing\"","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-08-19T17:38:28Z","receivedAt":"2008-08-19T17:38:28Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Looking the diff at\n\nhttp://git.kernel.org/?p=git/git.git;a=commitdiff;h=289796dd29dd656734cfd59b657deb943a71cf6a\n\nthe part of the patch applied to /t/t5100/sample.mbox file seems very\nstrange, is it correct ?\n\nMarco\n"},{"id":"87718","messageId":"48AB0805.1020309@gmail.com","threadId":"15090","inReplyTo":"e5bfff550808191038u645cf4baldca5c2c4bbd02162@mail.gmail.com","subject":"Re: Stange diff in \"mailinfo: re-fix MIME multipart boundary parsing\"","fromName":"Marcus Griep","fromEmail":"neoeinstein@gmail.com","sentAt":"2008-08-19T17:51:01Z","receivedAt":"2008-08-19T17:51:01Z","isPatch":false,"sender":{"key":"neoeinstein@gmail.com","avatar":"https://gravatar.com/avatar/75d467077b37e56699d408fb97545e9a92a2907ff1feea4ba3a4b861f7cb7af4?d=mp&s=160"},"body":"Marco Costalba wrote:\n> Looking the diff at\n> \n> http://git.kernel.org/?p=git/git.git;a=commitdiff;h=289796dd29dd656734cfd59b657deb943a71cf6a\n> \n> the part of the patch applied to /t/t5100/sample.mbox file seems very\n> strange, is it correct ?\n\nIt looks like an empty line added to the end of the file.\nUnsanitary, but ok since it comes after the last MIME\nmultipart boundary.  Junio could probably just ax the change\nto sample.mbox from the patch before applying it.\n\n-- \nMarcus Griep\nGPG Key ID: 0x5E968152\n——\nhttp://www.boohaunt.net\nאת.ψο´\n\n"},{"id":"87721","messageId":"48AB0983.2050706@gmail.com","threadId":"15090","inReplyTo":"48AB0805.1020309@gmail.com","subject":"Re: Stange diff in \"mailinfo: re-fix MIME multipart boundary parsing\"","fromName":"Marcus Griep","fromEmail":"neoeinstein@gmail.com","sentAt":"2008-08-19T17:57:23Z","receivedAt":"2008-08-19T17:57:23Z","isPatch":false,"sender":{"key":"neoeinstein@gmail.com","avatar":"https://gravatar.com/avatar/75d467077b37e56699d408fb97545e9a92a2907ff1feea4ba3a4b861f7cb7af4?d=mp&s=160"},"body":"Marcus Griep wrote:\n> It looks like an empty line added to the end of the file.\n> Unsanitary, but ok since it comes after the last MIME\n> multipart boundary.  Junio could probably just ax the change\n> to sample.mbox from the patch before applying it.\n\nOr I could have misunderstood the intent of the change, and it\nis necessary to fully test the change, since it appears to\noperate line-by-line, an empty line at the end would be necessary\nto trigger the code path that stops mailinfo from looking for\nanother boundary.\n\n-- \nMarcus Griep\nGPG Key ID: 0x5E968152\n——\nhttp://www.boohaunt.net\nאת.ψο´\n\n"},{"id":"87819","messageId":"68948ca0808200610v6d81228fiabf0317ee4ae6ec5@mail.gmail.com","threadId":"15090","inReplyTo":"48AB0983.2050706@gmail.com","subject":"Re: Stange diff in \"mailinfo: re-fix MIME multipart boundary parsing\"","fromName":"Don Zickus","fromEmail":"dzickus@gmail.com","sentAt":"2008-08-20T13:10:11Z","receivedAt":"2008-08-20T13:10:11Z","isPatch":false,"sender":{"key":"dzickus@gmail.com","avatar":"https://gravatar.com/avatar/fbc96d0d5584c05dec11867b861650fe9f5d7d0ddec2655a1f90542fe07d9769?d=mp&s=160"},"body":"On Tue, Aug 19, 2008 at 1:57 PM, Marcus Griep <neoeinstein@gmail.com> wrote:\n> Marcus Griep wrote:\n>> It looks like an empty line added to the end of the file.\n>> Unsanitary, but ok since it comes after the last MIME\n>> multipart boundary.  Junio could probably just ax the change\n>> to sample.mbox from the patch before applying it.\n\nNo the change was intentional.  In fact, because that extra line was\nnot there, a bug was hidden.  Adding the extra line exposed the bug\nand hopefully will catch any more bugs in the future with regards to\nthe boundary code.\n\n>\n> Or I could have misunderstood the intent of the change, and it\n> is necessary to fully test the change, since it appears to\n> operate line-by-line, an empty line at the end would be necessary\n> to trigger the code path that stops mailinfo from looking for\n> another boundary.\n\nYes, exactly.\n\nCheers,\nDon\n"}]}