{"thread":{"id":"15045","subject":"[JGIT RFC] JGit mavenization done right","startedAt":"2008-08-17T04:52:16Z","lastAt":"2008-08-20T02:39:33Z","messageCount":6,"participants":["Imran M Yousuf","Shawn O. Pearce","Robin Rosenberg"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"87405","messageId":"7bfdc29a0808162152y4329303dte8f82bfea646180d@mail.gmail.com","threadId":"15045","inReplyTo":null,"subject":"[JGIT RFC] JGit mavenization done right","fromName":"Imran M Yousuf","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-17T04:52:16Z","receivedAt":"2008-08-17T04:52:16Z","isPatch":false,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"Hi,\n\nFirstly I would like to apologize for taking so long to get it right,\ncould not get enough time :(. As of now the mavenized version of jgit\nuses the same codebase and resources of that of the original JGit.\nWith modifications in resources location - previously resources were\nbeing read from the current working directory and now from classpath.\nMoved the location just to separate code and reources.\n\nI would like to request you all to test out JGit from\nhttp://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch\n'unified_tst_rsrc' and try to build it with both maven and Eclipse\n(i.e. as was built earlier) and please be kind enough to inform me if\nthe build fails. Please feel free to suggest any improvements you have\nin mind.\n\nIf it is okayed I will improve it further to configure various test\nreport and maven site plugin to host the summary of project.\n\nThank you and Best regards,\n\n-- \nImran M Yousuf\nEmail: imran@smartitengineering.com\nBlog: http://imyousuf-tech.blogs.smartitengineering.com/\nMobile: +880-1711402557\n"},{"id":"87517","messageId":"20080818055502.GE7376@spearce.org","threadId":"15045","inReplyTo":"7bfdc29a0808162152y4329303dte8f82bfea646180d@mail.gmail.com","subject":"Re: [JGIT RFC] JGit mavenization done right","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-18T05:55:02Z","receivedAt":"2008-08-18T05:55:02Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Imran M Yousuf <imyousuf@gmail.com> wrote:\n> I would like to request you all to test out JGit from\n> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch\n> 'unified_tst_rsrc' and try to build it with both maven and Eclipse\n> (i.e. as was built earlier) and please be kind enough to inform me if\n> the build fails. Please feel free to suggest any improvements you have\n> in mind.\n\nThanks, I'll take a look at it tomorrow or the day after.\n\nI am looking forward to making JGit more available to the Java\ncommunity, so support under Maven is welcome, even if Maven isn't\nthe project's (current) primary build tool.\n \n-- \nShawn.\n"},{"id":"87519","messageId":"7bfdc29a0808172333g1cbe2102n6e76ae98a1943411@mail.gmail.com","threadId":"15045","inReplyTo":"20080818055502.GE7376@spearce.org","subject":"Re: [JGIT RFC] JGit mavenization done right","fromName":"Imran M Yousuf","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-18T06:33:29Z","receivedAt":"2008-08-18T06:33:29Z","isPatch":false,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:\n> Imran M Yousuf <imyousuf@gmail.com> wrote:\n>> I would like to request you all to test out JGit from\n>> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch\n>> 'unified_tst_rsrc' and try to build it with both maven and Eclipse\n>> (i.e. as was built earlier) and please be kind enough to inform me if\n>> the build fails. Please feel free to suggest any improvements you have\n>> in mind.\n>\n> Thanks, I'll take a look at it tomorrow or the day after.\n\nThanks, it would nice to know whether it works in the original build\nprocess or not :).\n\n>\n> I am looking forward to making JGit more available to the Java\n> community, so support under Maven is welcome, even if Maven isn't\n> the project's (current) primary build tool.\n\nOnce this is out of the way I will add configuration to make the\nsource code and other project related information to be allowed to be\npublished online from maven POM file using the 'site' plugin.\n\nAdditionally I also want to add configuration to build a distribution\nfor JGit PGM project.\n\n>\n> --\n> Shawn.\n\nBest regards,\n\n-- \nImran M Yousuf\nEmail: imran@smartitengineering.com\nBlog: http://imyousuf-tech.blogs.smartitengineering.com/\nMobile: +880-1711402557\n"},{"id":"87699","messageId":"20080819144424.GC20947@spearce.org","threadId":"15045","inReplyTo":"7bfdc29a0808172333g1cbe2102n6e76ae98a1943411@mail.gmail.com","subject":"Re: [JGIT RFC] JGit mavenization done right","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-19T14:44:24Z","receivedAt":"2008-08-19T14:44:24Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Imran M Yousuf <imyousuf@gmail.com> wrote:\n> On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:\n> > Imran M Yousuf <imyousuf@gmail.com> wrote:\n> >> I would like to request you all to test out JGit from\n> >> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch\n> >> 'unified_tst_rsrc' and try to build it with both maven and Eclipse\n> >> (i.e. as was built earlier)\n> \n> Thanks, it would nice to know whether it works in the original build\n> process or not :).\n\nWell, it did break it in Eclipse:\n\n$ git diff-tree --abbrev -r -M --diff-filter=D orcz-pub/master HEAD\n:100644 000000 9d7d138... 0000000... D  org.spearce.jgit.test/.gitignore\n:100644 000000 987d6be... 0000000... D  org.spearce.jgit.test/.project\n:100644 000000 8bfa5f1... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n:100644 000000 fce94cf... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.ui.prefs\n:100644 000000 304e861... 0000000... D  org.spearce.jgit/.classpath\n:100644 000000 ba077a4... 0000000... D  org.spearce.jgit/.gitignore\n:100644 000000 7d38455... 0000000... D  org.spearce.jgit/.project\n:100644 000000 709a440... 0000000... D  org.spearce.jgit/.settings/org.eclipse.jdt.ui.prefs\n\nRemoving this stuff was not so good.  The Eclipse projects are\nbusted and can't be used anymore.  We need them back.\n\nThe make_jgit.sh however seems to produce a valid JAR.  Given the\nfile-level differences I didn't expect it to fail.\n\nAlso, I wonder if JGitTestUtil is better handled by placing the\nmethod in RepositoryTestCase and making sure everyone subclasses\nthat if they need a test resource file?  I'm fairly certain they\nalready do, and its a lot easier to invoke a method you inherited\nthan one in another class.  (Well, easier for the guy writing the\ntest case anyway, Java obviously doesn't care either way.)\n\nIf we are going to take this in upstream I'd like a flattened/cleaned\nup history.  Being able to bisect the misstep of using symlinks\n(the old Maven approach) isn't very valuable in the long-term view\nof the history.\n\nRobin, any thoughts?\n \n-- \nShawn.\n"},{"id":"87748","messageId":"200808192152.55267.robin.rosenberg.lists@dewire.com","threadId":"15045","inReplyTo":"20080819144424.GC20947@spearce.org","subject":"Re: [JGIT RFC] JGit mavenization done right","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2008-08-19T19:52:55Z","receivedAt":"2008-08-19T19:52:55Z","isPatch":false,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"tisdagen den 19 augusti 2008 16.44.24 skrev Shawn O. Pearce:\n> Imran M Yousuf <imyousuf@gmail.com> wrote:\n> > On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:\n> > > Imran M Yousuf <imyousuf@gmail.com> wrote:\n> > >> I would like to request you all to test out JGit from\n> > >> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch\n> > >> 'unified_tst_rsrc' and try to build it with both maven and Eclipse\n> > >> (i.e. as was built earlier)\n> > \n> > Thanks, it would nice to know whether it works in the original build\n> > process or not :).\n> \n> Well, it did break it in Eclipse:\n> \n> $ git diff-tree --abbrev -r -M --diff-filter=D orcz-pub/master HEAD\n> :100644 000000 9d7d138... 0000000... D  org.spearce.jgit.test/.gitignore\n> :100644 000000 987d6be... 0000000... D  org.spearce.jgit.test/.project\n> :100644 000000 8bfa5f1... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n> :100644 000000 fce94cf... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.ui.prefs\n> :100644 000000 304e861... 0000000... D  org.spearce.jgit/.classpath\n> :100644 000000 ba077a4... 0000000... D  org.spearce.jgit/.gitignore\n> :100644 000000 7d38455... 0000000... D  org.spearce.jgit/.project\n> :100644 000000 709a440... 0000000... D  org.spearce.jgit/.settings/org.eclipse.jdt.ui.prefs\n> \n> Removing this stuff was not so good.  The Eclipse projects are\n> busted and can't be used anymore.  We need them back.\n> \n> The make_jgit.sh however seems to produce a valid JAR.  Given the\n> file-level differences I didn't expect it to fail.\n> \n> Also, I wonder if JGitTestUtil is better handled by placing the\n> method in RepositoryTestCase and making sure everyone subclasses\n> that if they need a test resource file?  I'm fairly certain they\n> already do, and its a lot easier to invoke a method you inherited\n> than one in another class.  (Well, easier for the guy writing the\n> test case anyway, Java obviously doesn't care either way.)\n> \n> If we are going to take this in upstream I'd like a flattened/cleaned\n> up history.  Being able to bisect the misstep of using symlinks\n> (the old Maven approach) isn't very valuable in the long-term view\n> of the history.\n> \n> Robin, any thoughts?\n\nRight, I'd also like to see that cleaned up approch in patch form. Cleaning up\nhelps when preparing for review because one usually find bad stuff during\nthat process.\n\n-- robin\n"},{"id":"87785","messageId":"7bfdc29a0808191939u2a060883o6a0047dc2caaa4fb@mail.gmail.com","threadId":"15045","inReplyTo":"200808192152.55267.robin.rosenberg.lists@dewire.com","subject":"Re: [JGIT RFC] JGit mavenization done right","fromName":"Imran M Yousuf","fromEmail":"imyousuf@gmail.com","sentAt":"2008-08-20T02:39:33Z","receivedAt":"2008-08-20T02:39:33Z","isPatch":false,"sender":{"key":"imyousuf@gmail.com","avatar":"https://gravatar.com/avatar/fda3c870262849d03c7b9c4d288842e128d6d80769fa7bc2d22731b7597928be?d=mp&s=160"},"body":"On Wed, Aug 20, 2008 at 1:52 AM, Robin Rosenberg\n<robin.rosenberg.lists@dewire.com> wrote:\n> tisdagen den 19 augusti 2008 16.44.24 skrev Shawn O. Pearce:\n>> Imran M Yousuf <imyousuf@gmail.com> wrote:\n>> > On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:\n>> > > Imran M Yousuf <imyousuf@gmail.com> wrote:\n>> > >> I would like to request you all to test out JGit from\n>> > >> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch\n>> > >> 'unified_tst_rsrc' and try to build it with both maven and Eclipse\n>> > >> (i.e. as was built earlier)\n>> >\n>> > Thanks, it would nice to know whether it works in the original build\n>> > process or not :).\n>>\n>> Well, it did break it in Eclipse:\n>>\n>> $ git diff-tree --abbrev -r -M --diff-filter=D orcz-pub/master HEAD\n>> :100644 000000 9d7d138... 0000000... D  org.spearce.jgit.test/.gitignore\n>> :100644 000000 987d6be... 0000000... D  org.spearce.jgit.test/.project\n>> :100644 000000 8bfa5f1... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n>> :100644 000000 fce94cf... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.ui.prefs\n>> :100644 000000 304e861... 0000000... D  org.spearce.jgit/.classpath\n>> :100644 000000 ba077a4... 0000000... D  org.spearce.jgit/.gitignore\n>> :100644 000000 7d38455... 0000000... D  org.spearce.jgit/.project\n>> :100644 000000 709a440... 0000000... D  org.spearce.jgit/.settings/org.eclipse.jdt.ui.prefs\n>>\n>> Removing this stuff was not so good.  The Eclipse projects are\n>> busted and can't be used anymore.  We need them back.\n>>\n>> The make_jgit.sh however seems to produce a valid JAR.  Given the\n>> file-level differences I didn't expect it to fail.\n>>\n>> Also, I wonder if JGitTestUtil is better handled by placing the\n>> method in RepositoryTestCase and making sure everyone subclasses\n>> that if they need a test resource file?  I'm fairly certain they\n>> already do, and its a lot easier to invoke a method you inherited\n>> than one in another class.  (Well, easier for the guy writing the\n>> test case anyway, Java obviously doesn't care either way.)\n\nIn a true OOP sense a util class seemed a more valid approach to me. I\nusually prefer to inherit staffs that are actually part of the object,\nwhat I can do is have a base class method invoking the util, that will\nnot harm me :).\n\n>>\n>> If we are going to take this in upstream I'd like a flattened/cleaned\n>> up history.  Being able to bisect the misstep of using symlinks\n>> (the old Maven approach) isn't very valuable in the long-term view\n>> of the history.\n>>\n>> Robin, any thoughts?\n>\n> Right, I'd also like to see that cleaned up approch in patch form. Cleaning up\n> helps when preparing for review because one usually find bad stuff during\n> that process.\n\nI agree with the cleaned up approach I will redo it afresh by tonight\nor day after tomorrow and create patches and resubmit it.\n\nThanks,\n\nImran\n\n>\n> -- robin\n>\n\n\n\n-- \nImran M Yousuf\nEntrepreneur & Software Engineer\nSmart IT Engineering\nDhaka, Bangladesh\nEmail: imran@smartitengineering.com\nBlog: http://imyousuf-tech.blogs.smartitengineering.com/\nMobile: +880-1711402557\n"}]}