{"thread":{"id":"15016","subject":"[JGIT PATCH] Paper bag fix 'jgit glog' handling of commit-ish arguments","startedAt":"2008-08-14T23:26:03Z","lastAt":"2008-08-14T23:26:03Z","messageCount":1,"participants":["Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"87272","messageId":"1218756363-27702-1-git-send-email-spearce@spearce.org","threadId":"15016","inReplyTo":null,"subject":"[JGIT PATCH] Paper bag fix 'jgit glog' handling of commit-ish arguments","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-14T23:26:03Z","receivedAt":"2008-08-14T23:26:03Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"When we parsed these arguments into RevCommit instances they were\ndone against the wrong RevWalk instance.  We parsed them into a\ngeneric RevWalk which has no plotting support, so the objects do\nnot have the extra fields used by the plotting code.  We need to\nlookup the commit from the PlotRevWalk and use those instances.\n\nOne of the calls (markStart) failed to use the secondary RevWalk\ninstance, resulting in a ClassCastException during plotting.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n .../org/spearce/jgit/pgm/RevWalkTextBuiltin.java   |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java\nindex 97fe7a4..338af40 100644\n--- a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java\n+++ b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java\n@@ -152,7 +152,7 @@ abstract class RevWalkTextBuiltin extends TextBuiltin {\n \t\t\tif (c.has(RevFlag.UNINTERESTING))\n \t\t\t\twalk.markUninteresting(real);\n \t\t\telse\n-\t\t\t\twalk.markStart(c);\n+\t\t\t\twalk.markStart(real);\n \t\t}\n \n \t\tfinal long start = System.currentTimeMillis();\n-- \n1.6.0.rc3.250.g8dd0\n"}]}