{"thread":{"id":"14960","subject":"TOPGIT: [PATCH] Use standard prefix and DESTDIR rather than explain","startedAt":"2008-08-12T12:54:30Z","lastAt":"2008-08-13T07:04:49Z","messageCount":3,"participants":["Jan Nieuwenhuizen","Bert Wesarg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"86929","messageId":"1218545670.7264.2.camel@heerbeest","threadId":"14960","inReplyTo":null,"subject":"TOPGIT: [PATCH] Use standard prefix and DESTDIR rather than explain","fromName":"Jan Nieuwenhuizen","fromEmail":"janneke-list@xs4all.nl","sentAt":"2008-08-12T12:54:30Z","receivedAt":"2008-08-12T12:54:30Z","isPatch":true,"sender":{"key":"janneke-list@xs4all.nl","avatar":null},"body":"First an install nitpick.\n\n\n\nSigned-off-by: Jan Nieuwenhuizen <janneke@gnu.org>\n---\n Makefile |   26 +++++++++++++-------------\n 1 files changed, 13 insertions(+), 13 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 6eade1e..ea6489e 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1,8 +1,7 @@\n-# Set PREFIX to wherever you want to install TopGit\n-PREFIX = $(HOME)\n-bindir = $(PREFIX)/bin\n-cmddir = $(PREFIX)/libexec/topgit\n-sharedir = $(PREFIX)/share/topgit\n+prefix = $(HOME)\n+bindir = $(prefix)/bin\n+cmddir = $(prefix)/libexec/topgit\n+sharedir = $(prefix)/share/topgit\n hooksdir = $(cmddir)/hooks\n \n \n@@ -31,14 +30,15 @@ $(help_out): README\n \t./create-help.sh $$CMD\n \n install:: all\n-\tinstall -d -m 755 \"$(bindir)\"\n-\tinstall tg \"$(bindir)\"\n-\tinstall -d -m 755 \"$(cmddir)\"\n-\tinstall $(commands_out) \"$(cmddir)\"\n-\tinstall -d -m 755 \"$(hooksdir)\"\n-\tinstall $(hooks_out) \"$(hooksdir)\"\n-\tinstall -d -m 755 \"$(sharedir)\"\n-\tinstall -m 644 $(help_out) \"$(sharedir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(bindir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(bindir)\"\n+\tinstall tg \"$(DESTDIR)$(bindir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(cmddir)\"\n+\tinstall $(commands_out) \"$(DESTDIR)$(cmddir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(hooksdir)\"\n+\tinstall $(hooks_out) \"$(DESTDIR)$(hooksdir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(sharedir)\"\n+\tinstall -m 644 $(help_out) \"$(DESTDIR)$(sharedir)\"\n \n clean::\n \trm -f tg $(commands_out) $(hooks_out) $(help_out)\n-- \n1.6.0.rc0.44.g67270\n\n\n-- \nJan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter\nhttp://www.xs4all.nl/~jantien       | http://www.lilypond.org\n"},{"id":"86944","messageId":"36ca99e90808120934h6d86a7cbpeca8a6c85ba3bce2@mail.gmail.com","threadId":"14960","inReplyTo":"1218545670.7264.2.camel@heerbeest","subject":"Re: TOPGIT: [PATCH] Use standard prefix and DESTDIR rather than explain","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-08-12T16:34:34Z","receivedAt":"2008-08-12T16:34:34Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"On Tue, Aug 12, 2008 at 14:54, Jan Nieuwenhuizen <janneke-list@xs4all.nl> wrote:\n> First an install nitpick.\n>\n>\n>\n> Signed-off-by: Jan Nieuwenhuizen <janneke@gnu.org>\n> ---\n>  Makefile |   26 +++++++++++++-------------\n>  1 files changed, 13 insertions(+), 13 deletions(-)\n>\n> diff --git a/Makefile b/Makefile\n> index 6eade1e..ea6489e 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1,8 +1,7 @@\n> -# Set PREFIX to wherever you want to install TopGit\n> -PREFIX = $(HOME)\n> -bindir = $(PREFIX)/bin\n> -cmddir = $(PREFIX)/libexec/topgit\n> -sharedir = $(PREFIX)/share/topgit\n> +prefix = $(HOME)\n> +bindir = $(prefix)/bin\n> +cmddir = $(prefix)/libexec/topgit\n> +sharedir = $(prefix)/share/topgit\n>  hooksdir = $(cmddir)/hooks\n>\n>\n> @@ -31,14 +30,15 @@ $(help_out): README\n>        ./create-help.sh $$CMD\n>\n>  install:: all\n> -       install -d -m 755 \"$(bindir)\"\n> -       install tg \"$(bindir)\"\n> -       install -d -m 755 \"$(cmddir)\"\n> -       install $(commands_out) \"$(cmddir)\"\n> -       install -d -m 755 \"$(hooksdir)\"\n> -       install $(hooks_out) \"$(hooksdir)\"\n> -       install -d -m 755 \"$(sharedir)\"\n> -       install -m 644 $(help_out) \"$(sharedir)\"\n\n> +       install -d -m 755 \"$(DESTDIR)$(bindir)\"\n> +       install -d -m 755 \"$(DESTDIR)$(bindir)\"\nduplicate\n\nBert\n> +       install tg \"$(DESTDIR)$(bindir)\"\n> +       install -d -m 755 \"$(DESTDIR)$(cmddir)\"\n> +       install $(commands_out) \"$(DESTDIR)$(cmddir)\"\n> +       install -d -m 755 \"$(DESTDIR)$(hooksdir)\"\n> +       install $(hooks_out) \"$(DESTDIR)$(hooksdir)\"\n> +       install -d -m 755 \"$(DESTDIR)$(sharedir)\"\n> +       install -m 644 $(help_out) \"$(DESTDIR)$(sharedir)\"\n>\n>  clean::\n>        rm -f tg $(commands_out) $(hooks_out) $(help_out)\n> --\n> 1.6.0.rc0.44.g67270\n>\n>\n> --\n> Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter\n> http://www.xs4all.nl/~jantien       | http://www.lilypond.org\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n>\n"},{"id":"87036","messageId":"1218611089.7561.11.camel@heerbeest","threadId":"14960","inReplyTo":"36ca99e90808120934h6d86a7cbpeca8a6c85ba3bce2@mail.gmail.com","subject":"Re: TOPGIT: [PATCH] Use standard prefix and DESTDIR rather than explain","fromName":"Jan Nieuwenhuizen","fromEmail":"janneke-list@xs4all.nl","sentAt":"2008-08-13T07:04:49Z","receivedAt":"2008-08-13T07:04:49Z","isPatch":true,"sender":{"key":"janneke-list@xs4all.nl","avatar":null},"body":"On di, 2008-08-12 at 18:34 +0200, Bert Wesarg wrote:\n\n> On Tue, Aug 12, 2008 at 14:54, Jan Nieuwenhuizen <janneke-list@xs4all.nl> wrote:\n> > First an install nitpick.\n> > +       install -d -m 755 \"$(DESTDIR)$(bindir)\"\n> > +       install -d -m 755 \"$(DESTDIR)$(bindir)\"\n> duplicate\n\nNow I see: we both fixed that.  I did not see the merge conflict, should\nhave looked better.  New try:\n\n[Why is it so difficult for a SCM to detect such duplicates?  Of course,\nonce in a 1000 years you'd want two identical lines, but wouldn't it be\nnice if by default git would help you would not to mess up]\n\nSigned-off-by: Jan Nieuwenhuizen <janneke@gnu.org>\n---\n Makefile |   25 ++++++++++++-------------\n 1 files changed, 12 insertions(+), 13 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 6eade1e..af46399 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1,8 +1,7 @@\n-# Set PREFIX to wherever you want to install TopGit\n-PREFIX = $(HOME)\n-bindir = $(PREFIX)/bin\n-cmddir = $(PREFIX)/libexec/topgit\n-sharedir = $(PREFIX)/share/topgit\n+prefix = $(HOME)\n+bindir = $(prefix)/bin\n+cmddir = $(prefix)/libexec/topgit\n+sharedir = $(prefix)/share/topgit\n hooksdir = $(cmddir)/hooks\n \n \n@@ -31,14 +30,14 @@ $(help_out): README\n \t./create-help.sh $$CMD\n \n install:: all\n-\tinstall -d -m 755 \"$(bindir)\"\n-\tinstall tg \"$(bindir)\"\n-\tinstall -d -m 755 \"$(cmddir)\"\n-\tinstall $(commands_out) \"$(cmddir)\"\n-\tinstall -d -m 755 \"$(hooksdir)\"\n-\tinstall $(hooks_out) \"$(hooksdir)\"\n-\tinstall -d -m 755 \"$(sharedir)\"\n-\tinstall -m 644 $(help_out) \"$(sharedir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(bindir)\"\n+\tinstall tg \"$(DESTDIR)$(bindir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(cmddir)\"\n+\tinstall $(commands_out) \"$(DESTDIR)$(cmddir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(hooksdir)\"\n+\tinstall $(hooks_out) \"$(DESTDIR)$(hooksdir)\"\n+\tinstall -d -m 755 \"$(DESTDIR)$(sharedir)\"\n+\tinstall -m 644 $(help_out) \"$(DESTDIR)$(sharedir)\"\n \n clean::\n \trm -f tg $(commands_out) $(hooks_out) $(help_out)\n-- \n1.6.0.rc0.44.g67270\n\n\n\n-- \nJan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter\nhttp://www.xs4all.nl/~jantien       | http://www.lilypond.org\n"}]}