{"thread":{"id":"14947","subject":"[PATCH] Add \"extern\" qualifier to function declarations in header files","startedAt":"2008-08-11T23:32:19Z","lastAt":"2008-08-11T23:32:19Z","messageCount":1,"participants":["Stephan Beyer"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"86855","messageId":"1218497539-9545-1-git-send-email-s-beyer@gmx.net","threadId":"14947","inReplyTo":null,"subject":"[PATCH] Add \"extern\" qualifier to function declarations in header files","fromName":"Stephan Beyer","fromEmail":"s-beyer@gmx.net","sentAt":"2008-08-11T23:32:19Z","receivedAt":"2008-08-11T23:32:19Z","isPatch":true,"sender":{"key":"s-beyer@gmx.net","avatar":"https://avatars.githubusercontent.com/u/143889?v=4"},"body":"This patch prepends \"extern \" to function declarations in\nall header files in the root source directory.\n\nLines that were longer then 80 characters, are kept this way.\nDeclarations with more than 80 characters that were stretched\nover several lines, are reindented if the indentation followed\nsome logic.\n\nSigned-off-by: Stephan Beyer <s-beyer@gmx.net>\n---\nHi,\n\nJunio wrote in <7vod3zuqpv.fsf@gitster.siamese.dyndns.org>:\n> > Is this a mistake that some forward declarations in header files are not\n> > declared \"extern\"?\n> \n> Yup, that looks old fashioned.\n\nOk, so I changed this, though I think it's not really useful because it's\nreally only cosmetic.  (But I needed some very simple task to bring me down\nto make me go to bed now.) ;-)\n\nThe patch itself is 53kiB, so it's not inline-attached, but can be found\non\n\thttp://pkqs.net/~sbeyer/tmp/extern.patch\nor the commit can be fetched from\n\tgit://repo.or.cz/git/sbeyer.git extern\n\nI've grepped through *.h and it seems that no function declaration is left\nwithout either \"static inline\" or \"extern\" now.\n\n attr.h            |    4 +-\n blob.h            |    6 ++--\n branch.h          |    7 +++--\n bundle.h          |   14 +++++-----\n cache-tree.h      |   18 ++++++------\n cache.h           |   50 ++++++++++++++++++------------------\n color.h           |   10 +++---\n commit.h          |   72 ++++++++++++++++++++++++++--------------------------\n diff.h            |    2 +-\n diffcore.h        |    6 ++--\n fetch-pack.h      |    2 +-\n fsck.h            |    6 ++--\n git-compat-util.h |    8 +++---\n graph.h           |   24 +++++++++---------\n list-objects.h    |    4 +-\n ll-merge.h        |   12 ++++----\n log-tree.h        |   20 +++++++-------\n mailmap.h         |    4 +-\n merge-recursive.h |   26 +++++++++---------\n object.h          |   24 +++++++++---------\n pack-refs.h       |    2 +-\n pack-revindex.h   |    2 +-\n patch-ids.h       |    8 +++---\n pkt-line.h        |    8 +++---\n progress.h        |   16 ++++++-----\n quote.h           |    4 +-\n refs.h            |    4 +-\n remote.h          |   51 ++++++++++++++++++++-----------------\n revision.h        |    2 +-\n run-command.h     |   16 ++++++------\n send-pack.h       |    6 ++--\n shortlog.h        |    6 ++--\n sideband.h        |    4 +-\n string-list.h     |   16 ++++++------\n transport.h       |   19 +++++++------\n tree-walk.h       |   12 ++++----\n tree.h            |    8 +++---\n unpack-trees.h    |   10 +++---\n utf8.h            |   12 ++++----\n walker.h          |   15 ++++++-----\n wt-status.h       |    6 ++--\n xdiff-interface.h |   14 +++++-----\n 42 files changed, 284 insertions(+), 276 deletions(-)\n"}]}