{"thread":{"id":"14899","subject":"[PATCH] builtin-rm: Add a --force flag","startedAt":"2008-08-08T22:37:02Z","lastAt":"2008-08-09T01:21:58Z","messageCount":6,"participants":["Pieter de Bie","Junio C Hamano","Todd Zullinger","Jeff King","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"86553","messageId":"1218235022-33695-1-git-send-email-pdebie@ai.rug.nl","threadId":"14899","inReplyTo":null,"subject":"[PATCH] builtin-rm: Add a --force flag","fromName":"Pieter de Bie","fromEmail":"pdebie@ai.rug.nl","sentAt":"2008-08-08T22:37:02Z","receivedAt":"2008-08-08T22:37:02Z","isPatch":true,"sender":{"key":"pdebie@ai.rug.nl","avatar":null},"body":"This adds a --force flag to git-rm, making it somewhat easier for\nsubversion people to switch.\n\nSigned-off-by: Pieter de Bie \n---\n\n I heard some people complain about how they try \"svn rm -f\" or \"git rm\n --force\", which both fail. We can help them a bit by supporting --force too.\n\n builtin-rm.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-rm.c b/builtin-rm.c\nindex ee8247b..4c9f483 100644\n--- a/builtin-rm.c\n+++ b/builtin-rm.c\n@@ -131,7 +131,7 @@ static struct option builtin_rm_options[] = {\n \tOPT__DRY_RUN(&show_only),\n \tOPT__QUIET(&quiet),\n \tOPT_BOOLEAN( 0 , \"cached\", &index_only, \"only remove from the index\"),\n-\tOPT_BOOLEAN('f', NULL, &force, \"override the up-to-date check\"),\n+\tOPT_BOOLEAN('f', \"force\", &force, \"override the up-to-date check\"),\n \tOPT_BOOLEAN('r', NULL, &recursive, \"allow recursive removal\"),\n \tOPT_BOOLEAN( 0 , \"ignore-unmatch\", &ignore_unmatch,\n \t\t\t\t\"exit with a zero status even if nothing matched\"),\n-- \n1.6.0.rc1.288.g5b89f\n"},{"id":"86557","messageId":"7v8wv7az0z.fsf@gitster.siamese.dyndns.org","threadId":"14899","inReplyTo":"1218235022-33695-1-git-send-email-pdebie@ai.rug.nl","subject":"Re: [PATCH] builtin-rm: Add a --force flag","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-08-08T23:05:16Z","receivedAt":"2008-08-08T23:05:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I think this makes sense even this late in -rc cycle. Thanks.\n"},{"id":"86559","messageId":"20080808234134.GH5655@inocybe.teonanacatl.org","threadId":"14899","inReplyTo":"7v8wv7az0z.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] bash completion: git rm has grown a --force option","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2008-08-08T23:41:34Z","receivedAt":"2008-08-08T23:41:34Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Signed-off-by: Todd Zullinger \n---\n\nJunio C Hamano wrote:\n> I think this makes sense even this late in -rc cycle. Thanks.\n\nPerhaps this is worth adding as well then, since Lee went to the\ntrouble of adding completion for git rm just the other day? ;)\n\n contrib/completion/git-completion.bash | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 3396e35..2d0e468 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1361,7 +1361,7 @@ _git_rm ()\n \tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n \tcase \"$cur\" in\n \t--*)\n-\t\t__gitcomp \"--cached --dry-run --ignore-unmatch --quiet\"\n+\t\t__gitcomp \"--cached --dry-run --force --ignore-unmatch --quiet\"\n \t\treturn\n \t\t;;\n \tesac\n-- \n1.6.0.rc2\n\n-- \nTodd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nIn some cultures what I do would be considered normal.\n"},{"id":"86561","messageId":"20080809000536.GB6065@sigill.intra.peff.net","threadId":"14899","inReplyTo":"7v8wv7az0z.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] builtin-rm: Add a --force flag","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-08-09T00:05:36Z","receivedAt":"2008-08-09T00:05:36Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Aug 08, 2008 at 04:05:16PM -0700, Junio C Hamano wrote:\n\n> I think this makes sense even this late in -rc cycle. Thanks.\n\nMaybe squash this in?\n\n-Peff\n\ndiff --git a/Documentation/git-rm.txt b/Documentation/git-rm.txt\nindex 4d0c495..0aaf161 100644\n--- a/Documentation/git-rm.txt\n+++ b/Documentation/git-rm.txt\n@@ -36,6 +36,7 @@ OPTIONS\n \tbut this requires the `-r` option to be explicitly given.\n \n -f::\n+--force::\n \tOverride the up-to-date check.\n \n -n::\n"},{"id":"86567","messageId":"20080809010713.GF7299@neumann","threadId":"14899","inReplyTo":"20080808234134.GH5655@inocybe.teonanacatl.org","subject":"Re: [PATCH] bash completion: git rm has grown a --force option","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2008-08-09T01:07:35Z","receivedAt":"2008-08-09T01:07:35Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Hi,\n\nOn Fri, Aug 08, 2008 at 07:41:34PM -0400, Todd Zullinger wrote:\n> Perhaps this is worth adding as well then, since Lee went to the\n> trouble of adding completion for git rm just the other day? ;)\nI disagree here. '--force' is an option that should be used with\ncare, therefore facilitating its usage by completion support is not a\ngood idea IMHO. This is also the status quo: while there are many\ngit commands with a '--force' option, we do not complete any of them.\n\nRegards,\nGábor\n"},{"id":"86570","messageId":"20080809012158.GI5655@inocybe.teonanacatl.org","threadId":"14899","inReplyTo":"20080809010713.GF7299@neumann","subject":"Re: [PATCH] bash completion: git rm has grown a --force option","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2008-08-09T01:21:58Z","receivedAt":"2008-08-09T01:21:58Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"SZEDER Gábor wrote:\n> I disagree here. '--force' is an option that should be used with\n> care, therefore facilitating its usage by completion support is not\n> a good idea IMHO. This is also the status quo: while there are\n> many git commands with a '--force' option, we do not complete any of\n> them.\n\nYes, my apologies for missing that point. It is a good one.\n\n-- \nTodd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nA word to the wise ain't necessary -- it's the stupid ones who need\nthe advice.\n -- Bill Cosby\n\n"}]}