{"thread":{"id":"14847","subject":"Re: [TopGit PATCH 2/2] tg-create.sh: Introduce topgit.subjectprefix config option","startedAt":"2008-08-05T19:13:29Z","lastAt":"2008-08-06T05:10:08Z","messageCount":5,"participants":["Petr Baudis","Bert Wesarg"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"299059","messageId":"1217963610-15195-1-git-send-email-bert.wesarg@googlemail.com","threadId":"14847","inReplyTo":null,"subject":"[TopGit PATCH 1/2] Fix generated Subject: line in .topmsg","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-08-05T19:13:29Z","receivedAt":"2008-08-05T19:13:29Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"$1 is unset after parsing all arguments, so use $name instead.\n\nSigned-off-by: Bert Wesarg \n\n---\n tg-create.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/tg-create.sh b/tg-create.sh\nindex d196e4f..0bf329c 100644\n--- a/tg-create.sh\n+++ b/tg-create.sh\n@@ -107,7 +107,7 @@ author_addr=\"${author%> *}>\"\n \t! header=\"$(git config topgit.to)\" || echo \"To: $header\"\n \t! header=\"$(git config topgit.cc)\" || echo \"Cc: $header\"\n \t! header=\"$(git config topgit.bcc)\" || echo \"Bcc: $header\"\n-\techo \"Subject: [PATCH] $1\"\n+\techo \"Subject: [PATCH] $name\"\n \techo\n \tcat <\n-- \ntg: (24367cc..) t/fix-subject-line-in-.topmsg (depends on: master)\n"},{"id":"299060","messageId":"1217963610-15195-2-git-send-email-bert.wesarg@googlemail.com","threadId":"14847","inReplyTo":"1217963610-15195-1-git-send-email-bert.wesarg@googlemail.com","subject":"[TopGit PATCH 2/2] tg-create.sh: Introduce topgit.subjectprefix config option","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-08-05T19:13:30Z","receivedAt":"2008-08-05T19:13:30Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"Set the topgit.subjectprefix config option to prepend the string to the [PATCH]\nfield in the Subject: line of the '.topmsg' file.\n\nSigned-off-by: Bert Wesarg \n\n---\n README | 7 ++++---\n tg-create.sh | 3 ++-\n 2 files changed, 6 insertions(+), 4 deletions(-)\n\ndiff --git a/README b/README\nindex bd4f17a..f821bab 100644\n--- a/README\n+++ b/README\n@@ -204,9 +204,10 @@ tg create\n \n \tAfter `tg create`, you should insert the patch description\n \tto the '.topmsg' file, which will already contain some\n-\tpre-filled bits. You can set topgit.to, topgit.cc and topgit.bcc\n-\tconfiguration variables in order to have `tg create`\n-\tadd these headers with given default values to '.topmsg'.\n+\tpre-filled bits. You can set topgit.subjectprefix, topgit.to,\n+\ttopgit.cc and topgit.bcc configuration variables in order to\n+\thave `tg create` use this subject prefix and add these headers\n+\twith the given default values to '.topmsg', respectively.\n \n \tThe main task of `tg create` is to set up the topic branch\n \tbase from the dependencies. This may fail due to merge conflicts.\ndiff --git a/tg-create.sh b/tg-create.sh\nindex 0bf329c..c2b38bf 100644\n--- a/tg-create.sh\n+++ b/tg-create.sh\n@@ -107,7 +107,8 @@ author_addr=\"${author%> *}>\"\n \t! header=\"$(git config topgit.to)\" || echo \"To: $header\"\n \t! header=\"$(git config topgit.cc)\" || echo \"Cc: $header\"\n \t! header=\"$(git config topgit.bcc)\" || echo \"Bcc: $header\"\n-\techo \"Subject: [PATCH] $name\"\n+\tsubject_prefix=\"$(git config topgit.subjectprefix)\" && subject_prefix=\"$subject_prefix \"\n+\techo \"Subject: [${subject_prefix}PATCH] $name\"\n \techo\n \tcat <\n-- \ntg: (2fc069d..) t/subject-prefix (depends on: t/fix-subject-line-in-.topmsg)\n"},{"id":"86298","messageId":"20080805221837.GU10151@machine.or.cz","threadId":"14847","inReplyTo":"1217963610-15195-2-git-send-email-bert.wesarg@googlemail.com","subject":"Re: [TopGit PATCH 2/2] tg-create.sh: Introduce topgit.subjectprefix config option","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2008-08-05T22:18:37Z","receivedAt":"2008-08-05T22:18:37Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":" Hi,\n\nOn Tue, Aug 05, 2008 at 09:13:30PM +0200, Bert Wesarg wrote:\n> Set the topgit.subjectprefix config option to prepend the string to the [PATCH]\n> field in the Subject: line of the '.topmsg' file.\n> \n> Signed-off-by: Bert Wesarg \n\n hmm, the patch does not apply as-is because $1 -> $name got changed in\nt/fix-subject-line-in-.topmsg which you didn't submit (I *instantly*\nknew adding the depends line to the patch will be good idea ;-).\n\n Actually, the line was always meant to be just empty, but putting the\npatch name there does no harm. I will change that.\n\n> ---\n> README | 7 ++++---\n> tg-create.sh | 3 ++-\n> 2 files changed, 6 insertions(+), 4 deletions(-)\n> \n> diff --git a/README b/README\n> index bd4f17a..f821bab 100644\n> --- a/README\n> +++ b/README\n> @@ -204,9 +204,10 @@ tg create\n> \n> \tAfter `tg create`, you should insert the patch description\n> \tto the '.topmsg' file, which will already contain some\n> -\tpre-filled bits. You can set topgit.to, topgit.cc and topgit.bcc\n> -\tconfiguration variables in order to have `tg create`\n> -\tadd these headers with given default values to '.topmsg'.\n> +\tpre-filled bits. You can set topgit.subjectprefix, topgit.to,\n> +\ttopgit.cc and topgit.bcc configuration variables in order to\n> +\thave `tg create` use this subject prefix and add these headers\n> +\twith the given default values to '.topmsg', respectively.\n> \n> \tThe main task of `tg create` is to set up the topic branch\n> \tbase from the dependencies. This may fail due to merge conflicts.\n> diff --git a/tg-create.sh b/tg-create.sh\n> index 0bf329c..c2b38bf 100644\n> --- a/tg-create.sh\n> +++ b/tg-create.sh\n> @@ -107,7 +107,8 @@ author_addr=\"${author%> *}>\"\n> \t! header=\"$(git config topgit.to)\" || echo \"To: $header\"\n> \t! header=\"$(git config topgit.cc)\" || echo \"Cc: $header\"\n> \t! header=\"$(git config topgit.bcc)\" || echo \"Bcc: $header\"\n> -\techo \"Subject: [PATCH] $name\"\n> +\tsubject_prefix=\"$(git config topgit.subjectprefix)\" && subject_prefix=\"$subject_prefix \"\n> +\techo \"Subject: [${subject_prefix}PATCH] $name\"\n> \techo\n> \tcat < \n\n I have converted this to the ||-form since that's much clearer with\nset -e.\n\n Thanks,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nThe next generation of interesting software will be done\non the Macintosh, not the IBM PC. -- Bill Gates\n"},{"id":"86314","messageId":"36ca99e90808052208p31889debgd7b468db2c34892@mail.gmail.com","threadId":"14847","inReplyTo":"20080805233930.GA1249@toroid.org","subject":"Re: [TopGit PATCH 2/2] tg-create.sh: Introduce topgit.subjectprefix config option","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-08-06T05:08:57Z","receivedAt":"2008-08-06T05:08:57Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"On Wed, Aug 6, 2008 at 01:39, Abhijit Menon-Sen wrote:\n> Hi Bert.\n>\n> I'm wondering how you managed to get two To: fields in your patch mail.\n> Is it a git-send-email bug, or did you do something special?\nYeah, I noticed this too, I have a To: line in the mail file, formated\nfrom tg patch, and than send it with git-send-mail with an --to\noption. without this option git-send-mail has asked me for the\nrecipient.\n\nAny help would be appreciate.\n\nThanks\nBert\n\n>\n> -- ams\n>\n"},{"id":"86315","messageId":"36ca99e90808052210y109e1321j319f531141112f96@mail.gmail.com","threadId":"14847","inReplyTo":"1217963610-15195-1-git-send-email-bert.wesarg@googlemail.com","subject":"Re: [TopGit PATCH 1/2] Fix generated Subject: line in .topmsg","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2008-08-06T05:10:08Z","receivedAt":"2008-08-06T05:10:08Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"Just a resend, because Petr didn't get this mail.\n\nBert\n\nOn Tue, Aug 5, 2008 at 21:13, Bert Wesarg wrote:\n> $1 is unset after parsing all arguments, so use $name instead.\n>\n> Signed-off-by: Bert Wesarg \n>\n> ---\n> tg-create.sh | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/tg-create.sh b/tg-create.sh\n> index d196e4f..0bf329c 100644\n> --- a/tg-create.sh\n> +++ b/tg-create.sh\n> @@ -107,7 +107,7 @@ author_addr=\"${author%> *}>\"\n> ! header=\"$(git config topgit.to)\" || echo \"To: $header\"\n> ! header=\"$(git config topgit.cc)\" || echo \"Cc: $header\"\n> ! header=\"$(git config topgit.bcc)\" || echo \"Bcc: $header\"\n> - echo \"Subject: [PATCH] $1\"\n> + echo \"Subject: [PATCH] $name\"\n> echo\n> cat < \n> --\n> tg: (24367cc..) t/fix-subject-line-in-.topmsg (depends on: master)\n>\n"}]}