{"thread":{"id":"14836","subject":"[PATCH 1/8] bash completion: Add completion for 'git clone'","startedAt":"2008-08-05T05:50:30Z","lastAt":"2008-08-06T15:47:10Z","messageCount":13,"participants":["Lee Marlow","Shawn O. Pearce","Junio C Hamano","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":8},"messages":[{"id":"86253","messageId":"1217915438-6838-1-git-send-email-lee.marlow@gmail.com","threadId":"14836","inReplyTo":null,"subject":"[PATCH 0/8] bash completion: more porcelain completions","fromName":"Lee Marlow","fromEmail":"lee.marlow@gmail.com","sentAt":"2008-08-05T05:50:30Z","receivedAt":"2008-08-05T05:50:30Z","isPatch":true,"sender":{"key":"lee.marlow@gmail.com","avatar":"https://gravatar.com/avatar/231170f3c8456cf1af984d30d09f35c5509b5f81494c81fa69dc7a1027473fc0?d=mp&s=160"},"body":"This adds basic long option completion for some common commands that I\nuse, as well as stash name completion.\n\nLee Marlow (8):\n  bash completion: Add completion for 'git clone'\n  bash completion: Add completion for 'git clean'\n  bash completion: Add completion for 'git init'\n  bash completion: Add completion for 'git revert'\n  bash completion: More completions for 'git stash'\n  bash completion: Add completion for 'git archive'\n  bash completion: Add completion for 'git ls-files'\n  bash completion: Add completion for 'git mv'\n\n contrib/completion/git-completion.bash |  143 +++++++++++++++++++++++++++++++-\n git-stash.sh                           |    2 +-\n 2 files changed, 143 insertions(+), 2 deletions(-)\n"},{"id":"86252","messageId":"1217915438-6838-2-git-send-email-lee.marlow@gmail.com","threadId":"14836","inReplyTo":"1217915438-6838-1-git-send-email-lee.marlow@gmail.com","subject":"[PATCH 1/8] bash completion: Add completion for 'git clone'","fromName":"Lee Marlow","fromEmail":"lee.marlow@gmail.com","sentAt":"2008-08-05T05:50:31Z","receivedAt":"2008-08-05T05:50:31Z","isPatch":true,"sender":{"key":"lee.marlow@gmail.com","avatar":"https://gravatar.com/avatar/231170f3c8456cf1af984d30d09f35c5509b5f81494c81fa69dc7a1027473fc0?d=mp&s=160"},"body":"Added completions for all long options specified in the docs\n\t--local --no-hardlinks --shared --reference\n\t--quiet --no-checkout --bare --mirror --origin\n\t--upload-pack --template= --depth\n\nSigned-off-by: Lee Marlow <lee.marlow@gmail.com>\n---\n contrib/completion/git-completion.bash |   26 ++++++++++++++++++++++++++\n 1 files changed, 26 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 678a155..6ffe259 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -667,6 +667,31 @@ _git_cherry_pick ()\n \tesac\n }\n \n+_git_clone ()\n+{\n+\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+\tcase \"$cur\" in\n+\t--*)\n+\t\t__gitcomp \"\n+\t\t\t--local\n+\t\t\t--no-hardlinks\n+\t\t\t--shared\n+\t\t\t--reference\n+\t\t\t--quiet\n+\t\t\t--no-checkout\n+\t\t\t--bare\n+\t\t\t--mirror\n+\t\t\t--origin\n+\t\t\t--upload-pack\n+\t\t\t--template=\n+\t\t\t--depth\n+\t\t\t\"\n+\t\treturn\n+\t\t;;\n+\tesac\n+\tCOMPREPLY=()\n+}\n+\n _git_commit ()\n {\n \t__git_has_doubledash && return\n@@ -1475,6 +1500,7 @@ _git ()\n \tcheckout)    _git_checkout ;;\n \tcherry)      _git_cherry ;;\n \tcherry-pick) _git_cherry_pick ;;\n+\tclone)       _git_clone ;;\n \tcommit)      _git_commit ;;\n \tconfig)      _git_config ;;\n \tdescribe)    _git_describe ;;\n-- \n1.6.0.rc1.48.g2b6032\n"},{"id":"86254","messageId":"1217915438-6838-3-git-send-email-lee.marlow@gmail.com","threadId":"14836","inReplyTo":"1217915438-6838-2-git-send-email-lee.marlow@gmail.com","subject":"[PATCH 2/8] bash completion: Add completion for 'git clean'","fromName":"Lee Marlow","fromEmail":"lee.marlow@gmail.com","sentAt":"2008-08-05T05:50:32Z","receivedAt":"2008-08-05T05:50:32Z","isPatch":true,"sender":{"key":"lee.marlow@gmail.com","avatar":"https://gravatar.com/avatar/231170f3c8456cf1af984d30d09f35c5509b5f81494c81fa69dc7a1027473fc0?d=mp&s=160"},"body":"Added completions for all long options specified in the docs\n        --dry-run --quiet\n\nSigned-off-by: Lee Marlow <lee.marlow@gmail.com>\n---\n contrib/completion/git-completion.bash |   15 +++++++++++++++\n 1 files changed, 15 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 6ffe259..72be4f1 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -667,6 +667,20 @@ _git_cherry_pick ()\n \tesac\n }\n \n+_git_clean ()\n+{\n+\t__git_has_doubledash && return\n+\n+\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+\tcase \"$cur\" in\n+\t--*)\n+\t\t__gitcomp \"--dry-run --quiet\"\n+\t\treturn\n+\t\t;;\n+\tesac\n+\tCOMPREPLY=()\n+}\n+\n _git_clone ()\n {\n \tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n@@ -1500,6 +1514,7 @@ _git ()\n \tcheckout)    _git_checkout ;;\n \tcherry)      _git_cherry ;;\n \tcherry-pick) _git_cherry_pick ;;\n+\tclean)       _git_clean ;;\n \tclone)       _git_clone ;;\n \tcommit)      _git_commit ;;\n \tconfig)      _git_config ;;\n-- \n1.6.0.rc1.48.g2b6032\n"},{"id":"86257","messageId":"1217915438-6838-4-git-send-email-lee.marlow@gmail.com","threadId":"14836","inReplyTo":"1217915438-6838-3-git-send-email-lee.marlow@gmail.com","subject":"[PATCH 3/8] bash completion: Add completion for 'git init'","fromName":"Lee Marlow","fromEmail":"lee.marlow@gmail.com","sentAt":"2008-08-05T05:50:33Z","receivedAt":"2008-08-05T05:50:33Z","isPatch":true,"sender":{"key":"lee.marlow@gmail.com","avatar":"https://gravatar.com/avatar/231170f3c8456cf1af984d30d09f35c5509b5f81494c81fa69dc7a1027473fc0?d=mp&s=160"},"body":"Added completions for all long options specified in the docs\n        --quiet --bare --template= --shared\n        --shared={false|true|umask|group|all|world|everybody}\n\nSigned-off-by: Lee Marlow <lee.marlow@gmail.com>\n---\n contrib/completion/git-completion.bash |   19 +++++++++++++++++++\n 1 files changed, 19 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 72be4f1..c7a6d92 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -842,6 +842,24 @@ _git_help ()\n \t__gitcomp \"$(__git_all_commands)\"\n }\n \n+_git_init ()\n+{\n+\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+\tcase \"$cur\" in\n+\t--shared=*)\n+\t\t__gitcomp \"\n+\t\t\tfalse true umask group all world everybody\n+\t\t\t\" \"\" \"${cur##--shared=}\"\n+\t\treturn\n+\t\t;;\n+\t--*)\n+\t\t__gitcomp \"--quiet --bare --template= --shared --shared=\"\n+\t\treturn\n+\t\t;;\n+\tesac\n+\tCOMPREPLY=()\n+}\n+\n _git_ls_remote ()\n {\n \t__gitcomp \"$(__git_remotes)\"\n@@ -1524,6 +1542,7 @@ _git ()\n \tformat-patch) _git_format_patch ;;\n \tgc)          _git_gc ;;\n \thelp)        _git_help ;;\n+\tinit)        _git_init ;;\n \tlog)         _git_log ;;\n \tls-remote)   _git_ls_remote ;;\n \tls-tree)     _git_ls_tree ;;\n-- \n1.6.0.rc1.48.g2b6032\n"},{"id":"86258","messageId":"1217915438-6838-5-git-send-email-lee.marlow@gmail.com","threadId":"14836","inReplyTo":"1217915438-6838-4-git-send-email-lee.marlow@gmail.com","subject":"[PATCH 4/8] bash completion: Add completion for 'git revert'","fromName":"Lee Marlow","fromEmail":"lee.marlow@gmail.com","sentAt":"2008-08-05T05:50:34Z","receivedAt":"2008-08-05T05:50:34Z","isPatch":true,"sender":{"key":"lee.marlow@gmail.com","avatar":"https://gravatar.com/avatar/231170f3c8456cf1af984d30d09f35c5509b5f81494c81fa69dc7a1027473fc0?d=mp&s=160"},"body":"Added completions for all long options specified in the docs\n        --edit --mainline --no-edit --no-commit --signoff\n\nSigned-off-by: Lee Marlow <lee.marlow@gmail.com>\n---\n contrib/completion/git-completion.bash |   13 +++++++++++++\n 1 files changed, 13 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex c7a6d92..6a5c4cd 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1264,6 +1264,18 @@ _git_reset ()\n \t__gitcomp \"$(__git_refs)\"\n }\n \n+_git_revert ()\n+{\n+\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+\tcase \"$cur\" in\n+\t--*)\n+\t\t__gitcomp \"--edit --mainline --no-edit --no-commit --signoff\"\n+\t\treturn\n+\t\t;;\n+\tesac\n+\tCOMPREPLY=()\n+}\n+\n _git_rm ()\n {\n \t__git_has_doubledash && return\n@@ -1554,6 +1566,7 @@ _git ()\n \trebase)      _git_rebase ;;\n \tremote)      _git_remote ;;\n \treset)       _git_reset ;;\n+\trevert)      _git_revert ;;\n \trm)          _git_rm ;;\n \tsend-email)  _git_send_email ;;\n \tshortlog)    _git_shortlog ;;\n-- \n1.6.0.rc1.48.g2b6032\n"},{"id":"86255","messageId":"1217915438-6838-6-git-send-email-lee.marlow@gmail.com","threadId":"14836","inReplyTo":"1217915438-6838-5-git-send-email-lee.marlow@gmail.com","subject":"[PATCH 5/8] bash completion: More completions for 'git stash'","fromName":"Lee Marlow","fromEmail":"lee.marlow@gmail.com","sentAt":"2008-08-05T05:50:35Z","receivedAt":"2008-08-05T05:50:35Z","isPatch":true,"sender":{"key":"lee.marlow@gmail.com","avatar":"https://gravatar.com/avatar/231170f3c8456cf1af984d30d09f35c5509b5f81494c81fa69dc7a1027473fc0?d=mp&s=160"},"body":"Add branch subcommand to completions and USAGE for git-stash.sh.\nComplete stash names for show, apply, drop, pop, and branch.\nAdd \"--index\" long option for apply.\n\nSigned-off-by: Lee Marlow <lee.marlow@gmail.com>\n---\n contrib/completion/git-completion.bash |   12 +++++++++++-\n git-stash.sh                           |    2 +-\n 2 files changed, 12 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 6a5c4cd..a292cbd 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1348,7 +1348,7 @@ _git_show_branch ()\n \n _git_stash ()\n {\n-\tlocal subcommands='save list show apply clear drop pop create'\n+\tlocal subcommands='save list show apply clear drop pop create branch'\n \tlocal subcommand=\"$(__git_find_subcommand \"$subcommands\")\"\n \tif [ -z \"$subcommand\" ]; then\n \t\t__gitcomp \"$subcommands\"\n@@ -1358,6 +1358,16 @@ _git_stash ()\n \t\tsave,--*)\n \t\t\t__gitcomp \"--keep-index\"\n \t\t\t;;\n+\t\tapply,--*)\n+\t\t\t__gitcomp \"--index\"\n+\t\t\t;;\n+\t\tshow,--*|apply,--*|drop,--*|pop,--*|branch,--*)\n+\t\t\tCOMPREPLY=()\n+\t\t\t;;\n+\t\tshow,*|apply,*|drop,*|pop,*|branch,*)\n+\t\t\t__gitcomp \"$(git --git-dir=\"$(__gitdir)\" stash list \\\n+\t\t\t\t\t| sed -n -e 's/:.*//p')\"\n+\t\t\t;;\n \t\t*)\n \t\t\tCOMPREPLY=()\n \t\t\t;;\ndiff --git a/git-stash.sh b/git-stash.sh\nindex d4609ed..5ad2c4b 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -1,7 +1,7 @@\n #!/bin/sh\n # Copyright (c) 2007, Nanako Shiraishi\n \n-USAGE='[  | save | list | show | apply | clear | drop | pop | create ]'\n+USAGE='[  | save | list | show | apply | clear | drop | pop | create | branch ]'\n \n SUBDIRECTORY_OK=Yes\n OPTIONS_SPEC=\n-- \n1.6.0.rc1.48.g2b6032\n"},{"id":"86256","messageId":"1217915438-6838-7-git-send-email-lee.marlow@gmail.com","threadId":"14836","inReplyTo":"1217915438-6838-6-git-send-email-lee.marlow@gmail.com","subject":"[PATCH 6/8] bash completion: Add completion for 'git archive'","fromName":"Lee Marlow","fromEmail":"lee.marlow@gmail.com","sentAt":"2008-08-05T05:50:36Z","receivedAt":"2008-08-05T05:50:36Z","isPatch":true,"sender":{"key":"lee.marlow@gmail.com","avatar":"https://gravatar.com/avatar/231170f3c8456cf1af984d30d09f35c5509b5f81494c81fa69dc7a1027473fc0?d=mp&s=160"},"body":"Added completions for all long options specified in the docs\n\t--format= --list --verbose\n\t--prefix= --remote= --exec=\nThe --format= long option can be completed with available formats\nand the --remote= can be completed with defined remote repositories.\n\nSigned-off-by: Lee Marlow <lee.marlow@gmail.com>\n---\n contrib/completion/git-completion.bash |   24 ++++++++++++++++++++++++\n 1 files changed, 24 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex a292cbd..61ea6d9 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -561,6 +561,29 @@ _git_add ()\n \tCOMPREPLY=()\n }\n \n+_git_archive ()\n+{\n+\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+\tcase \"$cur\" in\n+\t--format=*)\n+\t\t__gitcomp \"$(git archive --list)\" \"\" \"${cur##--format=}\"\n+\t\treturn\n+\t\t;;\n+\t--remote=*)\n+\t\t__gitcomp \"$(__git_remotes)\" \"\" \"${cur##--remote=}\"\n+\t\treturn\n+\t\t;;\n+\t--*)\n+\t\t__gitcomp \"\n+\t\t\t--format= --list --verbose\n+\t\t\t--prefix= --remote= --exec=\n+\t\t\t\"\n+\t\treturn\n+\t\t;;\n+\tesac\n+\t__git_complete_file\n+}\n+\n _git_bisect ()\n {\n \t__git_has_doubledash && return\n@@ -1548,6 +1571,7 @@ _git ()\n \tam)          _git_am ;;\n \tadd)         _git_add ;;\n \tapply)       _git_apply ;;\n+\tarchive)     _git_archive ;;\n \tbisect)      _git_bisect ;;\n \tbundle)      _git_bundle ;;\n \tbranch)      _git_branch ;;\n-- \n1.6.0.rc1.48.g2b6032\n"},{"id":"86259","messageId":"1217915438-6838-8-git-send-email-lee.marlow@gmail.com","threadId":"14836","inReplyTo":"1217915438-6838-7-git-send-email-lee.marlow@gmail.com","subject":"[PATCH 7/8] bash completion: Add completion for 'git ls-files'","fromName":"Lee Marlow","fromEmail":"lee.marlow@gmail.com","sentAt":"2008-08-05T05:50:37Z","receivedAt":"2008-08-05T05:50:37Z","isPatch":true,"sender":{"key":"lee.marlow@gmail.com","avatar":"https://gravatar.com/avatar/231170f3c8456cf1af984d30d09f35c5509b5f81494c81fa69dc7a1027473fc0?d=mp&s=160"},"body":"Added completions for all long options specified in the docs\n\t--cached --deleted --modified --others --ignored\n\t--stage --directory --no-empty-directory --unmerged\n\t--killed --exclude= --exclude-from=\n\t--exclude-per-directory= --exclude-standard\n\t--error-unmatch --with-tree= --full-name\n\t--abbrev --ignored --exclude-per-directory\n\nSigned-off-by: Lee Marlow <lee.marlow@gmail.com>\n---\n contrib/completion/git-completion.bash |   21 +++++++++++++++++++++\n 1 files changed, 21 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 61ea6d9..936cd35 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -883,6 +883,26 @@ _git_init ()\n \tCOMPREPLY=()\n }\n \n+_git_ls_files ()\n+{\n+\t__git_has_doubledash && return\n+\n+\tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+\tcase \"$cur\" in\n+\t--*)\n+\t\t__gitcomp \"--cached --deleted --modified --others --ignored\n+\t\t\t--stage --directory --no-empty-directory --unmerged\n+\t\t\t--killed --exclude= --exclude-from=\n+\t\t\t--exclude-per-directory= --exclude-standard\n+\t\t\t--error-unmatch --with-tree= --full-name\n+\t\t\t--abbrev --ignored --exclude-per-directory\n+\t\t\t\"\n+\t\treturn\n+\t\t;;\n+\tesac\n+\tCOMPREPLY=()\n+}\n+\n _git_ls_remote ()\n {\n \t__gitcomp \"$(__git_remotes)\"\n@@ -1590,6 +1610,7 @@ _git ()\n \thelp)        _git_help ;;\n \tinit)        _git_init ;;\n \tlog)         _git_log ;;\n+\tls-files)    _git_ls_files ;;\n \tls-remote)   _git_ls_remote ;;\n \tls-tree)     _git_ls_tree ;;\n \tmerge)       _git_merge;;\n-- \n1.6.0.rc1.48.g2b6032\n"},{"id":"86273","messageId":"20080805142919.GA27295@spearce.org","threadId":"14836","inReplyTo":"1217915438-6838-1-git-send-email-lee.marlow@gmail.com","subject":"Re: [PATCH 0/8] bash completion: more porcelain completions","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-05T14:29:19Z","receivedAt":"2008-08-05T14:29:19Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Lee Marlow <lee.marlow@gmail.com> wrote:\n> This adds basic long option completion for some common commands that I\n> use, as well as stash name completion.\n\nEntire series is good.\n\nAcked-by: Shawn O. Pearce <spearce@spearce.org>\n \n> Lee Marlow (8):\n>   bash completion: Add completion for 'git clone'\n>   bash completion: Add completion for 'git clean'\n>   bash completion: Add completion for 'git init'\n>   bash completion: Add completion for 'git revert'\n>   bash completion: More completions for 'git stash'\n>   bash completion: Add completion for 'git archive'\n>   bash completion: Add completion for 'git ls-files'\n>   bash completion: Add completion for 'git mv'\n> \n>  contrib/completion/git-completion.bash |  143 +++++++++++++++++++++++++++++++-\n>  git-stash.sh                           |    2 +-\n>  2 files changed, 143 insertions(+), 2 deletions(-)\n> \n\n-- \nShawn.\n"},{"id":"86285","messageId":"7vbq07waph.fsf@gitster.siamese.dyndns.org","threadId":"14836","inReplyTo":"20080805142919.GA27295@spearce.org","subject":"Re: [PATCH 0/8] bash completion: more porcelain completions","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-08-05T18:58:18Z","receivedAt":"2008-08-05T18:58:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" <spearce@spearce.org> writes:\n\n> Lee Marlow <lee.marlow@gmail.com> wrote:\n>> This adds basic long option completion for some common commands that I\n>> use, as well as stash name completion.\n>\n> Entire series is good.\n>\n> Acked-by: Shawn O. Pearce <spearce@spearce.org>\n\nHave you looked at the last one [PATCH 8/8]?  I do not seem to have it.\n\n>> Lee Marlow (8):\n>>   bash completion: Add completion for 'git clone'\n>>   bash completion: Add completion for 'git clean'\n>>   bash completion: Add completion for 'git init'\n>>   bash completion: Add completion for 'git revert'\n>>   bash completion: More completions for 'git stash'\n>>   bash completion: Add completion for 'git archive'\n>>   bash completion: Add completion for 'git ls-files'\n>>   bash completion: Add completion for 'git mv'\n>> \n>>  contrib/completion/git-completion.bash |  143 +++++++++++++++++++++++++++++++-\n>>  git-stash.sh                           |    2 +-\n>>  2 files changed, 143 insertions(+), 2 deletions(-)\n>> \n>\n> -- \n> Shawn.\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"},{"id":"86288","messageId":"20080805190909.GE27207@spearce.org","threadId":"14836","inReplyTo":"7vbq07waph.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH 0/8] bash completion: more porcelain completions","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-05T19:09:09Z","receivedAt":"2008-08-05T19:09:09Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano <gitster@pobox.com> wrote:\n> \"Shawn O. Pearce\" <spearce@spearce.org> writes:\n> > Lee Marlow <lee.marlow@gmail.com> wrote:\n> >> This adds basic long option completion for some common commands that I\n> >> use, as well as stash name completion.\n> >\n> > Entire series is good.\n> >\n> > Acked-by: Shawn O. Pearce <spearce@spearce.org>\n> \n> Have you looked at the last one [PATCH 8/8]?  I do not seem to have it.\n\nYes.  I just sent it back to you and the list.  Hopefully at least\none copy makes it.  ;-)\n \n-- \nShawn.\n"},{"id":"86355","messageId":"1218037523-32266-1-git-send-email-szeder@ira.uka.de","threadId":"14836","inReplyTo":"1217915438-6838-6-git-send-email-lee.marlow@gmail.com","subject":"[PATCH] bash: remove redundant check for 'git stash apply' options","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2008-08-06T15:45:23Z","receivedAt":"2008-08-06T15:45:23Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"It will never trigger anyway because of the first check, and even if it\nwould, it would not offer the command line option.\n\nSigned-off-by: SZEDER Gábor <szeder@ira.uka.de>\n---\n contrib/completion/git-completion.bash |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 447cb06..5d60f82 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1427,7 +1427,7 @@ _git_stash ()\n \t\tapply,--*)\n \t\t\t__gitcomp \"--index\"\n \t\t\t;;\n-\t\tshow,--*|apply,--*|drop,--*|pop,--*|branch,--*)\n+\t\tshow,--*|drop,--*|pop,--*|branch,--*)\n \t\t\tCOMPREPLY=()\n \t\t\t;;\n \t\tshow,*|apply,*|drop,*|pop,*|branch,*)\n-- \n1.6.0.rc1.104.gf5b36\n"},{"id":"86356","messageId":"20080806154710.GB28749@spearce.org","threadId":"14836","inReplyTo":"1218037523-32266-1-git-send-email-szeder@ira.uka.de","subject":"Re: [PATCH] bash: remove redundant check for 'git stash apply' options","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-08-06T15:47:10Z","receivedAt":"2008-08-06T15:47:10Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"SZEDER GGGbor <szeder@ira.uka.de> wrote:\n> It will never trigger anyway because of the first check, and even if it\n> would, it would not offer the command line option.\n> \n> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>\n\nOops.  I should have caught that.  ACK.\n\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 447cb06..5d60f82 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1427,7 +1427,7 @@ _git_stash ()\n>  \t\tapply,--*)\n>  \t\t\t__gitcomp \"--index\"\n>  \t\t\t;;\n> -\t\tshow,--*|apply,--*|drop,--*|pop,--*|branch,--*)\n> +\t\tshow,--*|drop,--*|pop,--*|branch,--*)\n>  \t\t\tCOMPREPLY=()\n>  \t\t\t;;\n>  \t\tshow,*|apply,*|drop,*|pop,*|branch,*)\n\n-- \nShawn.\n"}]}