{"thread":{"id":"14831","subject":"StGit and charsets","startedAt":"2008-08-04T14:21:20Z","lastAt":"2008-08-04T15:31:46Z","messageCount":3,"participants":["Jon Smirl","Karl Hasselström"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"86193","messageId":"9e4733910808040721n6c47908o9d8fabd8f16293c1@mail.gmail.com","threadId":"14831","inReplyTo":null,"subject":"StGit and charsets","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2008-08-04T14:21:20Z","receivedAt":"2008-08-04T14:21:20Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"Do you have tests in place to handle the names and comments in patches\nbeing in different charsets? When I was working with the mailmap file\na large source of errors was from mangling names in alternate\ncharsets. I recall errors in Finnish, Japanese and Chinese names for\nsure. I don't know which tools did the charset mangling.\n\nI don't work much with international charsets. If someone is using\nsomething like Russian or Finish locally, is the metadata in the patch\nconverted to UTF8 before exporting or sending it as mail? Comments\nshould be in English, but people's names may need UTF8. And what about\nemail addresses, does DNS allow Unicode names now?\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"86205","messageId":"9e4733910808040821t492b74fcq7c2178690c0a6831@mail.gmail.com","threadId":"14831","inReplyTo":"20080804153146.GF12232@diana.vm.bytemark.co.uk","subject":"Re: StGit and charsets","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2008-08-04T15:21:31Z","receivedAt":"2008-08-04T15:21:31Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 8/4/08, Karl Hasselström <kha@treskal.com> wrote:\n> On 2008-08-04 10:21:20 -0400, Jon Smirl wrote:\n>  > I don't work much with international charsets. If someone is using\n>  > something like Russian or Finish locally, is the metadata in the\n>  > patch converted to UTF8 before exporting or sending it as mail?\n>\n>\n> I think what happens is that it's assumed to be utf8. No one has\n>  complained that their non-utf8 locale doesn't work, but my guess is\n>  that's because those people just haven't tried StGit yet.\n\nThis might be worth testing for Asian locales. If Asian locales make\nit through ok everything else probably will too.\n\nI don't know enough about Unicode to decode the mangled names, I\nsuspect they are still in the local charset and haven't been UTF8\nconverted.  Of course the name mangling may be coming from other\ntools. There is no way to tell.\n\nThis problem happens in other ways in the kernel. There is a file in\nthe DRM code where two people's names have been inserted in different\ncharsets. If I set my editor to display one right the other is always\nwrong. checkpatch probably needs to make sure that patches are\ncompletely valid UTF8.\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"86202","messageId":"20080804153146.GF12232@diana.vm.bytemark.co.uk","threadId":"14831","inReplyTo":"9e4733910808040721n6c47908o9d8fabd8f16293c1@mail.gmail.com","subject":"Re: StGit and charsets","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2008-08-04T15:31:46Z","receivedAt":"2008-08-04T15:31:46Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2008-08-04 10:21:20 -0400, Jon Smirl wrote:\n\n> Do you have tests in place to handle the names and comments in\n> patches being in different charsets?\n\nThere are some tests in t1800 and t1900 that use non-ascii names.\nMight be others, but a quick grep didn't find them.\n\n> I don't work much with international charsets. If someone is using\n> something like Russian or Finish locally, is the metadata in the\n> patch converted to UTF8 before exporting or sending it as mail?\n\nI think what happens is that it's assumed to be utf8. No one has\ncomplained that their non-utf8 locale doesn't work, but my guess is\nthat's because those people just haven't tried StGit yet.\n\n> Comments should be in English, but people's names may need UTF8.\n\nMine does, for example. I started my StGit career by making sure it\ncould send out patches that didn't mangle my name. (That's a while\nago, though, so my memory's getting a bit rusty.)\n\n> And what about email addresses, does DNS allow Unicode names now?\n\nI think it's up to each TLD whether they want to allow it. See e.g.\n\n  http://en.wikipedia.org/wiki/Internationalized_domain_name\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"}]}