{"thread":{"id":"1483","subject":"[PATCH] Add \"--sign\" option to git-format-patch-script","startedAt":"2005-08-12T13:32:42Z","lastAt":"2005-08-12T16:28:39Z","messageCount":5,"participants":["Johannes Schindelin","Junio C Hamano","Daniel Barkalow"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"7118","messageId":"Pine.LNX.4.63.0508121532051.25606@wgmdd8.biozentrum.uni-wuerzburg.de","threadId":"1483","inReplyTo":null,"subject":"[PATCH] Add \"--sign\" option to git-format-patch-script","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2005-08-12T13:32:42Z","receivedAt":"2005-08-12T13:32:42Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"This adds the option \"--sign\" to git-format-patch-script which adds\na Signed-off-by: line automatically.\n\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n\n---\n\n git-format-patch-script |   12 +++++++++++-\n 1 files changed, 11 insertions(+), 1 deletions(-)\n\na72d370d43c397238a26c1c7f260a3fd6401f4e6\ndiff --git a/git-format-patch-script b/git-format-patch-script\n--- a/git-format-patch-script\n+++ b/git-format-patch-script\n@@ -6,7 +6,7 @@\n . git-sh-setup-script || die \"Not a git archive.\"\n \n usage () {\n-    echo >&2 \"usage: $0\"' [-n] [-o dir] [--mbox] [--check] [-<diff options>...] upstream [ our-head ]\n+    echo >&2 \"usage: $0\"' [-n] [-o dir] [--mbox] [--check] [--sign] [-<diff options>...] upstream [ our-head ]\n \n Prepare each commit with its patch since our-head forked from upstream,\n one file per patch, for e-mail submission.  Each output file is\n@@ -46,6 +46,8 @@ do\n     date=t author=t mbox=t ;;\n     -n|--n|--nu|--num|--numb|--numbe|--number|--numbere|--numbered)\n     numbered=t ;;\n+    -s|--s|--si|--sig|--sign)\n+    signoff=t ;;\n     -o=*|--o=*|--ou=*|--out=*|--outp=*|--outpu=*|--output=*|--output-=*|\\\n     --output-d=*|--output-di=*|--output-dir=*|--output-dire=*|\\\n     --output-direc=*|--output-direct=*|--output-directo=*|\\\n@@ -174,6 +176,14 @@ Date: '\"$ad\"\n \tb body'\n \n \tsed -ne \"$mailScript\" <$commsg\n+\n+\ttest \"$signoff\" = \"t\" && {\n+\t\toffsigner=`git-var GIT_COMMITTER_IDENT | sed -e 's/>.*/>/'`\n+\t\techo\n+\t\techo \"Signed-off-by: $offsigner\"\n+\t\techo\n+\t}\n+\n \techo '---'\n \techo\n \tgit-diff-tree -p $diff_opts \"$commit\" | git-apply --stat --summary\n"},{"id":"7122","messageId":"7vr7czxj6s.fsf@assigned-by-dhcp.cox.net","threadId":"1483","inReplyTo":"Pine.LNX.4.63.0508121532051.25606@wgmdd8.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Add \"--sign\" option to git-format-patch-script","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-12T15:34:51Z","receivedAt":"2005-08-12T15:34:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Good intentions, but I'd rather see these S-O-B lines in the\nactual commit objects.  Giving format-patch this option would\ndiscourage people to do so.  Maybe a patch to git commit would\nbe more appropriate, methinks.\n"},{"id":"7124","messageId":"Pine.LNX.4.63.0508121146210.12816@iabervon.org","threadId":"1483","inReplyTo":"7vr7czxj6s.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Add \"--sign\" option to git-format-patch-script","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2005-08-12T15:56:36Z","receivedAt":"2005-08-12T15:56:36Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Fri, 12 Aug 2005, Junio C Hamano wrote:\n\n> Good intentions, but I'd rather see these S-O-B lines in the\n> actual commit objects.  Giving format-patch this option would\n> discourage people to do so.  Maybe a patch to git commit would\n> be more appropriate, methinks.\n\nMaybe also something in format-patch to check that the commit has one? I, \nat least, tend to have unsigned commits for tracking stuff I've done but \nnot cleaned up and signed ones that I want to send off as patches. I've \nconfused the branches on occasion, although never when sending stuff, and \nit would be nice to have format-patch tell you if the commit didn't look \nright.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"7127","messageId":"Pine.LNX.4.63.0508121804240.26333@wgmdd8.biozentrum.uni-wuerzburg.de","threadId":"1483","inReplyTo":"7vr7czxj6s.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Add \"--sign\" option to git-format-patch-script","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2005-08-12T16:05:09Z","receivedAt":"2005-08-12T16:05:09Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 12 Aug 2005, Junio C Hamano wrote:\n\n> Good intentions, but I'd rather see these S-O-B lines in the\n> actual commit objects.  Giving format-patch this option would\n> discourage people to do so.  Maybe a patch to git commit would\n> be more appropriate, methinks.\n\nMaybe in addition to this one? I meant that option to be for on-passers of \ncommits they are not author of.\n\nCiao,\nDscho\n"},{"id":"7130","messageId":"7v64ubxgp4.fsf@assigned-by-dhcp.cox.net","threadId":"1483","inReplyTo":"Pine.LNX.4.63.0508121804240.26333@wgmdd8.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Add \"--sign\" option to git-format-patch-script","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-12T16:28:39Z","receivedAt":"2005-08-12T16:28:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> Hi,\n>\n> On Fri, 12 Aug 2005, Junio C Hamano wrote:\n>\n>> Good intentions, but I'd rather see these S-O-B lines in the\n>> actual commit objects.  Giving format-patch this option would\n>> discourage people to do so.  Maybe a patch to git commit would\n>> be more appropriate, methinks.\n>\n> Maybe in addition to this one? I meant that option to be for on-passers of \n> commits they are not author of.\n\nSurely.  Also I find Daniel's suggestion to check a good one.\n"}]}