{"thread":{"id":"1482","subject":"[PATCH] Use \"-script\" postfix for scripts","startedAt":"2005-08-12T13:28:27Z","lastAt":"2005-08-13T22:28:51Z","messageCount":9,"participants":["Johannes Schindelin","Junio C Hamano","Linus Torvalds","Ryan Anderson","Petr Baudis"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"7117","messageId":"Pine.LNX.4.63.0508121526050.25606@wgmdd8.biozentrum.uni-wuerzburg.de","threadId":"1482","inReplyTo":null,"subject":"[PATCH] Use \"-script\" postfix for scripts","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2005-08-12T13:28:27Z","receivedAt":"2005-08-12T13:28:27Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nFor consistency reasons, the names of all scripts should end in \"-script\".\n\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n\n---\n\nThis may be a bit controversial (people might find it unnecessary). \nSubject to discussion.\n\n---\n\n Makefile                   |   15 ++++++++-------\n git-cherry-script          |    0 \n git-clone-dumb-http-script |    0 \n git-clone-script           |    2 +-\n git-rebase-script          |    4 ++--\n git-request-pull-script    |    4 ++--\n git-shortlog-script        |    0 \n git-whatchanged-script     |    0 \n 8 files changed, 13 insertions(+), 12 deletions(-)\n rename git-cherry => git-cherry-script (100%)\n rename git-clone-dumb-http => git-clone-dumb-http-script (100%)\n rename git-shortlog => git-shortlog-script (100%)\n rename git-whatchanged => git-whatchanged-script (100%)\n\n5cc55f08d874b61f1067857c7310fac325504ec8\ndiff --git a/Makefile b/Makefile\n--- a/Makefile\n+++ b/Makefile\n@@ -58,15 +58,16 @@ SPARSE_FLAGS?=-D__BIG_ENDIAN__ -D__power\n \n \n SCRIPTS=git git-apply-patch-script git-merge-one-file-script git-prune-script \\\n-\tgit-pull-script git-tag-script git-resolve-script git-whatchanged \\\n-\tgit-fetch-script git-status-script git-commit-script \\\n-\tgit-log-script git-shortlog git-cvsimport-script git-diff-script \\\n-\tgit-reset-script git-add-script git-checkout-script git-clone-script \\\n-\tgitk git-cherry git-rebase-script git-relink-script git-repack-script \\\n+\tgit-pull-script git-tag-script git-resolve-script \\\n+\tgit-whatchanged-script git-fetch-script git-status-script \\\n+\tgit-commit-script git-log-script git-shortlog-script \\\n+\tgit-cvsimport-script git-diff-script git-reset-script git-add-script \\\n+\tgit-checkout-script git-clone-script gitk git-cherry-script \\\n+\tgit-rebase-script git-relink-script git-repack-script \\\n \tgit-format-patch-script git-sh-setup-script git-push-script \\\n \tgit-branch-script git-parse-remote git-verify-tag-script \\\n-\tgit-ls-remote-script git-clone-dumb-http git-rename-script \\\n-\tgit-request-pull-script git-bisect-script\n+\tgit-ls-remote-script git-clone-dumb-http-script \\\n+\tgit-rename-script git-request-pull-script git-bisect-script\n \n SCRIPTS += git-count-objects-script\n # SCRIPTS += git-send-email-script\ndiff --git a/git-cherry b/git-cherry-script\nsimilarity index 100%\nrename from git-cherry\nrename to git-cherry-script\ndiff --git a/git-clone-dumb-http b/git-clone-dumb-http-script\nsimilarity index 100%\nrename from git-clone-dumb-http\nrename to git-clone-dumb-http-script\ndiff --git a/git-clone-script b/git-clone-script\n--- a/git-clone-script\n+++ b/git-clone-script\n@@ -89,7 +89,7 @@ yes,yes)\n \t\trsync $quiet -avz --ignore-existing \"$repo/refs/\" \"$D/.git/refs/\"\n \t\t;;\n \thttp://*)\n-\t\tgit-clone-dumb-http \"$repo\" \"$D\"\n+\t\tgit-clone-dumb-http-script \"$repo\" \"$D\"\n \t\tcase \"$?\" in\n \t\t2)\n \t\t\techo \"Somebody should define smarter http server protocol\" >&2\ndiff --git a/git-rebase-script b/git-rebase-script\n--- a/git-rebase-script\n+++ b/git-rebase-script\n@@ -7,7 +7,7 @@\n \n usage=\"usage: $0 \"'<upstream> [<head>]\n \n-Uses output from git-cherry to rebase local commits to the new head of\n+Uses output from git-cherry-script to rebase local commits to the new head of\n upstream tree.'\n \n case \"$#,$1\" in\n@@ -36,7 +36,7 @@ trap \"rm -rf $tmp-*\" 0 1 2 3 15\n \n >$fail\n \n-git-cherry $upstream $ours |\n+git-cherry-script $upstream $ours |\n while read sign commit\n do\n \tcase \"$sign\" in\ndiff --git a/git-request-pull-script b/git-request-pull-script\n--- a/git-request-pull-script\n+++ b/git-request-pull-script\n@@ -24,12 +24,12 @@ headrev=`git-rev-parse --verify $head^0`\n \n echo \"The following changes since commit $baserev:\"\n git log --max-count=1 --pretty=short \"$baserev\" |\n-git-shortlog | sed -e 's/^\\(.\\)/  \\1/'\n+git-shortlog-script | sed -e 's/^\\(.\\)/  \\1/'\n \n echo \"are found in the git repository at:\" \n echo\n echo \"  $url\"\n echo\n \n-git log  $baserev..$headrev | git-shortlog ;\n+git log  $baserev..$headrev | git-shortlog-script ;\n git diff $baserev..$headrev | git-apply --stat --summary\ndiff --git a/git-shortlog b/git-shortlog-script\nsimilarity index 100%\nrename from git-shortlog\nrename to git-shortlog-script\ndiff --git a/git-whatchanged b/git-whatchanged-script\nsimilarity index 100%\nrename from git-whatchanged\nrename to git-whatchanged-script\n"},{"id":"7120","messageId":"7vwtmrxjbb.fsf@assigned-by-dhcp.cox.net","threadId":"1482","inReplyTo":"Pine.LNX.4.63.0508121526050.25606@wgmdd8.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Use \"-script\" postfix for scripts","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-12T15:32:08Z","receivedAt":"2005-08-12T15:32:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> For consistency reasons, the names of all scripts should end in \"-script\".\n>\n> This may be a bit controversial (people might find it unnecessary). \n> Subject to discussion.\n\nI have never liked the original -script name convention.  It\nonly meant that they are implemented as scripts (as opposed to\nthose on the $(PROG) Makefile variable), but the end users who\nend up typing their names from the command line, and to a lesser\ndegree the people who use them in their scripts, should not care\nhow they are implemented to begin with.\n\nAnd to cope with long names and make things look a bit more\nfamiliar to CVS migrants, \"git\" wrapper was invented to supply\nthe -script suffix to grok \"git whatever\", but just in case if\nsomething was _not_ implemented as a script, it ends up needing\nto try \"git-whatever\" in addition to \"git-whatever-script\".  The\npatch alleviates the \"git\" problem for \"git-whatchanged\" and\nfriends whose names currently do not end with -script, but it\nstill does not help \"git apply\", for example.  I like the\ngeneral direction of making things consistent, but I wonder if\nwe can become consistent by losing -script suffix, not adding to\nthe ones that lack it.\n\nAnd as you imply, this kind of change inevitable breaks people's\nscripts.  But I do agree with you that we should do something\nabout it, so it may be better to break them sooner rather than\nlater, as long as we make sure we break them just once.\n"},{"id":"7125","messageId":"Pine.LNX.4.63.0508121800050.26333@wgmdd8.biozentrum.uni-wuerzburg.de","threadId":"1482","inReplyTo":"7vwtmrxjbb.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Use \"-script\" postfix for scripts","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2005-08-12T16:00:48Z","receivedAt":"2005-08-12T16:00:48Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"hI,\n\nOn Fri, 12 Aug 2005, Junio C Hamano wrote:\n\n> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n> \n> > For consistency reasons, the names of all scripts should end in \"-script\".\n> >\n> > This may be a bit controversial (people might find it unnecessary). \n> > Subject to discussion.\n> \n> I have never liked the original -script name convention.\n\nOkay. I'm all for dropping the \"-script\" postfix.\n\nCiao,\nDscho\n"},{"id":"7148","messageId":"Pine.LNX.4.58.0508121451590.3295@g5.osdl.org","threadId":"1482","inReplyTo":"7vwtmrxjbb.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Use \"-script\" postfix for scripts","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-08-12T21:55:01Z","receivedAt":"2005-08-12T21:55:01Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 12 Aug 2005, Junio C Hamano wrote:\n> \n> I have never liked the original -script name convention.  It\n> only meant that they are implemented as scripts (as opposed to\n> those on the $(PROG) Makefile variable), but the end users who\n> end up typing their names from the command line, and to a lesser\n> degree the people who use them in their scripts, should not care\n> how they are implemented to begin with.\n\nWell, end users _don't_ care, since they are supposed to use just a simple\n\"git xxx\".\n\nThe advantage with \"git-xxx-script\" is for git developers: at least yours \ntruly does \"grep xyz *.c\" all the time, and the \"grep abc *-script\" is \nentirely analogous to that. That's where the \"-script\" ending comes from: \nit really helps pick out the stuff you can grep from (as opposed to the \nstuff that got compiled and isn't greppable).\n\nSure, I could have called it \".sh\" instead to make it look even more like \na shell script thing, but I actually think \"-script\" describes any \nscripting language - shell, perl, you name it..\n\n\t\t\tLinus\n"},{"id":"7150","messageId":"20050812222716.GD22778@mythryan2.michonline.com","threadId":"1482","inReplyTo":"Pine.LNX.4.58.0508121451590.3295@g5.osdl.org","subject":"Re: [PATCH] Use \"-script\" postfix for scripts","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2005-08-12T22:27:16Z","receivedAt":"2005-08-12T22:27:16Z","isPatch":true,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"On Fri, Aug 12, 2005 at 02:55:01PM -0700, Linus Torvalds wrote:\n> \n> Sure, I could have called it \".sh\" instead to make it look even more like \n> a shell script thing, but I actually think \"-script\" describes any \n> scripting language - shell, perl, you name it..\n\nSee, for example, the history on git-rename-script for why this is good.\n\n-- \n\nRyan Anderson\n  sometimes Pug Majere\n"},{"id":"7178","messageId":"7v64uaqknh.fsf@assigned-by-dhcp.cox.net","threadId":"1482","inReplyTo":"20050812222716.GD22778@mythryan2.michonline.com","subject":"Re: [PATCH] Use \"-script\" postfix for scripts","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-13T08:57:22Z","receivedAt":"2005-08-13T08:57:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ryan Anderson <ryan@michonline.com> writes:\n\n> See, for example, the history on git-rename-script for why this is good.\n\nWhy do you think it is a good example?  What happens when next\ntime somebody rewrites it in C?\n"},{"id":"7202","messageId":"Pine.LNX.4.58.0508130934000.19049@g5.osdl.org","threadId":"1482","inReplyTo":"7v64uaqknh.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Use \"-script\" postfix for scripts","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-08-13T16:35:50Z","receivedAt":"2005-08-13T16:35:50Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Sat, 13 Aug 2005, Junio C Hamano wrote:\n> Ryan Anderson <ryan@michonline.com> writes:\n> > See, for example, the history on git-rename-script for why this is good.\n> \n> Why do you think it is a good example?  What happens when next\n> time somebody rewrites it in C?\n\nWe'll call the C version \"rename.c\", and the program gets to be called \n\"git-rename\", and \"git rename\" continues to work perfectly fine, so users \nwon't be affected in the least.\n\nAnd \"grep ... *.c\" and \"grep ... *-script\" also still work right.\n\nThat sounds like a good outcome to me.\n\n\t\tLinus\n"},{"id":"7222","messageId":"20050813222512.GA6844@mythryan2.michonline.com","threadId":"1482","inReplyTo":"7v64uaqknh.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Use \"-script\" postfix for scripts","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2005-08-13T22:25:12Z","receivedAt":"2005-08-13T22:25:12Z","isPatch":true,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"On Sat, Aug 13, 2005 at 01:57:22AM -0700, Junio C Hamano wrote:\n> Ryan Anderson <ryan@michonline.com> writes:\n> \n> > See, for example, the history on git-rename-script for why this is good.\n> \n> Why do you think it is a good example?  What happens when next\n> time somebody rewrites it in C?\n\nWell, I was really responding to the comment about \"-script\" being\nbetter than \".sh\", as trying \".sh\", \".pl\", \".php\", etc, would rapidly\nbe annoying.\n\nHonestly, I think the biggest argument against the \"-script\" suffix is\nrelated to man-page usage:  It requires significant knowledge of the Git\nproject to figure out what name variant to use to find the man page.\n\n(There are other problems with man pages, but I'll address those\nseperately now that they have occurred to me.)\n\n-- \n\nRyan Anderson\n  sometimes Pug Majere\n"},{"id":"7223","messageId":"20050813222851.GN5608@pasky.ji.cz","threadId":"1482","inReplyTo":"20050813222512.GA6844@mythryan2.michonline.com","subject":"Re: [PATCH] Use \"-script\" postfix for scripts","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-08-13T22:28:51Z","receivedAt":"2005-08-13T22:28:51Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Sun, Aug 14, 2005 at 12:25:12AM CEST, I got a letter\nwhere Ryan Anderson <ryan@michonline.com> told me that...\n> Honestly, I think the biggest argument against the \"-script\" suffix is\n> related to man-page usage:  It requires significant knowledge of the Git\n> project to figure out what name variant to use to find the man page.\n\n.oO(Hey, tcl has own man section as well!)\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nIf you want the holes in your knowledge showing up try teaching\nsomeone.  -- Alan Cox\n"}]}