{"thread":{"id":"14813","subject":"Missing pieces for 1.6.0 on MinGW?","startedAt":"2008-08-02T19:05:04Z","lastAt":"2008-08-03T10:45:51Z","messageCount":6,"participants":["Junio C Hamano","Steffen Prohaska","Johannes Sixt","Björn Steinbrink","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"86002","messageId":"7vljzfkzkv.fsf@gitster.siamese.dyndns.org","threadId":"14813","inReplyTo":null,"subject":"Missing pieces for 1.6.0 on MinGW?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-08-02T19:05:04Z","receivedAt":"2008-08-02T19:05:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Just a quick question before the weekend ends and -rc2 gets tagged. (I\nlost track of that argv0 vs bin/git vs libexec/git-core/git-foo\ndiscussion).\n\nAre there any missing but necessary patches we need before 1.6.0 for\nMinGW?\n"},{"id":"86051","messageId":"E7278ED4-5423-4D53-B4B8-9AC620FDF769@zib.de","threadId":"14813","inReplyTo":"7vljzfkzkv.fsf@gitster.siamese.dyndns.org","subject":"Re: Missing pieces for 1.6.0 on MinGW?","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2008-08-03T08:52:15Z","receivedAt":"2008-08-03T08:52:15Z","isPatch":false,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"\nOn Aug 2, 2008, at 9:05 PM, Junio C Hamano wrote:\n\n> Just a quick question before the weekend ends and -rc2 gets tagged. \n> (I\n> lost track of that argv0 vs bin/git vs libexec/git-core/git-foo\n> discussion).\n\nI haven't found time to work on this and I also haven't observed\nany progress made by others.\n\n\n> Are there any missing but necessary patches we need before 1.6.0 for\n> MinGW?\n\nSo we don't have patches, although we still have the problem\ndiscussed last weekend.\n\nUnfortunately, I cannot promise that I'll find time the next couple\nof days to work on the issue. I propose you just continue the\nrelease cycle without waiting for MinGW.\n\n\tSteffen\n"},{"id":"86052","messageId":"1217754985.4895776973fda@webmail.nextra.at","threadId":"14813","inReplyTo":"7vljzfkzkv.fsf@gitster.siamese.dyndns.org","subject":"Re: Missing pieces for 1.6.0 on MinGW?","fromName":"Johannes Sixt","fromEmail":"johannes.sixt@telecom.at","sentAt":"2008-08-03T09:16:25Z","receivedAt":"2008-08-03T09:16:25Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Zitat von Junio C Hamano :\n> Just a quick question before the weekend ends and -rc2 gets tagged. (I\n> lost track of that argv0 vs bin/git vs libexec/git-core/git-foo\n> discussion).\n>\n> Are there any missing but necessary patches we need before 1.6.0 for\n> MinGW?\n\nYes, there are some open issues:\n\n(1) git-gui was fixed for the msysgit installer, but it broke for me; but I\nthink I know where to fix it.\n\n(2) the non-builtins in $(bindir) don't set argv0_path, and consequently don't\nfind ETC_GITCONFIG.\n\n(3) the 'mingw_main undefined' error is still a mystery. I'm about to send a\npreprocessed file to Steffen (it's a bit large, even compressed, so I'll do\nthat in a private mail).\n\nItem (1) I expect to work on later today, but needs some investigation by\nSteffen and perhaps Shawn. (2) is probably a minor issue. (3) is, well, a\nmystery, although Steffen's patch works for me, too. Nevertheless, I'd like to\nknow why my original approach does not always work.\n\n-- Hannes\n"},{"id":"86055","messageId":"20080803101044.GA32565@atjola.homenet","threadId":"14813","inReplyTo":"1217754985.4895776973fda@webmail.nextra.at","subject":"Re: Missing pieces for 1.6.0 on MinGW?","fromName":"Björn Steinbrink","fromEmail":"b.steinbrink@gmx.de","sentAt":"2008-08-03T10:10:44Z","receivedAt":"2008-08-03T10:10:44Z","isPatch":false,"sender":{"key":"b.steinbrink@gmx.de","avatar":"https://avatars.githubusercontent.com/u/230962?v=4"},"body":"On 2008.08.03 11:16:25 +0200, Johannes Sixt wrote:\n> (3) the 'mingw_main undefined' error is still a mystery. I'm about to send a\n> preprocessed file to Steffen (it's a bit large, even compressed, so I'll do\n> that in a private mail).\n\nFWIW, gcc 4.3 complains about such function declarations:\nx.c:4: error: invalid storage class for function ‘foo’\n\nSeems that gcc complains about that since 4.0, and linking failed with\nolder versions under some circumstances.\n\nhttp://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738\nhttp://gcc.gnu.org/bugzilla/show_bug.cgi?id=17205\n\nBjörn\n"},{"id":"86057","messageId":"1E34BC5D-5A83-4B27-8F62-96F582F0625F@zib.de","threadId":"14813","inReplyTo":"1217754985.4895776973fda@webmail.nextra.at","subject":"Re: Missing pieces for 1.6.0 on MinGW?","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2008-08-03T10:17:33Z","receivedAt":"2008-08-03T10:17:33Z","isPatch":false,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"\nOn Aug 3, 2008, at 11:16 AM, Johannes Sixt wrote:\n\n> Zitat von Junio C Hamano :\n>> Just a quick question before the weekend ends and -rc2 gets \n>> tagged. (I\n>> lost track of that argv0 vs bin/git vs libexec/git-core/git-foo\n>> discussion).\n>>\n>> Are there any missing but necessary patches we need before 1.6.0 for\n>> MinGW?\n>\n> Yes, there are some open issues:\n>\n> (1) git-gui was fixed for the msysgit installer, but it broke for \n> me; but I\n> think I know where to fix it.\n\nI now recognized that not all hunks that I have in 4msysgit were applied\nby Shawn. See separate mail\n\n http://article.gmane.org/gmane.comp.version-control.git/91221\n\n\n> (2) the non-builtins in $(bindir) don't set argv0_path, and \n> consequently don't\n> find ETC_GITCONFIG.\n\nSetting argv0_path correctly wouldn't help alone. The relative\npath to $prefix is different in $prefix/bin and\n$prefix/libexec/git-core. Thus, we cannot do the same computation.\nsystem_path() would need to check from which directory the computation\nstarts.\n\n\n> (3) the 'mingw_main undefined' error is still a mystery. I'm about \n> to send a\n> preprocessed file to Steffen (it's a bit large, even compressed, so \n> I'll do\n> that in a private mail).\n\nok.\n\n\tSteffen\n"},{"id":"86058","messageId":"alpine.DEB.1.00.0808031239110.9611@pacific.mpi-cbg.de.mpi-cbg.de","threadId":"14813","inReplyTo":"1217754985.4895776973fda@webmail.nextra.at","subject":"Re: Missing pieces for 1.6.0 on MinGW?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-08-03T10:45:51Z","receivedAt":"2008-08-03T10:45:51Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sun, 3 Aug 2008, Johannes Sixt wrote:\n\n> (2) the non-builtins in $(bindir) don't set argv0_path, and consequently \n> don't find ETC_GITCONFIG.\n> \n> (3) the 'mingw_main undefined' error is still a mystery. I'm about to \n> send a preprocessed file to Steffen (it's a bit large, even compressed, \n> so I'll do that in a private mail).\n\nFor both issues, IMHO Steve's patches should be superior, as they (with my \nproposed lookup_program_in_path()) would not only make relative \nETC_GITCONFIG work on MinGW, but everywhere else, too. Obsoleting \nmingw_main, of course.\n\nCiao,\nDscho\n"}]}